)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"2673896332c1edf92738659361d5cee119cd61ae","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Morgan Fainberg \u003cmorgan.fainberg@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-06-18 11:58:17 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"create python-keystonemiddleware repo"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Co-Authored-By: Adam Young \u003cayoung@redhat.com\u003e"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"1ae5cdf2_ecf3e570","line":7,"updated":"2014-06-18 19:20:27.000000000","message":"change to \"keystonemiddleware\"","commit_id":"5ce841f33f77b285712294e56b0ae01040c14be1"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"85b71ea21012ff31d3cba2a57d2ddc93a81264c0","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Morgan Fainberg \u003cmorgan.fainberg@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-06-18 12:18:43 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"create python-keystonemiddleware repo"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Co-Authored-By: Adam Young \u003cayoung@redhat.com\u003e"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"1ae5cdf2_17a2dafb","line":7,"updated":"2014-06-18 19:29:42.000000000","message":"change \"python-keystonemiddleware\" to \"keystonemiddleware\"","commit_id":"3e40c416a7d90fa00d9d0ba2f27fafa180c4559a"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"3e990250dbe41bcba54dc25d60caeb0f076c84f1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Morgan Fainberg \u003cmorgan.fainberg@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-06-18 12:18:43 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"create python-keystonemiddleware repo"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Co-Authored-By: Adam Young \u003cayoung@redhat.com\u003e"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"1ae5cdf2_97e18a9d","line":7,"in_reply_to":"1ae5cdf2_17a2dafb","updated":"2014-06-18 19:46:25.000000000","message":"done","commit_id":"3e40c416a7d90fa00d9d0ba2f27fafa180c4559a"}],"doc/source/index.rst":[{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"85a21eadde952aed4ad878880fb37c1decd5c3df","unresolved":false,"context_lines":[{"line_number":35,"context_line":"  :glob:"},{"line_number":36,"context_line":"  :maxdepth: 1"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"  specs/keystoneclient/*"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":41,"context_line":"Indices and tables"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3ae8d1ca_00475f20","line":38,"updated":"2014-05-28 01:42:02.000000000","message":"Should be middleware not client.","commit_id":"f313eaf0cb6a8a371b90cbc0758248fdb8049001"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"4a000f0198f26dc09f75771532faf1fa28cc8ba9","unresolved":false,"context_lines":[{"line_number":35,"context_line":"  :glob:"},{"line_number":36,"context_line":"  :maxdepth: 1"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"  specs/middelware/*"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":41,"context_line":"Indices and tables"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3ae8d1ca_3b6d6c33","line":38,"updated":"2014-05-28 02:59:13.000000000","message":"s/middelware/middleware","commit_id":"0d5b56685faa91df8f64b4112b324c0c36af709f"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"0ab9dd2dc50c091283a69aef84095c04c1fe9f3b","unresolved":false,"context_lines":[{"line_number":35,"context_line":"  :glob:"},{"line_number":36,"context_line":"  :maxdepth: 1"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"  specs/middelware/*"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":41,"context_line":"Indices and tables"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_2f3c5a2f","line":38,"in_reply_to":"1ae5cdf2_6fe4a23b","updated":"2014-05-30 14:29:46.000000000","message":"keystonemiddleware (i\u0027m making an oslo.middleware lib)... i\u0027ll also be making a oslo.notifiermiddleware so it follows that naming... or don\u0027t :)","commit_id":"0d5b56685faa91df8f64b4112b324c0c36af709f"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"4838e45c98c218e638d4b2d8b3941ee0ebd9c0e5","unresolved":false,"context_lines":[{"line_number":35,"context_line":"  :glob:"},{"line_number":36,"context_line":"  :maxdepth: 1"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"  specs/middelware/*"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":41,"context_line":"Indices and tables"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_6fe4a23b","line":38,"in_reply_to":"3ae8d1ca_3b6d6c33","updated":"2014-05-30 14:23:26.000000000","message":"++ there\u0027s also inconsistent usage of \"keystonemiddleware\" and \"middleware\" - i don\u0027t really care which we pick, but everything should be the same","commit_id":"0d5b56685faa91df8f64b4112b324c0c36af709f"}],"specs/keystonemiddleware/split-middleware-repo.rst":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"61c895bdb9ee02211c0aeda57446440556f13fbe","unresolved":false,"context_lines":[{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"`bp split-middleware"},{"line_number":12,"context_line":"\u003chttps://blueprints.launchpad.net/keystone/+spec/split-middleware\u003e`_"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Keystone has a sufficient quantity of Middleware to justify a separate repo."},{"line_number":15,"context_line":"These will come from multiple projects, to include the Keystone Server and"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1ae5cdf2_74c9ca78","line":12,"updated":"2014-06-16 18:29:23.000000000","message":"this launchpad blueprint needs to be created.","commit_id":"25ff221090fc3f560062c6eae5ff48d9b3c7b009"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"df785f7496f98c7455d272c3600ee3305330a8b8","unresolved":false,"context_lines":[{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"`bp split-middleware"},{"line_number":12,"context_line":"\u003chttps://blueprints.launchpad.net/keystone/+spec/split-middleware\u003e`_"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Keystone has a sufficient quantity of Middleware to justify a separate repo."},{"line_number":15,"context_line":"These will come from multiple projects, to include the Keystone Server and"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1ae5cdf2_d410dead","line":12,"in_reply_to":"1ae5cdf2_74c9ca78","updated":"2014-06-16 18:33:10.000000000","message":"Done\n\nhttps://blueprints.launchpad.net/keystone/+spec/split-middleware","commit_id":"25ff221090fc3f560062c6eae5ff48d9b3c7b009"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"beb1d80f84b6c79d8a5f1b14de093c7a1efe315d","unresolved":false,"context_lines":[{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"`bp split-middleware"},{"line_number":12,"context_line":"\u003chttps://blueprints.launchpad.net/keystone/+spec/split-middleware\u003e`_"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Keystone has a sufficient quantity of Middleware to justify a separate repo."},{"line_number":15,"context_line":"These will come from multiple projects, to include the Keystone Server and"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1ae5cdf2_143a46e7","line":12,"in_reply_to":"1ae5cdf2_d410dead","updated":"2014-06-16 18:39:46.000000000","message":"It was initially discussed the BP would only be created once the spec was approved.","commit_id":"25ff221090fc3f560062c6eae5ff48d9b3c7b009"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"f718f174b4b5ab6a6b021ce82e081d2a17a66961","unresolved":false,"context_lines":[{"line_number":17,"context_line":"a few major requests:"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"* Limit the dependencies of python-keystoneclient. Some of the middleware"},{"line_number":20,"context_line":"  dependencies do not make sense to require of a CLI utility or a API library."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"* Allow for separate release scheduling (and isolation of changes) between"},{"line_number":23,"context_line":"  server requirements (e.g. the middleware) and the CLI/client library. The"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1ae5cdf2_a5ae982d","line":20,"updated":"2014-06-17 15:50:01.000000000","message":"s/a API/an API/","commit_id":"25ff221090fc3f560062c6eae5ff48d9b3c7b009"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"38ce52e1563234bac089ea8ab9df62ff12ff6ec7","unresolved":false,"context_lines":[{"line_number":17,"context_line":"a few major requests:"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"* Limit the dependencies of python-keystoneclient. Some of the middleware"},{"line_number":20,"context_line":"  dependencies do not make sense to require of a CLI utility or a API library."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"* Allow for separate release scheduling (and isolation of changes) between"},{"line_number":23,"context_line":"  server requirements (e.g. the middleware) and the CLI/client library. The"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1ae5cdf2_833eb4b6","line":20,"in_reply_to":"1ae5cdf2_a5ae982d","updated":"2014-06-18 17:51:20.000000000","message":"Fixed in next.","commit_id":"25ff221090fc3f560062c6eae5ff48d9b3c7b009"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"f718f174b4b5ab6a6b021ce82e081d2a17a66961","unresolved":false,"context_lines":[{"line_number":28,"context_line":"* Consolidate all ``OpenStack Identity``-specific middleware to a single"},{"line_number":29,"context_line":"  repository."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Problem Description"},{"line_number":34,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1ae5cdf2_4565d41b","line":31,"updated":"2014-06-17 15:50:01.000000000","message":"extra whitespace can be removed throughout","commit_id":"25ff221090fc3f560062c6eae5ff48d9b3c7b009"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"38ce52e1563234bac089ea8ab9df62ff12ff6ec7","unresolved":false,"context_lines":[{"line_number":28,"context_line":"* Consolidate all ``OpenStack Identity``-specific middleware to a single"},{"line_number":29,"context_line":"  repository."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Problem Description"},{"line_number":34,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1ae5cdf2_c3443c49","line":31,"in_reply_to":"1ae5cdf2_4565d41b","updated":"2014-06-18 17:51:20.000000000","message":"Done in next","commit_id":"25ff221090fc3f560062c6eae5ff48d9b3c7b009"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"f718f174b4b5ab6a6b021ce82e081d2a17a66961","unresolved":false,"context_lines":[{"line_number":50,"context_line":"Alternatives"},{"line_number":51,"context_line":"------------"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"None"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Data Model Impact"},{"line_number":56,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1ae5cdf2_88f531ef","line":53,"updated":"2014-06-17 15:50:01.000000000","message":"- creating multiple packages from a single repo","commit_id":"25ff221090fc3f560062c6eae5ff48d9b3c7b009"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"38ce52e1563234bac089ea8ab9df62ff12ff6ec7","unresolved":false,"context_lines":[{"line_number":50,"context_line":"Alternatives"},{"line_number":51,"context_line":"------------"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"None"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Data Model Impact"},{"line_number":56,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1ae5cdf2_d857fa25","line":53,"in_reply_to":"1ae5cdf2_88f531ef","updated":"2014-06-18 17:51:20.000000000","message":"Is that really an option? I thought that wasn\u0027t viable within infra.","commit_id":"25ff221090fc3f560062c6eae5ff48d9b3c7b009"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"f718f174b4b5ab6a6b021ce82e081d2a17a66961","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"The other projects will gain a dependency on the new package. To start,"},{"line_number":79,"context_line":"keystoneclient will depend on the new package. Once the other projects are"},{"line_number":80,"context_line":"updated, this will be reversed."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Performance Impact"},{"line_number":83,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1ae5cdf2_2836ddb4","line":80,"updated":"2014-06-17 15:50:01.000000000","message":"what will be reversed? (you mean the dependency will be removed?) it seems keystoneclient will need to depend on keystonemiddleware for a while","commit_id":"25ff221090fc3f560062c6eae5ff48d9b3c7b009"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"38ce52e1563234bac089ea8ab9df62ff12ff6ec7","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"The other projects will gain a dependency on the new package. To start,"},{"line_number":79,"context_line":"keystoneclient will depend on the new package. Once the other projects are"},{"line_number":80,"context_line":"updated, this will be reversed."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Performance Impact"},{"line_number":83,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1ae5cdf2_1829629b","line":80,"in_reply_to":"1ae5cdf2_2836ddb4","updated":"2014-06-18 17:51:20.000000000","message":"This blob is bad. This is not easy to solve... Based upon information i dredged up on the internet, it still isn\u0027t clear how pip would handle a circular dependency - if pip can do circular dependency resolution, this is easy.","commit_id":"25ff221090fc3f560062c6eae5ff48d9b3c7b009"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"61c895bdb9ee02211c0aeda57446440556f13fbe","unresolved":false,"context_lines":[{"line_number":94,"context_line":"Developer Impact"},{"line_number":95,"context_line":"----------------"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"Develpoers will need to be aware of which repo to submit code changes against."},{"line_number":98,"context_line":""},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Implementation"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1ae5cdf2_746d4a99","line":97,"updated":"2014-06-16 18:29:23.000000000","message":"Developers","commit_id":"25ff221090fc3f560062c6eae5ff48d9b3c7b009"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"beb1d80f84b6c79d8a5f1b14de093c7a1efe315d","unresolved":false,"context_lines":[{"line_number":94,"context_line":"Developer Impact"},{"line_number":95,"context_line":"----------------"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"Develpoers will need to be aware of which repo to submit code changes against."},{"line_number":98,"context_line":""},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Implementation"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1ae5cdf2_d42ffea5","line":97,"in_reply_to":"1ae5cdf2_746d4a99","updated":"2014-06-16 18:39:46.000000000","message":"Fixed in next patch if a next patch is needed.","commit_id":"25ff221090fc3f560062c6eae5ff48d9b3c7b009"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"61c895bdb9ee02211c0aeda57446440556f13fbe","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"* copy code from python-keystoneclient to new repo using the oslo-incubator"},{"line_number":117,"context_line":"  graduation utilities to maintain the change history of each of the different"},{"line_number":118,"context_line":"  middlewares."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1ae5cdf2_f4d6ba26","line":118,"updated":"2014-06-16 18:29:23.000000000","message":"are there oslo docs for this process?","commit_id":"25ff221090fc3f560062c6eae5ff48d9b3c7b009"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"beb1d80f84b6c79d8a5f1b14de093c7a1efe315d","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"* copy code from python-keystoneclient to new repo using the oslo-incubator"},{"line_number":117,"context_line":"  graduation utilities to maintain the change history of each of the different"},{"line_number":118,"context_line":"  middlewares."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1ae5cdf2_34482287","line":118,"in_reply_to":"1ae5cdf2_f4d6ba26","updated":"2014-06-16 18:39:46.000000000","message":"It is in https://wiki.openstack.org/wiki/Oslo/CreatingANewLibrary\n but the script is likely going to need to be customized to make this happen. There is no \"canned\" way to do this.","commit_id":"25ff221090fc3f560062c6eae5ff48d9b3c7b009"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"4e6878a5b84a70e4dba12d60ba363277f7998054","unresolved":false,"context_lines":[{"line_number":11,"context_line":"`bp split-middleware"},{"line_number":12,"context_line":"\u003chttps://blueprints.launchpad.net/keystone/+spec/split-middleware\u003e`_"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Keystone has a sufficient quantity of Middleware to justify a separate repo."},{"line_number":15,"context_line":"These will come from multiple projects, to include the Keystone Server and"},{"line_number":16,"context_line":"python-keystoneclient repositories. This split is specifically to address"},{"line_number":17,"context_line":"a few major requests:"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1ae5cdf2_663ff625","line":14,"updated":"2014-06-18 18:43:37.000000000","message":"\"Middleware\" -\u003e \"middleware\"","commit_id":"70c041476ea38fdfcf0697c2a81040a888861226"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"4e6878a5b84a70e4dba12d60ba363277f7998054","unresolved":false,"context_lines":[{"line_number":12,"context_line":"\u003chttps://blueprints.launchpad.net/keystone/+spec/split-middleware\u003e`_"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Keystone has a sufficient quantity of Middleware to justify a separate repo."},{"line_number":15,"context_line":"These will come from multiple projects, to include the Keystone Server and"},{"line_number":16,"context_line":"python-keystoneclient repositories. This split is specifically to address"},{"line_number":17,"context_line":"a few major requests:"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"1ae5cdf2_a6457eb5","line":15,"updated":"2014-06-18 18:43:37.000000000","message":"lowercase \"server\"","commit_id":"70c041476ea38fdfcf0697c2a81040a888861226"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"4e6878a5b84a70e4dba12d60ba363277f7998054","unresolved":false,"context_lines":[{"line_number":17,"context_line":"a few major requests:"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"* Limit the dependencies of python-keystoneclient. Some of the middleware"},{"line_number":20,"context_line":"  dependencies do not make sense to require of a CLI utility or an API"},{"line_number":21,"context_line":"  library."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"* Allow for separate release scheduling (and isolation of changes) between"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1ae5cdf2_86232204","line":20,"updated":"2014-06-18 18:43:37.000000000","message":"(e.g., memcache)","commit_id":"70c041476ea38fdfcf0697c2a81040a888861226"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"4e6878a5b84a70e4dba12d60ba363277f7998054","unresolved":false,"context_lines":[{"line_number":32,"context_line":"Problem Description"},{"line_number":33,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Most of the middleware currently lives in python-keystoneclient. However, the"},{"line_number":36,"context_line":"middleware code pulls in dependencies specific to servers, and that are not"},{"line_number":37,"context_line":"appropriate for command line clients and other integrated scripts. There are"},{"line_number":38,"context_line":"sufficiently different use cases that they should be their own repositories and"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1ae5cdf2_46467a7c","line":35,"updated":"2014-06-18 18:43:37.000000000","message":"does the library need python- on it? openstack/keystone isn\u0027t openstack/python-keystone. And the oslo libs are python-oslo.db.","commit_id":"70c041476ea38fdfcf0697c2a81040a888861226"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"c2d6c6b00a0f8d8eee9c3bc2e0def1e6b98a7035","unresolved":false,"context_lines":[{"line_number":32,"context_line":"Problem Description"},{"line_number":33,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Most of the middleware currently lives in python-keystoneclient. However, the"},{"line_number":36,"context_line":"middleware code pulls in dependencies specific to servers, and that are not"},{"line_number":37,"context_line":"appropriate for command line clients and other integrated scripts. There are"},{"line_number":38,"context_line":"sufficiently different use cases that they should be their own repositories and"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1ae5cdf2_110caaeb","line":35,"in_reply_to":"1ae5cdf2_46467a7c","updated":"2014-06-18 18:46:51.000000000","message":"in git it is \u0027python-keystoneclient\u0027","commit_id":"70c041476ea38fdfcf0697c2a81040a888861226"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"4e6878a5b84a70e4dba12d60ba363277f7998054","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Create a new repository called python-keystonemiddleware and use the"},{"line_number":45,"context_line":"oslo-incubator graduation utilities to copy the data from"},{"line_number":46,"context_line":"python-keystoneclient/middleware while maintaining the commit history."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Once the new package is released the old middleware would be frozen"},{"line_number":49,"context_line":"(security fixes only, no new features) and all new development would"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1ae5cdf2_a64adeaa","line":46,"updated":"2014-06-18 18:43:37.000000000","message":"python-keystoneclient/middleware and the tests!\n\nThis mentions middleware in keystoneclient but not middleware in keystone.","commit_id":"70c041476ea38fdfcf0697c2a81040a888861226"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"c2d6c6b00a0f8d8eee9c3bc2e0def1e6b98a7035","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Create a new repository called python-keystonemiddleware and use the"},{"line_number":45,"context_line":"oslo-incubator graduation utilities to copy the data from"},{"line_number":46,"context_line":"python-keystoneclient/middleware while maintaining the commit history."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Once the new package is released the old middleware would be frozen"},{"line_number":49,"context_line":"(security fixes only, no new features) and all new development would"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1ae5cdf2_91ffdaaa","line":46,"in_reply_to":"1ae5cdf2_a64adeaa","updated":"2014-06-18 18:46:51.000000000","message":"Will add","commit_id":"70c041476ea38fdfcf0697c2a81040a888861226"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"4e6878a5b84a70e4dba12d60ba363277f7998054","unresolved":false,"context_lines":[{"line_number":45,"context_line":"oslo-incubator graduation utilities to copy the data from"},{"line_number":46,"context_line":"python-keystoneclient/middleware while maintaining the commit history."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Once the new package is released the old middleware would be frozen"},{"line_number":49,"context_line":"(security fixes only, no new features) and all new development would"},{"line_number":50,"context_line":"be done against the code in the new middleware package."},{"line_number":51,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"1ae5cdf2_66b0d68b","line":48,"updated":"2014-06-18 18:43:37.000000000","message":"should make it clear that the new package here is an initial release of keystonemiddleware so nobody\u0027s thinking it\u0027s a new python-keystoneclient release.","commit_id":"70c041476ea38fdfcf0697c2a81040a888861226"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"c2d6c6b00a0f8d8eee9c3bc2e0def1e6b98a7035","unresolved":false,"context_lines":[{"line_number":45,"context_line":"oslo-incubator graduation utilities to copy the data from"},{"line_number":46,"context_line":"python-keystoneclient/middleware while maintaining the commit history."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Once the new package is released the old middleware would be frozen"},{"line_number":49,"context_line":"(security fixes only, no new features) and all new development would"},{"line_number":50,"context_line":"be done against the code in the new middleware package."},{"line_number":51,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"1ae5cdf2_11daea4a","line":48,"in_reply_to":"1ae5cdf2_66b0d68b","updated":"2014-06-18 18:46:51.000000000","message":"done in next patch","commit_id":"70c041476ea38fdfcf0697c2a81040a888861226"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"4e6878a5b84a70e4dba12d60ba363277f7998054","unresolved":false,"context_lines":[{"line_number":57,"context_line":"the OpenStack named releases (similar to the python-keystoneclient"},{"line_number":58,"context_line":"library)."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"The inital release of the middleware package will be version 1.0."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Alternatives"},{"line_number":63,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1ae5cdf2_e6186686","line":60,"updated":"2014-06-18 18:43:37.000000000","message":"is the library versioning done using semver? http://semver.org/","commit_id":"70c041476ea38fdfcf0697c2a81040a888861226"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"c2d6c6b00a0f8d8eee9c3bc2e0def1e6b98a7035","unresolved":false,"context_lines":[{"line_number":57,"context_line":"the OpenStack named releases (similar to the python-keystoneclient"},{"line_number":58,"context_line":"library)."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"The inital release of the middleware package will be version 1.0."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Alternatives"},{"line_number":63,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1ae5cdf2_711dee0e","line":60,"in_reply_to":"1ae5cdf2_e6186686","updated":"2014-06-18 18:46:51.000000000","message":"It will use whatever PBR uses, pretty sure semver","commit_id":"70c041476ea38fdfcf0697c2a81040a888861226"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"4e6878a5b84a70e4dba12d60ba363277f7998054","unresolved":false,"context_lines":[{"line_number":83,"context_line":"Security Impact"},{"line_number":84,"context_line":"---------------"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"None"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"Notifications Impact"},{"line_number":89,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1ae5cdf2_918c3a82","line":86,"updated":"2014-06-18 18:43:37.000000000","message":"If we\u0027re going to keep a copy, then this should mention that we\u0027ll have 2 copies of the code and we\u0027ll have to provide security fixes for both.","commit_id":"70c041476ea38fdfcf0697c2a81040a888861226"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"c2d6c6b00a0f8d8eee9c3bc2e0def1e6b98a7035","unresolved":false,"context_lines":[{"line_number":83,"context_line":"Security Impact"},{"line_number":84,"context_line":"---------------"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"None"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"Notifications Impact"},{"line_number":89,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1ae5cdf2_31dfe63b","line":86,"in_reply_to":"1ae5cdf2_918c3a82","updated":"2014-06-18 18:46:51.000000000","message":"Sure.","commit_id":"70c041476ea38fdfcf0697c2a81040a888861226"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"4e6878a5b84a70e4dba12d60ba363277f7998054","unresolved":false,"context_lines":[{"line_number":131,"context_line":""},{"line_number":132,"context_line":"* copy code from python-keystoneclient to new repo using the oslo-incubator"},{"line_number":133,"context_line":"  graduation utilities to maintain the change history of each of the different"},{"line_number":134,"context_line":"  middlewares."},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"Dependencies"},{"line_number":137,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1ae5cdf2_51dd526f","line":134,"updated":"2014-06-18 18:43:37.000000000","message":"This mentions keystoneclient but doesn\u0027t mention keystone.\n\nAlso, the work to update the other projects to use auth_token middleware in middleware rather than python-keystoneclient.","commit_id":"70c041476ea38fdfcf0697c2a81040a888861226"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"c2d6c6b00a0f8d8eee9c3bc2e0def1e6b98a7035","unresolved":false,"context_lines":[{"line_number":131,"context_line":""},{"line_number":132,"context_line":"* copy code from python-keystoneclient to new repo using the oslo-incubator"},{"line_number":133,"context_line":"  graduation utilities to maintain the change history of each of the different"},{"line_number":134,"context_line":"  middlewares."},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"Dependencies"},{"line_number":137,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1ae5cdf2_71e40e0d","line":134,"in_reply_to":"1ae5cdf2_51dd526f","updated":"2014-06-18 18:46:51.000000000","message":"will add","commit_id":"70c041476ea38fdfcf0697c2a81040a888861226"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"4e6878a5b84a70e4dba12d60ba363277f7998054","unresolved":false,"context_lines":[{"line_number":132,"context_line":"* copy code from python-keystoneclient to new repo using the oslo-incubator"},{"line_number":133,"context_line":"  graduation utilities to maintain the change history of each of the different"},{"line_number":134,"context_line":"  middlewares."},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"Dependencies"},{"line_number":137,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":138,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"1ae5cdf2_e695c6e4","line":135,"updated":"2014-06-18 18:43:37.000000000","message":"* change keystoneclient middleware so that it prints out a deprecated message if it\u0027s used","commit_id":"70c041476ea38fdfcf0697c2a81040a888861226"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"585c1cedb731d3139d3f0a800c70345a596a2180","unresolved":false,"context_lines":[{"line_number":132,"context_line":"* copy code from python-keystoneclient to new repo using the oslo-incubator"},{"line_number":133,"context_line":"  graduation utilities to maintain the change history of each of the different"},{"line_number":134,"context_line":"  middlewares."},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"Dependencies"},{"line_number":137,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":138,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"1ae5cdf2_9168ba89","line":135,"in_reply_to":"1ae5cdf2_e695c6e4","updated":"2014-06-18 18:44:57.000000000","message":"Also, \"release an initial version of the keystonemiddleware package\"\n\nAlso, \"update global requirements to add the new keystonemiddleware\"","commit_id":"70c041476ea38fdfcf0697c2a81040a888861226"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"c2d6c6b00a0f8d8eee9c3bc2e0def1e6b98a7035","unresolved":false,"context_lines":[{"line_number":132,"context_line":"* copy code from python-keystoneclient to new repo using the oslo-incubator"},{"line_number":133,"context_line":"  graduation utilities to maintain the change history of each of the different"},{"line_number":134,"context_line":"  middlewares."},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"Dependencies"},{"line_number":137,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":138,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"1ae5cdf2_b1ea16d6","line":135,"in_reply_to":"1ae5cdf2_e695c6e4","updated":"2014-06-18 18:46:51.000000000","message":"will add","commit_id":"70c041476ea38fdfcf0697c2a81040a888861226"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"2291b9314b4b46544e7a393bc7c9688ba852ec10","unresolved":false,"context_lines":[{"line_number":26,"context_line":"  concern when updating the middleware (no accidental impact to the public"},{"line_number":27,"context_line":"  interfaces of the client library/CLI)."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"* Consolidate all ``OpenStack Identity``-specific middleware to a single"},{"line_number":30,"context_line":"  repository."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Problem Description"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1ae5cdf2_6ca0b590","line":29,"updated":"2014-06-18 19:15:20.000000000","message":"I don\u0027t think OpenStack Identity belongs in `` since it\u0027s just a name, not some constant string.","commit_id":"5ce841f33f77b285712294e56b0ae01040c14be1"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"2291b9314b4b46544e7a393bc7c9688ba852ec10","unresolved":false,"context_lines":[{"line_number":42,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Create a new repository called keystonemiddleware and use the"},{"line_number":45,"context_line":"oslo-incubator graduation utilities to copy the data from"},{"line_number":46,"context_line":"python-keystoneclient/middleware and keystone/middleware while"},{"line_number":47,"context_line":"maintaining the commit history. The tests for the middleware code will"},{"line_number":48,"context_line":"also be migrated (maintaining history as possible). Only middleware"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1ae5cdf2_4cd139fa","line":45,"updated":"2014-06-18 19:15:20.000000000","message":"suggest change \"data\" to \"code\"","commit_id":"5ce841f33f77b285712294e56b0ae01040c14be1"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"2291b9314b4b46544e7a393bc7c9688ba852ec10","unresolved":false,"context_lines":[{"line_number":49,"context_line":"from Keystone that is used by external services will be migrated"},{"line_number":50,"context_line":"(e.g. ec2token)."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Once the python-keystonemiddlewate package is released the middleware"},{"line_number":53,"context_line":"in the old locations (pythong-keystoneclient and keystone) will be frozen"},{"line_number":54,"context_line":"(security fixes only, no new features) and all new development would"},{"line_number":55,"context_line":"be done against the code in the new middleware package."}],"source_content_type":"text/x-rst","patch_set":9,"id":"1ae5cdf2_0cfbb17b","line":52,"updated":"2014-06-18 19:15:20.000000000","message":"change \"python-keystonemiddlewate\" to \"keystonemiddleware\"","commit_id":"5ce841f33f77b285712294e56b0ae01040c14be1"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"2291b9314b4b46544e7a393bc7c9688ba852ec10","unresolved":false,"context_lines":[{"line_number":50,"context_line":"(e.g. ec2token)."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Once the python-keystonemiddlewate package is released the middleware"},{"line_number":53,"context_line":"in the old locations (pythong-keystoneclient and keystone) will be frozen"},{"line_number":54,"context_line":"(security fixes only, no new features) and all new development would"},{"line_number":55,"context_line":"be done against the code in the new middleware package."},{"line_number":56,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"1ae5cdf2_aceb9da2","line":53,"updated":"2014-06-18 19:15:20.000000000","message":"change \"pythong-keystoneclient\" to \"python-keystoneclient\"\n\nI would expect the middleware in keystone would be removed and not copied since there\u0027s no circular dependency issue there.","commit_id":"5ce841f33f77b285712294e56b0ae01040c14be1"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"2291b9314b4b46544e7a393bc7c9688ba852ec10","unresolved":false,"context_lines":[{"line_number":62,"context_line":"the OpenStack named releases (similar to the python-keystoneclient"},{"line_number":63,"context_line":"library)."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"The inital release of the middleware package will be version 1.0.0."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Alternatives"},{"line_number":68,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1ae5cdf2_8c4501b6","line":65,"updated":"2014-06-18 19:15:20.000000000","message":"document that semver is going to be used, if that\u0027s what we\u0027re using.","commit_id":"5ce841f33f77b285712294e56b0ae01040c14be1"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"2291b9314b4b46544e7a393bc7c9688ba852ec10","unresolved":false,"context_lines":[{"line_number":139,"context_line":"  oslo-incubator graduation utilities to maintain the change history."},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"* Copy middleware (used by external services (e.g. ec2token)) code and tests from"},{"line_number":142,"context_line":"  keystone to the new repo using the oslo-incubator gratuation utilities to"},{"line_number":143,"context_line":"  maintain the change history."},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"* Change keystoneclient middleware so that it prints out a deprecated message if"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1ae5cdf2_2c286d32","line":142,"updated":"2014-06-18 19:15:20.000000000","message":"\"gratuation\" -\u003e \"graduation\"","commit_id":"5ce841f33f77b285712294e56b0ae01040c14be1"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"2291b9314b4b46544e7a393bc7c9688ba852ec10","unresolved":false,"context_lines":[{"line_number":142,"context_line":"  keystone to the new repo using the oslo-incubator gratuation utilities to"},{"line_number":143,"context_line":"  maintain the change history."},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"* Change keystoneclient middleware so that it prints out a deprecated message if"},{"line_number":146,"context_line":"  it\u0027s used."},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"* Release an initial version of the keystonemiddleware package."}],"source_content_type":"text/x-rst","patch_set":9,"id":"1ae5cdf2_cc82a951","line":145,"updated":"2014-06-18 19:15:20.000000000","message":"should be \"Change keystone and keystoneclient middleware\"\n\nAlso, the keystone s3_token middleware deprecated message should be updated to refer to keystonemiddleware rather than keystoneclient.","commit_id":"5ce841f33f77b285712294e56b0ae01040c14be1"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"2291b9314b4b46544e7a393bc7c9688ba852ec10","unresolved":false,"context_lines":[{"line_number":145,"context_line":"* Change keystoneclient middleware so that it prints out a deprecated message if"},{"line_number":146,"context_line":"  it\u0027s used."},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"* Release an initial version of the keystonemiddleware package."},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"* Update global requirements to add the new keystonemiddleware package."},{"line_number":151,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"1ae5cdf2_cce9c91b","line":148,"updated":"2014-06-18 19:15:20.000000000","message":"this must be done before keystone and keystoneclient middleware is deprecated.","commit_id":"5ce841f33f77b285712294e56b0ae01040c14be1"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"85b71ea21012ff31d3cba2a57d2ddc93a81264c0","unresolved":false,"context_lines":[{"line_number":50,"context_line":"(e.g. ec2token)."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Once the keystonemiddleware package is released the middleware"},{"line_number":53,"context_line":"in the old locations (python-keystoneclient and keystone) will be frozen"},{"line_number":54,"context_line":"(security fixes only, no new features) and all new development would"},{"line_number":55,"context_line":"be done against the code in the new middleware package."},{"line_number":56,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"1ae5cdf2_5741c237","line":53,"updated":"2014-06-18 19:29:42.000000000","message":"I would expect the middleware in keystone would be removed and not copied since there\u0027s no circular dependency issue there.","commit_id":"3e40c416a7d90fa00d9d0ba2f27fafa180c4559a"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"3e990250dbe41bcba54dc25d60caeb0f076c84f1","unresolved":false,"context_lines":[{"line_number":50,"context_line":"(e.g. ec2token)."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Once the keystonemiddleware package is released the middleware"},{"line_number":53,"context_line":"in the old locations (python-keystoneclient and keystone) will be frozen"},{"line_number":54,"context_line":"(security fixes only, no new features) and all new development would"},{"line_number":55,"context_line":"be done against the code in the new middleware package."},{"line_number":56,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"1ae5cdf2_17573a5b","line":53,"in_reply_to":"1ae5cdf2_5741c237","updated":"2014-06-18 19:46:25.000000000","message":"I think i missed that part of the comment last time (looking back it was there)","commit_id":"3e40c416a7d90fa00d9d0ba2f27fafa180c4559a"}],"specs/middleware/keystoneclient/split-middleware-repo":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"4a000f0198f26dc09f75771532faf1fa28cc8ba9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3ae8d1ca_9b4be0af","updated":"2014-05-28 02:59:13.000000000","message":"2 spaces? what is this, 1980? \n\nit\u0027s all over the doc.","commit_id":"0d5b56685faa91df8f64b4112b324c0c36af709f"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"514f675938030212cce99ffbb14e6a24fdbdbf27","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3ae8d1ca_033670e7","in_reply_to":"3ae8d1ca_9b4be0af","updated":"2014-05-28 15:47:26.000000000","message":"Hey You\u0027re stealing bknudson\u0027s comment!","commit_id":"0d5b56685faa91df8f64b4112b324c0c36af709f"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"8365e6e4c776687144031df3187379ab1b59527f","unresolved":false,"context_lines":[{"line_number":3,"context_line":" License."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Create the Middleware Repo"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"3ae8d1ca_572756b6","line":6,"updated":"2014-05-28 14:02:36.000000000","message":"I think this filename has to end with .rst","commit_id":"0d5b56685faa91df8f64b4112b324c0c36af709f"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"4838e45c98c218e638d4b2d8b3941ee0ebd9c0e5","unresolved":false,"context_lines":[{"line_number":3,"context_line":" License."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Create the Middleware Repo"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"1ae5cdf2_ef1432f7","line":6,"in_reply_to":"1ae5cdf2_aff881c5","updated":"2014-05-30 14:23:26.000000000","message":"++ to clarify: split-middleware-repo.rst - i thought the comment was referring to CC legalcode[.rst]","commit_id":"0d5b56685faa91df8f64b4112b324c0c36af709f"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"110abf6f849752d2fbebb782d381a8cd9c478389","unresolved":false,"context_lines":[{"line_number":3,"context_line":" License."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Create the Middleware Repo"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"1ae5cdf2_aff881c5","line":6,"in_reply_to":"3ae8d1ca_572756b6","updated":"2014-05-29 22:47:50.000000000","message":"++","commit_id":"0d5b56685faa91df8f64b4112b324c0c36af709f"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"110abf6f849752d2fbebb782d381a8cd9c478389","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Include the URL of your launchpad blueprint::"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"  https://blueprints.launchpad.net/keystone/+spec/example"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Keystone has sufficient quantity of Middleware components that require"},{"line_number":16,"context_line":"their own repo. These will come from multiple projects, to include the"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"1ae5cdf2_ef19a923","line":13,"updated":"2014-05-29 22:47:50.000000000","message":"This isn\u0027t a valid or proposed BP link. \n\nThis should be a link (at the very least unindented) - I\u0027ll fix the template","commit_id":"0d5b56685faa91df8f64b4112b324c0c36af709f"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"4d33a9f315c2aca44ac0414618bf67964c444fb8","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Include the URL of your launchpad blueprint::"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"  https://blueprints.launchpad.net/keystone/+spec/example"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Keystone has sufficient quantity of Middleware components that require"},{"line_number":16,"context_line":"their own repo. These will come from multiple projects, to include the"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"1ae5cdf2_45f2679b","line":13,"in_reply_to":"1ae5cdf2_8fd3ae37","updated":"2014-05-30 15:03:38.000000000","message":"Works for me.","commit_id":"0d5b56685faa91df8f64b4112b324c0c36af709f"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"4838e45c98c218e638d4b2d8b3941ee0ebd9c0e5","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Include the URL of your launchpad blueprint::"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"  https://blueprints.launchpad.net/keystone/+spec/example"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Keystone has sufficient quantity of Middleware components that require"},{"line_number":16,"context_line":"their own repo. These will come from multiple projects, to include the"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"1ae5cdf2_8fd3ae37","line":13,"in_reply_to":"1ae5cdf2_ef19a923","updated":"2014-05-30 14:23:26.000000000","message":"i think we should discuss this process, as-is we\u0027re requiring spec-proposers to file blueprints which may seem redundant. if the spec is approved, maybe then -drivers should create the corresponding bp?","commit_id":"0d5b56685faa91df8f64b4112b324c0c36af709f"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"110abf6f849752d2fbebb782d381a8cd9c478389","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"  https://blueprints.launchpad.net/keystone/+spec/example"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Keystone has sufficient quantity of Middleware components that require"},{"line_number":16,"context_line":"their own repo. These will come from multiple projects, to include the"},{"line_number":17,"context_line":"Keystone Server and python-keystoneclient repositories."},{"line_number":18,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"1ae5cdf2_0f17b5ee","line":15,"updated":"2014-05-29 22:47:50.000000000","message":"suggest: \"has a sufficient quantity of Middleware to justify a separate repo\"","commit_id":"0d5b56685faa91df8f64b4112b324c0c36af709f"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"4838e45c98c218e638d4b2d8b3941ee0ebd9c0e5","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"  https://blueprints.launchpad.net/keystone/+spec/example"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Keystone has sufficient quantity of Middleware components that require"},{"line_number":16,"context_line":"their own repo. These will come from multiple projects, to include the"},{"line_number":17,"context_line":"Keystone Server and python-keystoneclient repositories."},{"line_number":18,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"1ae5cdf2_efe27202","line":15,"in_reply_to":"1ae5cdf2_0f17b5ee","updated":"2014-05-30 14:23:26.000000000","message":"++","commit_id":"0d5b56685faa91df8f64b4112b324c0c36af709f"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"4838e45c98c218e638d4b2d8b3941ee0ebd9c0e5","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Keystone has sufficient quantity of Middleware components that require"},{"line_number":16,"context_line":"their own repo. These will come from multiple projects, to include the"},{"line_number":17,"context_line":"Keystone Server and python-keystoneclient repositories."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"1ae5cdf2_8fbacedf","line":17,"updated":"2014-05-30 14:23:26.000000000","message":"this is also very weak reasoning, which i don\u0027t buy at all. discuss the benefits of a separate packaging and dependency process instead.","commit_id":"0d5b56685faa91df8f64b4112b324c0c36af709f"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"110abf6f849752d2fbebb782d381a8cd9c478389","unresolved":false,"context_lines":[{"line_number":21,"context_line":"Problem Description"},{"line_number":22,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Most of the middleware currently live in python-keystoneclient.  However, the"},{"line_number":25,"context_line":"middleware code pulls in dependencies specific to servers, and that are not"},{"line_number":26,"context_line":"appropriate for command line clients and other integrated scripts.  They are"},{"line_number":27,"context_line":"sufficiently different use cases that they should be their own repositories and"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"1ae5cdf2_2fd39139","line":24,"updated":"2014-05-29 22:47:50.000000000","message":"change \"live\" to \"lives\"","commit_id":"0d5b56685faa91df8f64b4112b324c0c36af709f"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"4a000f0198f26dc09f75771532faf1fa28cc8ba9","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Most of the middleware currently live in python-keystoneclient.  However, the"},{"line_number":25,"context_line":"middleware code pulls in dependencies specific to servers, and that are not"},{"line_number":26,"context_line":"appropriate for command line clients and other integrated scripts.  They are"},{"line_number":27,"context_line":"sufficiently different use cases that they should be their own repositories and"},{"line_number":28,"context_line":"python packages."},{"line_number":29,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"3ae8d1ca_1b60b031","line":26,"updated":"2014-05-28 02:59:13.000000000","message":"s/They/There","commit_id":"0d5b56685faa91df8f64b4112b324c0c36af709f"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"4a000f0198f26dc09f75771532faf1fa28cc8ba9","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Create a new repository called python-keystonemiddleware and"},{"line_number":35,"context_line":"Copy the contents of python-keystoneclient/middleware into the subdirectory"},{"line_number":36,"context_line":"keystonemiddelware/"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Alternatives"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"3ae8d1ca_bb609c36","line":36,"updated":"2014-05-28 02:59:13.000000000","message":"s/middel/middle","commit_id":"0d5b56685faa91df8f64b4112b324c0c36af709f"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"4838e45c98c218e638d4b2d8b3941ee0ebd9c0e5","unresolved":false,"context_lines":[{"line_number":39,"context_line":"Alternatives"},{"line_number":40,"context_line":"------------"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"None"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Data Model Impact"},{"line_number":45,"context_line":"-----------------"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"1ae5cdf2_8fa1eeab","line":42,"updated":"2014-05-30 14:23:26.000000000","message":"might be worth pointing out that we already have an alternative - middleware stays in the client.","commit_id":"0d5b56685faa91df8f64b4112b324c0c36af709f"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"4838e45c98c218e638d4b2d8b3941ee0ebd9c0e5","unresolved":false,"context_lines":[{"line_number":54,"context_line":"Security Impact"},{"line_number":55,"context_line":"---------------"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"None"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"Notifications Impact"},{"line_number":60,"context_line":"--------------------"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"1ae5cdf2_cfabf687","line":57,"updated":"2014-05-30 14:23:26.000000000","message":"you\u0027ve been discussing security impact, as the release process for vulnerabilities is impacted. add that here.","commit_id":"0d5b56685faa91df8f64b4112b324c0c36af709f"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"4a000f0198f26dc09f75771532faf1fa28cc8ba9","unresolved":false,"context_lines":[{"line_number":64,"context_line":"Other End User Impact"},{"line_number":65,"context_line":"---------------------"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"The other projects will gain a dependency on the new package.  To start, keystoneclient will depend on the new package.  Once the other projects are updated,"},{"line_number":68,"context_line":"this will be reversed."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Performance Impact"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"3ae8d1ca_fbd144ce","line":67,"updated":"2014-05-28 02:59:13.000000000","message":"i\u0027m surprised jenkins didn\u0027t complain about this, it\u0027s a very long line","commit_id":"0d5b56685faa91df8f64b4112b324c0c36af709f"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"514f675938030212cce99ffbb14e6a24fdbdbf27","unresolved":false,"context_lines":[{"line_number":64,"context_line":"Other End User Impact"},{"line_number":65,"context_line":"---------------------"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"The other projects will gain a dependency on the new package.  To start, keystoneclient will depend on the new package.  Once the other projects are updated,"},{"line_number":68,"context_line":"this will be reversed."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Performance Impact"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"3ae8d1ca_a30a1c1f","line":67,"in_reply_to":"3ae8d1ca_fbd144ce","updated":"2014-05-28 15:47:26.000000000","message":"We don\u0027t line-length check. There will be cases we can\u0027t (e.g. LONG urls).\n\nIt is a convention we likely need to manage via review.","commit_id":"0d5b56685faa91df8f64b4112b324c0c36af709f"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"4838e45c98c218e638d4b2d8b3941ee0ebd9c0e5","unresolved":false,"context_lines":[{"line_number":75,"context_line":"Other Deployer Impact"},{"line_number":76,"context_line":"---------------------"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"None"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"Developer Impact"},{"line_number":81,"context_line":"----------------"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"1ae5cdf2_efcfd2ae","line":78,"updated":"2014-05-30 14:23:26.000000000","message":"deployers will be impacted by a new repo, so will packagers","commit_id":"0d5b56685faa91df8f64b4112b324c0c36af709f"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"4a000f0198f26dc09f75771532faf1fa28cc8ba9","unresolved":false,"context_lines":[{"line_number":80,"context_line":"Developer Impact"},{"line_number":81,"context_line":"----------------"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"Develpoers will need to be aware of which repo to submit code changes against."},{"line_number":84,"context_line":""},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"Implementation"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"3ae8d1ca_1bd7d0c2","line":83,"updated":"2014-05-28 02:59:13.000000000","message":"use repository, not repo, few other instances in the doc","commit_id":"0d5b56685faa91df8f64b4112b324c0c36af709f"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"4838e45c98c218e638d4b2d8b3941ee0ebd9c0e5","unresolved":false,"context_lines":[{"line_number":95,"context_line":"Work Items"},{"line_number":96,"context_line":"----------"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"* create new repo"},{"line_number":99,"context_line":"* copy code from python-keystoneclient to new repo"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"1ae5cdf2_8fb64edb","line":98,"updated":"2014-05-30 14:23:26.000000000","message":"nothing in this spec makes it clear exactly what that repo will be called","commit_id":"0d5b56685faa91df8f64b4112b324c0c36af709f"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"4838e45c98c218e638d4b2d8b3941ee0ebd9c0e5","unresolved":false,"context_lines":[{"line_number":96,"context_line":"----------"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"* create new repo"},{"line_number":99,"context_line":"* copy code from python-keystoneclient to new repo"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"Dependencies"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"1ae5cdf2_0fa31e9f","line":99,"updated":"2014-05-30 14:23:26.000000000","message":"* propose changes to openstack/governance\n* release initial version of middleware to pypi\n* import from new repo into keystoneclient, to maintain backwards compatibility\n* global requirements has impact\n\ni\u0027m sure there are more things we have to touch - please think through them all.","commit_id":"0d5b56685faa91df8f64b4112b324c0c36af709f"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"4a000f0198f26dc09f75771532faf1fa28cc8ba9","unresolved":false,"context_lines":[{"line_number":103,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"None"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"Testing"},{"line_number":108,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":109,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"3ae8d1ca_5bd878ef","line":106,"updated":"2014-05-28 02:59:13.000000000","message":"add another line break here","commit_id":"0d5b56685faa91df8f64b4112b324c0c36af709f"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"110abf6f849752d2fbebb782d381a8cd9c478389","unresolved":false,"context_lines":[{"line_number":107,"context_line":"Testing"},{"line_number":108,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"Will be tested by current gate."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"Documentation Impact"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"1ae5cdf2_8fe2e501","line":110,"updated":"2014-05-29 22:47:50.000000000","message":"Suggest adding: Middleware specific unit tests will be moved to the new repository.","commit_id":"0d5b56685faa91df8f64b4112b324c0c36af709f"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"4838e45c98c218e638d4b2d8b3941ee0ebd9c0e5","unresolved":false,"context_lines":[{"line_number":107,"context_line":"Testing"},{"line_number":108,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"Will be tested by current gate."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"Documentation Impact"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"1ae5cdf2_6fd8221e","line":110,"in_reply_to":"1ae5cdf2_8fe2e501","updated":"2014-05-30 14:23:26.000000000","message":"Tests are certainly going to be a challenge.","commit_id":"0d5b56685faa91df8f64b4112b324c0c36af709f"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"4838e45c98c218e638d4b2d8b3941ee0ebd9c0e5","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"Docs will need to be updated as far as where to look for keystone middleware"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"References"},{"line_number":120,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":121,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"1ae5cdf2_4f9fe65f","line":118,"updated":"2014-05-30 14:23:26.000000000","message":"can we add a gate job that -1\u0027s on \\n\\n\\n or more?","commit_id":"0d5b56685faa91df8f64b4112b324c0c36af709f"}]}