)]}'
{"keystone_tempest_plugin/tests/api/identity/v3/test_oauth1_tokens.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"313e1e28955277a182cd7d88f9857729a0b49e93","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        return consumer"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def _create_request_token(self, consumer):"},{"line_number":37,"context_line":"        \"\"\"Create request token\"\"\""},{"line_number":38,"context_line":"        project_id \u003d self.oauth_token_client \\"},{"line_number":39,"context_line":"                         .auth_provider.credentials.project_id"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7f231b9d_5fda9977","line":37,"updated":"2017-06-16 17:44:19.000000000","message":"nit: We can use docstring as an opportunity to elaborate on a method or it\u0027s usage. There isn\u0027t much information provided here that we don\u0027t already glean from the method name. We could iterate on it either now or in a follow on patch:\n\n  \"\"\"Create a request token to authorize access for a consumer.\"\"\"\n\nOr something along those lines that gives the reader more information. This comment could be applied throughout the module.","commit_id":"f8fe2a7e3b48ea1886895c0b46b2483bc7461691"},{"author":{"_account_id":10366,"name":"Hemanth N","email":"hemanth.nakkina@canonical.com","username":"Hemanth"},"change_message_id":"a820ca676f37976d355d9dd3cf58091016593ed7","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        return consumer"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def _create_request_token(self, consumer):"},{"line_number":37,"context_line":"        \"\"\"Create request token\"\"\""},{"line_number":38,"context_line":"        project_id \u003d self.oauth_token_client \\"},{"line_number":39,"context_line":"                         .auth_provider.credentials.project_id"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7f231b9d_a7028208","line":37,"in_reply_to":"7f231b9d_5fda9977","updated":"2017-06-20 06:46:56.000000000","message":"Done, Fixed in PS3","commit_id":"f8fe2a7e3b48ea1886895c0b46b2483bc7461691"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"313e1e28955277a182cd7d88f9857729a0b49e93","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    def _create_request_token(self, consumer):"},{"line_number":37,"context_line":"        \"\"\"Create request token\"\"\""},{"line_number":38,"context_line":"        project_id \u003d self.oauth_token_client \\"},{"line_number":39,"context_line":"                         .auth_provider.credentials.project_id"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        request_token \u003d self.oauth_token_client.create_request_token("},{"line_number":42,"context_line":"            consumer[\u0027id\u0027], consumer[\u0027secret\u0027], project_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f231b9d_c974bad1","line":39,"updated":"2017-06-16 17:44:19.000000000","message":"nit: We typically avoid line breaks by wrapping long lines in ()\n\n  project_id \u003d (\n      self.oauth_token_client.auth_provider.credentials.project_id\n  )\n\nThis comment could be applied throughout the module.","commit_id":"f8fe2a7e3b48ea1886895c0b46b2483bc7461691"},{"author":{"_account_id":10366,"name":"Hemanth N","email":"hemanth.nakkina@canonical.com","username":"Hemanth"},"change_message_id":"a820ca676f37976d355d9dd3cf58091016593ed7","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    def _create_request_token(self, consumer):"},{"line_number":37,"context_line":"        \"\"\"Create request token\"\"\""},{"line_number":38,"context_line":"        project_id \u003d self.oauth_token_client \\"},{"line_number":39,"context_line":"                         .auth_provider.credentials.project_id"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        request_token \u003d self.oauth_token_client.create_request_token("},{"line_number":42,"context_line":"            consumer[\u0027id\u0027], consumer[\u0027secret\u0027], project_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f231b9d_87078619","line":39,"in_reply_to":"7f231b9d_c974bad1","updated":"2017-06-20 06:46:56.000000000","message":"Done, Fixed in PS3","commit_id":"f8fe2a7e3b48ea1886895c0b46b2483bc7461691"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"313e1e28955277a182cd7d88f9857729a0b49e93","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    @decorators.idempotent_id(\u002723d2fe8d-fc8d-4bef-8aaa-289400732c3f\u0027)"},{"line_number":78,"context_line":"    def test_create_and_show_consumer(self):"},{"line_number":79,"context_line":"        \"\"\"Tests to make sure that a consumer with parameters is made\"\"\""},{"line_number":80,"context_line":"        consumer \u003d self._create_consumer()"},{"line_number":81,"context_line":"        # fetch created consumer from client"},{"line_number":82,"context_line":"        fetched_consumer \u003d self.consumers_client.show_consumer("}],"source_content_type":"text/x-python","patch_set":2,"id":"7f231b9d_293a0ee6","line":79,"updated":"2017-06-16 17:44:19.000000000","message":"nit: End the docstring with punctuation to be consistent with other doc strings in this module.","commit_id":"f8fe2a7e3b48ea1886895c0b46b2483bc7461691"},{"author":{"_account_id":10366,"name":"Hemanth N","email":"hemanth.nakkina@canonical.com","username":"Hemanth"},"change_message_id":"a820ca676f37976d355d9dd3cf58091016593ed7","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    @decorators.idempotent_id(\u002723d2fe8d-fc8d-4bef-8aaa-289400732c3f\u0027)"},{"line_number":78,"context_line":"    def test_create_and_show_consumer(self):"},{"line_number":79,"context_line":"        \"\"\"Tests to make sure that a consumer with parameters is made\"\"\""},{"line_number":80,"context_line":"        consumer \u003d self._create_consumer()"},{"line_number":81,"context_line":"        # fetch created consumer from client"},{"line_number":82,"context_line":"        fetched_consumer \u003d self.consumers_client.show_consumer("}],"source_content_type":"text/x-python","patch_set":2,"id":"7f231b9d_47116e53","line":79,"in_reply_to":"7f231b9d_293a0ee6","updated":"2017-06-20 06:46:56.000000000","message":"Done, fixed in PS3","commit_id":"f8fe2a7e3b48ea1886895c0b46b2483bc7461691"}],"releasenotes/notes/add-OS-OAUTH1-api-functional-tests-d8f1987d98c9ec0b.yaml":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"313e1e28955277a182cd7d88f9857729a0b49e93","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add Functional API tests for Identity OS-OAUTH1 API"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7f231b9d_49c42af5","line":3,"updated":"2017-06-16 17:44:19.000000000","message":"Yeah - I\u0027m not sure we need a release note for a change like this. Since this is closing the bug though, it would be great to have a release note explain the bug being fixed.","commit_id":"f8fe2a7e3b48ea1886895c0b46b2483bc7461691"},{"author":{"_account_id":10366,"name":"Hemanth N","email":"hemanth.nakkina@canonical.com","username":"Hemanth"},"change_message_id":"a820ca676f37976d355d9dd3cf58091016593ed7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add Functional API tests for Identity OS-OAUTH1 API"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7f231b9d_675a2a2b","line":3,"in_reply_to":"7f231b9d_49c42af5","updated":"2017-06-20 06:46:56.000000000","message":"The bug fix is on keystone side. And functional test cases are added as additional as part of that bug fix. So mentioning about the bug fix in keystone-tempest-plugin does not make sense to me. So deleting the releasenotes.","commit_id":"f8fe2a7e3b48ea1886895c0b46b2483bc7461691"}]}