)]}'
{"keystone_tempest_plugin/tests/api/identity/v3/test_identity_providers.py":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"e4ea4e1898819debf67b6bdaaa3494f6bf1b01c9","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    def _create_idp(self, idp_id, idp_ref):"},{"line_number":44,"context_line":"        idp \u003d self.idps_client.create_identity_provider("},{"line_number":45,"context_line":"            idp_id, **idp_ref)[\u0027identity_provider\u0027]"},{"line_number":46,"context_line":"        if not idp_ref.get(\u0027domain_id\u0027):"},{"line_number":47,"context_line":"            self.addCleanup("},{"line_number":48,"context_line":"                self.keystone_manager.domains_client.delete_domain,"},{"line_number":49,"context_line":"                idp[\u0027domain_id\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_100930db","line":46,"range":{"start_line":46,"start_character":11,"end_line":46,"end_character":14},"updated":"2018-07-24 13:40:16.000000000","message":"Isn\u0027t this backwards? Shouldn\u0027t this only add the cleanup if the domain_id is there?","commit_id":"fb2cf2cd394bace4360da373ef57c8a3e87578d2"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"2acd3878d3c65fea7afaf559ac88d601b68bd2a9","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    def _create_idp(self, idp_id, idp_ref):"},{"line_number":44,"context_line":"        idp \u003d self.idps_client.create_identity_provider("},{"line_number":45,"context_line":"            idp_id, **idp_ref)[\u0027identity_provider\u0027]"},{"line_number":46,"context_line":"        if not idp_ref.get(\u0027domain_id\u0027):"},{"line_number":47,"context_line":"            self.addCleanup("},{"line_number":48,"context_line":"                self.keystone_manager.domains_client.delete_domain,"},{"line_number":49,"context_line":"                idp[\u0027domain_id\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_b091579e","line":46,"range":{"start_line":46,"start_character":11,"end_line":46,"end_character":14},"in_reply_to":"5f7c97a3_100930db","updated":"2018-07-24 16:25:21.000000000","message":"ipd_ref is the idp\u0027s input.\nif domain_id is there, it means the new created idp\u0027s domain is an exist one, not the auto generated. So we should not cleanup it.","commit_id":"fb2cf2cd394bace4360da373ef57c8a3e87578d2"}],"keystone_tempest_plugin/tests/scenario/test_federated_authentication.py":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"42f6e36fd13cb46c5b89502b4a4c7d520f3de911","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            self.idp_id, remote_ids\u003dremote_ids, enabled\u003dTrue)"},{"line_number":55,"context_line":"        self.addCleanup("},{"line_number":56,"context_line":"            self.keystone_manager.domains_client.delete_domain,"},{"line_number":57,"context_line":"            idp[\u0027domain_id\u0027])"},{"line_number":58,"context_line":"        self.addCleanup("},{"line_number":59,"context_line":"            self.keystone_manager.domains_client.update_domain,"},{"line_number":60,"context_line":"            idp[\u0027domain_id\u0027], enabled\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_9fb3f609","line":57,"updated":"2018-07-25 09:08:56.000000000","message":"This seems to be causing the v3 tests to fail http://logs.openstack.org/63/579063/3/check/legacy-keystone-dsvm-functional-v3-only/e387e53/job-output.txt.gz#_2018-06-29_09_16_56_478371","commit_id":"fb2cf2cd394bace4360da373ef57c8a3e87578d2"}]}