)]}'
{"id":"openstack%2Fkeystone-tempest-plugin~689222","triplet_id":"openstack%2Fkeystone-tempest-plugin~master~I534470df7ca529511ab9a7631f167ec2035ab4be","project":"openstack/keystone-tempest-plugin","branch":"master","topic":"federation-testing","hashtags":[],"change_id":"I534470df7ca529511ab9a7631f167ec2035ab4be","subject":"Add option to disable testing against external idp","status":"MERGED","created":"2019-10-17 17:13:10.000000000","updated":"2019-10-25 21:55:49.000000000","submitted":"2019-10-25 21:55:49.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"689222-1572040549673-fa70c53b","meta_rev_id":"5f671ea8f2c4b0e693b1a11ac382deaa38eadf0d","_number":689222,"virtual_id_number":689222,"owner":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},{"value":0,"date":"2019-10-21 16:06:47.000000000","_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2019-10-25 21:55:49.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"all":[{"value":2,"date":"2019-10-22 16:50:50.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},{"value":0,"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"all":[{"value":1,"date":"2019-10-22 16:50:50.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},{"value":0,"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-10-21 16:06:47.000000000","updated_by":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"reviewer":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"state":"REVIEWER"},{"updated":"2019-10-22 16:50:50.000000000","updated_by":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"reviewer":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"state":"REVIEWER"},{"updated":"2019-10-25 21:55:49.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"56d3d5a3cdec06ce9e3ede8361de1d5c2c4239af","author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"date":"2019-10-17 17:13:10.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"480c53d37103cdc40ff620f74c125d66f61593f8","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-17 17:49:09.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/9f3492de45ca44948b234fb8af711391 : FAILURE in 3m 32s\n- keystone-dsvm-functional https://zuul.opendev.org/t/openstack/build/09bca3f669b5419fabb5059404ca6257 : SUCCESS in 33m 01s\n- keystone-dsvm-py3-functional https://zuul.opendev.org/t/openstack/build/4f8f87c8e1a04ef593812f79ee17eb85 : SUCCESS in 33m 18s\n- keystone-dsvm-functional-federation https://zuul.opendev.org/t/openstack/build/2a55c496536a4b068480b7874cc91658 : SUCCESS in 33m 56s (non-voting)\n- keystone-dsvm-py35-functional-federation https://zuul.opendev.org/t/openstack/build/8919d58e493f4a58b498fb58877ca516 : SUCCESS in 34m 29s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"ee99b51c18f217060503741a9a58a4e137cd441f","author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"date":"2019-10-17 18:01:38.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"bc1bd9b416b2070a80db24e6f91310cfe0444b93","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-17 18:33:47.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/397e6ef9d99843469cad2657dfcfec55 : SUCCESS in 3m 16s\n- keystone-dsvm-functional https://zuul.opendev.org/t/openstack/build/a87159fa66384ef1a9f4a1088f7f8bb9 : SUCCESS in 28m 34s\n- keystone-dsvm-py3-functional https://zuul.opendev.org/t/openstack/build/9734ba363f774ddd8323d75f998288fd : SUCCESS in 28m 38s\n- keystone-dsvm-functional-federation https://zuul.opendev.org/t/openstack/build/e94f2c2cd76e4d259e4cdbe7c1ed50f9 : SUCCESS in 28m 26s (non-voting)\n- keystone-dsvm-py35-functional-federation https://zuul.opendev.org/t/openstack/build/05e28b969e4a4f6e9ad3013a14897626 : SUCCESS in 30m 52s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"88d50277f11722efb73fc5970483d0e3771f26c0","author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"date":"2019-10-21 16:06:47.000000000","message":"Patch Set 2:\n\nAgreed. It should totally be the case after the Testshib wasn\u0027t maintained and broke our federation job cases which we used as an external IDP for our keystone. Testing K2K is a better regression testing.","accounts_in_message":[],"_revision_number":2},{"id":"08d68a15783915d9db8c8d400fb6246f4de9aa23","author":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"date":"2019-10-22 16:50:50.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"71e7ca5585b9bbf5fab7fd011a50f9ddd7c8ebf6","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-25 19:40:50.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"1480c4570ddb7622bc950117da09ff0d15d0da4f","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-25 21:55:49.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/cc94a3b0b2eb4bddb8fca7820bc184bb : SUCCESS in 4m 45s\n- keystone-dsvm-functional https://zuul.opendev.org/t/openstack/build/958757e9d9bf478d8df042f66d8c5028 : SUCCESS in 38m 54s\n- keystone-dsvm-py3-functional https://zuul.opendev.org/t/openstack/build/f3fbb608b7144154a71a8ed14c0219e2 : SUCCESS in 33m 51s","accounts_in_message":[],"_revision_number":2},{"id":"2ad52570c77f34843d577e0563f3f5904a723c4e","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-25 21:55:49.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"8ec445b13d329e6d347ff7a0a69a529f589ba649","revisions":{"c25ea2d79fa5cb3c15375f567853c5aeb8405f42":{"kind":"REWORK","_number":1,"created":"2019-10-17 17:13:10.000000000","uploader":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"ref":"refs/changes/22/689222/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystone-tempest-plugin","ref":"refs/changes/22/689222/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystone-tempest-plugin refs/changes/22/689222/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystone-tempest-plugin refs/changes/22/689222/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystone-tempest-plugin refs/changes/22/689222/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystone-tempest-plugin refs/changes/22/689222/1"}}},"commit":{"parents":[{"commit":"a9f65e0bcf9bbae35b7dae557429614d2a749e5d","subject":"Keystone to Keystone tests","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone-tempest-plugin/commit/a9f65e0bcf9bbae35b7dae557429614d2a749e5d"}]}],"author":{"name":"Colleen Murphy","email":"colleen.murphy@suse.de","date":"2019-10-17 17:02:31.000000000","tz":-420},"committer":{"name":"Colleen Murphy","email":"colleen.murphy@suse.de","date":"2019-10-17 17:02:31.000000000","tz":-420},"subject":"Add option to disable testing against external idp","message":"Add option to disable testing against external idp\n\nCurrently, the federation tests are non-voting because they require\nconnecting to an external service that is not under our control, and is\ntherefore unreliable. Non-voting tests are a problem because they are\noften ignored even when their results are related to new changes. This\nchange adds a tempest config option\n``[identity-feature-enabled]/external_idp``, defaulting to true for\nbackwards compatibility, which when disabled causes the tests that rely\non the external IdP to be disabled leaving only the K2K federation tests\nto be executed. Exercising only the K2K tests is still a good means of\nregression testing and we can safely make those tests voting.\n\nChange-Id: I534470df7ca529511ab9a7631f167ec2035ab4be\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone-tempest-plugin/commit/c25ea2d79fa5cb3c15375f567853c5aeb8405f42"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone-tempest-plugin/commit/c25ea2d79fa5cb3c15375f567853c5aeb8405f42"}]},"branch":"refs/heads/master"},"8ec445b13d329e6d347ff7a0a69a529f589ba649":{"kind":"REWORK","_number":2,"created":"2019-10-17 18:01:38.000000000","uploader":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"ref":"refs/changes/22/689222/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystone-tempest-plugin","ref":"refs/changes/22/689222/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystone-tempest-plugin refs/changes/22/689222/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystone-tempest-plugin refs/changes/22/689222/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystone-tempest-plugin refs/changes/22/689222/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystone-tempest-plugin refs/changes/22/689222/2"}}},"commit":{"parents":[{"commit":"a9f65e0bcf9bbae35b7dae557429614d2a749e5d","subject":"Keystone to Keystone tests","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone-tempest-plugin/commit/a9f65e0bcf9bbae35b7dae557429614d2a749e5d"}]}],"author":{"name":"Colleen Murphy","email":"colleen.murphy@suse.de","date":"2019-10-17 17:02:31.000000000","tz":-420},"committer":{"name":"Colleen Murphy","email":"colleen.murphy@suse.de","date":"2019-10-17 18:01:32.000000000","tz":-420},"subject":"Add option to disable testing against external idp","message":"Add option to disable testing against external idp\n\nCurrently, the federation tests are non-voting because they require\nconnecting to an external service that is not under our control, and is\ntherefore unreliable. Non-voting tests are a problem because they are\noften ignored even when their results are related to new changes. This\nchange adds a tempest config option\n``[identity-feature-enabled]/external_idp``, defaulting to true for\nbackwards compatibility, which when disabled causes the tests that rely\non the external IdP to be disabled leaving only the K2K federation tests\nto be executed. Exercising only the K2K tests is still a good means of\nregression testing and we can safely make those tests voting.\n\nChange-Id: I534470df7ca529511ab9a7631f167ec2035ab4be\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone-tempest-plugin/commit/8ec445b13d329e6d347ff7a0a69a529f589ba649"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone-tempest-plugin/commit/8ec445b13d329e6d347ff7a0a69a529f589ba649"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}