)]}'
{"keystone_tempest_plugin/config.py":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"c21b56ec90f9ff58b0995d006a2563d586d47a07","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    # Mapping rules"},{"line_number":48,"context_line":"    cfg.StrOpt(\u0027mapping_remote_type\u0027,"},{"line_number":49,"context_line":"               help\u003d\u0027The assertion attribute to be used in the remote rules\u0027),"},{"line_number":50,"context_line":"    cfg.StrOpt(\u0027mapping_remote_type_idp\u0027,"},{"line_number":51,"context_line":"               help\u003d\u0027The assertion attribute to be used in the remote rules \u0027"},{"line_number":52,"context_line":"                    \u0027i.e \"openstack_groups\"\u0027),"},{"line_number":53,"context_line":"    cfg.StrOpt(\u0027mapping_user_name\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_916b37b6","line":50,"updated":"2020-01-28 23:10:55.000000000","message":"This doesn\u0027t need to be configurable. This only needs to test the openstack_group attribute.","commit_id":"4dbb6f67a177c75680fee303ba387a6233ce18df"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"8f0912943bfe05b737a495fadf377c591a40580e","unresolved":false,"context_lines":[{"line_number":49,"context_line":"               help\u003d\u0027The assertion attribute to be used in the remote rules\u0027),"},{"line_number":50,"context_line":"    cfg.StrOpt(\u0027mapping_remote_type_idp\u0027,"},{"line_number":51,"context_line":"               help\u003d\u0027The assertion attribute to be used in the remote rules \u0027"},{"line_number":52,"context_line":"                    \u0027i.e \"openstack_groups\"\u0027),"},{"line_number":53,"context_line":"    cfg.StrOpt(\u0027mapping_user_name\u0027,"},{"line_number":54,"context_line":"               default\u003d\u0027{0}\u0027,"},{"line_number":55,"context_line":"               help\u003d\u0027The username to be used in the local rules.\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_0295d4e2","line":52,"range":{"start_line":52,"start_character":21,"end_line":52,"end_character":24},"updated":"2020-01-27 17:15:25.000000000","message":"Looks like we\u0027re missing an opening parenthesis here.","commit_id":"4dbb6f67a177c75680fee303ba387a6233ce18df"}],"keystone_tempest_plugin/tests/scenario/test_federated_authentication.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"8f0912943bfe05b737a495fadf377c591a40580e","unresolved":false,"context_lines":[{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    def _request_unscoped_token(self):"},{"line_number":156,"context_line":"        assertion, sp_url \u003d self._get_sp_authn_request()"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        # Present the identity provider authn response to the service provider"},{"line_number":159,"context_line":"        resp \u003d self.saml2_client.send_service_provider_saml2_authn_response("},{"line_number":160,"context_line":"            assertion, sp_url)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_c29a5c10","side":"PARENT","line":157,"updated":"2020-01-27 17:15:25.000000000","message":"Unrelated whitespace change?","commit_id":"e3163c2a695a5171ca4bb1fd0ae5f51c2b57f027"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"c21b56ec90f9ff58b0995d006a2563d586d47a07","unresolved":false,"context_lines":[{"line_number":228,"context_line":"                    \u0027user\u0027: {\u0027name\u0027: self.mapping_user_name}"},{"line_number":229,"context_line":"                },"},{"line_number":230,"context_line":"                {"},{"line_number":231,"context_line":"                    \u0027group\u0027: {"},{"line_number":232,"context_line":"                        \u0027domain\u0027: {\u0027name\u0027: self.mapping_group_domain_name},"},{"line_number":233,"context_line":"                        \u0027name\u0027: self.mapping_group_name"},{"line_number":234,"context_line":"                    }"},{"line_number":235,"context_line":"                }"},{"line_number":236,"context_line":"            ],"},{"line_number":237,"context_line":"            \u0027remote\u0027: ["}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_f142ab3b","line":234,"range":{"start_line":231,"start_character":20,"end_line":234,"end_character":21},"updated":"2020-01-28 23:10:55.000000000","message":"This isn\u0027t testing the openstack_group change\n\nhttps://review.opendev.org/#/c/588211/40/doc/source/admin/federation/mapping_combinations.rst","commit_id":"4dbb6f67a177c75680fee303ba387a6233ce18df"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"c21b56ec90f9ff58b0995d006a2563d586d47a07","unresolved":false,"context_lines":[{"line_number":247,"context_line":"        self.mappings_client.create_mapping_rule(self.mapping_id, mapping_ref)"},{"line_number":248,"context_line":"        self.addCleanup("},{"line_number":249,"context_line":"            self.mappings_client.delete_mapping_rule, self.mapping_id)"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"    def setUp(self):"},{"line_number":252,"context_line":"        super(TestK2KFederatedAuthentication, self).setUp()"},{"line_number":253,"context_line":"        self._setup_sp()"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_51613fd3","line":250,"updated":"2020-01-28 23:10:55.000000000","message":"I suggest adding a new test instead of changing the way the existing test works.","commit_id":"4dbb6f67a177c75680fee303ba387a6233ce18df"},{"author":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"change_message_id":"52b45686d7155d8f9fba59ffcab4b196c0481e9a","unresolved":false,"context_lines":[{"line_number":283,"context_line":""},{"line_number":284,"context_line":"    def setUp(self):"},{"line_number":285,"context_line":"        super(TestK2KFederatedAuthenticationGroups, self).setUp()"},{"line_number":286,"context_line":"        user_id \u003d self.oauth_token_client.auth_provider.credentials.user_id"},{"line_number":287,"context_line":"        user_domain_id \u003d \\"},{"line_number":288,"context_line":"            self.oauth_token_client.auth_provider.credentials.user_domain_id"},{"line_number":289,"context_line":"        group \u003d self.keystone_manager.groups_client.create_group("},{"line_number":290,"context_line":"            name\u003ddata_utils.rand_uuid_hex(), domain_id\u003duser_domain_id)"},{"line_number":291,"context_line":"        role \u003d self.keystone_manager.roles_v3_client.create_role("}],"source_content_type":"text/x-python","patch_set":20,"id":"1fa4df85_d71b30c7","line":288,"range":{"start_line":286,"start_character":8,"end_line":288,"end_character":76},"updated":"2020-03-04 15:31:28.000000000","message":"This feels wrong. This test doesn\u0027t have anything to do with OAuth and you don\u0027t really need a specific domain id for the group. You could just use the identity providers domain.","commit_id":"a4ff27ca0131cf589e02e5d99f7270c5c71a7e3c"},{"author":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"change_message_id":"52b45686d7155d8f9fba59ffcab4b196c0481e9a","unresolved":false,"context_lines":[{"line_number":290,"context_line":"            name\u003ddata_utils.rand_uuid_hex(), domain_id\u003duser_domain_id)"},{"line_number":291,"context_line":"        role \u003d self.keystone_manager.roles_v3_client.create_role("},{"line_number":292,"context_line":"            name\u003d data_utils.rand_uuid_hex(), domain_id\u003duser_domain_id)"},{"line_number":293,"context_line":"        self.keystone_manager.roles_v3_client.create_group_role_on_domain("},{"line_number":294,"context_line":"            group_id\u003dgroup[\u0027group\u0027][\u0027id\u0027], domain_id\u003duser_domain_id,"},{"line_number":295,"context_line":"            role_id\u003drole[\u0027role\u0027][\u0027id\u0027])"},{"line_number":296,"context_line":"        self.keystone_manager.groups_client.add_group_user("},{"line_number":297,"context_line":"            group_id\u003dgroup[\u0027group\u0027][\u0027id\u0027], user_id\u003duser_id)"},{"line_number":298,"context_line":"        self.addCleanup("}],"source_content_type":"text/x-python","patch_set":20,"id":"1fa4df85_378084bf","line":295,"range":{"start_line":293,"start_character":8,"end_line":295,"end_character":39},"updated":"2020-03-04 15:31:28.000000000","message":"The role should be associated to the project rather than domain.","commit_id":"a4ff27ca0131cf589e02e5d99f7270c5c71a7e3c"},{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"50a3e24ec947f2bc9facf5c50caa91d11ad5f517","unresolved":false,"context_lines":[{"line_number":290,"context_line":"            name\u003ddata_utils.rand_uuid_hex(), domain_id\u003duser_domain_id)"},{"line_number":291,"context_line":"        role \u003d self.keystone_manager.roles_v3_client.create_role("},{"line_number":292,"context_line":"            name\u003d data_utils.rand_uuid_hex(), domain_id\u003duser_domain_id)"},{"line_number":293,"context_line":"        self.keystone_manager.roles_v3_client.create_group_role_on_domain("},{"line_number":294,"context_line":"            group_id\u003dgroup[\u0027group\u0027][\u0027id\u0027], domain_id\u003duser_domain_id,"},{"line_number":295,"context_line":"            role_id\u003drole[\u0027role\u0027][\u0027id\u0027])"},{"line_number":296,"context_line":"        self.keystone_manager.groups_client.add_group_user("},{"line_number":297,"context_line":"            group_id\u003dgroup[\u0027group\u0027][\u0027id\u0027], user_id\u003duser_id)"},{"line_number":298,"context_line":"        self.addCleanup("}],"source_content_type":"text/x-python","patch_set":20,"id":"1fa4df85_3e527d3c","line":295,"range":{"start_line":293,"start_character":8,"end_line":295,"end_character":39},"in_reply_to":"1fa4df85_378084bf","updated":"2020-03-06 09:04:53.000000000","message":"Done","commit_id":"a4ff27ca0131cf589e02e5d99f7270c5c71a7e3c"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"a6a892f068d229d79659758811b8bfe8520fc5a2","unresolved":false,"context_lines":[{"line_number":331,"context_line":""},{"line_number":332,"context_line":"    @testtools.skipUnless(CONF.identity_feature_enabled.federation,"},{"line_number":333,"context_line":"                          \"Federated Identity feature not enabled\")"},{"line_number":334,"context_line":"    def test_request_unscoped_token(self):"},{"line_number":335,"context_line":"        self._test_request_unscoped_token()"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"    @testtools.skipUnless(CONF.identity_feature_enabled.federation,"},{"line_number":338,"context_line":"                          \"Federated Identity feature not enabled\")"},{"line_number":339,"context_line":"    def test_request_scoped_token(self):"},{"line_number":340,"context_line":"        self._test_request_scoped_token()"}],"source_content_type":"text/x-python","patch_set":21,"id":"1fa4df85_aa6c3408","line":340,"range":{"start_line":334,"start_character":4,"end_line":340,"end_character":41},"updated":"2020-03-18 21:31:01.000000000","message":"(nit) you could omit these, since the class inherits from a parent class that already has these defined.","commit_id":"a2dadd2417bed9c03ee19474083cf40eeaa81f95"},{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"5cfb7733ab94c3a5db018c743763f25a2295a6ca","unresolved":false,"context_lines":[{"line_number":331,"context_line":""},{"line_number":332,"context_line":"    @testtools.skipUnless(CONF.identity_feature_enabled.federation,"},{"line_number":333,"context_line":"                          \"Federated Identity feature not enabled\")"},{"line_number":334,"context_line":"    def test_request_unscoped_token(self):"},{"line_number":335,"context_line":"        self._test_request_unscoped_token()"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"    @testtools.skipUnless(CONF.identity_feature_enabled.federation,"},{"line_number":338,"context_line":"                          \"Federated Identity feature not enabled\")"},{"line_number":339,"context_line":"    def test_request_scoped_token(self):"},{"line_number":340,"context_line":"        self._test_request_scoped_token()"}],"source_content_type":"text/x-python","patch_set":21,"id":"1fa4df85_9910ab5b","line":340,"range":{"start_line":334,"start_character":4,"end_line":340,"end_character":41},"in_reply_to":"1fa4df85_aa6c3408","updated":"2020-03-19 12:20:48.000000000","message":"Done","commit_id":"a2dadd2417bed9c03ee19474083cf40eeaa81f95"},{"author":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"change_message_id":"268d9dd52d2577ca9dbed859bdd735567fdcc8df","unresolved":false,"context_lines":[{"line_number":225,"context_line":""},{"line_number":226,"context_line":"    def _setup_settings(self):"},{"line_number":227,"context_line":"        super(TestK2KFederatedAuthentication, self)._setup_settings()"},{"line_number":228,"context_line":"        self.idp_id \u003d \u0027keystone\u0027"},{"line_number":229,"context_line":"        self.idp_remote_ids \u003d ["},{"line_number":230,"context_line":"            \u0027%s/OS-FEDERATION/saml2/idp\u0027 % self.keystone_v3_endpoint]"},{"line_number":231,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"df33271e_b8e476e1","line":228,"range":{"start_line":228,"start_character":8,"end_line":228,"end_character":32},"updated":"2020-04-01 01:04:27.000000000","message":"There is a race condition because both this test, and the openstack_groups test create and cleanup the `keystone` IdP.","commit_id":"e569a8c51276ba35cb00452286d3992a62e33fbb"}]}