)]}'
{"keystoneauth/auth/base.py":[{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"75d0d24c0d2856fd77072aa036230ecf6748a8d5","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        cloud."},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        :param sp_id: ID of the Service Provider to be queried."},{"line_number":196,"context_line":"        :type sp_id: string"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        :returns: A Service Provider auth_url or None if one is not available."},{"line_number":199,"context_line":"        :rtype: str"}],"source_content_type":"text/x-python","patch_set":2,"id":"3afb71cf_4efaa044","line":196,"updated":"2015-06-09 23:11:28.000000000","message":"nit: inconsistent here with string and str","commit_id":"1f1df1f3ca53d04b045c16bde8fc1ec4bddd0f97"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"4a0db3d7e2f5fac39c707060b2009cf6f6d69cde","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        cloud."},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        :param sp_id: ID of the Service Provider to be queried."},{"line_number":196,"context_line":"        :type sp_id: string"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        :returns: A Service Provider auth_url or None if one is not available."},{"line_number":199,"context_line":"        :rtype: str"}],"source_content_type":"text/x-python","patch_set":2,"id":"3afb71cf_14070b19","line":196,"in_reply_to":"3afb71cf_4efaa044","updated":"2015-06-10 06:14:11.000000000","message":"Done","commit_id":"1f1df1f3ca53d04b045c16bde8fc1ec4bddd0f97"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"75d0d24c0d2856fd77072aa036230ecf6748a8d5","unresolved":false,"context_lines":[{"line_number":196,"context_line":"        :type sp_id: string"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        :returns: A Service Provider auth_url or None if one is not available."},{"line_number":199,"context_line":"        :rtype: str"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"        \"\"\""},{"line_number":202,"context_line":"        return None"}],"source_content_type":"text/x-python","patch_set":2,"id":"3afb71cf_8e8bf8c2","line":199,"updated":"2015-06-09 23:11:28.000000000","message":"Is it intentional here that this may raise ServiceProviderNotFound?","commit_id":"1f1df1f3ca53d04b045c16bde8fc1ec4bddd0f97"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"4a0db3d7e2f5fac39c707060b2009cf6f6d69cde","unresolved":false,"context_lines":[{"line_number":196,"context_line":"        :type sp_id: string"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        :returns: A Service Provider auth_url or None if one is not available."},{"line_number":199,"context_line":"        :rtype: str"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"        \"\"\""},{"line_number":202,"context_line":"        return None"}],"source_content_type":"text/x-python","patch_set":2,"id":"3afb71cf_941bfb72","line":199,"in_reply_to":"3afb71cf_8e8bf8c2","updated":"2015-06-10 06:14:11.000000000","message":"it\u0027s my bad, i made it return None in the inheriting class.","commit_id":"1f1df1f3ca53d04b045c16bde8fc1ec4bddd0f97"}],"keystoneauth/auth/identity/base.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"eb3f8f8dfe0f175fdd157d169984200fb0c5225c","unresolved":false,"context_lines":[{"line_number":258,"context_line":"            return self.get_access("},{"line_number":259,"context_line":"                session).service_providers.get_auth_url(sp_id)"},{"line_number":260,"context_line":"        except exceptions.ServiceProviderNotFound:"},{"line_number":261,"context_line":"            return None"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    def get_sp_url(self, session, sp_id, **kwargs):"},{"line_number":264,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3afb71cf_e4925df5","line":261,"updated":"2015-06-10 19:56:32.000000000","message":"Do we need to log anything here? Maybe just saying that the sp wasn\u0027t found?","commit_id":"76fb42ce8736381b94f5da5df89656b75217823a"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"28cb8ff66c6a2dcd7a36c68ae3238f83d4ee5df9","unresolved":false,"context_lines":[{"line_number":258,"context_line":"            return self.get_access("},{"line_number":259,"context_line":"                session).service_providers.get_auth_url(sp_id)"},{"line_number":260,"context_line":"        except exceptions.ServiceProviderNotFound:"},{"line_number":261,"context_line":"            return None"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    def get_sp_url(self, session, sp_id, **kwargs):"},{"line_number":264,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3afb71cf_63ad23e8","line":261,"in_reply_to":"3afb71cf_3169c3f9","updated":"2015-06-11 12:55:21.000000000","message":"Makes sense, so if we do any logging, is should be done at the layer above. \n\nThanks Marek!","commit_id":"76fb42ce8736381b94f5da5df89656b75217823a"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"28370cb390eaf66d2e9868e9bedaa9c462ffa43f","unresolved":false,"context_lines":[{"line_number":258,"context_line":"            return self.get_access("},{"line_number":259,"context_line":"                session).service_providers.get_auth_url(sp_id)"},{"line_number":260,"context_line":"        except exceptions.ServiceProviderNotFound:"},{"line_number":261,"context_line":"            return None"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    def get_sp_url(self, session, sp_id, **kwargs):"},{"line_number":264,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3afb71cf_3169c3f9","line":261,"in_reply_to":"3afb71cf_e4925df5","updated":"2015-06-11 05:45:15.000000000","message":"I don\u0027t see the value in that. If it returns None there is some indication that there was not SP there, I don\u0027t really see this object as a part of a big workflow (it is not a plugin that executes .auth() method). If logged, I\u0027d do this somewhere else.","commit_id":"76fb42ce8736381b94f5da5df89656b75217823a"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"eb3f8f8dfe0f175fdd157d169984200fb0c5225c","unresolved":false,"context_lines":[{"line_number":264,"context_line":"        try:"},{"line_number":265,"context_line":"            return self.get_access("},{"line_number":266,"context_line":"                session).service_providers.get_sp_url(sp_id)"},{"line_number":267,"context_line":"        except exceptions.ServiceProviderNotFound:"},{"line_number":268,"context_line":"            return None"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"    @utils.positional()"}],"source_content_type":"text/x-python","patch_set":3,"id":"3afb71cf_c48d21d4","line":267,"updated":"2015-06-10 19:56:32.000000000","message":"Same comment here.","commit_id":"76fb42ce8736381b94f5da5df89656b75217823a"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"28370cb390eaf66d2e9868e9bedaa9c462ffa43f","unresolved":false,"context_lines":[{"line_number":264,"context_line":"        try:"},{"line_number":265,"context_line":"            return self.get_access("},{"line_number":266,"context_line":"                session).service_providers.get_sp_url(sp_id)"},{"line_number":267,"context_line":"        except exceptions.ServiceProviderNotFound:"},{"line_number":268,"context_line":"            return None"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"    @utils.positional()"}],"source_content_type":"text/x-python","patch_set":3,"id":"3afb71cf_f16e8bfe","line":267,"in_reply_to":"3afb71cf_c48d21d4","updated":"2015-06-11 05:45:15.000000000","message":"same","commit_id":"76fb42ce8736381b94f5da5df89656b75217823a"}]}