)]}'
{"keystoneauth/fixture/v3.py":[{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"1913e407b6cd3ebad48b639e8129edeae7fa2ba1","unresolved":false,"context_lines":[{"line_number":391,"context_line":""},{"line_number":392,"context_line":"    @property"},{"line_number":393,"context_line":"    def service_providers(self):"},{"line_number":394,"context_line":"        return self.root.get(\u0027service_providers\u0027)"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"    @service_providers.setter"},{"line_number":397,"context_line":"    def service_providers(self, value):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_2eed24b7","line":394,"updated":"2015-06-09 23:04:09.000000000","message":"not sure if we want to provide the getter, in the least these are generally done using setdefault so you can add entries directly.","commit_id":"f56e0ab7da2f7508a4f6c1d259334db2520eff1d"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"5378b2d18b1bdea3546e80534b7ad7431b0e57c0","unresolved":false,"context_lines":[{"line_number":391,"context_line":""},{"line_number":392,"context_line":"    @property"},{"line_number":393,"context_line":"    def service_providers(self):"},{"line_number":394,"context_line":"        return self.root.get(\u0027service_providers\u0027)"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"    @service_providers.setter"},{"line_number":397,"context_line":"    def service_providers(self, value):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_5497c3eb","line":394,"in_reply_to":"3afb71cf_2eed24b7","updated":"2015-06-10 06:47:38.000000000","message":"if it is not in the self.root \u0027service_providers\u0027 will not be considered a part of the dictionary, so test\n\n\u0027service_providers\u0027 in token[\u0027token\u0027]  give False result.\n\nIn the real token is is completely normal not to have have \u0027service_providers\u0027 inside, so (this will not be the case in AccessInfo which will create empty list), so maybe it\u0027s better to follow this design decision in the fixture?","commit_id":"f56e0ab7da2f7508a4f6c1d259334db2520eff1d"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"1913e407b6cd3ebad48b639e8129edeae7fa2ba1","unresolved":false,"context_lines":[{"line_number":395,"context_line":""},{"line_number":396,"context_line":"    @service_providers.setter"},{"line_number":397,"context_line":"    def service_providers(self, value):"},{"line_number":398,"context_line":"        self.root[\u0027service_providers\u0027] \u003d value"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"class V3FederationToken(Token):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_2e4404b5","line":398,"updated":"2015-06-09 23:04:09.000000000","message":"i would prefer we didn\u0027t have people setting the whole list like this. Instead can we have an add_service_provider like we have add_role or add_service above?","commit_id":"f56e0ab7da2f7508a4f6c1d259334db2520eff1d"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"5378b2d18b1bdea3546e80534b7ad7431b0e57c0","unresolved":false,"context_lines":[{"line_number":395,"context_line":""},{"line_number":396,"context_line":"    @service_providers.setter"},{"line_number":397,"context_line":"    def service_providers(self, value):"},{"line_number":398,"context_line":"        self.root[\u0027service_providers\u0027] \u003d value"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"class V3FederationToken(Token):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_349c470e","line":398,"in_reply_to":"3afb71cf_2e4404b5","updated":"2015-06-10 06:47:38.000000000","message":"Done","commit_id":"f56e0ab7da2f7508a4f6c1d259334db2520eff1d"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"51e1705d5fad32ef581721a9ec429a494d6af8a4","unresolved":false,"context_lines":[{"line_number":391,"context_line":"    def service_providers(self):"},{"line_number":392,"context_line":"        return self.root.get(\u0027service_providers\u0027)"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"    def add_service_provider(self, sp_id, sp_auth_url, sp_url):"},{"line_number":395,"context_line":"        _service_providers \u003d self.root.setdefault(\u0027service_providers\u0027, [])"},{"line_number":396,"context_line":"        sp \u003d {\u0027id\u0027: sp_id, \u0027auth_url\u0027: sp_auth_url, \u0027sp_url\u0027: sp_url}"},{"line_number":397,"context_line":"        _service_providers.append(sp)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_5e2511a9","line":394,"updated":"2015-06-15 05:11:09.000000000","message":"marek: maybe as a followup have these default\u003dNone and create uuids for them if not present \n\nMost of the time you just want to test that a value is in there, you don\u0027t actually care what the values are.","commit_id":"54decbd8543c697ee1a22234fe50fd9b0339bcb7"}]}