)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"bae12992ebe079e799429b962a0888259a367911","unresolved":false,"context_lines":[{"line_number":10,"context_line":"be able to determine the root keystone URL from DNS and use that as its"},{"line_number":11,"context_line":"entrypoint."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Implements: dns-discovery"},{"line_number":14,"context_line":"Change-Id: Ia1ee07710d955d949909313ed51643f34097dbf7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba15a1d1_6359345a","line":13,"updated":"2015-09-15 06:33:32.000000000","message":"implements bp dns-discovery","commit_id":"dc26074d4e9781802b02c1bdafd409cb39ea5c62"}],"keystoneauth1/loading/_plugins/identity/generic.py":[{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"55635924e6747f4584848b384b648aa9c219b686","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                         \"Ignoring all of them rather than picking one.\")"},{"line_number":72,"context_line":"            else:"},{"line_number":73,"context_line":"                LOG.debug(\"Using auth url from dns: %s\", urls[0])"},{"line_number":74,"context_line":"                return urls[0]"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def load_from_options(self, **kwargs):"},{"line_number":77,"context_line":"        if not kwargs.get(\u0027auth_url\u0027):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a1a9d01_018645b9","line":74,"updated":"2015-10-02 10:34:03.000000000","message":"How can you be sure that there is a valid URL? We don\u0027t do any validation, do we? \nWhat is TXT record is nonempty but it happens to be for instance value for SPF (Sender Policy Framework) that also uses DNS TXT records https://en.wikipedia.org/wiki/Sender_Policy_Framework .\n\nAlso, DNS load balancing is I think quite common technique so maybe it\u0027d be wise to depend on value (valid URL) not cardinality of found elements?","commit_id":"e4d0794b5f1875a845c3b2e488fa4badfbf69a38"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"d7df36e44e791348066cf2713917b00c5ae6916c","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                         \"Ignoring all of them rather than picking one.\")"},{"line_number":72,"context_line":"            else:"},{"line_number":73,"context_line":"                LOG.debug(\"Using auth url from dns: %s\", urls[0])"},{"line_number":74,"context_line":"                return urls[0]"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def load_from_options(self, **kwargs):"},{"line_number":77,"context_line":"        if not kwargs.get(\u0027auth_url\u0027):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a2ca52d_23623bae","line":74,"in_reply_to":"9a1a9d01_018645b9","updated":"2015-10-15 00:22:56.000000000","message":"We don\u0027t do any validation of the value provided by --os-auth-url either, there is definetly the assumption here that there is going to be good input , but i don\u0027t think there\u0027s anything we can/should do about that.\n\nWhy would we be getting mixed up with SPF? we have the \u0027_openstack_keystone\u0027 record. I\u0027ve been thinking of this very much from the enterprise perspective where we can just discover one entrypoint.\n\nwhy would load balance matter here? I\u0027m getting a fully qualified url which will probably go back through DNS which is where the load balancer would be.","commit_id":"e4d0794b5f1875a845c3b2e488fa4badfbf69a38"}],"keystoneauth1/tests/unit/loading/test_generic.py":[{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"c967e250a701ccb1f6ce210cff6f5c0fcfb9c7bc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9a1a9d01_216ca907","updated":"2015-10-02 10:35:51.000000000","message":"suggested adding tests with one entry but non url value (e.g. th like \"v\u003dspf1 include:_spf.google.com ~all\")","commit_id":"e4d0794b5f1875a845c3b2e488fa4badfbf69a38"}]}