)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"0d89d1147b38f558586f5cceaa43b8d7ac199d79","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In order for us to transition python-openstackclient to keystoneauth,"},{"line_number":10,"context_line":"we need a path forward so that people can move from using the in-tree"},{"line_number":11,"context_line":"token-endpoint drive to just using the admin-token driver (which is the"},{"line_number":12,"context_line":"thing that should be used for the bootstrapping-keystone usecase)"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"We could do fancy things in OCC to accomplish this (I have a patch) -"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a1a9d01_8503f30c","line":11,"updated":"2015-09-28 19:40:54.000000000","message":"change \"drive\" and \"driver\" to \"plugin\"","commit_id":"a6a9046bcc934097cb48e39e096a89343633a121"}],"keystoneauth1/tests/unit/test_token_endpoint.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"e7cbaefc2b3cc30ae0c64cc94898326f189d2f9b","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        opts \u003d [opt for opt in loader.AdminToken().get_options()"},{"line_number":71,"context_line":"                     if opt.name \u003d\u003d \u0027endpoint\u0027]"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        self.assertThat(opts, matchers.HasLength(1))"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        opt_names \u003d [opt.name for opt in opts[0].deprecated]"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9a1a9d01_e0faddbc","line":73,"updated":"2015-09-28 20:11:46.000000000","message":"Since test_token_endpoint_options has already shown that there\u0027s and \u0027endpoint\u0027 opt, no need to verify again, suggest something like:\n\n endpoint_opt \u003d [opt for opt in loader.AdminToken().get_options()\n                           if opt.name \u003d\u003d \u0027endpoint\u0027][0]\n\nthe code is a little clearer what it\u0027s trying to verify vs extra stuff.","commit_id":"26092f30c14cc8f8b03cd206100fbcd3c14b6faf"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"e7cbaefc2b3cc30ae0c64cc94898326f189d2f9b","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        opt_names \u003d [opt.name for opt in opts[0].deprecated]"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        self.assertIn(\u0027url\u0027, opt_names)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a1a9d01_e0de5d6c","line":77,"updated":"2015-09-28 20:11:46.000000000","message":"can use assertEquals here...\n\n self.assertEquals([\u0027url\u0027], opt_names)\n\nThis will validate that the length, too.","commit_id":"26092f30c14cc8f8b03cd206100fbcd3c14b6faf"}]}
