)]}'
{"keystoneauth1/fixture/keystoneauth_betamax.py":[{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"2cfcae9e7ff85184f7d0051bf9750e446a114552","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from keystoneauth1 import session"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class KeystoneAuthBetamaxFixture(fixtures.Fixture):"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def __init__(self, cassette_name, cassette_library_dir\u003dNone,"},{"line_number":28,"context_line":"                 serializer\u003dNone, record\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a740942_ea3080ea","line":25,"updated":"2015-12-06 22:50:31.000000000","message":"drop the keystoneauth prefixes. you have to import from keystoneauth so people know this already.","commit_id":"fbf07c299f3a067ece6add42f52108209dbb2213"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"a38a40067378418848e05dfdbcf68875aa9fad4b","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from keystoneauth1 import session"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class KeystoneAuthBetamaxFixture(fixtures.Fixture):"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def __init__(self, cassette_name, cassette_library_dir\u003dNone,"},{"line_number":28,"context_line":"                 serializer\u003dNone, record\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a740942_4a6f54c5","line":25,"in_reply_to":"7a740942_ea3080ea","updated":"2015-12-06 22:54:29.000000000","message":"sure. I disagree for some things.","commit_id":"fbf07c299f3a067ece6add42f52108209dbb2213"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"2cfcae9e7ff85184f7d0051bf9750e446a114552","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        super(KeystoneAuthBetamaxFixture, self).setUp()"},{"line_number":38,"context_line":"        self.mockpatch \u003d mock.patch.object("},{"line_number":39,"context_line":"            session, \u0027_construct_session\u0027,"},{"line_number":40,"context_line":"            partial(_construct_session_with_betamax, self))"},{"line_number":41,"context_line":"        self.mockpatch.start()"},{"line_number":42,"context_line":"        # Unpatch during cleanup"},{"line_number":43,"context_line":"        self.addCleanup(self.mockpatch.stop)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a8ffd7b_dd154f9b","line":40,"updated":"2015-12-06 22:50:31.000000000","message":"could make this an instance method and patch with that.","commit_id":"fbf07c299f3a067ece6add42f52108209dbb2213"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"a38a40067378418848e05dfdbcf68875aa9fad4b","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        super(KeystoneAuthBetamaxFixture, self).setUp()"},{"line_number":38,"context_line":"        self.mockpatch \u003d mock.patch.object("},{"line_number":39,"context_line":"            session, \u0027_construct_session\u0027,"},{"line_number":40,"context_line":"            partial(_construct_session_with_betamax, self))"},{"line_number":41,"context_line":"        self.mockpatch.start()"},{"line_number":42,"context_line":"        # Unpatch during cleanup"},{"line_number":43,"context_line":"        self.addCleanup(self.mockpatch.stop)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a740942_0a6aacb3","line":40,"in_reply_to":"9a8ffd7b_dd154f9b","updated":"2015-12-06 22:54:29.000000000","message":"I was having issues with the self being wrong by patching with an instance method in an earlier iteration. It may have also surfaced here.\n\nI also don\u0027t see a huge win making it an instance method.","commit_id":"fbf07c299f3a067ece6add42f52108209dbb2213"}],"keystoneauth1/session.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"d8c6cbd762b0b1b8b34d37d0111e78e35e97601a","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"def _construct_session(session_obj\u003dNone):"},{"line_number":45,"context_line":"    # NOTE(morganfainberg): if the logic in this function changes be sure to"},{"line_number":46,"context_line":"    # update the betamax fixture\u0027s \u0027_construct_session_with_betamax\" function"},{"line_number":47,"context_line":"    # as well."},{"line_number":48,"context_line":"    if not session_obj:"},{"line_number":49,"context_line":"        session_obj \u003d requests.Session()"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a740942_b77d1f1e","line":46,"updated":"2015-12-04 19:59:45.000000000","message":"nit: mismatching \u0027 and \"","commit_id":"fbf07c299f3a067ece6add42f52108209dbb2213"}],"keystoneauth1/tests/unit/data/README":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"d8c6cbd762b0b1b8b34d37d0111e78e35e97601a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"This directory holds the betamax test cassettes that are pre-generated"},{"line_number":2,"context_line":"for unit testing. This can be removed in the future with a functional"},{"line_number":3,"context_line":"test that stands up a full devstack, records a cassette and then"},{"line_number":4,"context_line":"replays it as part of the test suite."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"Until the functional testing is implemented do not remove this"},{"line_number":7,"context_line":"directory or enclosed files."}],"source_content_type":"application/octet-stream","patch_set":8,"id":"7a740942_97726348","line":4,"updated":"2015-12-04 19:59:45.000000000","message":"Should we have this be a format, like rst or markdown?","commit_id":"fbf07c299f3a067ece6add42f52108209dbb2213"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"a38a40067378418848e05dfdbcf68875aa9fad4b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"This directory holds the betamax test cassettes that are pre-generated"},{"line_number":2,"context_line":"for unit testing. This can be removed in the future with a functional"},{"line_number":3,"context_line":"test that stands up a full devstack, records a cassette and then"},{"line_number":4,"context_line":"replays it as part of the test suite."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"Until the functional testing is implemented do not remove this"},{"line_number":7,"context_line":"directory or enclosed files."}],"source_content_type":"application/octet-stream","patch_set":8,"id":"7a740942_ea5e4011","line":4,"in_reply_to":"7a740942_97726348","updated":"2015-12-06 22:54:29.000000000","message":"Nope. This will go away soon enough, but there is no reason to *really* format this/sphinx it up.\n\nIt\u0027s a note of \"hey don\u0027t delete this\" for now.","commit_id":"fbf07c299f3a067ece6add42f52108209dbb2213"}],"keystoneauth1/tests/unit/test_betamax_fixture.py":[{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"6970818e7f73980550dd2f36b3d52783954ca42c","unresolved":false,"context_lines":[{"line_number":57,"context_line":"                text\u003djson.dumps(self.V2_TOKEN))"},{"line_number":58,"context_line":"            s \u003d session.Session()"},{"line_number":59,"context_line":"            s.get_token(auth\u003dplugin)"},{"line_number":60,"context_line":"            self.ksa_betamax_fixture.recorder.stop()"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def _replay_cassette(self):"},{"line_number":63,"context_line":"        plugin \u003d v2.Password("}],"source_content_type":"text/x-python","patch_set":5,"id":"9a8ffd7b_b45a81f0","line":60,"updated":"2015-11-27 16:56:03.000000000","message":"This is not yet correctly recording the cassette, therefore the replay below fails. This might be a bad interaction between requests-mock and betamax (seeing as betamax also relies on requests-mock)","commit_id":"fce9976cf847dbd1542482a38ffe958dc2cb24d3"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"28dabd3da6b55ee514e037fb2dbef0e74edae0bf","unresolved":false,"context_lines":[{"line_number":57,"context_line":"                text\u003djson.dumps(self.V2_TOKEN))"},{"line_number":58,"context_line":"            s \u003d session.Session()"},{"line_number":59,"context_line":"            s.get_token(auth\u003dplugin)"},{"line_number":60,"context_line":"            self.ksa_betamax_fixture.recorder.stop()"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def _replay_cassette(self):"},{"line_number":63,"context_line":"        plugin \u003d v2.Password("}],"source_content_type":"text/x-python","patch_set":5,"id":"9a8ffd7b_4f6ce0cd","line":60,"in_reply_to":"9a8ffd7b_b45a81f0","updated":"2015-11-27 17:13:12.000000000","message":"yep, the more I look at it the more I think this is requests-mock breaks how betamax does the recording. *ohwell* we will need a functional test/devstack to do this correctly [or a full HTTP response requests can hit]","commit_id":"fce9976cf847dbd1542482a38ffe958dc2cb24d3"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"d8c6cbd762b0b1b8b34d37d0111e78e35e97601a","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class TestBetamaxFixture(testtools.TestCase):"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    TEST_USERNAME \u003d \u0027test_user_name\u0027"},{"line_number":26,"context_line":"    TEST_PASSWORD \u003d \u0027test_password\u0027"},{"line_number":27,"context_line":"    TEST_TENANT_NAME \u003d \u0027test_tenant_name\u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a740942_b7275f11","line":24,"updated":"2015-12-04 19:59:45.000000000","message":"Per Ian\u0027s comment and the next steps; should we add a TODO here?","commit_id":"fbf07c299f3a067ece6add42f52108209dbb2213"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"a38a40067378418848e05dfdbcf68875aa9fad4b","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class TestBetamaxFixture(testtools.TestCase):"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    TEST_USERNAME \u003d \u0027test_user_name\u0027"},{"line_number":26,"context_line":"    TEST_PASSWORD \u003d \u0027test_password\u0027"},{"line_number":27,"context_line":"    TEST_TENANT_NAME \u003d \u0027test_tenant_name\u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a740942_4aa67411","line":24,"in_reply_to":"7a740942_b7275f11","updated":"2015-12-06 22:54:29.000000000","message":"possibly, will consider for the next patchset.","commit_id":"fbf07c299f3a067ece6add42f52108209dbb2213"}]}