)]}'
{"keystoneauth1/access/access.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"01081d65655a58bfe7d751c0370ab26c5e81d25c","unresolved":false,"context_lines":[{"line_number":394,"context_line":"        raise NotImplementedError()"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":""},{"line_number":397,"context_line":"class AccessInfoV2(AccessInfo):"},{"line_number":398,"context_line":"    \"\"\"An object for encapsulating raw v2 auth token from identity service.\"\"\""},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"    version \u003d \u0027v2.0\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_dc3190ee","line":397,"range":{"start_line":397,"start_character":0,"end_line":397,"end_character":31},"updated":"2016-02-19 15:41:56.000000000","message":"we probably also want it in this class too, this way the v2 and v3 implementations of this class have the same methods.\n\nbut is can always return False since in v2, there is no concept of a domain","commit_id":"99da134d670772a76525f543baf06a6e01540a1d"},{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"48a57d246ac20ecc25b24d558bc8a587cc2f33f9","unresolved":false,"context_lines":[{"line_number":672,"context_line":""},{"line_number":673,"context_line":"    @_missingproperty"},{"line_number":674,"context_line":"    def project_is_domain(self):"},{"line_number":675,"context_line":"        return self._data.get(\u0027token\u0027, {}).get(\u0027is_domain\u0027)"},{"line_number":676,"context_line":""},{"line_number":677,"context_line":"    @_missingproperty"},{"line_number":678,"context_line":"    def project_domain_id(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"bab6814e_60e9be1a","line":675,"updated":"2016-05-18 14:08:49.000000000","message":"I think we can change this for something simpler, like:\nreturn self._data[\u0027token\u0027][\u0027is_domain\u0027]","commit_id":"d469fb12219a7a5defab061fe7d9a427172e4655"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"6447fa83ba3d1aa5641f551ebbb2bba3067ddf35","unresolved":false,"context_lines":[{"line_number":672,"context_line":""},{"line_number":673,"context_line":"    @_missingproperty"},{"line_number":674,"context_line":"    def project_is_domain(self):"},{"line_number":675,"context_line":"        return self._data.get(\u0027token\u0027, {}).get(\u0027is_domain\u0027)"},{"line_number":676,"context_line":""},{"line_number":677,"context_line":"    @_missingproperty"},{"line_number":678,"context_line":"    def project_domain_id(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"bab6814e_2bde5d3f","line":675,"in_reply_to":"bab6814e_024c2f6f","updated":"2016-05-19 00:26:57.000000000","message":"that\u0027s what @_missingproperty does - handles any keyerrors for you.","commit_id":"d469fb12219a7a5defab061fe7d9a427172e4655"},{"author":{"_account_id":20259,"name":"Clenimar Filemon","email":"clenimar@lsd.ufcg.edu.br","username":"clenimar"},"change_message_id":"b81fa29da761904b73e6a165125728d9f320b226","unresolved":false,"context_lines":[{"line_number":672,"context_line":""},{"line_number":673,"context_line":"    @_missingproperty"},{"line_number":674,"context_line":"    def project_is_domain(self):"},{"line_number":675,"context_line":"        return self._data.get(\u0027token\u0027, {}).get(\u0027is_domain\u0027)"},{"line_number":676,"context_line":""},{"line_number":677,"context_line":"    @_missingproperty"},{"line_number":678,"context_line":"    def project_domain_id(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"bab6814e_8b8f89cb","line":675,"in_reply_to":"bab6814e_2bde5d3f","updated":"2016-05-19 00:51:06.000000000","message":"hmm. then i\u0027ll change it. thank you both","commit_id":"d469fb12219a7a5defab061fe7d9a427172e4655"},{"author":{"_account_id":20259,"name":"Clenimar Filemon","email":"clenimar@lsd.ufcg.edu.br","username":"clenimar"},"change_message_id":"2be48c786a6907c410147e0d04d41d92e17229ff","unresolved":false,"context_lines":[{"line_number":672,"context_line":""},{"line_number":673,"context_line":"    @_missingproperty"},{"line_number":674,"context_line":"    def project_is_domain(self):"},{"line_number":675,"context_line":"        return self._data.get(\u0027token\u0027, {}).get(\u0027is_domain\u0027)"},{"line_number":676,"context_line":""},{"line_number":677,"context_line":"    @_missingproperty"},{"line_number":678,"context_line":"    def project_domain_id(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"bab6814e_024c2f6f","line":675,"in_reply_to":"bab6814e_60e9be1a","updated":"2016-05-18 16:11:55.000000000","message":"yea, but using get() we avoid a KeyError along the way","commit_id":"d469fb12219a7a5defab061fe7d9a427172e4655"}],"keystoneauth1/fixture/v3.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"01081d65655a58bfe7d751c0370ab26c5e81d25c","unresolved":false,"context_lines":[{"line_number":391,"context_line":"        self.project_domain_name \u003d domain_name or uuid.uuid4().hex"},{"line_number":392,"context_line":"        self.is_domain \u003d is_domain or False"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"    def set_project_as_domain_scope(self, id\u003dNone, name\u003dNone, domain_id\u003dNone,"},{"line_number":395,"context_line":"                                    domain_name\u003dNone, is_domain\u003dTrue):"},{"line_number":396,"context_line":"        self.project_id \u003d id or uuid.uuid4().hex"},{"line_number":397,"context_line":"        self.project_name \u003d name or uuid.uuid4().hex"},{"line_number":398,"context_line":"        self.project_domain_id \u003d domain_id or uuid.uuid4().hex"},{"line_number":399,"context_line":"        self.project_domain_name \u003d domain_name or uuid.uuid4().hex"},{"line_number":400,"context_line":"        self.is_domain \u003d is_domain or False"},{"line_number":401,"context_line":""},{"line_number":402,"context_line":"    def set_domain_scope(self, id\u003dNone, name\u003dNone):"},{"line_number":403,"context_line":"        self.domain_id \u003d id or uuid.uuid4().hex"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_bcc48c92","line":400,"range":{"start_line":394,"start_character":4,"end_line":400,"end_character":43},"updated":"2016-02-19 15:41:56.000000000","message":"not sure i get the point of this when it\u0027s the same code as above, just a different default for is_domain","commit_id":"99da134d670772a76525f543baf06a6e01540a1d"},{"author":{"_account_id":20259,"name":"Clenimar Filemon","email":"clenimar@lsd.ufcg.edu.br","username":"clenimar"},"change_message_id":"08bae423040e31f90ff61ccf8c0dd03ebb45a0bd","unresolved":false,"context_lines":[{"line_number":391,"context_line":"        self.project_domain_name \u003d domain_name or uuid.uuid4().hex"},{"line_number":392,"context_line":"        self.is_domain \u003d is_domain or False"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"    def set_project_as_domain_scope(self, id\u003dNone, name\u003dNone, domain_id\u003dNone,"},{"line_number":395,"context_line":"                                    domain_name\u003dNone, is_domain\u003dTrue):"},{"line_number":396,"context_line":"        self.project_id \u003d id or uuid.uuid4().hex"},{"line_number":397,"context_line":"        self.project_name \u003d name or uuid.uuid4().hex"},{"line_number":398,"context_line":"        self.project_domain_id \u003d domain_id or uuid.uuid4().hex"},{"line_number":399,"context_line":"        self.project_domain_name \u003d domain_name or uuid.uuid4().hex"},{"line_number":400,"context_line":"        self.is_domain \u003d is_domain or False"},{"line_number":401,"context_line":""},{"line_number":402,"context_line":"    def set_domain_scope(self, id\u003dNone, name\u003dNone):"},{"line_number":403,"context_line":"        self.domain_id \u003d id or uuid.uuid4().hex"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_6fdd2842","line":400,"range":{"start_line":394,"start_character":4,"end_line":400,"end_character":43},"in_reply_to":"bae84128_bcc48c92","updated":"2016-02-19 16:01:05.000000000","message":"oh, you\u0027re right... there\u0027s no point at all. just a waste of code :( gonna fix that. thanks!","commit_id":"99da134d670772a76525f543baf06a6e01540a1d"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"f03496a0d2dbe35bdb78a4b8ed1b98198d7d5248","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                 trust_id\u003dNone, trust_impersonation\u003dNone, trustee_user_id\u003dNone,"},{"line_number":64,"context_line":"                 trustor_user_id\u003dNone, oauth_access_token_id\u003dNone,"},{"line_number":65,"context_line":"                 oauth_consumer_id\u003dNone, audit_id\u003dNone, audit_chain_id\u003dNone,"},{"line_number":66,"context_line":"                 is_domain\u003dFalse):"},{"line_number":67,"context_line":"        super(Token, self).__init__()"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        self.user_id \u003d user_id or uuid.uuid4().hex"}],"source_content_type":"text/x-python","patch_set":2,"id":"7af24918_9387e460","line":66,"range":{"start_line":66,"start_character":17,"end_line":66,"end_character":26},"updated":"2016-03-01 22:38:28.000000000","message":"prefer project_is_domain when using it for this more global scope.","commit_id":"20fbcc2bcd6407d8bd33f8e2912ba72a5800e21e"},{"author":{"_account_id":20259,"name":"Clenimar Filemon","email":"clenimar@lsd.ufcg.edu.br","username":"clenimar"},"change_message_id":"cf9b276e5e26793f991ff3852b8cb51a0f9ee824","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                 trust_id\u003dNone, trust_impersonation\u003dNone, trustee_user_id\u003dNone,"},{"line_number":64,"context_line":"                 trustor_user_id\u003dNone, oauth_access_token_id\u003dNone,"},{"line_number":65,"context_line":"                 oauth_consumer_id\u003dNone, audit_id\u003dNone, audit_chain_id\u003dNone,"},{"line_number":66,"context_line":"                 is_domain\u003dFalse):"},{"line_number":67,"context_line":"        super(Token, self).__init__()"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        self.user_id \u003d user_id or uuid.uuid4().hex"}],"source_content_type":"text/x-python","patch_set":2,"id":"7af24918_8190f544","line":66,"range":{"start_line":66,"start_character":17,"end_line":66,"end_character":26},"in_reply_to":"7af24918_9387e460","updated":"2016-03-02 16:18:39.000000000","message":"You\u0027re right. Thanks for reviewing, Jamie.","commit_id":"20fbcc2bcd6407d8bd33f8e2912ba72a5800e21e"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"f03496a0d2dbe35bdb78a4b8ed1b98198d7d5248","unresolved":false,"context_lines":[{"line_number":100,"context_line":"                                   name\u003dproject_name,"},{"line_number":101,"context_line":"                                   domain_id\u003dproject_domain_id,"},{"line_number":102,"context_line":"                                   domain_name\u003dproject_domain_name,"},{"line_number":103,"context_line":"                                   is_domain\u003dis_domain)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        if domain_id or domain_name:"},{"line_number":106,"context_line":"            self.set_domain_scope(id\u003ddomain_id, name\u003ddomain_name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7af24918_3397f091","line":103,"range":{"start_line":103,"start_character":35,"end_line":103,"end_character":44},"updated":"2016-03-01 22:38:28.000000000","message":"it makes it more standard here where all the project variables are project_ prefixed","commit_id":"20fbcc2bcd6407d8bd33f8e2912ba72a5800e21e"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"f03496a0d2dbe35bdb78a4b8ed1b98198d7d5248","unresolved":false,"context_lines":[{"line_number":212,"context_line":"        self.root.setdefault(\u0027project\u0027, {})[\u0027id\u0027] \u003d value"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    @property"},{"line_number":215,"context_line":"    def is_domain(self):"},{"line_number":216,"context_line":"        return self.root.get(\u0027project\u0027, {}).get[\u0027is_domain\u0027]"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    @is_domain.setter"}],"source_content_type":"text/x-python","patch_set":2,"id":"7af24918_93eec420","line":215,"range":{"start_line":215,"start_character":8,"end_line":215,"end_character":17},"updated":"2016-03-01 22:38:28.000000000","message":"same","commit_id":"20fbcc2bcd6407d8bd33f8e2912ba72a5800e21e"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"f03496a0d2dbe35bdb78a4b8ed1b98198d7d5248","unresolved":false,"context_lines":[{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    @property"},{"line_number":215,"context_line":"    def is_domain(self):"},{"line_number":216,"context_line":"        return self.root.get(\u0027project\u0027, {}).get[\u0027is_domain\u0027]"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    @is_domain.setter"},{"line_number":219,"context_line":"    def is_domain(self, value):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7af24918_33ded06d","line":216,"range":{"start_line":216,"start_character":49,"end_line":216,"end_character":58},"updated":"2016-03-01 22:38:28.000000000","message":".get with [] ?","commit_id":"20fbcc2bcd6407d8bd33f8e2912ba72a5800e21e"},{"author":{"_account_id":20259,"name":"Clenimar Filemon","email":"clenimar@lsd.ufcg.edu.br","username":"clenimar"},"change_message_id":"cf9b276e5e26793f991ff3852b8cb51a0f9ee824","unresolved":false,"context_lines":[{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    @property"},{"line_number":215,"context_line":"    def is_domain(self):"},{"line_number":216,"context_line":"        return self.root.get(\u0027project\u0027, {}).get[\u0027is_domain\u0027]"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    @is_domain.setter"},{"line_number":219,"context_line":"    def is_domain(self, value):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7af24918_01a505a1","line":216,"range":{"start_line":216,"start_character":49,"end_line":216,"end_character":58},"in_reply_to":"7af24918_33ded06d","updated":"2016-03-02 16:18:39.000000000","message":"Whops. Fixed.","commit_id":"20fbcc2bcd6407d8bd33f8e2912ba72a5800e21e"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"2e3680bf16e032cdb560e9da86654d92864539bd","unresolved":false,"context_lines":[{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    @project_is_domain.setter"},{"line_number":222,"context_line":"    def project_is_domain(self, value):"},{"line_number":223,"context_line":"        self.root.setdefault(\u0027project\u0027, {})[\u0027is_domain\u0027] \u003d value"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"    @property"},{"line_number":226,"context_line":"    def project_name(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"dab17558_d6f33b07","line":223,"range":{"start_line":223,"start_character":30,"end_line":223,"end_character":37},"updated":"2016-05-18 00:09:12.000000000","message":"compared to keystone patch and api this is wrong. It lives in the root of the token, not the project info. \n\n(makes more sense to me in project info but whatever)","commit_id":"f4764f473b2f2eeccc02a818a2fbc7bd390092ed"},{"author":{"_account_id":20259,"name":"Clenimar Filemon","email":"clenimar@lsd.ufcg.edu.br","username":"clenimar"},"change_message_id":"3275158c78b37061c8b8d310d87daf7e16726f13","unresolved":false,"context_lines":[{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    @project_is_domain.setter"},{"line_number":222,"context_line":"    def project_is_domain(self, value):"},{"line_number":223,"context_line":"        self.root.setdefault(\u0027project\u0027, {})[\u0027is_domain\u0027] \u003d value"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"    @property"},{"line_number":226,"context_line":"    def project_name(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"bab6814e_82cadf9f","line":223,"range":{"start_line":223,"start_character":30,"end_line":223,"end_character":37},"in_reply_to":"dab17558_d6f33b07","updated":"2016-05-18 16:16:53.000000000","message":"Done","commit_id":"f4764f473b2f2eeccc02a818a2fbc7bd390092ed"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"2e3680bf16e032cdb560e9da86654d92864539bd","unresolved":false,"context_lines":[{"line_number":404,"context_line":"        self.project_name \u003d name or uuid.uuid4().hex"},{"line_number":405,"context_line":"        self.project_domain_id \u003d domain_id or uuid.uuid4().hex"},{"line_number":406,"context_line":"        self.project_domain_name \u003d domain_name or uuid.uuid4().hex"},{"line_number":407,"context_line":"        self.project_is_domain \u003d is_domain or False"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"    def set_domain_scope(self, id\u003dNone, name\u003dNone):"},{"line_number":410,"context_line":"        self.domain_id \u003d id or uuid.uuid4().hex"}],"source_content_type":"text/x-python","patch_set":6,"id":"dab17558_963b739b","line":407,"range":{"start_line":407,"start_character":46,"end_line":407,"end_character":51},"updated":"2016-05-18 00:09:12.000000000","message":"default is False so what does the or do? \n\nNormally with these I like to leave the default as None and then only set the value if it\u0027s a True/False because given this setup there is no way to leave is_domain out of a token which a people may want.","commit_id":"f4764f473b2f2eeccc02a818a2fbc7bd390092ed"},{"author":{"_account_id":20259,"name":"Clenimar Filemon","email":"clenimar@lsd.ufcg.edu.br","username":"clenimar"},"change_message_id":"3275158c78b37061c8b8d310d87daf7e16726f13","unresolved":false,"context_lines":[{"line_number":404,"context_line":"        self.project_name \u003d name or uuid.uuid4().hex"},{"line_number":405,"context_line":"        self.project_domain_id \u003d domain_id or uuid.uuid4().hex"},{"line_number":406,"context_line":"        self.project_domain_name \u003d domain_name or uuid.uuid4().hex"},{"line_number":407,"context_line":"        self.project_is_domain \u003d is_domain or False"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"    def set_domain_scope(self, id\u003dNone, name\u003dNone):"},{"line_number":410,"context_line":"        self.domain_id \u003d id or uuid.uuid4().hex"}],"source_content_type":"text/x-python","patch_set":6,"id":"bab6814e_62e25b05","line":407,"range":{"start_line":407,"start_character":46,"end_line":407,"end_character":51},"in_reply_to":"dab17558_963b739b","updated":"2016-05-18 16:16:53.000000000","message":"sure, it makes sense. thank you","commit_id":"f4764f473b2f2eeccc02a818a2fbc7bd390092ed"}],"keystoneauth1/tests/unit/access/test_v3_access.py":[{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"d879182f23d1943bcd667fda44c0f00fd54ae625","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        self.assertFalse(auth_ref.domain_scoped)"},{"line_number":46,"context_line":"        self.assertFalse(auth_ref.project_scoped)"},{"line_number":47,"context_line":"        self.assertIsNone(auth_ref.project_is_domain)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        self.assertEqual(token.user_domain_id, auth_ref.user_domain_id)"},{"line_number":50,"context_line":"        self.assertEqual(token.user_domain_name, auth_ref.user_domain_name)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_0a97583a","line":47,"range":{"start_line":47,"start_character":35,"end_line":47,"end_character":52},"updated":"2016-04-29 16:55:52.000000000","message":"i feel like this should be false - but i can see that we use the None pattern for this elsewhere.","commit_id":"5d29e644c1b33d5e3b7d828ffeb7af908e7b8b30"},{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"b409d20f81d743b073563e051536dab68741c84a","unresolved":false,"context_lines":[{"line_number":166,"context_line":"        token \u003d fixture.V3Token()"},{"line_number":167,"context_line":"        token.set_project_scope(is_domain\u003dTrue)"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"        s \u003d token.add_service(type\u003d\u0027identity\u0027)"},{"line_number":170,"context_line":"        s.add_standard_endpoints(public\u003d\u0027http://url\u0027)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        token_id \u003d uuid.uuid4().hex"},{"line_number":173,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_7644f845","line":170,"range":{"start_line":169,"start_character":8,"end_line":170,"end_character":9},"updated":"2016-04-29 16:25:20.000000000","message":"can you use a better name than s?","commit_id":"5d29e644c1b33d5e3b7d828ffeb7af908e7b8b30"},{"author":{"_account_id":20259,"name":"Clenimar Filemon","email":"clenimar@lsd.ufcg.edu.br","username":"clenimar"},"change_message_id":"5134704038ac851c8f2de86514ef64afeb82e623","unresolved":false,"context_lines":[{"line_number":166,"context_line":"        token \u003d fixture.V3Token()"},{"line_number":167,"context_line":"        token.set_project_scope(is_domain\u003dTrue)"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"        s \u003d token.add_service(type\u003d\u0027identity\u0027)"},{"line_number":170,"context_line":"        s.add_standard_endpoints(public\u003d\u0027http://url\u0027)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        token_id \u003d uuid.uuid4().hex"},{"line_number":173,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_0901d004","line":170,"range":{"start_line":169,"start_character":8,"end_line":170,"end_character":9},"in_reply_to":"1a122d0e_7644f845","updated":"2016-05-03 21:09:45.000000000","message":"sure. changed to \u0027service\u0027 to improve clarity.","commit_id":"5d29e644c1b33d5e3b7d828ffeb7af908e7b8b30"}],"keystoneauth1/tests/unit/client_fixtures.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"f14f5b1bf8aca8a909eddb5db8b9d5e5d725ca6d","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    return f"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"def project_as_domain_scoped_token():"},{"line_number":67,"context_line":"    f \u003d fixture.V3Token(user_id\u003d\u0027c4da488862bd435c9e6c0275a0d0e49a\u0027,"},{"line_number":68,"context_line":"                        user_name\u003d\u0027exampleuser\u0027,"},{"line_number":69,"context_line":"                        user_domain_id\u003d\u00274e6893b7ba0b4006840c3845660b86ed\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_889342a3","line":66,"range":{"start_line":66,"start_character":0,"end_line":66,"end_character":37},"updated":"2016-02-19 16:43:17.000000000","message":"hmm, there\u0027s a lot of duplication here, but it looks like that\u0027s what we did for the domain token, so that\u0027s oK in this patch, makes things a bit more explicit i guess.","commit_id":"20fbcc2bcd6407d8bd33f8e2912ba72a5800e21e"},{"author":{"_account_id":20259,"name":"Clenimar Filemon","email":"clenimar@lsd.ufcg.edu.br","username":"clenimar"},"change_message_id":"cf9b276e5e26793f991ff3852b8cb51a0f9ee824","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    return f"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"def project_as_domain_scoped_token():"},{"line_number":67,"context_line":"    f \u003d fixture.V3Token(user_id\u003d\u0027c4da488862bd435c9e6c0275a0d0e49a\u0027,"},{"line_number":68,"context_line":"                        user_name\u003d\u0027exampleuser\u0027,"},{"line_number":69,"context_line":"                        user_domain_id\u003d\u00274e6893b7ba0b4006840c3845660b86ed\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7af24918_01fb45c2","line":66,"range":{"start_line":66,"start_character":0,"end_line":66,"end_character":37},"in_reply_to":"7af24918_33e890e2","updated":"2016-03-02 16:18:39.000000000","message":"Thanks for reviewing. I\u0027ve done what Raildo suggested to avoid code duplication. A major refactor should be addressed by another patch :)","commit_id":"20fbcc2bcd6407d8bd33f8e2912ba72a5800e21e"},{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"cad45bcf818e91955593ebe62ac72da83f216e68","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    return f"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"def project_as_domain_scoped_token():"},{"line_number":67,"context_line":"    f \u003d fixture.V3Token(user_id\u003d\u0027c4da488862bd435c9e6c0275a0d0e49a\u0027,"},{"line_number":68,"context_line":"                        user_name\u003d\u0027exampleuser\u0027,"},{"line_number":69,"context_line":"                        user_domain_id\u003d\u00274e6893b7ba0b4006840c3845660b86ed\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_eac6f447","line":66,"range":{"start_line":66,"start_character":0,"end_line":66,"end_character":37},"in_reply_to":"bae84128_889342a3","updated":"2016-02-22 13:22:05.000000000","message":"++ I believe we can find a better solution reusing the project scoped token and just add the \u0027is_domain\u0027 flag on it.","commit_id":"20fbcc2bcd6407d8bd33f8e2912ba72a5800e21e"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"f03496a0d2dbe35bdb78a4b8ed1b98198d7d5248","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    return f"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"def project_as_domain_scoped_token():"},{"line_number":67,"context_line":"    f \u003d fixture.V3Token(user_id\u003d\u0027c4da488862bd435c9e6c0275a0d0e49a\u0027,"},{"line_number":68,"context_line":"                        user_name\u003d\u0027exampleuser\u0027,"},{"line_number":69,"context_line":"                        user_domain_id\u003d\u00274e6893b7ba0b4006840c3845660b86ed\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7af24918_33e890e2","line":66,"range":{"start_line":66,"start_character":0,"end_line":66,"end_character":37},"in_reply_to":"bae84128_eac6f447","updated":"2016-03-01 22:38:28.000000000","message":"yep, any time anyone wants to refactor these properly go right ahead, there is just a few places from the older test that rely on these fixed values. They should be replaced with generating the fixture as you need it and using uuids.","commit_id":"20fbcc2bcd6407d8bd33f8e2912ba72a5800e21e"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"d879182f23d1943bcd667fda44c0f00fd54ae625","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    f.project_is_domain(True)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    return f"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"def domain_scoped_token():"},{"line_number":74,"context_line":"    f \u003d fixture.V3Token(user_id\u003d\u0027c4da488862bd435c9e6c0275a0d0e49a\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_0afc7870","line":71,"updated":"2016-04-29 16:55:52.000000000","message":"do you use this? I wouldn\u0027t bother. \n\nThese functions were here because they used to exist for tests that have specific user_id and domain id values that were used in testing. For an example this simple you can just make the modification you need in the individual test.","commit_id":"5d29e644c1b33d5e3b7d828ffeb7af908e7b8b30"},{"author":{"_account_id":20259,"name":"Clenimar Filemon","email":"clenimar@lsd.ufcg.edu.br","username":"clenimar"},"change_message_id":"5134704038ac851c8f2de86514ef64afeb82e623","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    f.project_is_domain(True)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    return f"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"def domain_scoped_token():"},{"line_number":74,"context_line":"    f \u003d fixture.V3Token(user_id\u003d\u0027c4da488862bd435c9e6c0275a0d0e49a\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_e9757432","line":71,"in_reply_to":"1a122d0e_0afc7870","updated":"2016-05-03 21:09:45.000000000","message":"you\u0027re right. i\u0027ll remove this method.","commit_id":"5d29e644c1b33d5e3b7d828ffeb7af908e7b8b30"}],"keystoneauth1/tests/unit/test_fixtures.py":[{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"2e3680bf16e032cdb560e9da86654d92864539bd","unresolved":false,"context_lines":[{"line_number":191,"context_line":"        self.assertEqual(project_name, token.project_name)"},{"line_number":192,"context_line":"        self.assertEqual(project_name, token[\u0027token\u0027][\u0027project\u0027][\u0027name\u0027])"},{"line_number":193,"context_line":"        self.assertEqual(project_is_domain,"},{"line_number":194,"context_line":"                         token[\u0027token\u0027][\u0027project\u0027][\u0027is_domain\u0027])"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"        project_domain \u003d token[\u0027token\u0027][\u0027project\u0027][\u0027domain\u0027]"},{"line_number":197,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"dab17558_1648232c","line":194,"range":{"start_line":194,"start_character":61,"end_line":194,"end_character":64},"updated":"2016-05-18 00:09:12.000000000","message":"yep - wrong?","commit_id":"f4764f473b2f2eeccc02a818a2fbc7bd390092ed"},{"author":{"_account_id":20259,"name":"Clenimar Filemon","email":"clenimar@lsd.ufcg.edu.br","username":"clenimar"},"change_message_id":"3275158c78b37061c8b8d310d87daf7e16726f13","unresolved":false,"context_lines":[{"line_number":191,"context_line":"        self.assertEqual(project_name, token.project_name)"},{"line_number":192,"context_line":"        self.assertEqual(project_name, token[\u0027token\u0027][\u0027project\u0027][\u0027name\u0027])"},{"line_number":193,"context_line":"        self.assertEqual(project_is_domain,"},{"line_number":194,"context_line":"                         token[\u0027token\u0027][\u0027project\u0027][\u0027is_domain\u0027])"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"        project_domain \u003d token[\u0027token\u0027][\u0027project\u0027][\u0027domain\u0027]"},{"line_number":197,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"bab6814e_e2ee4beb","line":194,"range":{"start_line":194,"start_character":61,"end_line":194,"end_character":64},"in_reply_to":"dab17558_1648232c","updated":"2016-05-18 16:16:53.000000000","message":"Done","commit_id":"f4764f473b2f2eeccc02a818a2fbc7bd390092ed"},{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"48a57d246ac20ecc25b24d558bc8a587cc2f33f9","unresolved":false,"context_lines":[{"line_number":184,"context_line":"                                project_name\u003dproject_name,"},{"line_number":185,"context_line":"                                project_domain_id\u003dproject_domain_id,"},{"line_number":186,"context_line":"                                project_domain_name\u003dproject_domain_name,"},{"line_number":187,"context_line":"                                project_is_domain\u003dTrue)"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"        self.assertEqual(project_id, token.project_id)"},{"line_number":190,"context_line":"        self.assertEqual(project_id, token[\u0027token\u0027][\u0027project\u0027][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"bab6814e_008ef277","line":187,"updated":"2016-05-18 14:08:49.000000000","message":"change this for project_is_domain\u003dproject_is_domain\nor remove this variable and make a assertTrue in the last line on this test","commit_id":"d469fb12219a7a5defab061fe7d9a427172e4655"},{"author":{"_account_id":20259,"name":"Clenimar Filemon","email":"clenimar@lsd.ufcg.edu.br","username":"clenimar"},"change_message_id":"2be48c786a6907c410147e0d04d41d92e17229ff","unresolved":false,"context_lines":[{"line_number":184,"context_line":"                                project_name\u003dproject_name,"},{"line_number":185,"context_line":"                                project_domain_id\u003dproject_domain_id,"},{"line_number":186,"context_line":"                                project_domain_name\u003dproject_domain_name,"},{"line_number":187,"context_line":"                                project_is_domain\u003dTrue)"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"        self.assertEqual(project_id, token.project_id)"},{"line_number":190,"context_line":"        self.assertEqual(project_id, token[\u0027token\u0027][\u0027project\u0027][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"bab6814e_87b67188","line":187,"in_reply_to":"bab6814e_008ef277","updated":"2016-05-18 16:11:55.000000000","message":"Done","commit_id":"d469fb12219a7a5defab061fe7d9a427172e4655"}]}