)]}'
{"keystoneauth1/session.py":[{"author":{"_account_id":18338,"name":"Ron De Rose","email":"ronald.de.rose@intel.com","username":"derosenet"},"change_message_id":"06e0e6c5594cb7243f325ae45c2b070e51ea59d1","unresolved":false,"context_lines":[{"line_number":234,"context_line":""},{"line_number":235,"context_line":"        if user_agent is None:"},{"line_number":236,"context_line":"            # FIXME(shaleh): bike shed this message"},{"line_number":237,"context_line":"            debtcollector.deprecate(\u0027When creating or using keytoneauth1.Session user_agent must be set.\u0027)  # NOQA"},{"line_number":238,"context_line":"            user_agent \u003d _determine_user_agent()"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"        if user_agent is not None:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_903b31d1","line":237,"range":{"start_line":237,"start_character":92,"end_line":237,"end_character":96},"updated":"2016-06-06 19:13:54.000000000","message":"nit: ... should be set","commit_id":"d9d40d03c88f558b99c8de068766b9ad0aa8bb1a"},{"author":{"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"},"change_message_id":"9f697f1800734e2b70c66c41c9ae48eee6f6f2b7","unresolved":false,"context_lines":[{"line_number":234,"context_line":""},{"line_number":235,"context_line":"        if user_agent is None:"},{"line_number":236,"context_line":"            # FIXME(shaleh): bike shed this message"},{"line_number":237,"context_line":"            debtcollector.deprecate(\u0027When creating or using keytoneauth1.Session user_agent must be set.\u0027)  # NOQA"},{"line_number":238,"context_line":"            user_agent \u003d _determine_user_agent()"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"        if user_agent is not None:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_907df11e","line":237,"range":{"start_line":237,"start_character":92,"end_line":237,"end_character":96},"in_reply_to":"7aa08908_903b31d1","updated":"2016-06-06 19:16:49.000000000","message":"no no no :-)\n\nOnce the deprecation cycle is complete Keystone Auth will not let a Session be created that does not have some form of user_agent data provided by the caller.\n\nI used \u0027must\u0027 in the RFC sense. \u0027should\u0027 implies it is optional. Today it is. Once this commit occurs it no longer will be.","commit_id":"d9d40d03c88f558b99c8de068766b9ad0aa8bb1a"},{"author":{"_account_id":18338,"name":"Ron De Rose","email":"ronald.de.rose@intel.com","username":"derosenet"},"change_message_id":"aaf2746827ae700f25d41bfa8e655ee620c0e4e6","unresolved":false,"context_lines":[{"line_number":234,"context_line":""},{"line_number":235,"context_line":"        if user_agent is None:"},{"line_number":236,"context_line":"            # FIXME(shaleh): bike shed this message"},{"line_number":237,"context_line":"            debtcollector.deprecate(\u0027When creating or using keytoneauth1.Session user_agent must be set.\u0027)  # NOQA"},{"line_number":238,"context_line":"            user_agent \u003d _determine_user_agent()"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"        if user_agent is not None:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_0696e7ef","line":237,"range":{"start_line":237,"start_character":92,"end_line":237,"end_character":96},"in_reply_to":"7aa08908_907df11e","updated":"2016-06-06 20:04:21.000000000","message":"Ah, okay","commit_id":"d9d40d03c88f558b99c8de068766b9ad0aa8bb1a"},{"author":{"_account_id":18338,"name":"Ron De Rose","email":"ronald.de.rose@intel.com","username":"derosenet"},"change_message_id":"06e0e6c5594cb7243f325ae45c2b070e51ea59d1","unresolved":false,"context_lines":[{"line_number":496,"context_line":"            user_agent \u003d headers.setdefault(\u0027User-Agent\u0027, self.user_agent)"},{"line_number":497,"context_line":"        else:"},{"line_number":498,"context_line":"            # FIXME(shaleh): bike shed this message"},{"line_number":499,"context_line":"            debtcollector.deprecate(\u0027When creating or using keytoneauth1.Session user_agent must be set.\u0027)  # NOQA"},{"line_number":500,"context_line":"            user_agent \u003d headers.setdefault(\u0027User-Agent\u0027, DEFAULT_USER_AGENT)"},{"line_number":501,"context_line":""},{"line_number":502,"context_line":"        if self.original_ip:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_f050b50c","line":499,"range":{"start_line":499,"start_character":92,"end_line":499,"end_character":96},"updated":"2016-06-06 19:13:54.000000000","message":"nit: ... should be set","commit_id":"d9d40d03c88f558b99c8de068766b9ad0aa8bb1a"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"9b11402e5d4b7bf758b0e734df5d2ceca125024b","unresolved":false,"context_lines":[{"line_number":233,"context_line":"        # requests version, and then the Python version."},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"        if user_agent is None:"},{"line_number":236,"context_line":"            # FIXME(shaleh): bike shed this message"},{"line_number":237,"context_line":"            debtcollector.deprecate(\u0027When creating or using keytoneauth1.Session user_agent must be set.\u0027)  # NOQA"},{"line_number":238,"context_line":"            user_agent \u003d _determine_user_agent()"},{"line_number":239,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7aa08908_e20d35e9","line":236,"range":{"start_line":236,"start_character":14,"end_line":236,"end_character":51},"updated":"2016-06-08 00:11:27.000000000","message":"May want to remove this. Bike shedding is a given. :-)","commit_id":"c6df4874db0a6c5fc4d6a3b2fdd4cc6e2e9aa56e"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"e22d64eb933dcea10e12c2f9475a4854f143e3e9","unresolved":false,"context_lines":[{"line_number":233,"context_line":"        # requests version, and then the Python version."},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"        if user_agent is None:"},{"line_number":236,"context_line":"            # FIXME(shaleh): bike shed this message"},{"line_number":237,"context_line":"            debtcollector.deprecate(\u0027When creating or using keytoneauth1.Session user_agent must be set.\u0027)  # NOQA"},{"line_number":238,"context_line":"            user_agent \u003d _determine_user_agent()"},{"line_number":239,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7aa08908_4a499bcf","line":236,"range":{"start_line":236,"start_character":14,"end_line":236,"end_character":51},"in_reply_to":"7aa08908_62aca58c","updated":"2016-06-08 12:45:40.000000000","message":"++ We either fix it in this change, or accept it as it is :)\n\nLet\u0027s not merge FIXME notes like this (I am agreeing with you Sean)","commit_id":"c6df4874db0a6c5fc4d6a3b2fdd4cc6e2e9aa56e"},{"author":{"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"},"change_message_id":"750f28d88ff9023fff04c152f5d4683328e70267","unresolved":false,"context_lines":[{"line_number":233,"context_line":"        # requests version, and then the Python version."},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"        if user_agent is None:"},{"line_number":236,"context_line":"            # FIXME(shaleh): bike shed this message"},{"line_number":237,"context_line":"            debtcollector.deprecate(\u0027When creating or using keytoneauth1.Session user_agent must be set.\u0027)  # NOQA"},{"line_number":238,"context_line":"            user_agent \u003d _determine_user_agent()"},{"line_number":239,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7aa08908_62aca58c","line":236,"range":{"start_line":236,"start_character":14,"end_line":236,"end_character":51},"in_reply_to":"7aa08908_e20d35e9","updated":"2016-06-08 00:20:49.000000000","message":"If cores are happy with the text then the FIXME can be removed. I left it in to highlight something in need of attention.","commit_id":"c6df4874db0a6c5fc4d6a3b2fdd4cc6e2e9aa56e"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"c50d11b6bda1b406dc26f2815563bdc08599c686","unresolved":false,"context_lines":[{"line_number":234,"context_line":""},{"line_number":235,"context_line":"        if user_agent is None:"},{"line_number":236,"context_line":"            # FIXME(shaleh): bike shed this message"},{"line_number":237,"context_line":"            debtcollector.deprecate(\u0027When creating or using keytoneauth1.Session user_agent must be set.\u0027)  # NOQA"},{"line_number":238,"context_line":"            user_agent \u003d _determine_user_agent()"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"        if user_agent is not None:"}],"source_content_type":"text/x-python","patch_set":5,"id":"7aa08908_6b047d49","line":237,"range":{"start_line":237,"start_character":81,"end_line":237,"end_character":91},"updated":"2016-06-08 04:21:56.000000000","message":"you can\u0027t get around the 80 char line limit just by tagging #noqa","commit_id":"c6df4874db0a6c5fc4d6a3b2fdd4cc6e2e9aa56e"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"e22d64eb933dcea10e12c2f9475a4854f143e3e9","unresolved":false,"context_lines":[{"line_number":495,"context_line":"        elif self.user_agent:"},{"line_number":496,"context_line":"            user_agent \u003d headers.setdefault(\u0027User-Agent\u0027, self.user_agent)"},{"line_number":497,"context_line":"        else:"},{"line_number":498,"context_line":"            # FIXME(shaleh): bike shed this message"},{"line_number":499,"context_line":"            debtcollector.deprecate(\u0027When creating or using keytoneauth1.Session user_agent must be set.\u0027)  # NOQA"},{"line_number":500,"context_line":"            user_agent \u003d headers.setdefault(\u0027User-Agent\u0027, DEFAULT_USER_AGENT)"},{"line_number":501,"context_line":""},{"line_number":502,"context_line":"        if self.original_ip:"}],"source_content_type":"text/x-python","patch_set":5,"id":"7aa08908_ca0bcb7b","line":499,"range":{"start_line":498,"start_character":12,"end_line":499,"end_character":114},"updated":"2016-06-08 12:45:40.000000000","message":"Same comments above apply here","commit_id":"c6df4874db0a6c5fc4d6a3b2fdd4cc6e2e9aa56e"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"09c49fb62a3bbe3b41547fac78484d3a0e325966","unresolved":false,"context_lines":[{"line_number":233,"context_line":""},{"line_number":234,"context_line":"        if user_agent is None:"},{"line_number":235,"context_line":"            warnings.warn(\u0027When creating or using keytoneauth1.Session \u0027 +"},{"line_number":236,"context_line":"                          \u0027user_agent must be set.\u0027)"},{"line_number":237,"context_line":"            user_agent \u003d _determine_user_agent()"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"        if user_agent is not None:"}],"source_content_type":"text/x-python","patch_set":7,"id":"1aa78d24_644c2c77","line":236,"range":{"start_line":236,"start_character":27,"end_line":236,"end_character":50},"updated":"2016-07-08 14:03:46.000000000","message":"why?","commit_id":"39f35a36908557b61cc083d81d901c7f9eae0a0d"}]}