)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":18338,"name":"Ron De Rose","email":"ronald.de.rose@intel.com","username":"derosenet"},"change_message_id":"b0c698c7f0f03061beff308e49ea8b947f13b812","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Removing tox ignore D401 and make keystoneauth compliant"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently tox ignores D401 (401: First line should be in imperative mood)."},{"line_number":10,"context_line":"This change removes it and make keystoneauth docstring compliantwith it."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ia3bc1ecf0d2bd9699e9a1a549f9995c008db233c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5a18252c_b5bb77e4","line":9,"range":{"start_line":9,"start_character":72,"end_line":9,"end_character":74},"updated":"2016-04-14 15:04:32.000000000","message":"nit: commit message is a little long :)","commit_id":"01cf25ad36aaaeb7743b0a3eb07f738955067640"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"08cbbfab1bce1a5d115b5e56cef6bb4479bb6b74","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Removing tox ignore D401 and make keystoneauth compliant"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently tox ignores D401 (401: First line should be in imperative mood)."},{"line_number":10,"context_line":"This change removes it and make keystoneauth docstring compliantwith it."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ia3bc1ecf0d2bd9699e9a1a549f9995c008db233c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5a18252c_125d2147","line":10,"updated":"2016-04-14 15:00:17.000000000","message":"compliant with","commit_id":"01cf25ad36aaaeb7743b0a3eb07f738955067640"}],"keystoneauth1/access/access.py":[{"author":{"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"},"change_message_id":"715365af0aeffcf208655edeeacc8a5f61d1b128","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        return self._service_catalog"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def will_expire_soon(self, stale_duration\u003dSTALE_TOKEN_DURATION):"},{"line_number":88,"context_line":"        \"\"\"It determines if expiration is about to occur."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        :returns: true if expiration is within the given duration"},{"line_number":91,"context_line":"        :rtype: boolean"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a18252c_90951be6","line":88,"updated":"2016-04-12 20:35:41.000000000","message":"You have appear to have misunderstood the check.\n\nFrom the code:\n        \"\"\"D401: First line should be in imperative mood: \u0027Do\u0027, not \u0027Does\u0027.\n        [Docstring] prescribes the function or method\u0027s effect as a command:\n        (\"Do this\", \"Return that\"), not as a description; e.g. don\u0027t write\n        \"Returns the pathname ...\".\n\nSo this docstring should be \"Determine if expiration is about to occur.\"\n\nThe next one should be \"Return true if the auth token has a service catalog.\".","commit_id":"4dcff672e39b10dfa849959614b4df59aa2a91d2"},{"author":{"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"},"change_message_id":"7292de0d75636d1126cae094c9e7b523f97a814d","unresolved":false,"context_lines":[{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    @property"},{"line_number":162,"context_line":"    def user_domain_name(self):"},{"line_number":163,"context_line":"        \"\"\"Return the user\u0027s  domain name associated with the auth request."},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"        :returns: str"},{"line_number":166,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a18252c_5fe26cd6","line":163,"range":{"start_line":163,"start_character":28,"end_line":163,"end_character":30},"updated":"2016-04-12 23:14:19.000000000","message":"You might as well fix the double space while you are here.","commit_id":"4bbb704a51824b4ab3918efa04f600c7698f6bc4"}],"keystoneauth1/identity/v2.py":[{"author":{"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"},"change_message_id":"7292de0d75636d1126cae094c9e7b523f97a814d","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    @property"},{"line_number":88,"context_line":"    def has_scope_parameters(self):"},{"line_number":89,"context_line":"        \"\"\"Do plugin have parameters that will create a scoped token\"\"\""},{"line_number":90,"context_line":"        return self.tenant_id or self.tenant_name or self.trust_id"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a18252c_bfe8e07d","line":89,"updated":"2016-04-12 23:14:19.000000000","message":"Maybe it should read:\n\nReturn whether the parameters will create a scoped token.","commit_id":"4bbb704a51824b4ab3918efa04f600c7698f6bc4"},{"author":{"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"},"change_message_id":"71fabc89aed58180b91a28eeac902b8ec02a85b6","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    @property"},{"line_number":88,"context_line":"    def has_scope_parameters(self):"},{"line_number":89,"context_line":"        \"\"\"Return plugin parameters that will create a scoped token\"\"\""},{"line_number":90,"context_line":"        return self.tenant_id or self.tenant_name or self.trust_id"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5a18252c_0315113f","line":89,"updated":"2016-04-13 16:08:02.000000000","message":"This states the property will return \u0027plugin parameters\u0027 but it doesn\u0027t. The docstring needs to indicate that this is a boolean. My suggestion did this but another phrasing would be ok.","commit_id":"3db4e45a309ee34af795bc986f8160fd2fa77d63"}],"keystoneauth1/identity/v3/base.py":[{"author":{"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"},"change_message_id":"7292de0d75636d1126cae094c9e7b523f97a814d","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    @property"},{"line_number":79,"context_line":"    def has_scope_parameters(self):"},{"line_number":80,"context_line":"        \"\"\"Do plugin have parameters that will create a scoped token\"\"\""},{"line_number":81,"context_line":"        return (self.domain_id or self.domain_name or"},{"line_number":82,"context_line":"                self.project_id or self.project_name or"},{"line_number":83,"context_line":"                self.trust_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a18252c_ff02583d","line":80,"updated":"2016-04-12 23:14:19.000000000","message":"Same.","commit_id":"4bbb704a51824b4ab3918efa04f600c7698f6bc4"},{"author":{"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"},"change_message_id":"71fabc89aed58180b91a28eeac902b8ec02a85b6","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    @property"},{"line_number":79,"context_line":"    def has_scope_parameters(self):"},{"line_number":80,"context_line":"        \"\"\"Return plugin parameters that will create a scoped token\"\"\""},{"line_number":81,"context_line":"        return (self.domain_id or self.domain_name or"},{"line_number":82,"context_line":"                self.project_id or self.project_name or"},{"line_number":83,"context_line":"                self.trust_id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a18252c_e30f352c","line":80,"updated":"2016-04-13 16:08:02.000000000","message":"Same as my previous comment.","commit_id":"3db4e45a309ee34af795bc986f8160fd2fa77d63"}],"keystoneauth1/session.py":[{"author":{"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"},"change_message_id":"7292de0d75636d1126cae094c9e7b523f97a814d","unresolved":false,"context_lines":[{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    @staticmethod"},{"line_number":200,"context_line":"    def _process_header(header):"},{"line_number":201,"context_line":"        \"\"\"Edit the secure headers to be logged.\"\"\""},{"line_number":202,"context_line":"        secure_headers \u003d (\u0027authorization\u0027, \u0027x-auth-token\u0027,"},{"line_number":203,"context_line":"                          \u0027x-subject-token\u0027,)"},{"line_number":204,"context_line":"        if header[0].lower() in secure_headers:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a18252c_7f95a8e2","line":201,"updated":"2016-04-12 23:14:19.000000000","message":"Just change from \u0027Redacts\u0027 to \u0027Redact\u0027.","commit_id":"4bbb704a51824b4ab3918efa04f600c7698f6bc4"}]}