)]}'
{"doc/source/using-sessions.rst":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"5940f3b9de5437acadba6848ad7c9b6eb35183de","unresolved":false,"context_lines":[{"line_number":166,"context_line":"                                            \u0027interface\u0027: \u0027public\u0027,"},{"line_number":167,"context_line":"                                            \u0027version\u0027: 1},"},{"line_number":168,"context_line":"                           allow\u003d{\u0027allow_deprecated\u0027: False})"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"The session object determines the URL matching the filters and append to it the"},{"line_number":171,"context_line":"provided path and so create a valid request. If multiple URL matches are found"},{"line_number":172,"context_line":"then any one may be chosen."}],"source_content_type":"text/x-rst","patch_set":4,"id":"dab17558_43f462f1","line":169,"updated":"2016-05-08 06:51:25.000000000","message":"could mention here that usual allows are:\n\n  allow_deprecated\n  allow_experimental\n  allow_unknown\n\njust a small suggestion","commit_id":"a0d88aac9309466a71789b74cbeea684e2274926"}],"keystoneauth1/adapter.py":[{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"2e4fc8c085f9c27fab2b3b672c34b0ed65caa488","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        if self.logger:"},{"line_number":99,"context_line":"            kwargs.setdefault(\u0027logger\u0027, self.logger)"},{"line_number":100,"context_line":"        if self.allow:"},{"line_number":101,"context_line":"            kwargs.setdefault(\u0027allow\u0027, self.allow)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        return self.session.request(url, method, **kwargs)"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"dab17558_a18a61bd","line":101,"range":{"start_line":101,"start_character":43,"end_line":101,"end_character":44},"updated":"2016-05-09 01:51:35.000000000","message":"this will completely override those from the adapter, i\u0027m not sure this is really a problem, but maybe \n\nif self.allow: \n    allow \u003d self.allow.copy()\n    allow.merge(kwargs.get(\u0027allow\u0027, {}))\n    kwargs[\u0027allow\u0027] \u003d allow\n\ni always hated that merge() doesn\u0027t return the dict","commit_id":"118c9629e57f353aa49ba29c4b27e0e240788463"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"35de8aa5a0378285ca8657514529733e54affaa0","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        if self.logger:"},{"line_number":99,"context_line":"            kwargs.setdefault(\u0027logger\u0027, self.logger)"},{"line_number":100,"context_line":"        if self.allow:"},{"line_number":101,"context_line":"            kwargs.setdefault(\u0027allow\u0027, self.allow)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        return self.session.request(url, method, **kwargs)"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"dab17558_b1de173d","line":101,"range":{"start_line":101,"start_character":43,"end_line":101,"end_character":44},"in_reply_to":"dab17558_a18a61bd","updated":"2016-05-09 16:37:05.000000000","message":"Wouldn\u0027t that be true for any of the other arguments? like if kwargs had user_agent in it for some reason?","commit_id":"118c9629e57f353aa49ba29c4b27e0e240788463"}],"keystoneauth1/identity/base.py":[{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"7f4af07112b3f32a957dd4cd11dd2c04d06a5a89","unresolved":false,"context_lines":[{"line_number":237,"context_line":"                        \u0027Fallback to using that endpoint as the base url.\u0027,"},{"line_number":238,"context_line":"                        url)"},{"line_number":239,"context_line":"        else:"},{"line_number":240,"context_line":"            url \u003d disc.url_for(version, **kwargs)"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"        return url"},{"line_number":243,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_a44ff5bc","line":240,"range":{"start_line":240,"start_character":30,"end_line":240,"end_character":31},"updated":"2016-04-25 21:35:06.000000000","message":"So i\u0027m not saying the way we do it is right, but this contradicts the documentation of the base class[1].\n\nThe idea was that because there are plugins that aren\u0027t identity (even theoretically) you could ignore any options here you didn\u0027t understand. \n\nPassing all kwargs here to url_for would raise an error for unknown arguments. I think the way to handle this is to list the arguments explicity - and if we do that i\u0027d be interested in opinions on what format this should take. For example we can do allow\u003d{\u0027deprecated\u0027: False, \u0027experimental\u0027: True} or a range of other things than need to specify each of these as an additional parameter. \n\n\n[1] https://github.com/openstack/keystoneauth/blob/master/keystoneauth1/plugin.py#L97","commit_id":"a308337f94a3489713a5339569ec4b151086996c"}]}