)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"6118b75cc7f7f8d635c27856678708a9671994a4","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Move the openid_scope parameter from the OidcPassword class into the"},{"line_number":10,"context_line":"base _OidcBase class, as this is needed by all the OpenID grant types."},{"line_number":11,"context_line":"Also move the option to the corresponding loader."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I9a242ae93a61737d032c19830c5d89ef6237f875"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7aa08908_7a02dbb5","line":12,"updated":"2016-06-16 13:57:07.000000000","message":"There isn\u0027t any bp or bug related to this changes?","commit_id":"0e8494e0d78520ddfeb386070d03681e057ce910"}],"keystoneauth1/identity/v3/oidc.py":[{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"cc0d86397f87c23016c9ad9bd74760ab5b90bf14","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        return auth_response"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"class OidcPassword(_OidcBase):"},{"line_number":131,"context_line":"    \"\"\"Implementation for OpenID Connect Resource Owner Password Credential.\"\"\""},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    @positional(4)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_203c9de1","line":130,"range":{"start_line":130,"start_character":6,"end_line":130,"end_character":18},"updated":"2016-06-22 23:51:12.000000000","message":"This is a public symbol. Changing the parameter name from scope to openid_scope will break anyone calling this constructor with scope\u003d\u0027profile email\u0027\n\nI suggest to just move the argument without renaming it, but this won\u0027t fix the bug. Is there a way to map the option \u0027openid-scope\u0027 to \u0027scope\u0027 in this method so we avoid the error on __init__ (as described in the bug report) ?\n\n\nI would like to see others\u0027 view on this","commit_id":"6370ee38ceb43b384bddbdffa69fd39168deacd8"},{"author":{"_account_id":91,"name":"Alvaro","email":"aloga@ifca.unican.es","username":"aloga"},"change_message_id":"fe5bcf6dfb888a88210638860c0996f1fb4788c1","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        return auth_response"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"class OidcPassword(_OidcBase):"},{"line_number":131,"context_line":"    \"\"\"Implementation for OpenID Connect Resource Owner Password Credential.\"\"\""},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    @positional(4)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_626e9e96","line":130,"range":{"start_line":130,"start_character":6,"end_line":130,"end_character":18},"in_reply_to":"3aaa91ec_203c9de1","updated":"2016-06-23 07:33:18.000000000","message":"Hi Samuel.\n\nI do not know if there are users of this class outside OpenStack, but your argument is valid, so if others agree I would move the argument without renaming it. However, I do think that naming it \"scope\" instead of \"openid-scope\" will lead into confusion, as scope in keystone has a different meaning than in OpenID.,\n\nRegarding the option mapping I am actually more concerned in the change between the `scope` option in python-openstackclient and the rename into `openid-scope` in keystoneauth. This switch has cause some problems to some users (see https://bugs.launchpad.net/keystoneauth/+bug/1582774/comments/19). However, keystoneauth has been already released with \"openid-scope\" as an option.","commit_id":"6370ee38ceb43b384bddbdffa69fd39168deacd8"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"fdcb47dd003aabdf91b6ac68dc5e39f136d11a26","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        self.access_token_endpoint \u003d access_token_endpoint"},{"line_number":80,"context_line":"        self.grant_type \u003d grant_type"},{"line_number":81,"context_line":"        self.access_token_type \u003d access_token_type"},{"line_number":82,"context_line":"        self.openid_scope \u003d scope"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    def _get_access_token(self, session, payload):"},{"line_number":85,"context_line":"        \"\"\"Exchange a variety of user supplied values for an access token."}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_a08e8676","line":82,"updated":"2016-06-24 01:59:09.000000000","message":"this is still renaming a public attribute from scope to openid_scope. Why do you want to rename this? the old way would work and i don\u0027t think having it named scope really affects anything.","commit_id":"c64fdb43baa9e8b5a5a979542fdc3f7a3a1db066"},{"author":{"_account_id":91,"name":"Alvaro","email":"aloga@ifca.unican.es","username":"aloga"},"change_message_id":"c9fd5b6ad2469bb45d93904673aa8ff66e60af74","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        self.access_token_endpoint \u003d access_token_endpoint"},{"line_number":80,"context_line":"        self.grant_type \u003d grant_type"},{"line_number":81,"context_line":"        self.access_token_type \u003d access_token_type"},{"line_number":82,"context_line":"        self.openid_scope \u003d scope"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    def _get_access_token(self, session, payload):"},{"line_number":85,"context_line":"        \"\"\"Exchange a variety of user supplied values for an access token."}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_9bc65066","line":82,"in_reply_to":"3aaa91ec_a08e8676","updated":"2016-06-24 08:27:57.000000000","message":"Yes, you\u0027re correct.","commit_id":"c64fdb43baa9e8b5a5a979542fdc3f7a3a1db066"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"6d526dea7d523ddab52faf2327826cf03e72148f","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        \"\"\""},{"line_number":181,"context_line":"        # get an access token"},{"line_number":182,"context_line":"        payload \u003d {\u0027grant_type\u0027: self.grant_type, \u0027username\u0027: self.username,"},{"line_number":183,"context_line":"                   \u0027password\u0027: self.password,"},{"line_number":184,"context_line":"                   \u0027scope\u0027: self.scope}"},{"line_number":185,"context_line":"        access_token \u003d self._get_access_token(session, payload)"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"        response \u003d self._get_keystone_token(session, access_token)"}],"source_content_type":"text/x-python","patch_set":9,"id":"1aa78d24_090aaed2","line":184,"range":{"start_line":183,"start_character":19,"end_line":184,"end_character":39},"updated":"2016-07-04 00:50:35.000000000","message":"unrelated change, but OK","commit_id":"3285894318cc4618fb54ff678ede1b4de4dd04a9"},{"author":{"_account_id":91,"name":"Alvaro","email":"aloga@ifca.unican.es","username":"aloga"},"change_message_id":"8955ceb5236c37c6fa3870e5c422121d56d68670","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        \"\"\""},{"line_number":181,"context_line":"        # get an access token"},{"line_number":182,"context_line":"        payload \u003d {\u0027grant_type\u0027: self.grant_type, \u0027username\u0027: self.username,"},{"line_number":183,"context_line":"                   \u0027password\u0027: self.password,"},{"line_number":184,"context_line":"                   \u0027scope\u0027: self.scope}"},{"line_number":185,"context_line":"        access_token \u003d self._get_access_token(session, payload)"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"        response \u003d self._get_keystone_token(session, access_token)"}],"source_content_type":"text/x-python","patch_set":9,"id":"1aa78d24_8349528e","line":184,"range":{"start_line":183,"start_character":19,"end_line":184,"end_character":39},"in_reply_to":"1aa78d24_090aaed2","updated":"2016-07-04 10:07:45.000000000","message":"Yes, sorry, this was caused by the patched being updated along the time. Initially I was using self.openid_scope and the line was longer than 80 chars... I will update it.","commit_id":"3285894318cc4618fb54ff678ede1b4de4dd04a9"}],"keystoneauth1/loading/_plugins/identity/v3.py":[{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"cb89f35859318b8b140b7f80f968f47c0450cb0c","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            loading.Opt(\u0027client-id\u0027, help\u003d\u0027OAuth 2.0 Client ID\u0027),"},{"line_number":86,"context_line":"            loading.Opt(\u0027client-secret\u0027, secret\u003dTrue,"},{"line_number":87,"context_line":"                        help\u003d\u0027OAuth 2.0 Client Secret\u0027),"},{"line_number":88,"context_line":"            loading.Opt(\u0027openid-scope\u0027, default\u003d\"profile\","},{"line_number":89,"context_line":"                        help\u003d\u0027OpenID Connect scope that is requested from OP\u0027),"},{"line_number":90,"context_line":"            loading.Opt(\u0027access-token-endpoint\u0027,"},{"line_number":91,"context_line":"                        help\u003d\u0027OpenID Connect Provider Token Endpoint\u0027),"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_3d994d20","line":88,"updated":"2016-06-23 11:12:42.000000000","message":"As discussed on IRC with Jamie, add dest\u003d\u0027scope\u0027 here and do not rename the scope argument on the __init__ method of _OidcBase","commit_id":"b18ac90373f7a9dae872ef7819bab7b25a0895be"},{"author":{"_account_id":91,"name":"Alvaro","email":"aloga@ifca.unican.es","username":"aloga"},"change_message_id":"47dbee29936ba55963b0d92556f6afe03626de22","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            loading.Opt(\u0027client-id\u0027, help\u003d\u0027OAuth 2.0 Client ID\u0027),"},{"line_number":86,"context_line":"            loading.Opt(\u0027client-secret\u0027, secret\u003dTrue,"},{"line_number":87,"context_line":"                        help\u003d\u0027OAuth 2.0 Client Secret\u0027),"},{"line_number":88,"context_line":"            loading.Opt(\u0027openid-scope\u0027, default\u003d\"profile\","},{"line_number":89,"context_line":"                        help\u003d\u0027OpenID Connect scope that is requested from OP\u0027),"},{"line_number":90,"context_line":"            loading.Opt(\u0027access-token-endpoint\u0027,"},{"line_number":91,"context_line":"                        help\u003d\u0027OpenID Connect Provider Token Endpoint\u0027),"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_d469febf","line":88,"in_reply_to":"3aaa91ec_3d994d20","updated":"2016-06-23 12:25:15.000000000","message":"Done in the following patchset (6) and in https://review.openstack.org/#/c/333261/","commit_id":"b18ac90373f7a9dae872ef7819bab7b25a0895be"}],"keystoneauth1/tests/unit/loading/test_v3.py":[{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"4823c8d3510cedc794caf5479971e615f0d1e560","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        )"},{"line_number":141,"context_line":"        # openid-scope gets renamed into \"scope\""},{"line_number":142,"context_line":"        self.assertIn(\u0027scope\u0027, [o.dest for o in options])"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"class OpenIDConnectPasswordTests(OpenIDConnectBaseTests, utils.TestCase):"},{"line_number":146,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3aaa91ec_92ba4a09","line":143,"updated":"2016-06-27 16:52:55.000000000","message":"Please add a test showing scope\u003d\"profile\" is the default","commit_id":"2404b4c9836c75382fa0fe0ad99f2413202fbf1f"}]}