)]}'
{"keystoneauth1/identity/v3/oidc.py":[{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"c83c967143a63cb4e19d01ccd9cfd8b64de2a647","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    ``http://openid.net/specs/openid-connect-core-1_0.html``"},{"line_number":58,"context_line":"    \"\"\""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    grant_type \u003d None,"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def __init__(self, auth_url, identity_provider, protocol,"},{"line_number":63,"context_line":"                 client_id, client_secret,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_ca8df22b","line":60,"range":{"start_line":60,"start_character":21,"end_line":60,"end_character":22},"updated":"2016-06-16 16:49:25.000000000","message":"something is wrong if this doesn\u0027t fail","commit_id":"4eeb022963dc64f70c7fc560282efb3318957d50"},{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"c83c967143a63cb4e19d01ccd9cfd8b64de2a647","unresolved":false,"context_lines":[{"line_number":253,"context_line":"class OidcAuthorizationCode(_OidcBase):"},{"line_number":254,"context_line":"    \"\"\"Implementation for OpenID Connect Authorization Code.\"\"\""},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"    grant_type \u003d \u0027authorization_code\u0027,"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"    @positional(5)"},{"line_number":259,"context_line":"    def __init__(self, auth_url, identity_provider, protocol,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_8adaca15","line":256,"range":{"start_line":256,"start_character":17,"end_line":256,"end_character":38},"updated":"2016-06-16 16:49:25.000000000","message":"something is VERY wrong if this doesn\u0027t fail the tests","commit_id":"4eeb022963dc64f70c7fc560282efb3318957d50"},{"author":{"_account_id":91,"name":"Alvaro","email":"aloga@ifca.unican.es","username":"aloga"},"change_message_id":"8182ff9a485c0fc1f44608068a5ae243c2258c20","unresolved":false,"context_lines":[{"line_number":253,"context_line":"class OidcAuthorizationCode(_OidcBase):"},{"line_number":254,"context_line":"    \"\"\"Implementation for OpenID Connect Authorization Code.\"\"\""},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"    grant_type \u003d \u0027authorization_code\u0027,"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"    @positional(5)"},{"line_number":259,"context_line":"    def __init__(self, auth_url, identity_provider, protocol,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_8dedc190","line":256,"range":{"start_line":256,"start_character":17,"end_line":256,"end_character":38},"in_reply_to":"7aa08908_8adaca15","updated":"2016-06-16 17:47:56.000000000","message":"Yes, the existing tests are a bit useless. I am refactoring the oidc support, but I did not start yet with upgrading the tests. If you see the other patches in these series, these are WIP, but I forgot to mark them as WIP.","commit_id":"4eeb022963dc64f70c7fc560282efb3318957d50"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"23b271678f22ce722fa322a8db338ce1804e423d","unresolved":false,"context_lines":[{"line_number":133,"context_line":"            if grant_type !\u003d self.grant_type:"},{"line_number":134,"context_line":"                raise exceptions.OidcGrantTypeMissmatch()"},{"line_number":135,"context_line":"            warnings.warn(\"Passing grant_type as an argument has \""},{"line_number":136,"context_line":"                          \"been deprecated.\","},{"line_number":137,"context_line":"                          DeprecationWarning)"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    def get_discovery_document(self, session):"}],"source_content_type":"text/x-python","patch_set":18,"id":"1aa78d24_66f3a10b","line":136,"range":{"start_line":136,"start_character":32,"end_line":136,"end_character":42},"updated":"2016-07-03 22:05:28.000000000","message":"nit: please add a why and a what to do. eg. \n\nhas been deprecated and is now specified by the plugin itself. This argument should be dropped.","commit_id":"e2e485b51dc2c56b4f7d4f0c3ce4808c6067273a"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"32b5666b1789856a62ed071836d888d811c61126","unresolved":false,"context_lines":[{"line_number":133,"context_line":"            if grant_type !\u003d self.grant_type:"},{"line_number":134,"context_line":"                raise exceptions.OidcGrantTypeMissmatch()"},{"line_number":135,"context_line":"            warnings.warn(\"Passing grant_type as an argument has \""},{"line_number":136,"context_line":"                          \"been deprecated.\","},{"line_number":137,"context_line":"                          DeprecationWarning)"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    def get_discovery_document(self, session):"}],"source_content_type":"text/x-python","patch_set":18,"id":"1aa78d24_dc5502c7","line":136,"range":{"start_line":136,"start_character":32,"end_line":136,"end_character":42},"in_reply_to":"1aa78d24_66f3a10b","updated":"2016-07-04 02:13:44.000000000","message":"you can also add in the message that it will be dropped in July 2017 or the next major release (3.0.0)","commit_id":"e2e485b51dc2c56b4f7d4f0c3ce4808c6067273a"},{"author":{"_account_id":91,"name":"Alvaro","email":"aloga@ifca.unican.es","username":"aloga"},"change_message_id":"fe54882a712638c12f97d70fa57aef64510b4b02","unresolved":false,"context_lines":[{"line_number":133,"context_line":"            if grant_type !\u003d self.grant_type:"},{"line_number":134,"context_line":"                raise exceptions.OidcGrantTypeMissmatch()"},{"line_number":135,"context_line":"            warnings.warn(\"Passing grant_type as an argument has \""},{"line_number":136,"context_line":"                          \"been deprecated.\","},{"line_number":137,"context_line":"                          DeprecationWarning)"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    def get_discovery_document(self, session):"}],"source_content_type":"text/x-python","patch_set":18,"id":"1aa78d24_098e2178","line":136,"range":{"start_line":136,"start_character":32,"end_line":136,"end_character":42},"in_reply_to":"1aa78d24_dc5502c7","updated":"2016-07-04 10:07:37.000000000","message":"Done","commit_id":"e2e485b51dc2c56b4f7d4f0c3ce4808c6067273a"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"43e6c3f6abfc0c4357e9877780a154fb72bfeb78","unresolved":false,"context_lines":[{"line_number":133,"context_line":"            if grant_type !\u003d self.grant_type:"},{"line_number":134,"context_line":"                raise exceptions.OidcGrantTypeMissmatch()"},{"line_number":135,"context_line":"            warnings.warn(\"Passing grant_type as an argument has been \""},{"line_number":136,"context_line":"                          \"deprecated as it is now defined in the plugin\""},{"line_number":137,"context_line":"                          \"itself. You should stop passing this argument \""},{"line_number":138,"context_line":"                          \"to the plugin, as it will be ignored, since you \""},{"line_number":139,"context_line":"                          \"cannot pass a free text string as a grant_type. \""}],"source_content_type":"text/x-python","patch_set":20,"id":"1aa78d24_6de23ed7","line":136,"range":{"start_line":136,"start_character":66,"end_line":136,"end_character":73},"updated":"2016-07-04 15:11:39.000000000","message":"need a space after \"plugin\" here or it\u0027ll read \"pluginitself\"","commit_id":"ca213a065d961adda344c4a48abe836c4a1db447"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"352986a2a720f7a28f488b138e73adc236a9f46e","unresolved":false,"context_lines":[{"line_number":164,"context_line":""},{"line_number":165,"context_line":"        if grant_type is not None:"},{"line_number":166,"context_line":"            if grant_type !\u003d self.grant_type:"},{"line_number":167,"context_line":"                raise exceptions.OidcGrantTypeMissmatch()"},{"line_number":168,"context_line":"            warnings.warn(\"Passing grant_type as an argument has been \""},{"line_number":169,"context_line":"                          \"deprecated as it is now defined in the plugin \""},{"line_number":170,"context_line":"                          \"itself. You should stop passing this argument \""}],"source_content_type":"text/x-python","patch_set":28,"id":"1aa78d24_f24aac5a","line":167,"range":{"start_line":167,"start_character":55,"end_line":167,"end_character":57},"updated":"2016-07-14 02:55:22.000000000","message":"this is theoretically incompatible because you\u0027re rejecting the user\u0027s argument - however its probably reasonable in this case.","commit_id":"3f9e4f01c9cf97d5cb60fe8b7b267d77b5d158e6"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"5d97db021286c39d98422bfc5da381ca9725445b","unresolved":false,"context_lines":[{"line_number":247,"context_line":"                 client_id, client_secret,"},{"line_number":248,"context_line":"                 access_token_endpoint\u003dNone,"},{"line_number":249,"context_line":"                 discovery_endpoint\u003dNone,"},{"line_number":250,"context_line":"                 grant_type\u003dNone,"},{"line_number":251,"context_line":"                 access_token_type\u003d\u0027access_token\u0027,"},{"line_number":252,"context_line":"                 username\u003dNone, password\u003dNone,"},{"line_number":253,"context_line":"                 **kwargs):"}],"source_content_type":"text/x-python","patch_set":29,"id":"1aa78d24_926cfed1","line":250,"range":{"start_line":250,"start_character":28,"end_line":250,"end_character":32},"updated":"2016-07-14 08:48:08.000000000","message":"you can remove this and it will be picked up by **kwargs. \n\n@positional ensures this is backwards compatible.","commit_id":"57d270d8aa92fe9a22c41317eb2fd4fe67ea68d4"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"5d97db021286c39d98422bfc5da381ca9725445b","unresolved":false,"context_lines":[{"line_number":312,"context_line":""},{"line_number":313,"context_line":"    grant_type \u003d \u0027authorization_code\u0027"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"    @positional(5)"},{"line_number":316,"context_line":"    def __init__(self, auth_url, identity_provider, protocol,"},{"line_number":317,"context_line":"                 client_id, client_secret,"},{"line_number":318,"context_line":"                 access_token_endpoint\u003dNone,"}],"source_content_type":"text/x-python","patch_set":29,"id":"1aa78d24_d2ade6eb","line":315,"range":{"start_line":315,"start_character":5,"end_line":315,"end_character":15},"updated":"2016-07-14 08:48:08.000000000","message":"i\u0027m not sure why you increased this. this would include client_id but not client_secret.","commit_id":"57d270d8aa92fe9a22c41317eb2fd4fe67ea68d4"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"5d97db021286c39d98422bfc5da381ca9725445b","unresolved":false,"context_lines":[{"line_number":338,"context_line":"            access_token_endpoint\u003daccess_token_endpoint,"},{"line_number":339,"context_line":"            discovery_endpoint\u003ddiscovery_endpoint,"},{"line_number":340,"context_line":"            access_token_type\u003daccess_token_type,"},{"line_number":341,"context_line":"            grant_type\u003dgrant_type,"},{"line_number":342,"context_line":"            **kwargs)"},{"line_number":343,"context_line":"        self.redirect_uri \u003d redirect_uri"},{"line_number":344,"context_line":"        self.code \u003d code"}],"source_content_type":"text/x-python","patch_set":29,"id":"1aa78d24_927a3e76","line":341,"range":{"start_line":341,"start_character":23,"end_line":341,"end_character":33},"updated":"2016-07-14 08:48:08.000000000","message":"same thing, this can now just be passed as kwargs","commit_id":"57d270d8aa92fe9a22c41317eb2fd4fe67ea68d4"}],"keystoneauth1/tests/unit/identity/test_identity_v3_oidc.py":[{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"23b271678f22ce722fa322a8db338ce1804e423d","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            grant_type\u003duuid.uuid4().hex"},{"line_number":64,"context_line":"        )"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def test_can_pass_gran_type(self):"},{"line_number":67,"context_line":"        self.plugin.__class__("},{"line_number":68,"context_line":"            self.AUTH_URL,"},{"line_number":69,"context_line":"            self.IDENTITY_PROVIDER,"}],"source_content_type":"text/x-python","patch_set":18,"id":"1aa78d24_86da0d77","line":66,"range":{"start_line":66,"start_character":36,"end_line":66,"end_character":38},"updated":"2016-07-03 22:05:28.000000000","message":"grant","commit_id":"e2e485b51dc2c56b4f7d4f0c3ce4808c6067273a"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"23b271678f22ce722fa322a8db338ce1804e423d","unresolved":false,"context_lines":[{"line_number":70,"context_line":"            self.PROTOCOL,"},{"line_number":71,"context_line":"            client_id\u003dself.CLIENT_ID,"},{"line_number":72,"context_line":"            client_secret\u003dself.CLIENT_SECRET,"},{"line_number":73,"context_line":"            grant_type\u003dself.GRANT_TYPE)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def test_discovery_not_found(self):"},{"line_number":76,"context_line":"        self.requests_mock.get(\"http://not.found\","}],"source_content_type":"text/x-python","patch_set":18,"id":"1aa78d24_c6e4153d","line":73,"range":{"start_line":73,"start_character":28,"end_line":73,"end_character":38},"updated":"2016-07-03 22:05:28.000000000","message":"you can test this warning like: https://docs.python.org/2/library/warnings.html#testing-warnings","commit_id":"e2e485b51dc2c56b4f7d4f0c3ce4808c6067273a"}]}