)]}'
{"keystoneauth1/identity/v3/oidc.py":[{"author":{"_account_id":91,"name":"Alvaro","email":"aloga@ifca.unican.es","username":"aloga"},"change_message_id":"fc99f3023ed678c6f80d56939586833b48a572e7","unresolved":false,"context_lines":[{"line_number":536,"context_line":"        self.access_token \u003d access_token"},{"line_number":537,"context_line":""},{"line_number":538,"context_line":"    def _get_payload(self, session):"},{"line_number":539,"context_line":"        \"\"\"OidcAccessToken does not require a payload.\"\"\""},{"line_number":540,"context_line":""},{"line_number":541,"context_line":"    def get_unscoped_auth_ref(self, session):"},{"line_number":542,"context_line":"        \"\"\"Authenticate with OpenID Connect and get back claims."}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_7807831c","line":539,"updated":"2016-07-05 07:49:18.000000000","message":"I do not know what is the best option: Defining the base class as an ABC requires us to define the _get_payload method. Not defining the base class as abstract won\u0027t force us to do this redefinition here...","commit_id":"9128d9b1e5b6bdb4300945022e9d6fea7b42d3bf"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"5614e7735f1a3e8f2065630e22d4bb3bb3b75894","unresolved":false,"context_lines":[{"line_number":350,"context_line":"        :rtype: :py:class:`keystoneauth1.access.AccessInfoV3`"},{"line_number":351,"context_line":"        \"\"\""},{"line_number":352,"context_line":"        # First of all, check if the grant type is supported"},{"line_number":353,"context_line":"        self._check_grant_type(session)"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"        payload \u003d self._get_payload(session)"},{"line_number":356,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"1aa78d24_72c23c88","line":353,"range":{"start_line":353,"start_character":31,"end_line":353,"end_character":38},"updated":"2016-07-14 03:06:05.000000000","message":"IMO absorb this method","commit_id":"0ee9bfc558ccec9bb628c8d252b0605f569497ee"},{"author":{"_account_id":91,"name":"Alvaro","email":"aloga@ifca.unican.es","username":"aloga"},"change_message_id":"ebd12c8dc016b59b76fa0f655f7fb949789b6be6","unresolved":false,"context_lines":[{"line_number":350,"context_line":"        :rtype: :py:class:`keystoneauth1.access.AccessInfoV3`"},{"line_number":351,"context_line":"        \"\"\""},{"line_number":352,"context_line":"        # First of all, check if the grant type is supported"},{"line_number":353,"context_line":"        self._check_grant_type(session)"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"        payload \u003d self._get_payload(session)"},{"line_number":356,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"1aa78d24_f533b111","line":353,"range":{"start_line":353,"start_character":31,"end_line":353,"end_character":38},"in_reply_to":"1aa78d24_72c23c88","updated":"2016-07-14 08:27:09.000000000","message":"Done","commit_id":"0ee9bfc558ccec9bb628c8d252b0605f569497ee"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"5614e7735f1a3e8f2065630e22d4bb3bb3b75894","unresolved":false,"context_lines":[{"line_number":352,"context_line":"        # First of all, check if the grant type is supported"},{"line_number":353,"context_line":"        self._check_grant_type(session)"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"        payload \u003d self._get_payload(session)"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"        # get an access token"},{"line_number":358,"context_line":"        access_token \u003d self._get_access_token(session, payload)"}],"source_content_type":"text/x-python","patch_set":11,"id":"1aa78d24_72db5c7e","line":355,"updated":"2016-07-14 03:06:05.000000000","message":"payload.setdefault(\u0027grant_type\u0027, self.grant_type) \n\nis that safe? you\u0027ll always want grant_type set there right?","commit_id":"0ee9bfc558ccec9bb628c8d252b0605f569497ee"},{"author":{"_account_id":91,"name":"Alvaro","email":"aloga@ifca.unican.es","username":"aloga"},"change_message_id":"ebd12c8dc016b59b76fa0f655f7fb949789b6be6","unresolved":false,"context_lines":[{"line_number":352,"context_line":"        # First of all, check if the grant type is supported"},{"line_number":353,"context_line":"        self._check_grant_type(session)"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"        payload \u003d self._get_payload(session)"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"        # get an access token"},{"line_number":358,"context_line":"        access_token \u003d self._get_access_token(session, payload)"}],"source_content_type":"text/x-python","patch_set":11,"id":"1aa78d24_f51a917b","line":355,"in_reply_to":"1aa78d24_72db5c7e","updated":"2016-07-14 08:27:09.000000000","message":"Yes, the payload must contain the gran type.","commit_id":"0ee9bfc558ccec9bb628c8d252b0605f569497ee"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"5614e7735f1a3e8f2065630e22d4bb3bb3b75894","unresolved":false,"context_lines":[{"line_number":363,"context_line":"        return access.create(resp\u003dresponse)"},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"    @abc.abstractmethod"},{"line_number":366,"context_line":"    def _get_payload(self, session):"},{"line_number":367,"context_line":"        \"\"\"Get the plugin specific payload for obtainin an access token."},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"        OpenID Connect supports different grant types. This method should"}],"source_content_type":"text/x-python","patch_set":11,"id":"1aa78d24_b28e6477","line":366,"range":{"start_line":366,"start_character":27,"end_line":366,"end_character":34},"updated":"2016-07-14 03:06:05.000000000","message":"don\u0027t make things that are supposed to be overridden private.","commit_id":"0ee9bfc558ccec9bb628c8d252b0605f569497ee"},{"author":{"_account_id":91,"name":"Alvaro","email":"aloga@ifca.unican.es","username":"aloga"},"change_message_id":"ebd12c8dc016b59b76fa0f655f7fb949789b6be6","unresolved":false,"context_lines":[{"line_number":363,"context_line":"        return access.create(resp\u003dresponse)"},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"    @abc.abstractmethod"},{"line_number":366,"context_line":"    def _get_payload(self, session):"},{"line_number":367,"context_line":"        \"\"\"Get the plugin specific payload for obtainin an access token."},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"        OpenID Connect supports different grant types. This method should"}],"source_content_type":"text/x-python","patch_set":11,"id":"1aa78d24_5510c559","line":366,"range":{"start_line":366,"start_character":27,"end_line":366,"end_character":34},"in_reply_to":"1aa78d24_b28e6477","updated":"2016-07-14 08:27:09.000000000","message":"Done","commit_id":"0ee9bfc558ccec9bb628c8d252b0605f569497ee"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"146cce08d2fe932fc723b7376fcecdcda540b433","unresolved":false,"context_lines":[{"line_number":327,"context_line":"        :returns: a python dictionary containing the payload to be exchanged"},{"line_number":328,"context_line":"        :rtype: dict"},{"line_number":329,"context_line":"        \"\"\""},{"line_number":330,"context_line":"        payload \u003d {\u0027grant_type\u0027: self.grant_type, \u0027username\u0027: self.username,"},{"line_number":331,"context_line":"                   \u0027password\u0027: self.password, \u0027scope\u0027: self.scope}"},{"line_number":332,"context_line":"        return payload"},{"line_number":333,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"1aa78d24_0fc3c939","line":330,"range":{"start_line":330,"start_character":33,"end_line":330,"end_character":37},"updated":"2016-07-14 08:37:32.000000000","message":"don\u0027t include grant_type","commit_id":"3a097d273ae6ebc29eb0df91fbdf231bcc1104a5"},{"author":{"_account_id":91,"name":"Alvaro","email":"aloga@ifca.unican.es","username":"aloga"},"change_message_id":"0e1d6b46b504bc1018be31987bbcd9d4d2c6c997","unresolved":false,"context_lines":[{"line_number":327,"context_line":"        :returns: a python dictionary containing the payload to be exchanged"},{"line_number":328,"context_line":"        :rtype: dict"},{"line_number":329,"context_line":"        \"\"\""},{"line_number":330,"context_line":"        payload \u003d {\u0027grant_type\u0027: self.grant_type, \u0027username\u0027: self.username,"},{"line_number":331,"context_line":"                   \u0027password\u0027: self.password, \u0027scope\u0027: self.scope}"},{"line_number":332,"context_line":"        return payload"},{"line_number":333,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"1aa78d24_7247d277","line":330,"range":{"start_line":330,"start_character":33,"end_line":330,"end_character":37},"in_reply_to":"1aa78d24_0fc3c939","updated":"2016-07-14 09:04:21.000000000","message":"Done","commit_id":"3a097d273ae6ebc29eb0df91fbdf231bcc1104a5"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"146cce08d2fe932fc723b7376fcecdcda540b433","unresolved":false,"context_lines":[{"line_number":377,"context_line":"        :returns: a python dictionary containing the payload to be exchanged"},{"line_number":378,"context_line":"        :rtype: dict"},{"line_number":379,"context_line":"        \"\"\""},{"line_number":380,"context_line":"        payload \u003d {\u0027grant_type\u0027: self.grant_type,"},{"line_number":381,"context_line":"                   \u0027redirect_uri\u0027: self.redirect_uri,"},{"line_number":382,"context_line":"                   \u0027code\u0027: self.code}"},{"line_number":383,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"1aa78d24_8f0a1978","line":380,"range":{"start_line":380,"start_character":20,"end_line":380,"end_character":30},"updated":"2016-07-14 08:37:32.000000000","message":"don\u0027t include grant_type","commit_id":"3a097d273ae6ebc29eb0df91fbdf231bcc1104a5"},{"author":{"_account_id":91,"name":"Alvaro","email":"aloga@ifca.unican.es","username":"aloga"},"change_message_id":"0e1d6b46b504bc1018be31987bbcd9d4d2c6c997","unresolved":false,"context_lines":[{"line_number":377,"context_line":"        :returns: a python dictionary containing the payload to be exchanged"},{"line_number":378,"context_line":"        :rtype: dict"},{"line_number":379,"context_line":"        \"\"\""},{"line_number":380,"context_line":"        payload \u003d {\u0027grant_type\u0027: self.grant_type,"},{"line_number":381,"context_line":"                   \u0027redirect_uri\u0027: self.redirect_uri,"},{"line_number":382,"context_line":"                   \u0027code\u0027: self.code}"},{"line_number":383,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"1aa78d24_92423e67","line":380,"range":{"start_line":380,"start_character":20,"end_line":380,"end_character":30},"in_reply_to":"1aa78d24_8f0a1978","updated":"2016-07-14 09:04:21.000000000","message":"Done","commit_id":"3a097d273ae6ebc29eb0df91fbdf231bcc1104a5"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"146cce08d2fe932fc723b7376fcecdcda540b433","unresolved":false,"context_lines":[{"line_number":417,"context_line":"        self.access_token \u003d access_token"},{"line_number":418,"context_line":""},{"line_number":419,"context_line":"    def get_payload(self, session):"},{"line_number":420,"context_line":"        \"\"\"OidcAccessToken does not require a payload.\"\"\""},{"line_number":421,"context_line":""},{"line_number":422,"context_line":"    def get_unscoped_auth_ref(self, session):"},{"line_number":423,"context_line":"        \"\"\"Authenticate with OpenID Connect and get back claims."}],"source_content_type":"text/x-python","patch_set":12,"id":"1aa78d24_6fb36dea","line":420,"range":{"start_line":420,"start_character":46,"end_line":420,"end_character":53},"updated":"2016-07-14 08:37:32.000000000","message":"must return {}","commit_id":"3a097d273ae6ebc29eb0df91fbdf231bcc1104a5"},{"author":{"_account_id":91,"name":"Alvaro","email":"aloga@ifca.unican.es","username":"aloga"},"change_message_id":"0e1d6b46b504bc1018be31987bbcd9d4d2c6c997","unresolved":false,"context_lines":[{"line_number":417,"context_line":"        self.access_token \u003d access_token"},{"line_number":418,"context_line":""},{"line_number":419,"context_line":"    def get_payload(self, session):"},{"line_number":420,"context_line":"        \"\"\"OidcAccessToken does not require a payload.\"\"\""},{"line_number":421,"context_line":""},{"line_number":422,"context_line":"    def get_unscoped_auth_ref(self, session):"},{"line_number":423,"context_line":"        \"\"\"Authenticate with OpenID Connect and get back claims."}],"source_content_type":"text/x-python","patch_set":12,"id":"1aa78d24_b2213aff","line":420,"range":{"start_line":420,"start_character":46,"end_line":420,"end_character":53},"in_reply_to":"1aa78d24_6fb36dea","updated":"2016-07-14 09:04:21.000000000","message":"Done","commit_id":"3a097d273ae6ebc29eb0df91fbdf231bcc1104a5"}]}