)]}'
{"doc/source/migrating.rst":[{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"1ff70fb8b3ade02a4fc170c068fc67e92e9e5671","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"Obtaining the session::"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    -from keystoneclient import session"},{"line_number":86,"context_line":"    +from keystoneauth1 import loading as ks_loading"},{"line_number":87,"context_line":"    +from keystoneauth1 import session"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a89bdaa_2f3135ed","side":"PARENT","line":85,"range":{"start_line":85,"start_character":0,"end_line":85,"end_character":39},"updated":"2016-09-09 11:28:36.000000000","message":"and this should be removed","commit_id":"50e8ace09c1293cbb45df505b9f491f74de838dc"},{"author":{"_account_id":14352,"name":"Antoni Segura Puimedon","email":"celebdor@gmail.com","username":"toni"},"change_message_id":"0bf171a8fbb9fa1023884bd953e786662004e0ef","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"Obtaining the session::"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    -from keystoneclient import session"},{"line_number":86,"context_line":"    +from keystoneauth1 import loading as ks_loading"},{"line_number":87,"context_line":"    +from keystoneauth1 import session"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a89bdaa_6fd41d47","side":"PARENT","line":85,"range":{"start_line":85,"start_character":0,"end_line":85,"end_character":39},"in_reply_to":"9a89bdaa_2f3135ed","updated":"2016-09-09 11:34:24.000000000","message":"This is being removed, note the \u0027-\u0027 leading the line.","commit_id":"50e8ace09c1293cbb45df505b9f491f74de838dc"},{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"1b04c6111429ffd9c674b8c802a0b099fb05b70b","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"Obtaining the session::"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    -from keystoneclient import session"},{"line_number":86,"context_line":"    +from keystoneauth1 import loading as ks_loading"},{"line_number":87,"context_line":"    +from keystoneauth1 import session"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a89bdaa_6a4ecb97","side":"PARENT","line":85,"range":{"start_line":85,"start_character":0,"end_line":85,"end_character":39},"in_reply_to":"9a89bdaa_6fd41d47","updated":"2016-09-09 12:00:27.000000000","message":"got it.","commit_id":"50e8ace09c1293cbb45df505b9f491f74de838dc"},{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"1ff70fb8b3ade02a4fc170c068fc67e92e9e5671","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    -from keystoneclient import session"},{"line_number":86,"context_line":"    +from keystoneauth1 import loading as ks_loading"},{"line_number":87,"context_line":"    +from keystoneauth1 import session"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    -_SESSION \u003d session.Session.load_from_conf_options("},{"line_number":90,"context_line":"    -auth_plugin \u003d auth.load_from_conf_options(conf, NEUTRON_GROUP)"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a89bdaa_ef366de6","side":"PARENT","line":87,"range":{"start_line":87,"start_character":4,"end_line":87,"end_character":38},"updated":"2016-09-09 11:28:36.000000000","message":"this line should have stayed","commit_id":"50e8ace09c1293cbb45df505b9f491f74de838dc"},{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"1b04c6111429ffd9c674b8c802a0b099fb05b70b","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    -from keystoneclient import session"},{"line_number":86,"context_line":"    +from keystoneauth1 import loading as ks_loading"},{"line_number":87,"context_line":"    +from keystoneauth1 import session"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    -_SESSION \u003d session.Session.load_from_conf_options("},{"line_number":90,"context_line":"    -auth_plugin \u003d auth.load_from_conf_options(conf, NEUTRON_GROUP)"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a89bdaa_ea73bbe5","side":"PARENT","line":87,"range":{"start_line":87,"start_character":4,"end_line":87,"end_character":38},"in_reply_to":"9a89bdaa_8f57a1c9","updated":"2016-09-09 12:00:27.000000000","message":"ooooh, i get it","commit_id":"50e8ace09c1293cbb45df505b9f491f74de838dc"},{"author":{"_account_id":14352,"name":"Antoni Segura Puimedon","email":"celebdor@gmail.com","username":"toni"},"change_message_id":"0bf171a8fbb9fa1023884bd953e786662004e0ef","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    -from keystoneclient import session"},{"line_number":86,"context_line":"    +from keystoneauth1 import loading as ks_loading"},{"line_number":87,"context_line":"    +from keystoneauth1 import session"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    -_SESSION \u003d session.Session.load_from_conf_options("},{"line_number":90,"context_line":"    -auth_plugin \u003d auth.load_from_conf_options(conf, NEUTRON_GROUP)"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a89bdaa_8f57a1c9","side":"PARENT","line":87,"range":{"start_line":87,"start_character":4,"end_line":87,"end_character":38},"in_reply_to":"9a89bdaa_ef366de6","updated":"2016-09-09 11:34:24.000000000","message":"The code in lines 91-92 is not using \u0027session\u0027 so I struggle to see why the migration instractions say that it should be imported. AFAICT it was used before the migration to do:\n\n    session.Session.load_from_conf_options\u0027\n\nHowever, now we use keystonauth1.loading for that.","commit_id":"50e8ace09c1293cbb45df505b9f491f74de838dc"},{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"1b04c6111429ffd9c674b8c802a0b099fb05b70b","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    -_SESSION \u003d session.Session.load_from_conf_options("},{"line_number":89,"context_line":"    -auth_plugin \u003d auth.load_from_conf_options(conf, NEUTRON_GROUP)"},{"line_number":90,"context_line":"    +_SESSION \u003d ks_loading.load_session_from_conf_options("},{"line_number":91,"context_line":"    +auth_plugin \u003d ks_loading.load_auth_from_conf_options(conf, NEUTRON_GROUP)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Mocking session for test purposes::"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a89bdaa_aa48d388","line":90,"updated":"2016-09-09 12:00:27.000000000","message":"something seems to be missing here","commit_id":"151f31314e21dff1ae27f956572ca9c8a45f45c3"},{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"61431d32385455e8b0f27e687e637fba988acf69","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    -_SESSION \u003d session.Session.load_from_conf_options("},{"line_number":89,"context_line":"    -auth_plugin \u003d auth.load_from_conf_options(conf, NEUTRON_GROUP)"},{"line_number":90,"context_line":"    +_SESSION \u003d ks_loading.load_session_from_conf_options("},{"line_number":91,"context_line":"    +auth_plugin \u003d ks_loading.load_auth_from_conf_options(conf, NEUTRON_GROUP)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Mocking session for test purposes::"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a89bdaa_022516c1","line":90,"in_reply_to":"9a89bdaa_aa48d388","updated":"2016-09-09 16:29:57.000000000","message":"looks intentional though, because 2 lines above it\u0027s still the same.","commit_id":"151f31314e21dff1ae27f956572ca9c8a45f45c3"}]}