)]}'
{"keystoneauth1/loading/_plugins/identity/v3.py":[{"author":{"_account_id":91,"name":"Alvaro","email":"aloga@ifca.unican.es","username":"aloga"},"change_message_id":"cddefe03b131384d3e1c77fac92b9d75b4db4bfd","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        options \u003d super(_OpenIDConnectBase, self).get_options()"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        options.extend(["},{"line_number":97,"context_line":"            loading.Opt(\u0027client-id\u0027, help\u003d\u0027OAuth 2.0 Client ID\u0027),"},{"line_number":98,"context_line":"            loading.Opt(\u0027client-secret\u0027, secret\u003dTrue,"},{"line_number":99,"context_line":"                        help\u003d\u0027OAuth 2.0 Client Secret\u0027),"},{"line_number":100,"context_line":"            loading.Opt(\u0027openid-scope\u0027, default\u003d\"openid profile\","}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_5fd67f28","line":97,"updated":"2016-11-02 21:35:09.000000000","message":"What about adding these two (client-id and client-secret)?","commit_id":"827895281ba2d0a1786ee92ad859414de1dbe64b"},{"author":{"_account_id":91,"name":"Alvaro","email":"aloga@ifca.unican.es","username":"aloga"},"change_message_id":"1f8092b6bd732d7b4bfca2d4658f7564d3cd97de","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        options \u003d super(_OpenIDConnectBase, self).get_options()"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        options.extend(["},{"line_number":97,"context_line":"            loading.Opt(\u0027client-id\u0027, help\u003d\u0027OAuth 2.0 Client ID\u0027),"},{"line_number":98,"context_line":"            loading.Opt(\u0027client-secret\u0027, secret\u003dTrue,"},{"line_number":99,"context_line":"                        help\u003d\u0027OAuth 2.0 Client Secret\u0027),"},{"line_number":100,"context_line":"            loading.Opt(\u0027openid-scope\u0027, default\u003d\"openid profile\","}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_db1bc371","line":97,"in_reply_to":"9a629dbe_102efa42","updated":"2016-11-09 16:37:28.000000000","message":"These two are actually required for the client credentials, the authorization code and the resource owner password grant types, so they can be added safely (no other subclasses inherit from this).\n\nHowever, as you said, we can add this in a further patch (I will double check the specs).","commit_id":"827895281ba2d0a1786ee92ad859414de1dbe64b"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"e38d5bed126cee76a00ba6a7c858a0e6d67dbd41","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        options \u003d super(_OpenIDConnectBase, self).get_options()"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        options.extend(["},{"line_number":97,"context_line":"            loading.Opt(\u0027client-id\u0027, help\u003d\u0027OAuth 2.0 Client ID\u0027),"},{"line_number":98,"context_line":"            loading.Opt(\u0027client-secret\u0027, secret\u003dTrue,"},{"line_number":99,"context_line":"                        help\u003d\u0027OAuth 2.0 Client Secret\u0027),"},{"line_number":100,"context_line":"            loading.Opt(\u0027openid-scope\u0027, default\u003d\"openid profile\","}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_102efa42","line":97,"in_reply_to":"ba5da102_5fd67f28","updated":"2016-11-09 16:24:10.000000000","message":"maybe? i\u0027m not entirely sure since these are in the base class and the last thing I want to do is apply it to all and make them required when they may not be. i\u0027m not familiar enough with the spec (or how the apache modules leverage them) to say for certain that they should always be there.\n\nwe could always make them required in a follow-on patch","commit_id":"827895281ba2d0a1786ee92ad859414de1dbe64b"}]}