)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"1a2b4a4c7c3cb480e6a6567cfc02521ab820c002","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When SSL Verfication is enabled (by default),"},{"line_number":10,"context_line":"not specifying a default CABundle causes unexpected"},{"line_number":11,"context_line":"SSL verification failures."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I62e5d58d5635b4541c8b65f83003c68f0b55c750"},{"line_number":14,"context_line":"Closes-Bug: #1678686"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"bff0334d_46a2949c","line":11,"updated":"2017-04-05 21:36:32.000000000","message":"In all cases or just certain cases?","commit_id":"156a842f3a28cf518f76b0d46150367469d3bd3b"}],"keystoneauth1/session.py":[{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"468eed24f3911a8b64521540e8d940ecedc95470","unresolved":false,"context_lines":[{"line_number":239,"context_line":"        if verify is True:"},{"line_number":240,"context_line":"            # Either verify was explicitly asked for, but no bundle specified."},{"line_number":241,"context_line":"            # We should always default to the system bundle, if it exists."},{"line_number":242,"context_line":"            _defaults \u003d ssl.get_default_verify_paths()"},{"line_number":243,"context_line":"            if _defaults.cafile:"},{"line_number":244,"context_line":"                verify \u003d _defaults.cafile"},{"line_number":245,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"dfeb2761_29af1ae4","line":242,"range":{"start_line":242,"start_character":24,"end_line":242,"end_character":54},"updated":"2017-04-03 13:58:51.000000000","message":"python docs say that this is new in version 2.7.9. Are we sure that everyone already runs 2.7.9 and not 2.7.8?","commit_id":"42ea64b83d163912763c55e29b30f9f2173b9129"},{"author":{"_account_id":6522,"name":"Sean McCully","email":"sean_mccully@yahoo.com","username":"sean-mccully"},"change_message_id":"f09a955668df67baac8d922fbde551ffc2af2a40","unresolved":false,"context_lines":[{"line_number":239,"context_line":"        if verify is True:"},{"line_number":240,"context_line":"            # Either verify was explicitly asked for, but no bundle specified."},{"line_number":241,"context_line":"            # We should always default to the system bundle, if it exists."},{"line_number":242,"context_line":"            _defaults \u003d ssl.get_default_verify_paths()"},{"line_number":243,"context_line":"            if _defaults.cafile:"},{"line_number":244,"context_line":"                verify \u003d _defaults.cafile"},{"line_number":245,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"dfeb2761_ff3b24c5","line":242,"range":{"start_line":242,"start_character":24,"end_line":242,"end_character":54},"in_reply_to":"dfeb2761_29af1ae4","updated":"2017-04-03 14:42:21.000000000","message":"Is there a standard 2.7.X  target for releases?","commit_id":"42ea64b83d163912763c55e29b30f9f2173b9129"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"1a2b4a4c7c3cb480e6a6567cfc02521ab820c002","unresolved":false,"context_lines":[{"line_number":314,"context_line":"        # so we need to actually check that this is False."},{"line_number":315,"context_line":"        if self.verify is False:"},{"line_number":316,"context_line":"            string_parts.append(\u0027--insecure\u0027)"},{"line_number":317,"context_line":"        elif isinstance(self.verify, six.string_types):"},{"line_number":318,"context_line":"            string_parts.append(\u0027--cacert \"%s\"\u0027 % self.verify)"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"        if method:"}],"source_content_type":"text/x-python","patch_set":8,"id":"bff0334d_ecb4e937","side":"PARENT","line":317,"updated":"2017-04-05 21:36:32.000000000","message":"(nit) I\u0027d probably remove the \u0027elif\u0027 and change move the new block on line 351 upt a level, rewriting the \u0027if\u0027 as an \u0027elif\u0027.","commit_id":"fdc454c154fddb415492669b3a1339f8286e2129"},{"author":{"_account_id":6522,"name":"Sean McCully","email":"sean_mccully@yahoo.com","username":"sean-mccully"},"change_message_id":"2d1db0167c006c3ffb5197fb754c8d68868f4ed7","unresolved":false,"context_lines":[{"line_number":314,"context_line":"        # so we need to actually check that this is False."},{"line_number":315,"context_line":"        if self.verify is False:"},{"line_number":316,"context_line":"            string_parts.append(\u0027--insecure\u0027)"},{"line_number":317,"context_line":"        elif isinstance(self.verify, six.string_types):"},{"line_number":318,"context_line":"            string_parts.append(\u0027--cacert \"%s\"\u0027 % self.verify)"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"        if method:"}],"source_content_type":"text/x-python","patch_set":8,"id":"bff0334d_5cab80d5","side":"PARENT","line":317,"in_reply_to":"bff0334d_ecb4e937","updated":"2017-04-05 22:33:36.000000000","message":"ok","commit_id":"fdc454c154fddb415492669b3a1339f8286e2129"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"1a2b4a4c7c3cb480e6a6567cfc02521ab820c002","unresolved":false,"context_lines":[{"line_number":269,"context_line":"        known CAPath(s)."},{"line_number":270,"context_line":"        \"\"\""},{"line_number":271,"context_line":"        def _try_paths():"},{"line_number":272,"context_line":"            tries \u003d (\u0027/etc/openssl/\u0027, \u0027/etc/pki/tls/\u0027,"},{"line_number":273,"context_line":"                     \u0027/System/Library/OpenSSL/\u0027, \u0027/usr/lib/ssl/\u0027,"},{"line_number":274,"context_line":"                     \u0027/usr/local/openssl/\u0027, \u0027/usr/local/ssl/\u0027,"},{"line_number":275,"context_line":"                     \u0027/usr/share/ssl/\u0027, \u0027/usr/ssl/\u0027, \u0027/var/ssl/\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"bff0334d_615b422e","line":272,"updated":"2017-04-05 21:36:32.000000000","message":"Where did this list come from? It worries me a bit that _try_paths() could return a directory that exists, but lacks certs. What happens in that case? It is better than the default behavior?","commit_id":"156a842f3a28cf518f76b0d46150367469d3bd3b"},{"author":{"_account_id":6522,"name":"Sean McCully","email":"sean_mccully@yahoo.com","username":"sean-mccully"},"change_message_id":"2d1db0167c006c3ffb5197fb754c8d68868f4ed7","unresolved":false,"context_lines":[{"line_number":269,"context_line":"        known CAPath(s)."},{"line_number":270,"context_line":"        \"\"\""},{"line_number":271,"context_line":"        def _try_paths():"},{"line_number":272,"context_line":"            tries \u003d (\u0027/etc/openssl/\u0027, \u0027/etc/pki/tls/\u0027,"},{"line_number":273,"context_line":"                     \u0027/System/Library/OpenSSL/\u0027, \u0027/usr/lib/ssl/\u0027,"},{"line_number":274,"context_line":"                     \u0027/usr/local/openssl/\u0027, \u0027/usr/local/ssl/\u0027,"},{"line_number":275,"context_line":"                     \u0027/usr/share/ssl/\u0027, \u0027/usr/ssl/\u0027, \u0027/var/ssl/\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"bff0334d_3c1c3c69","line":272,"in_reply_to":"bff0334d_615b422e","updated":"2017-04-05 22:33:36.000000000","message":"I looked through a handful of various distributions, various version of Ubuntu, Fedora, CentOS, Debian, these are paths that are used.\nBut I used this from somebody who compiled a list of all the common compiled CAPaths that are used by default with OpenSSL,\n\nhttp://gagravarr.org/writing/openssl-certs/others.shtml\n\nYeah, so I not really sure that this is really needed to support where get_default_verify_paths is not available. But I added, obviously it could be improved by actually validating that some \u0027crt\u0027/\u0027pem\u0027 files exists.","commit_id":"156a842f3a28cf518f76b0d46150367469d3bd3b"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"1a2b4a4c7c3cb480e6a6567cfc02521ab820c002","unresolved":false,"context_lines":[{"line_number":287,"context_line":"        elif _paths.capath and os.path.exists(_paths.capath):"},{"line_number":288,"context_line":"            return _paths.capath"},{"line_number":289,"context_line":"        else:"},{"line_number":290,"context_line":"            return _try_paths()"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"    @property"},{"line_number":293,"context_line":"    def adapters(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"bff0334d_ac514111","line":290,"updated":"2017-04-05 21:36:32.000000000","message":"Can this actually happen? I just looked over the python and openssl sources to see where this comes from. (UPDATE: I read the C code and related bugs for openssl...it looks like they can return incorrect values.)\n\nAny reason why we don\u0027t fall through to the default?","commit_id":"156a842f3a28cf518f76b0d46150367469d3bd3b"},{"author":{"_account_id":6522,"name":"Sean McCully","email":"sean_mccully@yahoo.com","username":"sean-mccully"},"change_message_id":"2d1db0167c006c3ffb5197fb754c8d68868f4ed7","unresolved":false,"context_lines":[{"line_number":287,"context_line":"        elif _paths.capath and os.path.exists(_paths.capath):"},{"line_number":288,"context_line":"            return _paths.capath"},{"line_number":289,"context_line":"        else:"},{"line_number":290,"context_line":"            return _try_paths()"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"    @property"},{"line_number":293,"context_line":"    def adapters(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"bff0334d_7c69a4bc","line":290,"in_reply_to":"bff0334d_ac514111","updated":"2017-04-05 22:33:36.000000000","message":"Yeah, I initially wrote it to fall through and then updated on second thoughts.\n\nAgain, I am ok with either.\n1. Removing the whole paths thing completly and never revisiting.\n2. Removing from this patch, and added it in a second though improved. Apparently this is akin to what PIP does as well.\n3.  I could improve this in this patch as well.","commit_id":"156a842f3a28cf518f76b0d46150367469d3bd3b"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"463f0ddcbce2be2ab929bd267df64f6f984cba46","unresolved":false,"context_lines":[{"line_number":242,"context_line":"        if verify is True:"},{"line_number":243,"context_line":"            # Either verify was explicitly asked for, but no bundle specified."},{"line_number":244,"context_line":"            # We should always default to the system bundle, if it exists."},{"line_number":245,"context_line":"            verify \u003d SSL_VERIFY or True"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"        self.auth \u003d auth"},{"line_number":248,"context_line":"        self.session \u003d _construct_session(session)"}],"source_content_type":"text/x-python","patch_set":12,"id":"bff0334d_56d9b4f0","line":245,"range":{"start_line":245,"start_character":32,"end_line":245,"end_character":39},"updated":"2017-04-09 08:35:58.000000000","message":"Anything or True will always return true, i.e. None or True \u003d\u003e True.  Wouldn\u0027t this block just always set verify to True if it is True?","commit_id":"0357db018410b11c9439808f5712ad9ae4dab8a1"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"e340401f50b930be34411c2442a58c24972ceb89","unresolved":false,"context_lines":[{"line_number":242,"context_line":"        if verify is True:"},{"line_number":243,"context_line":"            # Either verify was explicitly asked for, but no bundle specified."},{"line_number":244,"context_line":"            # We should always default to the system bundle, if it exists."},{"line_number":245,"context_line":"            verify \u003d SSL_VERIFY or True"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"        self.auth \u003d auth"},{"line_number":248,"context_line":"        self.session \u003d _construct_session(session)"}],"source_content_type":"text/x-python","patch_set":12,"id":"bff0334d_44e21ea2","line":245,"in_reply_to":"bff0334d_56d9b4f0","updated":"2017-04-09 14:48:28.000000000","message":"Yes, that looks to be the case. My guess is the author meant \u0027if verify\u0027 instead of \u0027if verify is True\u0027","commit_id":"0357db018410b11c9439808f5712ad9ae4dab8a1"}]}