)]}'
{"keystoneauth1/extras/_saml2/_loading.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"4e9d71c1d2c1f575d0044ae00097d2a0c03ed63f","unresolved":false,"context_lines":[{"line_number":56,"context_line":"                        help\u003d\"Service Provider\u0027s Endpoint\"),"},{"line_number":57,"context_line":"            loading.Opt(\u0027service-provider-entity-id\u0027,"},{"line_number":58,"context_line":"                        help\u003d\"Service Provider\u0027s SAML SP Entity ID\"),"},{"line_number":59,"context_line":"            loading.Opt(\u0027identity-provider-url\u0027,"},{"line_number":60,"context_line":"                        help\u003d(\u0027An Identity Provider URL, where the SAML2 \u0027"},{"line_number":61,"context_line":"                              \u0027authentication request will be sent.\u0027)),"},{"line_number":62,"context_line":"            loading.Opt(\u0027username\u0027, help\u003d\u0027Username\u0027),"},{"line_number":63,"context_line":"            loading.Opt(\u0027password\u0027, secret\u003dTrue, help\u003d\u0027Password\u0027)"},{"line_number":64,"context_line":"        ])"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f044301_a4c1fb82","line":61,"range":{"start_line":59,"start_character":0,"end_line":61,"end_character":71},"updated":"2017-05-09 03:07:03.000000000","message":"bah, we missed this, it\u0027s in the Saml2Password one mentioned above... :(","commit_id":"d2952068816875d556b5382a50a2e8127bf778a7"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"931a330526e382e19ab1da876e8933f72f034518","unresolved":false,"context_lines":[{"line_number":58,"context_line":"            loading.Opt(\u0027service-provider-endpoint\u0027,"},{"line_number":59,"context_line":"                        help\u003d\"Service Provider\u0027s Endpoint\"),"},{"line_number":60,"context_line":"            loading.Opt(\u0027service-provider-entity-id\u0027,"},{"line_number":61,"context_line":"                        help\u003d\"Service Provider\u0027s SAML Entity ID\"),"},{"line_number":62,"context_line":"            loading.Opt(\u0027username\u0027, help\u003d\u0027Username\u0027),"},{"line_number":63,"context_line":"            loading.Opt(\u0027password\u0027, secret\u003dTrue, help\u003d\u0027Password\u0027)"},{"line_number":64,"context_line":"        ])"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f044301_ec159b9d","line":61,"updated":"2017-05-10 01:38:03.000000000","message":"so adding this to options here will make this available as --os-service-provider-entity-id or in clouds.yaml. \n\nIs this the intent? It seems a fairly unusual thing for a user to set. I hoped ADFS was a bit more standard than this.","commit_id":"644fc79f0a44b087644c0460d158f38cef8ba7e3"},{"author":{"_account_id":25942,"name":"Blake Covarrubias","email":"blake@platform9.com","username":"blakegc"},"change_message_id":"a030b73c9216bb03e9db42ef73f6375d50dcbd28","unresolved":false,"context_lines":[{"line_number":58,"context_line":"            loading.Opt(\u0027service-provider-endpoint\u0027,"},{"line_number":59,"context_line":"                        help\u003d\"Service Provider\u0027s Endpoint\"),"},{"line_number":60,"context_line":"            loading.Opt(\u0027service-provider-entity-id\u0027,"},{"line_number":61,"context_line":"                        help\u003d\"Service Provider\u0027s SAML Entity ID\"),"},{"line_number":62,"context_line":"            loading.Opt(\u0027username\u0027, help\u003d\u0027Username\u0027),"},{"line_number":63,"context_line":"            loading.Opt(\u0027password\u0027, secret\u003dTrue, help\u003d\u0027Password\u0027)"},{"line_number":64,"context_line":"        ])"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f044301_6f6bbdb6","line":61,"in_reply_to":"3f044301_ec159b9d","updated":"2017-05-10 02:28:35.000000000","message":"Yes, this is the intent. An entity ID may not necessarily match the endpoint location so this parameter should be configurable.\n\nhttps://wiki.shibboleth.net/confluence/display/CONCEPT/EntityNaming\nhttps://spaces.internet2.edu/display/InCFederation/Entity+IDs","commit_id":"644fc79f0a44b087644c0460d158f38cef8ba7e3"}],"keystoneauth1/extras/_saml2/v3/adfs.py":[{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"bff3bbc33fb75d8fb684eea78ecd2311f5bff520","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            username\u003dusername, password\u003dpassword, protocol\u003dprotocol)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        self.service_provider_endpoint \u003d service_provider_endpoint"},{"line_number":88,"context_line":"        self.service_provider_entity_id \u003d service_provider_entity_id or \\"},{"line_number":89,"context_line":"            service_provider_endpoint"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def _cookies(self, session):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f013ff3_92b2e5e5","line":88,"range":{"start_line":88,"start_character":72,"end_line":88,"end_character":73},"updated":"2017-05-16 17:20:22.000000000","message":"It isn\u0027t in our code patterns to break the code like this. We prefer using ()","commit_id":"6b3fd6ec0806c18a737fb0167df6d548b3e96709"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"bff3bbc33fb75d8fb684eea78ecd2311f5bff520","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        self.service_provider_endpoint \u003d service_provider_endpoint"},{"line_number":88,"context_line":"        self.service_provider_entity_id \u003d service_provider_entity_id or \\"},{"line_number":89,"context_line":"            service_provider_endpoint"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def _cookies(self, session):"},{"line_number":92,"context_line":"        \"\"\"Check if cookie jar is not empty."}],"source_content_type":"text/x-python","patch_set":3,"id":"1f013ff3_52cc5d69","line":89,"updated":"2017-05-16 17:20:22.000000000","message":"also why are we setting self.service_provider_entity_id with service_provider_endpoint ? by it\u0027s name it should be an ID. we should do the OR check at line 263","commit_id":"6b3fd6ec0806c18a737fb0167df6d548b3e96709"}],"keystoneauth1/tests/unit/extras/saml2/test_auth_adfs.py":[{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"bff3bbc33fb75d8fb684eea78ecd2311f5bff520","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        self.adfsplugin \u003d saml2.V3ADFSPassword("},{"line_number":126,"context_line":"            self.TEST_URL, self.IDENTITY_PROVIDER,"},{"line_number":127,"context_line":"            self.IDENTITY_PROVIDER_URL, self.SP_ENDPOINT,"},{"line_number":128,"context_line":"            self.TEST_USER, self.TEST_TOKEN, self.PROTOCOL, self.SP_ENTITYID)"},{"line_number":129,"context_line":"        self.adfsplugin._prepare_adfs_request()"},{"line_number":130,"context_line":"        address \u003d self.adfsplugin.prepared_request.xpath("},{"line_number":131,"context_line":"            self.ADDRESS_XPATH, namespaces\u003dself.NAMESPACES)[0]"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f013ff3_729cf95c","line":128,"updated":"2017-05-16 17:20:22.000000000","message":"(nit) making params named would increase readability and we would be sure everything is in its correct place\n\n    service_provider_entity_id\u003dself.SP_ENTITYID","commit_id":"6b3fd6ec0806c18a737fb0167df6d548b3e96709"}],"releasenotes/notes/bug-1689424-set-adfspassword-endpointreference-f186d84a54007b09.yaml":[{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"fdc9c0f8dfa9eac4c2270ca44aea13a9e84cb7f4","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  - \u003e"},{"line_number":6,"context_line":"    Add the ability to specify the WS-Policy EndpointReference used in the"},{"line_number":7,"context_line":"    ADFSPassword plugin\u0027s RequestSecurityToken message via the"},{"line_number":8,"context_line":"    \u0027service-provider-entity-id\u0027 option."},{"line_number":9,"context_line":"fixes:"},{"line_number":10,"context_line":"  - \u003e"},{"line_number":11,"context_line":"    [`bug 1689424 \u003chttps://bugs.launchpad.net/keystoneauth/+bug/1689424\u003e`_]"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1f013ff3_14893c22","line":8,"updated":"2017-05-16 01:20:04.000000000","message":"you also added identity-provider-url as an option that can be specified, please add that info here too","commit_id":"644fc79f0a44b087644c0460d158f38cef8ba7e3"},{"author":{"_account_id":25942,"name":"Blake Covarrubias","email":"blake@platform9.com","username":"blakegc"},"change_message_id":"a017524367b511e6c70e2eb8c34ece87f6fe576e","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  - \u003e"},{"line_number":6,"context_line":"    Add the ability to specify the WS-Policy EndpointReference used in the"},{"line_number":7,"context_line":"    ADFSPassword plugin\u0027s RequestSecurityToken message via the"},{"line_number":8,"context_line":"    \u0027service-provider-entity-id\u0027 option."},{"line_number":9,"context_line":"fixes:"},{"line_number":10,"context_line":"  - \u003e"},{"line_number":11,"context_line":"    [`bug 1689424 \u003chttps://bugs.launchpad.net/keystoneauth/+bug/1689424\u003e`_]"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1f013ff3_f48810c7","line":8,"in_reply_to":"1f013ff3_14893c22","updated":"2017-05-16 01:36:47.000000000","message":"This option has existed since 34993d332cc5, but was not correctly documented in _saml2/_loading.py.\n\nAre you requesting I update the release notes to state that I\u0027ve added the help text for this required option?","commit_id":"644fc79f0a44b087644c0460d158f38cef8ba7e3"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"84345134285ab7fe93cda0acd33528b259b206bb","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  - \u003e"},{"line_number":6,"context_line":"    Add the ability to specify the WS-Policy EndpointReference used in the"},{"line_number":7,"context_line":"    ADFSPassword plugin\u0027s RequestSecurityToken message via the"},{"line_number":8,"context_line":"    \u0027service-provider-entity-id\u0027 option."},{"line_number":9,"context_line":"fixes:"},{"line_number":10,"context_line":"  - \u003e"},{"line_number":11,"context_line":"    [`bug 1689424 \u003chttps://bugs.launchpad.net/keystoneauth/+bug/1689424\u003e`_]"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1f013ff3_331fa56d","line":8,"in_reply_to":"1f013ff3_f48810c7","updated":"2017-05-16 10:14:36.000000000","message":"So you exposed that option to be used in the CLI, correct? Isn\u0027t that what your code in _saml2/_loading.py does with adding:\n\n    loading.Opt(\u0027identity-provider-url\u0027, ...)\n\nThat options was not exposed to the CLI before, but now it is, users need to know it","commit_id":"644fc79f0a44b087644c0460d158f38cef8ba7e3"}]}