)]}'
{"keystoneauth1/identity/v3/token.py":[{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"ae99df9cd92b55098ab37760a8b2644c9ae769e1","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    \"\"\""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    _auth_method_class \u003d TokenMethod"},{"line_number":52,"context_line":"    token \u003d None"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def __init__(self, auth_url, token, **kwargs):"},{"line_number":55,"context_line":"        super(Token, self).__init__(auth_url, token\u003dtoken, **kwargs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f013ff3_9cec412a","line":52,"updated":"2017-05-16 14:28:30.000000000","message":"this line is unnecessary","commit_id":"52fb017d29e972559a9c43c878357ee06ecd6235"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"ae99df9cd92b55098ab37760a8b2644c9ae769e1","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        super(Token, self).__init__(auth_url, token\u003dtoken, **kwargs)"},{"line_number":56,"context_line":"        self.token \u003d token"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def get_token(self, session, **kwargs):"},{"line_number":59,"context_line":"        return self.token"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f013ff3_07369ee7","line":58,"updated":"2017-05-16 14:28:30.000000000","message":"I think we should be overriding get_auth_ref to lookup the current token instead of request a new one. Then we would no longer need to override get_token (it would just work as-is, since it depends on get_auth_ref). And the auth_ref would be correct for other things (which it isn\u0027t yet with this change).","commit_id":"52fb017d29e972559a9c43c878357ee06ecd6235"},{"author":{"_account_id":13637,"name":"Divya K Konoor","email":"dikonoor@in.ibm.com","username":"dikonoor"},"change_message_id":"646a71969167b0992d64a239bd704aa4f9a52d7e","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        super(Token, self).__init__(auth_url, token\u003dtoken, **kwargs)"},{"line_number":56,"context_line":"        self.token \u003d token"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def get_token(self, session, **kwargs):"},{"line_number":59,"context_line":"        return self.token"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff0f0b1f_6c84eab1","line":58,"in_reply_to":"1f013ff3_07369ee7","updated":"2017-05-22 08:37:24.000000000","message":"In the flow we are referring to, get_token calls get_access() which calls get_auth_ref. get_auth_ref function (currently) requests for a new token and created an AccessInfoV3 object with token and response body and returns it. If we override get_auth_ref , we will be able to create an AccessInfoV3 object with only token (because we have no response body). Any references that looks for some data from the response body will fail. For eg. these:\n\nhttps://github.com/openstack/keystoneauth/blob/stable/ocata/keystoneauth1/access/access.py#L597\nhttps://github.com/openstack/keystoneauth/blob/stable/ocata/keystoneauth1/access/access.py#L609\n\nSo, I am not completely convinced that overriding get_auth_ref is the best option.","commit_id":"52fb017d29e972559a9c43c878357ee06ecd6235"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"2276a281699479e63c0b06653da46a774a09b15d","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        super(Token, self).__init__(auth_url, token\u003dtoken, **kwargs)"},{"line_number":56,"context_line":"        self.token \u003d token"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def get_token(self, session, **kwargs):"},{"line_number":59,"context_line":"        return self.token"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f201791_a4868712","line":58,"in_reply_to":"ff0f0b1f_607e1bb0","updated":"2017-06-25 23:34:42.000000000","message":"Yea, so the problem is that when you just give us a token we don\u0027t have any way of knowing this like the service catalog. It would be reasonable to fetch that information from keystone - however particularly as scope information is generally passed it\u0027s simply been easier to rescope the token than to fetch the existing and check if it matches. \n\nI don\u0027t mind a plugin that fetches the existing data, but i don\u0027t see that it should be merged with this one.","commit_id":"52fb017d29e972559a9c43c878357ee06ecd6235"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"b51fdc5c164451ab6c5fbd7c3a5df36377620efa","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        super(Token, self).__init__(auth_url, token\u003dtoken, **kwargs)"},{"line_number":56,"context_line":"        self.token \u003d token"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def get_token(self, session, **kwargs):"},{"line_number":59,"context_line":"        return self.token"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff0f0b1f_607e1bb0","line":58,"in_reply_to":"ff0f0b1f_6c84eab1","updated":"2017-05-22 17:33:22.000000000","message":"the override of get_auth_ref should make a call to keystone to read the token (the current token, not get a new one), so that you do have a response body.","commit_id":"52fb017d29e972559a9c43c878357ee06ecd6235"}],"keystoneauth1/tests/unit/identity/test_identity_v3.py":[{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"ae99df9cd92b55098ab37760a8b2644c9ae769e1","unresolved":false,"context_lines":[{"line_number":260,"context_line":"        self.assertEqual({\u0027X-Auth-Token\u0027: self.TEST_TOKEN},"},{"line_number":261,"context_line":"                         s.get_auth_headers())"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"        self.assertEqual(s.auth.get_token(session), self.TEST_TOKEN)"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"    def test_with_expired(self):"},{"line_number":266,"context_line":"        self.stub_auth(json\u003dself.TEST_RESPONSE_DICT)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f013ff3_1c3a7133","line":263,"updated":"2017-05-16 14:28:30.000000000","message":"This needs to continue to test auth_ref","commit_id":"52fb017d29e972559a9c43c878357ee06ecd6235"}]}