)]}'
{"keystoneauth1/adapter.py":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"c5afefdb1967ee194eecd4f132ae89a2d839f205","unresolved":false,"context_lines":[{"line_number":208,"context_line":"        \"\"\""},{"line_number":209,"context_line":"        # TODO(mordred) Plumb endpoint_override through discovery"},{"line_number":210,"context_line":"        # if self.endpoint_override:"},{"line_number":211,"context_line":"        #     return self.endpoint_override"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"        self._set_endpoint_filter_kwargs(kwargs)"},{"line_number":214,"context_line":"        return self.session.get_endpoint_data(auth or self.auth, **kwargs)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f201791_b138193d","line":211,"updated":"2017-06-23 21:49:06.000000000","message":"while I\u0027m not sure why you would both set endpoint_override and call get_endpoint_data, wouldn\u0027t implementing this in the future be a breaking change?","commit_id":"076ef9bebd90718fbb376978c73d21edd93abe2a"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"c838cae3db9344874b079d896a0abab768bcf230","unresolved":false,"context_lines":[{"line_number":208,"context_line":"        \"\"\""},{"line_number":209,"context_line":"        # TODO(mordred) Plumb endpoint_override through discovery"},{"line_number":210,"context_line":"        # if self.endpoint_override:"},{"line_number":211,"context_line":"        #     return self.endpoint_override"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"        self._set_endpoint_filter_kwargs(kwargs)"},{"line_number":214,"context_line":"        return self.session.get_endpoint_data(auth or self.auth, **kwargs)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f201791_2c5f0c0f","line":211,"in_reply_to":"5f201791_b138193d","updated":"2017-06-23 22:03:31.000000000","message":"never mind, i found the next patch","commit_id":"076ef9bebd90718fbb376978c73d21edd93abe2a"}],"keystoneauth1/fixture/discovery.py":[{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"aa154577bd73b16690734fba76019ccdee36b39a","unresolved":false,"context_lines":[{"line_number":207,"context_line":"    def __init__(self, href, id, min_version\u003dNone, max_version\u003dNone,"},{"line_number":208,"context_line":"                 **kwargs):"},{"line_number":209,"context_line":"        super(MicroversionDiscovery, self).__init__(id, **kwargs)"},{"line_number":210,"context_line":"        self[\u0027max_version\u0027] \u003d max_version or \u0027\u0027"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"        self.add_link(href)"},{"line_number":213,"context_line":"        if not min_version and self[\u0027id\u0027].startswith(\u0027v\u0027):"}],"source_content_type":"text/x-python","patch_set":6,"id":"7f231b9d_db293d8a","line":210,"updated":"2017-06-15 19:16:22.000000000","message":"how is this different/better than self.max_version \u003d ... ?\n\nI guess we use more self.\u003cthing\u003e here\n\nsame for others in this file","commit_id":"076ef9bebd90718fbb376978c73d21edd93abe2a"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"8129bed7e79a8e6cdb0bf43f177dc3b27d272328","unresolved":false,"context_lines":[{"line_number":207,"context_line":"    def __init__(self, href, id, min_version\u003dNone, max_version\u003dNone,"},{"line_number":208,"context_line":"                 **kwargs):"},{"line_number":209,"context_line":"        super(MicroversionDiscovery, self).__init__(id, **kwargs)"},{"line_number":210,"context_line":"        self[\u0027max_version\u0027] \u003d max_version or \u0027\u0027"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"        self.add_link(href)"},{"line_number":213,"context_line":"        if not min_version and self[\u0027id\u0027].startswith(\u0027v\u0027):"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f201791_54ad2ae7","line":210,"in_reply_to":"7f231b9d_db293d8a","updated":"2017-06-24 18:49:18.000000000","message":"It\u0027s not.","commit_id":"076ef9bebd90718fbb376978c73d21edd93abe2a"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"c5afefdb1967ee194eecd4f132ae89a2d839f205","unresolved":false,"context_lines":[{"line_number":237,"context_line":"        super(MicroversionDiscovery, self).__init__(id, **kwargs)"},{"line_number":238,"context_line":"        self[\u0027version\u0027] \u003d self[\u0027min_version\u0027]"},{"line_number":239,"context_line":"        del self[\u0027min_version\u0027]"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"class DiscoveryList(dict):"},{"line_number":243,"context_line":"    \"\"\"A List of version elements."}],"source_content_type":"text/x-python","patch_set":6,"id":"5f201791_b1edb98c","line":240,"updated":"2017-06-23 21:49:06.000000000","message":"The commit message is about adding get_endpoint_data to session and adapter but this is also adding microversion tests. I think that\u0027s fine but maybe just add that to the commit message?","commit_id":"076ef9bebd90718fbb376978c73d21edd93abe2a"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"8129bed7e79a8e6cdb0bf43f177dc3b27d272328","unresolved":false,"context_lines":[{"line_number":237,"context_line":"        super(MicroversionDiscovery, self).__init__(id, **kwargs)"},{"line_number":238,"context_line":"        self[\u0027version\u0027] \u003d self[\u0027min_version\u0027]"},{"line_number":239,"context_line":"        del self[\u0027min_version\u0027]"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"class DiscoveryList(dict):"},{"line_number":243,"context_line":"    \"\"\"A List of version elements."}],"source_content_type":"text/x-python","patch_set":6,"id":"5f201791_14b3324f","line":240,"in_reply_to":"5f201791_b1edb98c","updated":"2017-06-24 18:49:18.000000000","message":"We\u0027ve also added this in the microversion patch now.","commit_id":"076ef9bebd90718fbb376978c73d21edd93abe2a"}],"keystoneauth1/tests/unit/identity/test_identity_common.py":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"c5afefdb1967ee194eecd4f132ae89a2d839f205","unresolved":false,"context_lines":[{"line_number":821,"context_line":""},{"line_number":822,"context_line":"    def test_get_endpoint_data_compute(self):"},{"line_number":823,"context_line":"        common_disc \u003d fixture.DiscoveryList(v2\u003dFalse, v3\u003dFalse)"},{"line_number":824,"context_line":"        common_disc.add_microversion(href\u003dself.OTHER_URL,"},{"line_number":825,"context_line":"                                     id\u003d\u0027v2.1\u0027, max_version\u003d\u00272.35\u0027)"},{"line_number":826,"context_line":""},{"line_number":827,"context_line":"        common_m \u003d self.stub_url(\u0027GET\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f201791_7184c1b1","line":824,"range":{"start_line":824,"start_character":20,"end_line":824,"end_character":36},"updated":"2017-06-23 21:49:06.000000000","message":"Did you mean to have add_nova_microversion here?","commit_id":"076ef9bebd90718fbb376978c73d21edd93abe2a"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"8129bed7e79a8e6cdb0bf43f177dc3b27d272328","unresolved":false,"context_lines":[{"line_number":821,"context_line":""},{"line_number":822,"context_line":"    def test_get_endpoint_data_compute(self):"},{"line_number":823,"context_line":"        common_disc \u003d fixture.DiscoveryList(v2\u003dFalse, v3\u003dFalse)"},{"line_number":824,"context_line":"        common_disc.add_microversion(href\u003dself.OTHER_URL,"},{"line_number":825,"context_line":"                                     id\u003d\u0027v2.1\u0027, max_version\u003d\u00272.35\u0027)"},{"line_number":826,"context_line":""},{"line_number":827,"context_line":"        common_m \u003d self.stub_url(\u0027GET\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f201791_74b02644","line":824,"range":{"start_line":824,"start_character":20,"end_line":824,"end_character":36},"in_reply_to":"5f201791_7184c1b1","updated":"2017-06-24 18:49:18.000000000","message":"Done","commit_id":"076ef9bebd90718fbb376978c73d21edd93abe2a"}]}