)]}'
{"keystoneauth1/identity/base.py":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"54f091cfd4f01e961e43175dbc2e49c5c0439fd8","unresolved":false,"context_lines":[{"line_number":291,"context_line":"                     region_name\u003dNone, service_name\u003dNone, version\u003dNone,"},{"line_number":292,"context_line":"                     min_version\u003dNone, max_version\u003dNone,"},{"line_number":293,"context_line":"                     allow\u003d{}, allow_version_hack\u003dTrue,"},{"line_number":294,"context_line":"                     discover_versions\u003dFalse, skip_discovery\u003dFalse, **kwargs):"},{"line_number":295,"context_line":"        \"\"\"Return a valid endpoint for a service."},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"        If a valid token is not present then a new one will be fetched using"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f201791_8cdbc0eb","side":"PARENT","line":294,"range":{"start_line":294,"start_character":21,"end_line":294,"end_character":46},"updated":"2017-06-23 23:01:40.000000000","message":"Wouldn\u0027t it be better to just not add this in the first place instead of removing it here?","commit_id":"db8c6d535b371f8c8f20369bb42b845b7425f801"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"613bd2c97946d89ee636b761f5a95c54f71752b2","unresolved":false,"context_lines":[{"line_number":291,"context_line":"                     region_name\u003dNone, service_name\u003dNone, version\u003dNone,"},{"line_number":292,"context_line":"                     min_version\u003dNone, max_version\u003dNone,"},{"line_number":293,"context_line":"                     allow\u003d{}, allow_version_hack\u003dTrue,"},{"line_number":294,"context_line":"                     discover_versions\u003dFalse, skip_discovery\u003dFalse, **kwargs):"},{"line_number":295,"context_line":"        \"\"\"Return a valid endpoint for a service."},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"        If a valid token is not present then a new one will be fetched using"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f201791_19024b0c","side":"PARENT","line":294,"range":{"start_line":294,"start_character":21,"end_line":294,"end_character":46},"in_reply_to":"5f201791_8cdbc0eb","updated":"2017-06-24 18:26:47.000000000","message":"Yes. Yes it would. HOWEVER - I\u0027m going to ask y\u0027all for a pass on this one - I just tried to do the rebase to fix that and it\u0027s SUPER hard (basically the problem is that adding get_endpoint_data to session should have been done much earlier in the stack - without it, testing some things wasn\u0027t possible. But moving the add-get-endpoint-data to where it should be in the stack completely borks all of the tests.\n\nI\u0027ll rework the stack if I have to - but maybe we can not land any of it until we\u0027re ready to land this one then land the whole kit at once?","commit_id":"db8c6d535b371f8c8f20369bb42b845b7425f801"}]}