)]}'
{"doc/source/using-sessions.rst":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"3987942b3c8b8b6ca39786b7570b186beb9d9d6e","unresolved":false,"context_lines":[{"line_number":104,"context_line":"Major Version Discovery and Microversion Support"},{"line_number":105,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"The topic of major API versions and microversions can be confusion, especially"},{"line_number":108,"context_line":"as one starts to use `keystoneauth` for version discovery."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"Conceptually the most important thing to understand is that Major API Versions"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f1d235d_e02a4b2a","line":107,"range":{"start_line":107,"start_character":57,"end_line":107,"end_character":66},"updated":"2017-07-11 21:32:47.000000000","message":"agree but I think you meant confusing","commit_id":"ad7ea52f78f8a70730d75c5d2ed7a694749214fd"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"d5c16a69ad04f14448ae9fb4c03414c3fac72f90","unresolved":false,"context_lines":[{"line_number":104,"context_line":"Major Version Discovery and Microversion Support"},{"line_number":105,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"The topic of major API versions and microversions can be confusion, especially"},{"line_number":108,"context_line":"as one starts to use `keystoneauth` for version discovery."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"Conceptually the most important thing to understand is that Major API Versions"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f1d235d_a0e1f3fe","line":107,"updated":"2017-07-11 21:45:33.000000000","message":"confusing","commit_id":"ad7ea52f78f8a70730d75c5d2ed7a694749214fd"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"94b00f56d8f5864b05b849d722c662583a84c5a5","unresolved":false,"context_lines":[{"line_number":104,"context_line":"Major Version Discovery and Microversion Support"},{"line_number":105,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"The topic of major API versions and microversions can be confusion, especially"},{"line_number":108,"context_line":"as one starts to use `keystoneauth` for version discovery."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"Conceptually the most important thing to understand is that Major API Versions"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f1d235d_1ba5b804","line":107,"in_reply_to":"3f1d235d_a0e1f3fe","updated":"2017-07-11 22:05:28.000000000","message":"Done","commit_id":"ad7ea52f78f8a70730d75c5d2ed7a694749214fd"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"94b00f56d8f5864b05b849d722c662583a84c5a5","unresolved":false,"context_lines":[{"line_number":104,"context_line":"Major Version Discovery and Microversion Support"},{"line_number":105,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"The topic of major API versions and microversions can be confusion, especially"},{"line_number":108,"context_line":"as one starts to use `keystoneauth` for version discovery."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"Conceptually the most important thing to understand is that Major API Versions"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f1d235d_3b9e34b8","line":107,"range":{"start_line":107,"start_character":57,"end_line":107,"end_character":66},"in_reply_to":"3f1d235d_e02a4b2a","updated":"2017-07-11 22:05:28.000000000","message":"Done","commit_id":"ad7ea52f78f8a70730d75c5d2ed7a694749214fd"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"d5c16a69ad04f14448ae9fb4c03414c3fac72f90","unresolved":false,"context_lines":[{"line_number":105,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"The topic of major API versions and microversions can be confusion, especially"},{"line_number":108,"context_line":"as one starts to use `keystoneauth` for version discovery."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"Conceptually the most important thing to understand is that Major API Versions"},{"line_number":111,"context_line":"describe a discrete REST Endpoint, while microversions are properties of a"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f1d235d_60ebdbdb","line":108,"updated":"2017-07-11 21:45:33.000000000","message":"do you mean because you\u0027re using keystone auth now, it has become confusing, or: when you first start it is confusing","commit_id":"ad7ea52f78f8a70730d75c5d2ed7a694749214fd"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"d5c16a69ad04f14448ae9fb4c03414c3fac72f90","unresolved":false,"context_lines":[{"line_number":108,"context_line":"as one starts to use `keystoneauth` for version discovery."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"Conceptually the most important thing to understand is that Major API Versions"},{"line_number":111,"context_line":"describe a discrete REST Endpoint, while microversions are properties of a"},{"line_number":112,"context_line":"given Major API endpoint."},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"Requesting a Major API version is what a user does when they want to get the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f1d235d_e086cb13","line":111,"updated":"2017-07-11 21:45:33.000000000","message":"Is endpoint already defined elsewhere in this document, because if not you should define it. Is it the root of a service? The versioned root of a service? A URL within a service? ???\n\nI think you _might_ be better off talking in terms of URLs and their behaviors? Not sure.","commit_id":"ad7ea52f78f8a70730d75c5d2ed7a694749214fd"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"d5c16a69ad04f14448ae9fb4c03414c3fac72f90","unresolved":false,"context_lines":[{"line_number":122,"context_line":"endpoint may indicate that it has a minimum and maximum supported microversion."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"When a client makes REST calls to the Major API version\u0027s endpoint, the client"},{"line_number":125,"context_line":"can, optionally, on a call-by-call basis, include a header requesting that"},{"line_number":126,"context_line":"the individual call use the behavior defined by the given microversion. If a"},{"line_number":127,"context_line":"client does not request a specific microversion, the service will behave as if"},{"line_number":128,"context_line":"the minimum supported microversion was requested."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f1d235d_20096394","line":125,"updated":"2017-07-11 21:45:33.000000000","message":"s/call/request/ throughout\n\nWe\u0027ve tried (in api-wg) to avoid \u0027call\u0027 as it implies rpc and masks the request response resource semantics that are pretty important.","commit_id":"ad7ea52f78f8a70730d75c5d2ed7a694749214fd"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"94b00f56d8f5864b05b849d722c662583a84c5a5","unresolved":false,"context_lines":[{"line_number":122,"context_line":"endpoint may indicate that it has a minimum and maximum supported microversion."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"When a client makes REST calls to the Major API version\u0027s endpoint, the client"},{"line_number":125,"context_line":"can, optionally, on a call-by-call basis, include a header requesting that"},{"line_number":126,"context_line":"the individual call use the behavior defined by the given microversion. If a"},{"line_number":127,"context_line":"client does not request a specific microversion, the service will behave as if"},{"line_number":128,"context_line":"the minimum supported microversion was requested."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f1d235d_9b9e6861","line":125,"in_reply_to":"3f1d235d_20096394","updated":"2017-07-11 22:05:28.000000000","message":"Done","commit_id":"ad7ea52f78f8a70730d75c5d2ed7a694749214fd"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"d5c16a69ad04f14448ae9fb4c03414c3fac72f90","unresolved":false,"context_lines":[{"line_number":124,"context_line":"When a client makes REST calls to the Major API version\u0027s endpoint, the client"},{"line_number":125,"context_line":"can, optionally, on a call-by-call basis, include a header requesting that"},{"line_number":126,"context_line":"the individual call use the behavior defined by the given microversion. If a"},{"line_number":127,"context_line":"client does not request a specific microversion, the service will behave as if"},{"line_number":128,"context_line":"the minimum supported microversion was requested."},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"The overall transaction then has three parts:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f1d235d_202e03fa","line":127,"updated":"2017-07-11 21:45:33.000000000","message":"specified","commit_id":"ad7ea52f78f8a70730d75c5d2ed7a694749214fd"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"d5c16a69ad04f14448ae9fb4c03414c3fac72f90","unresolved":false,"context_lines":[{"line_number":131,"context_line":""},{"line_number":132,"context_line":"* What is the endpoint for a given Major API version of a given service?"},{"line_number":133,"context_line":"* What are the minimum and maximum microversions supported at that endpoint?"},{"line_number":134,"context_line":"* Which of those microversions, if any, does the user want for a given call?"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"`keystoneauth` provides facilities for discovering the endpoint for a given"},{"line_number":137,"context_line":"Major API of a given service, as well as reporting the available microversion"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f1d235d_6043dbb0","line":134,"updated":"2017-07-11 21:45:33.000000000","message":"To be explicit you might say \"Which one of that range of microversions, if any, ...\"","commit_id":"ad7ea52f78f8a70730d75c5d2ed7a694749214fd"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"94b00f56d8f5864b05b849d722c662583a84c5a5","unresolved":false,"context_lines":[{"line_number":131,"context_line":""},{"line_number":132,"context_line":"* What is the endpoint for a given Major API version of a given service?"},{"line_number":133,"context_line":"* What are the minimum and maximum microversions supported at that endpoint?"},{"line_number":134,"context_line":"* Which of those microversions, if any, does the user want for a given call?"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"`keystoneauth` provides facilities for discovering the endpoint for a given"},{"line_number":137,"context_line":"Major API of a given service, as well as reporting the available microversion"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f1d235d_db94e046","line":134,"in_reply_to":"3f1d235d_6043dbb0","updated":"2017-07-11 22:05:28.000000000","message":"Done","commit_id":"ad7ea52f78f8a70730d75c5d2ed7a694749214fd"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"d5c16a69ad04f14448ae9fb4c03414c3fac72f90","unresolved":false,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":"`keystoneauth` provides facilities for discovering the endpoint for a given"},{"line_number":137,"context_line":"Major API of a given service, as well as reporting the available microversion"},{"line_number":138,"context_line":"ranges that endpoint supports."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"Sessions for Client Developers"},{"line_number":141,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f1d235d_201723a6","line":138,"updated":"2017-07-11 21:45:33.000000000","message":"range\n\nsupports, if any \n\n(just to make the optionality doubly clear)","commit_id":"ad7ea52f78f8a70730d75c5d2ed7a694749214fd"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"eab021d8d84c03b78cf114035203d9ee8db5a65f","unresolved":false,"context_lines":[{"line_number":115,"context_line":"In OpenStack the root URLs of available services are distributed to the user"},{"line_number":116,"context_line":"in an object called the Service Catalog, which is part of the token they"},{"line_number":117,"context_line":"receive. Clients are expected to use the URLs from the Service Catalog rather"},{"line_number":118,"context_line":"than have them provided. The root URL of a given service is refered to as the"},{"line_number":119,"context_line":"`endpoint` of the service. The URL of a specific version of a service is"},{"line_number":120,"context_line":"referred to as a `versioned endpoint`. REST requests for a service are made"},{"line_number":121,"context_line":"against a given `versioned endpoint`."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f1d235d_9bf3089f","line":118,"range":{"start_line":118,"start_character":60,"end_line":118,"end_character":67},"updated":"2017-07-11 22:15:27.000000000","message":"referred","commit_id":"78501a871f1b7de5a857b7ecbf817e06938a6129"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"eab021d8d84c03b78cf114035203d9ee8db5a65f","unresolved":false,"context_lines":[{"line_number":127,"context_line":"of the distinction between the two."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"Conceptually the most important thing to understand is that a Major API Version"},{"line_number":130,"context_line":"describes the URL of a discrete versioned endpoint, while an given versioned"},{"line_number":131,"context_line":"endpoint might have properties that express that it supports a range of"},{"line_number":132,"context_line":"microversions."},{"line_number":133,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f1d235d_3b1754a6","line":130,"range":{"start_line":130,"start_character":58,"end_line":130,"end_character":60},"updated":"2017-07-11 22:15:27.000000000","message":"a","commit_id":"78501a871f1b7de5a857b7ecbf817e06938a6129"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"7d6c818bb5975868dbdd49554f3bf30b0aaeb7db","unresolved":false,"context_lines":[{"line_number":127,"context_line":"of the distinction between the two."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"Conceptually the most important thing to understand is that a Major API Version"},{"line_number":130,"context_line":"describes the URL of a discrete versioned endpoint, while an given versioned"},{"line_number":131,"context_line":"endpoint might have properties that express that it supports a range of"},{"line_number":132,"context_line":"microversions."},{"line_number":133,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"1f1a1f67_c2fc5c40","line":130,"updated":"2017-07-12 10:22:35.000000000","message":"You\u0027ve added in a typo here. A given, not an given.","commit_id":"1eb755555a14ebe74cd8a80d0203bbd39c3b669f"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"2875e2c06b45df12f69b0164e425f02cb32f66b4","unresolved":false,"context_lines":[{"line_number":127,"context_line":"of the distinction between the two."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"Conceptually the most important thing to understand is that a Major API Version"},{"line_number":130,"context_line":"describes the URL of a discrete versioned endpoint, while an given versioned"},{"line_number":131,"context_line":"endpoint might have properties that express that it supports a range of"},{"line_number":132,"context_line":"microversions."},{"line_number":133,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"1f1a1f67_9c5fe4e4","line":130,"in_reply_to":"1f1a1f67_c2fc5c40","updated":"2017-07-12 11:35:49.000000000","message":"Thanks! Fixed in followup patch (there\u0027s a stack on top of this one - avoiding rebase) https://review.openstack.org/482925","commit_id":"1eb755555a14ebe74cd8a80d0203bbd39c3b669f"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"1dcd2dac99371ccf53677f3973f0d96be6523e89","unresolved":false,"context_lines":[{"line_number":188,"context_line":"                           endpoint_filter\u003d{\u0027service_type\u0027: \u0027identity\u0027,"},{"line_number":189,"context_line":"                                            \u0027interface\u0027: \u0027admin\u0027,"},{"line_number":190,"context_line":"                                            \u0027region_name\u0027: \u0027myregion\u0027,"},{"line_number":191,"context_line":"                                            \u0027min_version\u0027: \u00272.0\u0027,"},{"line_number":192,"context_line":"                                            \u0027max_version\u0027: \u00273.4\u0027,"},{"line_number":193,"context_line":"                                            \u0027discover_versions\u0027: False})"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":".. note:: The min_version and max_version arguments in this example indicate"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1f1a1f67_b5187375","line":192,"range":{"start_line":191,"start_character":44,"end_line":192,"end_character":65},"updated":"2017-07-12 12:53:23.000000000","message":"I know that you didn\u0027t introduce this with this patch, but this is wrong. Min and max versions must have the same major version. So this should be either 2.0/2.4 or 3.0/3.4. I can fix this in a follow-up patch.","commit_id":"1eb755555a14ebe74cd8a80d0203bbd39c3b669f"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"77d0333381839d0235e316157fa2328cc2c11815","unresolved":false,"context_lines":[{"line_number":188,"context_line":"                           endpoint_filter\u003d{\u0027service_type\u0027: \u0027identity\u0027,"},{"line_number":189,"context_line":"                                            \u0027interface\u0027: \u0027admin\u0027,"},{"line_number":190,"context_line":"                                            \u0027region_name\u0027: \u0027myregion\u0027,"},{"line_number":191,"context_line":"                                            \u0027min_version\u0027: \u00272.0\u0027,"},{"line_number":192,"context_line":"                                            \u0027max_version\u0027: \u00273.4\u0027,"},{"line_number":193,"context_line":"                                            \u0027discover_versions\u0027: False})"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":".. note:: The min_version and max_version arguments in this example indicate"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1f1a1f67_b52ab38d","line":192,"range":{"start_line":191,"start_character":44,"end_line":192,"end_character":65},"in_reply_to":"1f1a1f67_b5187375","updated":"2017-07-12 13:13:29.000000000","message":"That was introduced here [1] which is still open if you want to comment there.\n\nBut we should talk further.  The code certainly allows these to span major versions.  And I\u0027m not sure why that would/should be disallowed.\n\n[1] https://review.openstack.org/#/c/477566/4..5/doc/source/using-sessions.rst@145","commit_id":"1eb755555a14ebe74cd8a80d0203bbd39c3b669f"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"35dd029459a4e679f04ed838494d6d0976a1e949","unresolved":false,"context_lines":[{"line_number":188,"context_line":"                           endpoint_filter\u003d{\u0027service_type\u0027: \u0027identity\u0027,"},{"line_number":189,"context_line":"                                            \u0027interface\u0027: \u0027admin\u0027,"},{"line_number":190,"context_line":"                                            \u0027region_name\u0027: \u0027myregion\u0027,"},{"line_number":191,"context_line":"                                            \u0027min_version\u0027: \u00272.0\u0027,"},{"line_number":192,"context_line":"                                            \u0027max_version\u0027: \u00273.4\u0027,"},{"line_number":193,"context_line":"                                            \u0027discover_versions\u0027: False})"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":".. note:: The min_version and max_version arguments in this example indicate"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1f1a1f67_e6064321","line":192,"range":{"start_line":191,"start_character":44,"end_line":192,"end_character":65},"in_reply_to":"1f1a1f67_b52ab38d","updated":"2017-07-12 14:32:14.000000000","message":"OK, after discussing on IRC, it was the naming that was confusing. This is supposed to span all available versions, major, minor, or micro.","commit_id":"1eb755555a14ebe74cd8a80d0203bbd39c3b669f"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"1dcd2dac99371ccf53677f3973f0d96be6523e89","unresolved":false,"context_lines":[{"line_number":230,"context_line":"  the maximum version of a given API, intended to be used as the upper bound of"},{"line_number":231,"context_line":"  a range with `min_version`. For example::"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"    \u0027min_version\u0027: \u00272.2\u0027,"},{"line_number":234,"context_line":"    \u0027max_version\u0027: \u00273.3\u0027"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"  will match ``2.2``, ``2.10``, ``3.0``, and ``3.3``, but not ``1.42``,"},{"line_number":237,"context_line":"  ``2.1``, or ``3.20``. Mutually exclusive with `version`."},{"line_number":238,"context_line":""},{"line_number":239,"context_line":".. note:: version, min_version and max_version are all in service of finding"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1f1a1f67_b546334f","line":236,"range":{"start_line":233,"start_character":3,"end_line":236,"end_character":51},"updated":"2017-07-12 12:53:23.000000000","message":"same comment here about mixing major versions.","commit_id":"1eb755555a14ebe74cd8a80d0203bbd39c3b669f"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"8c97d350499baf02a277eb72b5135f5286d50284","unresolved":false,"context_lines":[{"line_number":138,"context_line":"versioned endpoint of ``https://compute.example.com/v2``."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"As part of the version discovery process, a version discovery document is"},{"line_number":141,"context_line":"provided by the cloud for each major version of a given services, as well as"},{"line_number":142,"context_line":"a list of version discovery documents for the service. A given major API"},{"line_number":143,"context_line":"endpoint may indicate that it has a minimum and maximum supported microversion."},{"line_number":144,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"1f1a1f67_50a36d50","line":141,"range":{"start_line":141,"start_character":56,"end_line":141,"end_character":64},"updated":"2017-07-12 13:40:20.000000000","message":"service","commit_id":"d3ad9e8bebb82f17176ad7a0767e82a68fe13959"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"c6ec969cf8a8900908ec181d81bd1a3f62e02e37","unresolved":false,"context_lines":[{"line_number":138,"context_line":"versioned endpoint of ``https://compute.example.com/v2``."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"As part of the version discovery process, a version discovery document is"},{"line_number":141,"context_line":"provided by the cloud for each major version of a given services, as well as"},{"line_number":142,"context_line":"a list of version discovery documents for the service. A given major API"},{"line_number":143,"context_line":"endpoint may indicate that it has a minimum and maximum supported microversion."},{"line_number":144,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"1f1a1f67_2b04d614","line":141,"range":{"start_line":141,"start_character":56,"end_line":141,"end_character":64},"in_reply_to":"1f1a1f67_50a36d50","updated":"2017-07-13 14:38:41.000000000","message":"Done","commit_id":"d3ad9e8bebb82f17176ad7a0767e82a68fe13959"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"8c97d350499baf02a277eb72b5135f5286d50284","unresolved":false,"context_lines":[{"line_number":137,"context_line":"version 2 of the compute service from cloud.example.com and end up with a"},{"line_number":138,"context_line":"versioned endpoint of ``https://compute.example.com/v2``."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"As part of the version discovery process, a version discovery document is"},{"line_number":141,"context_line":"provided by the cloud for each major version of a given services, as well as"},{"line_number":142,"context_line":"a list of version discovery documents for the service. A given major API"},{"line_number":143,"context_line":"endpoint may indicate that it has a minimum and maximum supported microversion."},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"When a client makes REST requests to the Major API version\u0027s endpoint, the"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1f1a1f67_b062c115","line":142,"range":{"start_line":140,"start_character":42,"end_line":142,"end_character":54},"updated":"2017-07-12 13:40:20.000000000","message":"I don\u0027t get this.  What\u0027s the distinction between [a discovery document for each major version of a service] and [a list of discovery documents for a service]?  Are those overlapping-but-different sets?","commit_id":"d3ad9e8bebb82f17176ad7a0767e82a68fe13959"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"c6ec969cf8a8900908ec181d81bd1a3f62e02e37","unresolved":false,"context_lines":[{"line_number":137,"context_line":"version 2 of the compute service from cloud.example.com and end up with a"},{"line_number":138,"context_line":"versioned endpoint of ``https://compute.example.com/v2``."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"As part of the version discovery process, a version discovery document is"},{"line_number":141,"context_line":"provided by the cloud for each major version of a given services, as well as"},{"line_number":142,"context_line":"a list of version discovery documents for the service. A given major API"},{"line_number":143,"context_line":"endpoint may indicate that it has a minimum and maximum supported microversion."},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"When a client makes REST requests to the Major API version\u0027s endpoint, the"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1f1a1f67_4bff1201","line":142,"range":{"start_line":140,"start_character":42,"end_line":142,"end_character":54},"in_reply_to":"1f1a1f67_b062c115","updated":"2017-07-13 14:38:41.000000000","message":"Good point. Reworked.","commit_id":"d3ad9e8bebb82f17176ad7a0767e82a68fe13959"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"8c97d350499baf02a277eb72b5135f5286d50284","unresolved":false,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":"When a client makes REST requests to the Major API version\u0027s endpoint, the"},{"line_number":146,"context_line":"client can, optionally, on a request-by-request basis, include a header"},{"line_number":147,"context_line":"requesting that the individual request use the behavior defined by the given"},{"line_number":148,"context_line":"microversion. If a client does not request a microversion, the service will"},{"line_number":149,"context_line":"behave as if the minimum supported microversion was requested."},{"line_number":150,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"1f1a1f67_b04be185","line":147,"range":{"start_line":147,"start_character":0,"end_line":147,"end_character":10},"updated":"2017-07-12 13:40:20.000000000","message":"With all the other \u0027request\u0027ing going on here, maybe change this to \"specifying\" or similar.","commit_id":"d3ad9e8bebb82f17176ad7a0767e82a68fe13959"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"c6ec969cf8a8900908ec181d81bd1a3f62e02e37","unresolved":false,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":"When a client makes REST requests to the Major API version\u0027s endpoint, the"},{"line_number":146,"context_line":"client can, optionally, on a request-by-request basis, include a header"},{"line_number":147,"context_line":"requesting that the individual request use the behavior defined by the given"},{"line_number":148,"context_line":"microversion. If a client does not request a microversion, the service will"},{"line_number":149,"context_line":"behave as if the minimum supported microversion was requested."},{"line_number":150,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"1f1a1f67_ab0fc62c","line":147,"range":{"start_line":147,"start_character":0,"end_line":147,"end_character":10},"in_reply_to":"1f1a1f67_b04be185","updated":"2017-07-13 14:38:41.000000000","message":"Done","commit_id":"d3ad9e8bebb82f17176ad7a0767e82a68fe13959"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"8c97d350499baf02a277eb72b5135f5286d50284","unresolved":false,"context_lines":[{"line_number":146,"context_line":"client can, optionally, on a request-by-request basis, include a header"},{"line_number":147,"context_line":"requesting that the individual request use the behavior defined by the given"},{"line_number":148,"context_line":"microversion. If a client does not request a microversion, the service will"},{"line_number":149,"context_line":"behave as if the minimum supported microversion was requested."},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"The overall transaction then has three parts:"},{"line_number":152,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"1f1a1f67_9050e534","line":149,"range":{"start_line":149,"start_character":52,"end_line":149,"end_character":61},"updated":"2017-07-12 13:40:20.000000000","message":"ditto","commit_id":"d3ad9e8bebb82f17176ad7a0767e82a68fe13959"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"c6ec969cf8a8900908ec181d81bd1a3f62e02e37","unresolved":false,"context_lines":[{"line_number":146,"context_line":"client can, optionally, on a request-by-request basis, include a header"},{"line_number":147,"context_line":"requesting that the individual request use the behavior defined by the given"},{"line_number":148,"context_line":"microversion. If a client does not request a microversion, the service will"},{"line_number":149,"context_line":"behave as if the minimum supported microversion was requested."},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"The overall transaction then has three parts:"},{"line_number":152,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"1f1a1f67_6b19ae77","line":149,"range":{"start_line":149,"start_character":52,"end_line":149,"end_character":61},"in_reply_to":"1f1a1f67_9050e534","updated":"2017-07-13 14:38:41.000000000","message":"Done","commit_id":"d3ad9e8bebb82f17176ad7a0767e82a68fe13959"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"8c97d350499baf02a277eb72b5135f5286d50284","unresolved":false,"context_lines":[{"line_number":152,"context_line":""},{"line_number":153,"context_line":"* What is the endpoint for a given Major API version of a given service?"},{"line_number":154,"context_line":"* What are the minimum and maximum microversions supported at that endpoint?"},{"line_number":155,"context_line":"* Which one of that range of microversions, does the user want to use for a"},{"line_number":156,"context_line":"  given request?"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"`keystoneauth` provides facilities for discovering the endpoint for a given"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1f1a1f67_305fd142","line":155,"range":{"start_line":155,"start_character":42,"end_line":155,"end_character":43},"updated":"2017-07-12 13:40:20.000000000","message":"strike","commit_id":"d3ad9e8bebb82f17176ad7a0767e82a68fe13959"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"c6ec969cf8a8900908ec181d81bd1a3f62e02e37","unresolved":false,"context_lines":[{"line_number":152,"context_line":""},{"line_number":153,"context_line":"* What is the endpoint for a given Major API version of a given service?"},{"line_number":154,"context_line":"* What are the minimum and maximum microversions supported at that endpoint?"},{"line_number":155,"context_line":"* Which one of that range of microversions, does the user want to use for a"},{"line_number":156,"context_line":"  given request?"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"`keystoneauth` provides facilities for discovering the endpoint for a given"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1f1a1f67_2b529614","line":155,"range":{"start_line":155,"start_character":42,"end_line":155,"end_character":43},"in_reply_to":"1f1a1f67_305fd142","updated":"2017-07-13 14:38:41.000000000","message":"Done","commit_id":"d3ad9e8bebb82f17176ad7a0767e82a68fe13959"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"8c97d350499baf02a277eb72b5135f5286d50284","unresolved":false,"context_lines":[{"line_number":195,"context_line":".. note:: The min_version and max_version arguments in this example indicate"},{"line_number":196,"context_line":"          acceptable range for finding the endpoint for the given Major API"},{"line_number":197,"context_line":"          versions. They are in the endpoint_filter, they are not requesting"},{"line_number":198,"context_line":"          the call to /users be made at a specific microversion."},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"`endpoint_filter` accepts a number of arguments with which it can determine an"},{"line_number":201,"context_line":"endpoint url:"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1f1a1f67_4b0d0036","line":198,"range":{"start_line":198,"start_character":22,"end_line":198,"end_character":28},"updated":"2017-07-12 13:40:20.000000000","message":"(double) backtick this.","commit_id":"d3ad9e8bebb82f17176ad7a0767e82a68fe13959"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"c6ec969cf8a8900908ec181d81bd1a3f62e02e37","unresolved":false,"context_lines":[{"line_number":195,"context_line":".. note:: The min_version and max_version arguments in this example indicate"},{"line_number":196,"context_line":"          acceptable range for finding the endpoint for the given Major API"},{"line_number":197,"context_line":"          versions. They are in the endpoint_filter, they are not requesting"},{"line_number":198,"context_line":"          the call to /users be made at a specific microversion."},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"`endpoint_filter` accepts a number of arguments with which it can determine an"},{"line_number":201,"context_line":"endpoint url:"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1f1a1f67_eb5b7e2b","line":198,"range":{"start_line":198,"start_character":22,"end_line":198,"end_character":28},"in_reply_to":"1f1a1f67_4b0d0036","updated":"2017-07-13 14:38:41.000000000","message":"Done","commit_id":"d3ad9e8bebb82f17176ad7a0767e82a68fe13959"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"2121931bd44e21f0157275b0a398e8edc619dff9","unresolved":false,"context_lines":[{"line_number":115,"context_line":"In OpenStack the root URLs of available services are distributed to the user"},{"line_number":116,"context_line":"in an object called the Service Catalog, which is part of the token they"},{"line_number":117,"context_line":"receive. Clients are expected to use the URLs from the Service Catalog rather"},{"line_number":118,"context_line":"than have them provided. The root URL of a given service is refered to as the"},{"line_number":119,"context_line":"`endpoint` of the service. The URL of a specific version of a service is"},{"line_number":120,"context_line":"referred to as a `versioned endpoint`. REST requests for a service are made"},{"line_number":121,"context_line":"against a given `versioned endpoint`."}],"source_content_type":"text/x-rst","patch_set":6,"id":"1f1a1f67_9028aa34","line":118,"range":{"start_line":118,"start_character":60,"end_line":118,"end_character":67},"updated":"2017-07-13 20:29:56.000000000","message":"referred","commit_id":"599156751049b8ff8d3fc43b587c2231594b7e85"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"9711bb1efb13902a2da85526f2c3bff845940959","unresolved":false,"context_lines":[{"line_number":115,"context_line":"In OpenStack the root URLs of available services are distributed to the user"},{"line_number":116,"context_line":"in an object called the Service Catalog, which is part of the token they"},{"line_number":117,"context_line":"receive. Clients are expected to use the URLs from the Service Catalog rather"},{"line_number":118,"context_line":"than have them provided. The root URL of a given service is refered to as the"},{"line_number":119,"context_line":"`endpoint` of the service. The URL of a specific version of a service is"},{"line_number":120,"context_line":"referred to as a `versioned endpoint`. REST requests for a service are made"},{"line_number":121,"context_line":"against a given `versioned endpoint`."}],"source_content_type":"text/x-rst","patch_set":6,"id":"1f1a1f67_dea850dc","line":118,"range":{"start_line":118,"start_character":60,"end_line":118,"end_character":67},"in_reply_to":"1f1a1f67_9028aa34","updated":"2017-07-14 17:43:21.000000000","message":"Done","commit_id":"599156751049b8ff8d3fc43b587c2231594b7e85"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"babd8d6bad1dd0d3fd5dd7bf8c0b0d90051427df","unresolved":false,"context_lines":[{"line_number":137,"context_line":"version 2 of the compute service from cloud.example.com and end up with a"},{"line_number":138,"context_line":"versioned endpoint of ``https://compute.example.com/v2``."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"Each service provides a version document at the root of each versioned"},{"line_number":141,"context_line":"endpoint that contains information about that versioned endpoint. Each service"},{"line_number":142,"context_line":"also provides a document at the root of the unversioned endpoint that contains"},{"line_number":143,"context_line":"a list of the version documents for all of the available versioned endpoints."}],"source_content_type":"text/x-rst","patch_set":6,"id":"1f1a1f67_9c0a0e24","line":140,"range":{"start_line":140,"start_character":24,"end_line":140,"end_character":40},"updated":"2017-07-13 16:06:49.000000000","message":"\"version-discovery\" maybe. this doesn\u0027t read super well.","commit_id":"599156751049b8ff8d3fc43b587c2231594b7e85"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"2121931bd44e21f0157275b0a398e8edc619dff9","unresolved":false,"context_lines":[{"line_number":137,"context_line":"version 2 of the compute service from cloud.example.com and end up with a"},{"line_number":138,"context_line":"versioned endpoint of ``https://compute.example.com/v2``."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"Each service provides a version document at the root of each versioned"},{"line_number":141,"context_line":"endpoint that contains information about that versioned endpoint. Each service"},{"line_number":142,"context_line":"also provides a document at the root of the unversioned endpoint that contains"},{"line_number":143,"context_line":"a list of the version documents for all of the available versioned endpoints."}],"source_content_type":"text/x-rst","patch_set":6,"id":"1f1a1f67_d02e2242","line":140,"range":{"start_line":140,"start_character":24,"end_line":140,"end_character":40},"in_reply_to":"1f1a1f67_9c0a0e24","updated":"2017-07-13 20:29:56.000000000","message":"\"discovery document\" is what\u0027s in the API-WG spec, should probably be consistent with that","commit_id":"599156751049b8ff8d3fc43b587c2231594b7e85"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"9711bb1efb13902a2da85526f2c3bff845940959","unresolved":false,"context_lines":[{"line_number":137,"context_line":"version 2 of the compute service from cloud.example.com and end up with a"},{"line_number":138,"context_line":"versioned endpoint of ``https://compute.example.com/v2``."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"Each service provides a version document at the root of each versioned"},{"line_number":141,"context_line":"endpoint that contains information about that versioned endpoint. Each service"},{"line_number":142,"context_line":"also provides a document at the root of the unversioned endpoint that contains"},{"line_number":143,"context_line":"a list of the version documents for all of the available versioned endpoints."}],"source_content_type":"text/x-rst","patch_set":6,"id":"1f1a1f67_9e93f8a3","line":140,"range":{"start_line":140,"start_character":24,"end_line":140,"end_character":40},"in_reply_to":"1f1a1f67_d02e2242","updated":"2017-07-14 17:43:21.000000000","message":"Done","commit_id":"599156751049b8ff8d3fc43b587c2231594b7e85"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"2121931bd44e21f0157275b0a398e8edc619dff9","unresolved":false,"context_lines":[{"line_number":140,"context_line":"Each service provides a version document at the root of each versioned"},{"line_number":141,"context_line":"endpoint that contains information about that versioned endpoint. Each service"},{"line_number":142,"context_line":"also provides a document at the root of the unversioned endpoint that contains"},{"line_number":143,"context_line":"a list of the version documents for all of the available versioned endpoints."},{"line_number":144,"context_line":"By examining these documents, it is possible to find the versioned endpoint"},{"line_number":145,"context_line":"that corresponds with the user\u0027s desired Major API version."},{"line_number":146,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"1f1a1f67_309e7654","line":143,"range":{"start_line":143,"start_character":14,"end_line":143,"end_character":31},"updated":"2017-07-13 20:29:56.000000000","message":"\"discovery documents\" would be better","commit_id":"599156751049b8ff8d3fc43b587c2231594b7e85"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"881bb7830c402093eb8a0206632c16ceadaec014","unresolved":false,"context_lines":[{"line_number":140,"context_line":"Each service provides a version document at the root of each versioned"},{"line_number":141,"context_line":"endpoint that contains information about that versioned endpoint. Each service"},{"line_number":142,"context_line":"also provides a document at the root of the unversioned endpoint that contains"},{"line_number":143,"context_line":"a list of the version documents for all of the available versioned endpoints."},{"line_number":144,"context_line":"By examining these documents, it is possible to find the versioned endpoint"},{"line_number":145,"context_line":"that corresponds with the user\u0027s desired Major API version."},{"line_number":146,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"1f1a1f67_d514d4a2","line":143,"updated":"2017-07-13 19:57:33.000000000","message":"Thank you, this is MUCH clearer.","commit_id":"599156751049b8ff8d3fc43b587c2231594b7e85"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"9711bb1efb13902a2da85526f2c3bff845940959","unresolved":false,"context_lines":[{"line_number":140,"context_line":"Each service provides a version document at the root of each versioned"},{"line_number":141,"context_line":"endpoint that contains information about that versioned endpoint. Each service"},{"line_number":142,"context_line":"also provides a document at the root of the unversioned endpoint that contains"},{"line_number":143,"context_line":"a list of the version documents for all of the available versioned endpoints."},{"line_number":144,"context_line":"By examining these documents, it is possible to find the versioned endpoint"},{"line_number":145,"context_line":"that corresponds with the user\u0027s desired Major API version."},{"line_number":146,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"1f1a1f67_5e8d6079","line":143,"range":{"start_line":143,"start_character":14,"end_line":143,"end_character":31},"in_reply_to":"1f1a1f67_309e7654","updated":"2017-07-14 17:43:21.000000000","message":"Done","commit_id":"599156751049b8ff8d3fc43b587c2231594b7e85"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"ad38d72cba5e19461c157f125fafd2a6b88cc748","unresolved":false,"context_lines":[{"line_number":160,"context_line":""},{"line_number":161,"context_line":"* What is the endpoint for a given Major API version of a given service?"},{"line_number":162,"context_line":"* What are the minimum and maximum microversions supported at that endpoint?"},{"line_number":163,"context_line":"* Which one of those microversions, if any, does the user want to use for a"},{"line_number":164,"context_line":"  given request?"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"`keystoneauth` provides facilities for discovering the endpoint for a given"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1f1a1f67_4479372d","line":163,"range":{"start_line":163,"start_character":44,"end_line":163,"end_character":69},"updated":"2017-07-13 20:59:58.000000000","message":"Perhaps add a note saying that the changes that each microversion reflects are documented elsewhere, so that it\u0027s clear that that is not part of this discovery process.","commit_id":"599156751049b8ff8d3fc43b587c2231594b7e85"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"9711bb1efb13902a2da85526f2c3bff845940959","unresolved":false,"context_lines":[{"line_number":160,"context_line":""},{"line_number":161,"context_line":"* What is the endpoint for a given Major API version of a given service?"},{"line_number":162,"context_line":"* What are the minimum and maximum microversions supported at that endpoint?"},{"line_number":163,"context_line":"* Which one of those microversions, if any, does the user want to use for a"},{"line_number":164,"context_line":"  given request?"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"`keystoneauth` provides facilities for discovering the endpoint for a given"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1f1a1f67_7e6edc95","line":163,"range":{"start_line":163,"start_character":44,"end_line":163,"end_character":69},"in_reply_to":"1f1a1f67_4479372d","updated":"2017-07-14 17:43:21.000000000","message":"Done","commit_id":"599156751049b8ff8d3fc43b587c2231594b7e85"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"cfeaef6e7d028facef5d422ee4d6f2e16da47cc3","unresolved":false,"context_lines":[{"line_number":161,"context_line":"* What is the endpoint for a given Major API version of a given service?"},{"line_number":162,"context_line":"* What are the minimum and maximum microversions supported at that endpoint?"},{"line_number":163,"context_line":"* Which one of those microversions, if any, does the user want to use for a"},{"line_number":164,"context_line":"  given request?"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"`keystoneauth` provides facilities for discovering the endpoint for a given"},{"line_number":167,"context_line":"Major API of a given service, as well as reporting the available microversion"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1f1a1f67_5c632843","line":164,"updated":"2017-07-14 20:08:19.000000000","message":"Same comment here as below. Looks like this comment was addressed then regressed.","commit_id":"599156751049b8ff8d3fc43b587c2231594b7e85"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"ad38d72cba5e19461c157f125fafd2a6b88cc748","unresolved":false,"context_lines":[{"line_number":244,"context_line":"  will match ``2.2``, ``2.10``, ``3.0``, and ``3.3``, but not ``1.42``,"},{"line_number":245,"context_line":"  ``2.1``, or ``3.20``. Mutually exclusive with `version`."},{"line_number":246,"context_line":""},{"line_number":247,"context_line":".. note:: version, min_version and max_version are all in service of finding"},{"line_number":248,"context_line":"          the endpoint for a given Major API version of a service."},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"discover_versions"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1f1a1f67_e4dde314","line":247,"range":{"start_line":247,"start_character":55,"end_line":247,"end_character":65},"updated":"2017-07-13 20:59:58.000000000","message":"Service overload!  :)\n\nHow about \"... are all used to help determine the endpoint...\"","commit_id":"599156751049b8ff8d3fc43b587c2231594b7e85"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"9711bb1efb13902a2da85526f2c3bff845940959","unresolved":false,"context_lines":[{"line_number":244,"context_line":"  will match ``2.2``, ``2.10``, ``3.0``, and ``3.3``, but not ``1.42``,"},{"line_number":245,"context_line":"  ``2.1``, or ``3.20``. Mutually exclusive with `version`."},{"line_number":246,"context_line":""},{"line_number":247,"context_line":".. note:: version, min_version and max_version are all in service of finding"},{"line_number":248,"context_line":"          the endpoint for a given Major API version of a service."},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"discover_versions"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1f1a1f67_9ef418d1","line":247,"range":{"start_line":247,"start_character":55,"end_line":247,"end_character":65},"in_reply_to":"1f1a1f67_e4dde314","updated":"2017-07-14 17:43:21.000000000","message":"Done","commit_id":"599156751049b8ff8d3fc43b587c2231594b7e85"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"ad38d72cba5e19461c157f125fafd2a6b88cc748","unresolved":false,"context_lines":[{"line_number":323,"context_line":"    response \u003d adapter.get(\u0027/volumes\u0027)"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"As with ``endpoint_filter`` on a Session, the ``version``, ``min_version``"},{"line_number":326,"context_line":"and ``max_version`` parameters exist in service of finding the appropriate"},{"line_number":327,"context_line":"endpoint for a Major API of a service."},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"Endpoint Metadata"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1f1a1f67_c409c795","line":326,"range":{"start_line":326,"start_character":37,"end_line":326,"end_character":47},"updated":"2017-07-13 20:59:58.000000000","message":"same comment as above re: overloading the word \"service\"","commit_id":"599156751049b8ff8d3fc43b587c2231594b7e85"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"9711bb1efb13902a2da85526f2c3bff845940959","unresolved":false,"context_lines":[{"line_number":323,"context_line":"    response \u003d adapter.get(\u0027/volumes\u0027)"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"As with ``endpoint_filter`` on a Session, the ``version``, ``min_version``"},{"line_number":326,"context_line":"and ``max_version`` parameters exist in service of finding the appropriate"},{"line_number":327,"context_line":"endpoint for a Major API of a service."},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"Endpoint Metadata"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1f1a1f67_de2bb02d","line":326,"range":{"start_line":326,"start_character":37,"end_line":326,"end_character":47},"in_reply_to":"1f1a1f67_c409c795","updated":"2017-07-14 17:43:21.000000000","message":"Done","commit_id":"599156751049b8ff8d3fc43b587c2231594b7e85"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"ae21617e829c982ddfe92f4d2aecb589ae91a079","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  Clients are not expected to have any knowledge of an identity token or any"},{"line_number":37,"context_line":"  other form of identification credential. Service, endpoint, major version"},{"line_number":38,"context_line":"  discovery and microversion support discovery are handled by the Session and"},{"line_number":39,"context_line":"  plugins. Discovery information is automatically cached in memory, so the user"},{"line_number":40,"context_line":"  need not worry about excessive use of discovery metadata."},{"line_number":41,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"1f1a1f67_bc9ebc51","line":38,"updated":"2017-07-14 19:13:46.000000000","message":"oxford comma?","commit_id":"fb4c2084050184f112e9a3c9cda349fdd73e0569"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"ae21617e829c982ddfe92f4d2aecb589ae91a079","unresolved":false,"context_lines":[{"line_number":245,"context_line":"  ``2.1``, or ``3.20``. Mutually exclusive with `version`."},{"line_number":246,"context_line":""},{"line_number":247,"context_line":".. note:: version, min_version and max_version are all in service of finding"},{"line_number":248,"context_line":"          the endpoint for a given Major API version of a service."},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"discover_versions"},{"line_number":251,"context_line":"  whether or not version discovery should be run, even if not strictly"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1f1a1f67_fc8674db","line":248,"updated":"2017-07-14 19:13:46.000000000","message":"Ed had some comments here from patch set 6. Looks like the comments were addressed and then removed again?","commit_id":"fb4c2084050184f112e9a3c9cda349fdd73e0569"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"ae21617e829c982ddfe92f4d2aecb589ae91a079","unresolved":false,"context_lines":[{"line_number":324,"context_line":""},{"line_number":325,"context_line":"As with ``endpoint_filter`` on a Session, the ``version``, ``min_version``"},{"line_number":326,"context_line":"and ``max_version`` parameters exist in service of finding the appropriate"},{"line_number":327,"context_line":"endpoint for a Major API of a service."},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"Endpoint Metadata"},{"line_number":330,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1f1a1f67_dc6df832","line":327,"updated":"2017-07-14 19:13:46.000000000","message":"Same comment here.","commit_id":"fb4c2084050184f112e9a3c9cda349fdd73e0569"}]}