)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"b59ec9b5ab1e914bd728713cd1c21ec93e832127","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove kwargs from adapter.get_endpoint_data"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"get_endpoint_data on an adapater is intended to return the endpoint_data"},{"line_number":10,"context_line":"for the endpoint the adapter is mounted to, so passing in additional"},{"line_number":11,"context_line":"kwargs doesn\u0027t make any sense. What\u0027s more, the interaction between the"},{"line_number":12,"context_line":"existing values and the passed in values is hard to reason about."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1f1a1f67_8b8e782c","line":9,"range":{"start_line":9,"start_character":24,"end_line":9,"end_character":32},"updated":"2017-07-12 13:55:14.000000000","message":"Adapter","commit_id":"a85bc2973f42703ec096ff44a5817fef0a6a2ba0"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"b15555b39d329a4444754ca6e60ba91b5cd7e891","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove kwargs from adapter.get_endpoint_data"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"get_endpoint_data on an adapater is intended to return the endpoint_data"},{"line_number":10,"context_line":"for the endpoint the adapter is mounted to, so passing in additional"},{"line_number":11,"context_line":"kwargs doesn\u0027t make any sense. What\u0027s more, the interaction between the"},{"line_number":12,"context_line":"existing values and the passed in values is hard to reason about."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1f1a1f67_9e909850","line":9,"range":{"start_line":9,"start_character":24,"end_line":9,"end_character":32},"in_reply_to":"1f1a1f67_8b8e782c","updated":"2017-07-14 17:45:57.000000000","message":"Done","commit_id":"a85bc2973f42703ec096ff44a5817fef0a6a2ba0"}],"doc/source/using-sessions.rst":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"b59ec9b5ab1e914bd728713cd1c21ec93e832127","unresolved":false,"context_lines":[{"line_number":331,"context_line":"On the :class:`keystoneauth1.adapter.Adapter` it does not take arguments, as"},{"line_number":332,"context_line":"it returns the information for the Endpoint the Adapter is mounted on."},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"``get_endpoint_data`` returns an :class:`keystoneauth1.discovery.EndpointData`"},{"line_number":335,"context_line":"object. This object can be used to find information about the Endpoint,"},{"line_number":336,"context_line":"including which major `api_version` was found, or which `interface` in case"},{"line_number":337,"context_line":"of ranges, lists of input values or ``latest`` version."}],"source_content_type":"text/x-rst","patch_set":3,"id":"1f1a1f67_4b9d0058","line":334,"range":{"start_line":334,"start_character":30,"end_line":334,"end_character":32},"updated":"2017-07-12 13:55:14.000000000","message":"Still think this should be `a`.","commit_id":"a85bc2973f42703ec096ff44a5817fef0a6a2ba0"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"b15555b39d329a4444754ca6e60ba91b5cd7e891","unresolved":false,"context_lines":[{"line_number":331,"context_line":"On the :class:`keystoneauth1.adapter.Adapter` it does not take arguments, as"},{"line_number":332,"context_line":"it returns the information for the Endpoint the Adapter is mounted on."},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"``get_endpoint_data`` returns an :class:`keystoneauth1.discovery.EndpointData`"},{"line_number":335,"context_line":"object. This object can be used to find information about the Endpoint,"},{"line_number":336,"context_line":"including which major `api_version` was found, or which `interface` in case"},{"line_number":337,"context_line":"of ranges, lists of input values or ``latest`` version."}],"source_content_type":"text/x-rst","patch_set":3,"id":"1f1a1f67_5ec5605a","line":334,"range":{"start_line":334,"start_character":30,"end_line":334,"end_character":32},"in_reply_to":"1f1a1f67_4b9d0058","updated":"2017-07-14 17:45:57.000000000","message":"Done","commit_id":"a85bc2973f42703ec096ff44a5817fef0a6a2ba0"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"662e3e90c3dac245d6a6830dcb4fe7c33feebe70","unresolved":false,"context_lines":[{"line_number":344,"context_line":"including which major `api_version` was found, or which `interface` in case"},{"line_number":345,"context_line":"of ranges, lists of input values or ``latest`` version."},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"It can also be used to determine the `min_microversion` and `max_microversion`"},{"line_number":348,"context_line":"supported by the API. If an API does not support microversions, the values for"},{"line_number":349,"context_line":"both will be ``None``."},{"line_number":350,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"1f1a1f67_5761c3a8","line":347,"updated":"2017-07-14 19:33:43.000000000","message":"There are a lot of instances here were we are italicizing things. The `min_microversion` and `max_microversion` bits here seem like they are support to be literals, but those literals don\u0027t actually exist (they are ``min_version`` and ``max_version``). I\u0027m not sure if that\u0027s what we were going for here or not.","commit_id":"89eb6718752bd458e14c6defe61e50cec713bf13"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"9789f29bc1fa65bc5f219d6e834772d77d5635ef","unresolved":false,"context_lines":[{"line_number":349,"context_line":""},{"line_number":350,"context_line":"It can also be used to determine the `min_microversion` and `max_microversion`"},{"line_number":351,"context_line":"supported by the API. If an API does not support microversions, the values for"},{"line_number":352,"context_line":"both will be ``None``."},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"``get_endpoint_data`` makes use of the same cache as the rest of the discovery"},{"line_number":355,"context_line":"process, so calling it should incur no undue expense. By default it will make"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1f1a1f67_378e472e","line":352,"updated":"2017-07-14 19:37:37.000000000","message":"I had a comment here on patch set 6 that didn\u0027t get published before patch set 7 came through.","commit_id":"32afa6799f54f40f712edd8aa191af5119a3d233"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"6ecf5f60cff0baf90788dd3b3484922628915eaf","unresolved":false,"context_lines":[{"line_number":349,"context_line":""},{"line_number":350,"context_line":"It can also be used to determine the `min_microversion` and `max_microversion`"},{"line_number":351,"context_line":"supported by the API. If an API does not support microversions, the values for"},{"line_number":352,"context_line":"both will be ``None``."},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"``get_endpoint_data`` makes use of the same cache as the rest of the discovery"},{"line_number":355,"context_line":"process, so calling it should incur no undue expense. By default it will make"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1f1a1f67_f770cfde","line":352,"in_reply_to":"1f1a1f67_378e472e","updated":"2017-07-14 19:49:23.000000000","message":"I still have a comment here about the literals versus italics, but that can be addressed in a follow-on patch.","commit_id":"32afa6799f54f40f712edd8aa191af5119a3d233"}],"keystoneauth1/adapter.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"9789f29bc1fa65bc5f219d6e834772d77d5635ef","unresolved":false,"context_lines":[{"line_number":230,"context_line":"        :returns: Endpoint data if available or None."},{"line_number":231,"context_line":"        :rtype: keystoneauth1.discover.EndpointData"},{"line_number":232,"context_line":"        \"\"\""},{"line_number":233,"context_line":"        kwargs \u003d {}"},{"line_number":234,"context_line":"        self._set_endpoint_filter_kwargs(kwargs)"},{"line_number":235,"context_line":"        if self.endpoint_override:"},{"line_number":236,"context_line":"            kwargs[\u0027endpoint_override\u0027] \u003d self.endpoint_override"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f1a1f67_779a7f6e","line":233,"updated":"2017-07-14 19:37:37.000000000","message":"I wonder if it would be worth while to accept kwargs here only to point the user to the new way of doing things. If we just remove the args, we could break folks. If we continue to accept kwargs and give a useful error message - it might help elicit the behavior we want.","commit_id":"32afa6799f54f40f712edd8aa191af5119a3d233"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"69e05d219b56028d69a53513fbbc55adcbb99f40","unresolved":false,"context_lines":[{"line_number":230,"context_line":"        :returns: Endpoint data if available or None."},{"line_number":231,"context_line":"        :rtype: keystoneauth1.discover.EndpointData"},{"line_number":232,"context_line":"        \"\"\""},{"line_number":233,"context_line":"        kwargs \u003d {}"},{"line_number":234,"context_line":"        self._set_endpoint_filter_kwargs(kwargs)"},{"line_number":235,"context_line":"        if self.endpoint_override:"},{"line_number":236,"context_line":"            kwargs[\u0027endpoint_override\u0027] \u003d self.endpoint_override"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f1a1f67_97507b5f","line":233,"in_reply_to":"1f1a1f67_779a7f6e","updated":"2017-07-14 19:46:06.000000000","message":"This is a new interface. We should not include kwargs here. This has not been released yet, it is in master.","commit_id":"32afa6799f54f40f712edd8aa191af5119a3d233"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"4227614d30ef4fe7c923767dab6ed4d4f415a805","unresolved":false,"context_lines":[{"line_number":230,"context_line":"        :returns: Endpoint data if available or None."},{"line_number":231,"context_line":"        :rtype: keystoneauth1.discover.EndpointData"},{"line_number":232,"context_line":"        \"\"\""},{"line_number":233,"context_line":"        kwargs \u003d {}"},{"line_number":234,"context_line":"        self._set_endpoint_filter_kwargs(kwargs)"},{"line_number":235,"context_line":"        if self.endpoint_override:"},{"line_number":236,"context_line":"            kwargs[\u0027endpoint_override\u0027] \u003d self.endpoint_override"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f1a1f67_d7b27394","line":233,"in_reply_to":"1f1a1f67_97507b5f","updated":"2017-07-14 19:48:12.000000000","message":"Thanks for the clarification, Morgan.","commit_id":"32afa6799f54f40f712edd8aa191af5119a3d233"}]}