)]}'
{"doc/source/using-sessions.rst":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"de48490e4cc13daf34b0b9a4f68a21c136a8f424","unresolved":false,"context_lines":[{"line_number":449,"context_line":"  including information about the URL, ``service-type`` and ``request-id``."},{"line_number":450,"context_line":""},{"line_number":451,"context_line":"keystoneauth1.session.request"},{"line_number":452,"context_line":"  Emits a log entry at the ``DEBUG`` level for every http including a"},{"line_number":453,"context_line":"  curl formatted string of the request."},{"line_number":454,"context_line":""},{"line_number":455,"context_line":"keystoneath1.session.response"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f515b1d_55e136d0","line":452,"updated":"2017-09-21 22:01:14.000000000","message":"http request","commit_id":"cf34abec75142b8443ad0ee112d81e8490c41ae3"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"db6986be21977a9ce18200059ccfc7449cd15662","unresolved":false,"context_lines":[{"line_number":449,"context_line":"  including information about the URL, ``service-type`` and ``request-id``."},{"line_number":450,"context_line":""},{"line_number":451,"context_line":"keystoneauth1.session.request"},{"line_number":452,"context_line":"  Emits a log entry at the ``DEBUG`` level for every http including a"},{"line_number":453,"context_line":"  curl formatted string of the request."},{"line_number":454,"context_line":""},{"line_number":455,"context_line":"keystoneath1.session.response"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f515b1d_c482f64f","line":452,"in_reply_to":"7f515b1d_55e136d0","updated":"2017-09-22 21:16:03.000000000","message":"Done","commit_id":"cf34abec75142b8443ad0ee112d81e8490c41ae3"}],"keystoneauth1/session.py":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"1680e326999a513446a876ad516dc056cce899f5","unresolved":false,"context_lines":[{"line_number":328,"context_line":"        string_parts \u003d []"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"        if split_loggers:"},{"line_number":331,"context_line":"            string_parts.append(\u0027REQ:\u0027)"},{"line_number":332,"context_line":"            logger \u003d utils.get_logger(__name__ + \u0027.request\u0027)"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"        if not logger.isEnabledFor(logging.DEBUG):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f515b1d_9ed0dccb","line":331,"updated":"2017-09-22 13:24:24.000000000","message":"I think this is backwards - in the response logging you add RESP: when it\u0027s NOT split so that it\u0027s distinguished from the rest of the logging.\n\nIn any case why not keep the prefix in all cases? Sometimes the loggers could be split but directed to the same stream so it might be useful to keep the distinction in the output.","commit_id":"cf34abec75142b8443ad0ee112d81e8490c41ae3"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"db6986be21977a9ce18200059ccfc7449cd15662","unresolved":false,"context_lines":[{"line_number":328,"context_line":"        string_parts \u003d []"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"        if split_loggers:"},{"line_number":331,"context_line":"            string_parts.append(\u0027REQ:\u0027)"},{"line_number":332,"context_line":"            logger \u003d utils.get_logger(__name__ + \u0027.request\u0027)"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"        if not logger.isEnabledFor(logging.DEBUG):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f515b1d_84abded4","line":331,"in_reply_to":"7f515b1d_9ed0dccb","updated":"2017-09-22 21:16:03.000000000","message":"Because once\u0027s it\u0027s split you have the logger name to distinguish. I mean, we could keep it without much effort - but it\u0027s building a string prefix into the message content when a distinguishing feature already exists in the metadata.\n\nthat said - you are right- this is definitely reversed logic. :)","commit_id":"cf34abec75142b8443ad0ee112d81e8490c41ae3"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"ee35a5dac9bb2bed45af451a4e88054d4dd7c988","unresolved":false,"context_lines":[{"line_number":324,"context_line":""},{"line_number":325,"context_line":"    def _http_log_request(self, url, method\u003dNone, data\u003dNone,"},{"line_number":326,"context_line":"                          json\u003dNone, headers\u003dNone, query_params\u003dNone,"},{"line_number":327,"context_line":"                          logger\u003dNone, split_loggers\u003dTrue):"},{"line_number":328,"context_line":"        string_parts \u003d []"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"        if split_loggers:"}],"source_content_type":"text/x-python","patch_set":6,"id":"7f96bb07_853ccfbf","line":327,"range":{"start_line":327,"start_character":53,"end_line":327,"end_character":57},"updated":"2018-01-15 22:26:15.000000000","message":"Unfortunately, this is a change of behavior, this might actually break someone who is relying on the old behavior.\n\nI think this has to be default to false and let applications opt into it.","commit_id":"5ad7b5c7029feb966d4340f43c3f536b7fb65c28"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"6d37189f10492199bd88e32e08cd89d5bb5bd571","unresolved":false,"context_lines":[{"line_number":324,"context_line":""},{"line_number":325,"context_line":"    def _http_log_request(self, url, method\u003dNone, data\u003dNone,"},{"line_number":326,"context_line":"                          json\u003dNone, headers\u003dNone, query_params\u003dNone,"},{"line_number":327,"context_line":"                          logger\u003dNone, split_loggers\u003dTrue):"},{"line_number":328,"context_line":"        string_parts \u003d []"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"        if split_loggers:"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f93b717_13df72d6","line":327,"range":{"start_line":327,"start_character":53,"end_line":327,"end_character":57},"in_reply_to":"7f96bb07_853ccfbf","updated":"2018-01-31 15:34:20.000000000","message":"Done","commit_id":"5ad7b5c7029feb966d4340f43c3f536b7fb65c28"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"44f960e32910e5aa38358c3f835381295f24646b","unresolved":false,"context_lines":[{"line_number":243,"context_line":"                                 be provided here. (optional, defaults to"},{"line_number":244,"context_line":"                                 None which means automatically manage)"},{"line_number":245,"context_line":"    :param bool split_loggers: Split the logging of requests across multiple"},{"line_number":246,"context_line":"                               loggers instead of just one. Defaults to False."},{"line_number":247,"context_line":"    \"\"\""},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"    user_agent \u003d None"}],"source_content_type":"text/x-python","patch_set":8,"id":"3fa0c359_c9b7b4d8","line":246,"range":{"start_line":246,"start_character":31,"end_line":246,"end_character":77},"updated":"2018-02-05 19:17:50.000000000","message":"You\u0027ve actually defaulted to \"None\", suggest indicating \"None\" is \"False\" in this case. I\u0027d rather see this be a boolean if we\u0027re treating it as a boolean, but I\u0027m ok with it as is.","commit_id":"56b2c89c39e45bc2307113ea12ae584d4f1e11a1"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"2951530342bfd1d1fe3376b1e6b0f364e2638802","unresolved":false,"context_lines":[{"line_number":243,"context_line":"                                 be provided here. (optional, defaults to"},{"line_number":244,"context_line":"                                 None which means automatically manage)"},{"line_number":245,"context_line":"    :param bool split_loggers: Split the logging of requests across multiple"},{"line_number":246,"context_line":"                               loggers instead of just one. Defaults to False."},{"line_number":247,"context_line":"    \"\"\""},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"    user_agent \u003d None"}],"source_content_type":"text/x-python","patch_set":8,"id":"3fa0c359_06bee264","line":246,"range":{"start_line":246,"start_character":31,"end_line":246,"end_character":77},"in_reply_to":"3fa0c359_c9b7b4d8","updated":"2018-02-05 23:09:33.000000000","message":"Added an explanation in a followup. The None is so that we can track set vs. not set. The user is intended to only ever pass True or False though.","commit_id":"56b2c89c39e45bc2307113ea12ae584d4f1e11a1"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"44f960e32910e5aa38358c3f835381295f24646b","unresolved":false,"context_lines":[{"line_number":326,"context_line":"        return header"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"    def _get_split_loggers(self, split_loggers):"},{"line_number":329,"context_line":"        if split_loggers is None:"},{"line_number":330,"context_line":"            split_loggers \u003d self._split_loggers"},{"line_number":331,"context_line":"        if split_loggers is None:"},{"line_number":332,"context_line":"            split_loggers \u003d False"},{"line_number":333,"context_line":"        return split_loggers"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"    def _http_log_request(self, url, method\u003dNone, data\u003dNone,"},{"line_number":336,"context_line":"                          json\u003dNone, headers\u003dNone, query_params\u003dNone,"}],"source_content_type":"text/x-python","patch_set":8,"id":"3fa0c359_a99d885a","line":333,"range":{"start_line":329,"start_character":0,"end_line":333,"end_character":28},"updated":"2018-02-05 19:17:50.000000000","message":"A comment would be nice. Not required.","commit_id":"56b2c89c39e45bc2307113ea12ae584d4f1e11a1"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"2951530342bfd1d1fe3376b1e6b0f364e2638802","unresolved":false,"context_lines":[{"line_number":326,"context_line":"        return header"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"    def _get_split_loggers(self, split_loggers):"},{"line_number":329,"context_line":"        if split_loggers is None:"},{"line_number":330,"context_line":"            split_loggers \u003d self._split_loggers"},{"line_number":331,"context_line":"        if split_loggers is None:"},{"line_number":332,"context_line":"            split_loggers \u003d False"},{"line_number":333,"context_line":"        return split_loggers"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"    def _http_log_request(self, url, method\u003dNone, data\u003dNone,"},{"line_number":336,"context_line":"                          json\u003dNone, headers\u003dNone, query_params\u003dNone,"}],"source_content_type":"text/x-python","patch_set":8,"id":"3fa0c359_e6a3b64e","line":333,"range":{"start_line":329,"start_character":0,"end_line":333,"end_character":28},"in_reply_to":"3fa0c359_a99d885a","updated":"2018-02-05 23:09:33.000000000","message":"Added a followup patch with comments.","commit_id":"56b2c89c39e45bc2307113ea12ae584d4f1e11a1"}]}