)]}'
{"keystoneauth1/access/access.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"09f3e561a07d71c84567dc35f7d44888f1e54d9e","unresolved":false,"context_lines":[{"line_number":233,"context_line":"    def domain_scoped(self):"},{"line_number":234,"context_line":"        \"\"\"Return true if the auth token was scoped to a domain."},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"        :returns: bool"},{"line_number":237,"context_line":"        \"\"\""},{"line_number":238,"context_line":"        raise NotImplementedError()"},{"line_number":239,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf8cb3f7_39321cf3","line":236,"range":{"start_line":236,"start_character":8,"end_line":236,"end_character":22},"updated":"2017-12-21 22:42:41.000000000","message":"do we want this as a bool?","commit_id":"2d4aa4f3b434bc75de9cd456f6fc0f3151e710c9"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"4554469b69951520c2ea31caaad6771840d7a754","unresolved":false,"context_lines":[{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    @property"},{"line_number":241,"context_line":"    def system_scoped(self):"},{"line_number":242,"context_line":"        \"\"\"Return true if the auth token was scoped to the system."},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"        :returns: bool"},{"line_number":245,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_a35e870f","line":242,"range":{"start_line":242,"start_character":18,"end_line":242,"end_character":22},"updated":"2018-01-16 15:52:09.000000000","message":"This should be refactored to account for \u0027all\u0027 instead of a boolean.","commit_id":"6c9e01a3a51a0739626a55de32b449cc4fbd848c"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"4235da4382cfc1647154f44180eccf5f12a38cb8","unresolved":false,"context_lines":[{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    @property"},{"line_number":241,"context_line":"    def system_scoped(self):"},{"line_number":242,"context_line":"        \"\"\"Return true if the auth token was scoped to the system."},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"        :returns: bool"},{"line_number":245,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_729604f3","line":242,"range":{"start_line":242,"start_character":18,"end_line":242,"end_character":22},"in_reply_to":"7f96bb07_a35e870f","updated":"2018-01-16 20:13:39.000000000","message":"Actually - nevermind.. this should remain as is because it should operate like project_scoped or domain_scoped","commit_id":"6c9e01a3a51a0739626a55de32b449cc4fbd848c"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"d6f5e0c721a090de194118d701db9ee40712da0f","unresolved":false,"context_lines":[{"line_number":661,"context_line":""},{"line_number":662,"context_line":"    @_missingproperty"},{"line_number":663,"context_line":"    def system(self):"},{"line_number":664,"context_line":"        return self._data[\u0027token\u0027][\u0027system\u0027]"},{"line_number":665,"context_line":""},{"line_number":666,"context_line":"    @property"},{"line_number":667,"context_line":"    def _domain(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f96bb07_14451a43","line":664,"range":{"start_line":664,"start_character":34,"end_line":664,"end_character":44},"updated":"2018-01-17 09:56:30.000000000","message":"probably should be .get(\u0027system\u0027) ? This should remain compatible with older versions of keystone. Might need to adjust your test fixtures too.","commit_id":"dde68eb2d471b25bbacf07c94b399a987dbe04ae"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"5e0b5291c20d42197fdf3239ed808471e3d3c514","unresolved":false,"context_lines":[{"line_number":661,"context_line":""},{"line_number":662,"context_line":"    @_missingproperty"},{"line_number":663,"context_line":"    def system(self):"},{"line_number":664,"context_line":"        return self._data[\u0027token\u0027][\u0027system\u0027]"},{"line_number":665,"context_line":""},{"line_number":666,"context_line":"    @property"},{"line_number":667,"context_line":"    def _domain(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f96bb07_d1e1f99c","line":664,"range":{"start_line":664,"start_character":34,"end_line":664,"end_character":44},"in_reply_to":"7f96bb07_14451a43","updated":"2018-01-17 15:03:02.000000000","message":"I thought the same thing when looking at domain-scoped and project-scoped methods, but I believe that is what the decorator is for.\n\nhttps://github.com/openstack/keystoneauth/blob/d56791d6e83a30ed0f00195b922010fe8059cf50/keystoneauth1/access/access.py#L49-L58","commit_id":"dde68eb2d471b25bbacf07c94b399a987dbe04ae"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"d6f5e0c721a090de194118d701db9ee40712da0f","unresolved":false,"context_lines":[{"line_number":708,"context_line":""},{"line_number":709,"context_line":"    @_missingproperty"},{"line_number":710,"context_line":"    def system_scoped(self):"},{"line_number":711,"context_line":"        return self._data[\u0027token\u0027][\u0027system\u0027].get(\u0027all\u0027, False)"},{"line_number":712,"context_line":""},{"line_number":713,"context_line":"    @property"},{"line_number":714,"context_line":"    def _trust(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f96bb07_94728aac","line":711,"range":{"start_line":711,"start_character":34,"end_line":711,"end_character":44},"updated":"2018-01-17 09:56:30.000000000","message":"Same here I think","commit_id":"dde68eb2d471b25bbacf07c94b399a987dbe04ae"}],"keystoneauth1/identity/generic/base.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"4554469b69951520c2ea31caaad6771840d7a754","unresolved":false,"context_lines":[{"line_number":41,"context_line":"                 project_domain_name\u003dNone,"},{"line_number":42,"context_line":"                 domain_id\u003dNone,"},{"line_number":43,"context_line":"                 domain_name\u003dNone,"},{"line_number":44,"context_line":"                 system_scoped\u003dFalse,"},{"line_number":45,"context_line":"                 trust_id\u003dNone,"},{"line_number":46,"context_line":"                 default_domain_id\u003dNone,"},{"line_number":47,"context_line":"                 default_domain_name\u003dNone,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_03a3bb01","line":44,"range":{"start_line":44,"start_character":31,"end_line":44,"end_character":36},"updated":"2018-01-16 15:52:09.000000000","message":"this should be refactored to not be a boolean.","commit_id":"6c9e01a3a51a0739626a55de32b449cc4fbd848c"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"f6e80792c14f5c52443848f9045e457cc087ab53","unresolved":false,"context_lines":[{"line_number":41,"context_line":"                 project_domain_name\u003dNone,"},{"line_number":42,"context_line":"                 domain_id\u003dNone,"},{"line_number":43,"context_line":"                 domain_name\u003dNone,"},{"line_number":44,"context_line":"                 system_scoped\u003dFalse,"},{"line_number":45,"context_line":"                 trust_id\u003dNone,"},{"line_number":46,"context_line":"                 default_domain_id\u003dNone,"},{"line_number":47,"context_line":"                 default_domain_name\u003dNone,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_52bae86d","line":44,"range":{"start_line":44,"start_character":31,"end_line":44,"end_character":36},"in_reply_to":"7f96bb07_03a3bb01","updated":"2018-01-16 20:37:04.000000000","message":"Done","commit_id":"6c9e01a3a51a0739626a55de32b449cc4fbd848c"}],"keystoneauth1/identity/v3/base.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"4554469b69951520c2ea31caaad6771840d7a754","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    :param string auth_url: Identity service endpoint for authentication."},{"line_number":33,"context_line":"    :param string trust_id: Trust ID for trust scoping."},{"line_number":34,"context_line":"    :param bool system_scoped: True for system scoping."},{"line_number":35,"context_line":"    :param string domain_id: Domain ID for domain scoping."},{"line_number":36,"context_line":"    :param string domain_name: Domain name for domain scoping."},{"line_number":37,"context_line":"    :param string project_id: Project ID for project scoping."}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_83b6eb3d","line":34,"range":{"start_line":34,"start_character":31,"end_line":34,"end_character":35},"updated":"2018-01-16 15:52:09.000000000","message":"This should not be a boolean.","commit_id":"6c9e01a3a51a0739626a55de32b449cc4fbd848c"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"f6e80792c14f5c52443848f9045e457cc087ab53","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    :param string auth_url: Identity service endpoint for authentication."},{"line_number":33,"context_line":"    :param string trust_id: Trust ID for trust scoping."},{"line_number":34,"context_line":"    :param bool system_scoped: True for system scoping."},{"line_number":35,"context_line":"    :param string domain_id: Domain ID for domain scoping."},{"line_number":36,"context_line":"    :param string domain_name: Domain name for domain scoping."},{"line_number":37,"context_line":"    :param string project_id: Project ID for project scoping."}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_5248a885","line":34,"range":{"start_line":34,"start_character":31,"end_line":34,"end_character":35},"in_reply_to":"7f96bb07_83b6eb3d","updated":"2018-01-16 20:37:04.000000000","message":"Done","commit_id":"6c9e01a3a51a0739626a55de32b449cc4fbd848c"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"4554469b69951520c2ea31caaad6771840d7a754","unresolved":false,"context_lines":[{"line_number":156,"context_line":"            body[\u0027auth\u0027][\u0027scope\u0027] \u003d {\u0027OS-TRUST:trust\u0027: {\u0027id\u0027: self.trust_id}}"},{"line_number":157,"context_line":"        elif self.unscoped:"},{"line_number":158,"context_line":"            body[\u0027auth\u0027][\u0027scope\u0027] \u003d \u0027unscoped\u0027"},{"line_number":159,"context_line":"        elif self.system_scoped:"},{"line_number":160,"context_line":"            body[\u0027auth\u0027][\u0027scope\u0027] \u003d {\u0027system\u0027: {\u0027all\u0027: True}}"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        # NOTE(jamielennox): we add nocatalog here rather than in token_url"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_663e4d8d","line":159,"range":{"start_line":159,"start_character":18,"end_line":159,"end_character":31},"updated":"2018-01-16 15:52:09.000000000","message":"This shouldn\u0027t be a boolean and it should operate similar to self.project_id.","commit_id":"6c9e01a3a51a0739626a55de32b449cc4fbd848c"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"f6e80792c14f5c52443848f9045e457cc087ab53","unresolved":false,"context_lines":[{"line_number":156,"context_line":"            body[\u0027auth\u0027][\u0027scope\u0027] \u003d {\u0027OS-TRUST:trust\u0027: {\u0027id\u0027: self.trust_id}}"},{"line_number":157,"context_line":"        elif self.unscoped:"},{"line_number":158,"context_line":"            body[\u0027auth\u0027][\u0027scope\u0027] \u003d \u0027unscoped\u0027"},{"line_number":159,"context_line":"        elif self.system_scoped:"},{"line_number":160,"context_line":"            body[\u0027auth\u0027][\u0027scope\u0027] \u003d {\u0027system\u0027: {\u0027all\u0027: True}}"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        # NOTE(jamielennox): we add nocatalog here rather than in token_url"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_f260d403","line":159,"range":{"start_line":159,"start_character":18,"end_line":159,"end_character":31},"in_reply_to":"7f96bb07_663e4d8d","updated":"2018-01-16 20:37:04.000000000","message":"Done","commit_id":"6c9e01a3a51a0739626a55de32b449cc4fbd848c"}],"keystoneauth1/identity/v3/password.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"4554469b69951520c2ea31caaad6771840d7a754","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    :param string user_domain_id: User\u0027s domain ID for authentication."},{"line_number":63,"context_line":"    :param string user_domain_name: User\u0027s domain name for authentication."},{"line_number":64,"context_line":"    :param string trust_id: Trust ID for trust scoping."},{"line_number":65,"context_line":"    :param bool system_scoped: True for system scoping."},{"line_number":66,"context_line":"    :param string domain_id: Domain ID for domain scoping."},{"line_number":67,"context_line":"    :param string domain_name: Domain name for domain scoping."},{"line_number":68,"context_line":"    :param string project_id: Project ID for project scoping."}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_c64c0144","line":65,"range":{"start_line":65,"start_character":31,"end_line":65,"end_character":35},"updated":"2018-01-16 15:52:09.000000000","message":"This shouldn\u0027t be a boolean.","commit_id":"6c9e01a3a51a0739626a55de32b449cc4fbd848c"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"f6e80792c14f5c52443848f9045e457cc087ab53","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    :param string user_domain_id: User\u0027s domain ID for authentication."},{"line_number":63,"context_line":"    :param string user_domain_name: User\u0027s domain name for authentication."},{"line_number":64,"context_line":"    :param string trust_id: Trust ID for trust scoping."},{"line_number":65,"context_line":"    :param bool system_scoped: True for system scoping."},{"line_number":66,"context_line":"    :param string domain_id: Domain ID for domain scoping."},{"line_number":67,"context_line":"    :param string domain_name: Domain name for domain scoping."},{"line_number":68,"context_line":"    :param string project_id: Project ID for project scoping."}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_523d08db","line":65,"range":{"start_line":65,"start_character":31,"end_line":65,"end_character":35},"in_reply_to":"7f96bb07_c64c0144","updated":"2018-01-16 20:37:04.000000000","message":"Done","commit_id":"6c9e01a3a51a0739626a55de32b449cc4fbd848c"}]}