)]}'
{"keystoneauth1/session.py":[{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"3dfcebe2a2ce89cca6b92d14ccb219f46241e5da","unresolved":false,"context_lines":[{"line_number":22,"context_line":"import time"},{"line_number":23,"context_line":"import uuid"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"import opentracing"},{"line_number":26,"context_line":"from opentracing.ext import tags as ext_tags"},{"line_number":27,"context_line":"from opentracing.propagation import Format"},{"line_number":28,"context_line":"import requests"},{"line_number":29,"context_line":"import six"},{"line_number":30,"context_line":"from six.moves import urllib"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fce034c_054d8471","line":27,"range":{"start_line":25,"start_character":0,"end_line":27,"end_character":42},"updated":"2019-04-12 14:45:33.000000000","message":"Let\u0027s wrap this in a try: except ImportError: block so that the depend can be optional for ksa.","commit_id":"fa7866fbe3ece38f23c923a71956ed2aece14919"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"ec0727928e3f2a9879f4920c73ed269b3e9dc3e9","unresolved":false,"context_lines":[{"line_number":22,"context_line":"import time"},{"line_number":23,"context_line":"import uuid"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"import opentracing"},{"line_number":26,"context_line":"from opentracing.ext import tags as ext_tags"},{"line_number":27,"context_line":"from opentracing.propagation import Format"},{"line_number":28,"context_line":"import requests"},{"line_number":29,"context_line":"import six"},{"line_number":30,"context_line":"from six.moves import urllib"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fce034c_0d4a8a54","line":27,"range":{"start_line":25,"start_character":0,"end_line":27,"end_character":42},"in_reply_to":"3fce034c_054d8471","updated":"2019-04-12 16:47:51.000000000","message":"The thread says \"The actual change should go to osprofiler library\", so why import opentracing here? Or is this just for a temporary POC?","commit_id":"fa7866fbe3ece38f23c923a71956ed2aece14919"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"3dfcebe2a2ce89cca6b92d14ccb219f46241e5da","unresolved":false,"context_lines":[{"line_number":786,"context_line":"        for k, v in self.additional_headers.items():"},{"line_number":787,"context_line":"            headers.setdefault(k, v)"},{"line_number":788,"context_line":""},{"line_number":789,"context_line":"        # Start OpenTracing span and inject it into headers"},{"line_number":790,"context_line":"        # todo: with osprofiler the start notification is sent immediately,"},{"line_number":791,"context_line":"        # thus all tags need to be specified in start() call, not after"},{"line_number":792,"context_line":"        tags \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fce034c_056024a5","line":789,"updated":"2019-04-12 14:45:33.000000000","message":"Obviously, if we try/except the import above, we\u0027d want to set a flag and wrap this in a block.","commit_id":"fa7866fbe3ece38f23c923a71956ed2aece14919"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"3dfcebe2a2ce89cca6b92d14ccb219f46241e5da","unresolved":false,"context_lines":[{"line_number":794,"context_line":"            ext_tags.HTTP_METHOD: method,"},{"line_number":795,"context_line":"            ext_tags.HTTP_URL: url,"},{"line_number":796,"context_line":"        }"},{"line_number":797,"context_line":"        scope \u003d opentracing.tracer.start_active_span(\u0027keystoneauth1\u0027, tags\u003dtags)"},{"line_number":798,"context_line":"        span \u003d scope.span"},{"line_number":799,"context_line":"        opentracing.tracer.inject(span, Format.HTTP_HEADERS, kwargs[\u0027headers\u0027])"},{"line_number":800,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fce034c_85c5f490","line":797,"range":{"start_line":797,"start_character":53,"end_line":797,"end_character":68},"updated":"2019-04-12 14:45:33.000000000","message":"Instead of hard-coding keystoneauth1 here - maybe we can use some of the info we\u0027ve got in self.app_name and client_name? Something like:\n\n  span_name \u003d client_name or self.app_name or \u0027keystoneauth1\u0027","commit_id":"fa7866fbe3ece38f23c923a71956ed2aece14919"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"3dfcebe2a2ce89cca6b92d14ccb219f46241e5da","unresolved":false,"context_lines":[{"line_number":898,"context_line":""},{"line_number":899,"context_line":"                if auth_headers is not None:"},{"line_number":900,"context_line":"                    headers.update(auth_headers)"},{"line_number":901,"context_line":"                    resp \u003d send(**kwargs)"},{"line_number":902,"context_line":""},{"line_number":903,"context_line":"        if raise_exc and resp.status_code \u003e\u003d 400:"},{"line_number":904,"context_line":"            logger.debug(\u0027Request returned failure status: %s\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fce034c_2533e0ad","line":901,"range":{"start_line":901,"start_character":20,"end_line":901,"end_character":41},"updated":"2019-04-12 14:45:33.000000000","message":"We retry the send - so we might want to include this in the tracing call.\n\nIn fact, maybe the tracing span should be in send rather than request? Maybe not though.","commit_id":"fa7866fbe3ece38f23c923a71956ed2aece14919"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"3dfcebe2a2ce89cca6b92d14ccb219f46241e5da","unresolved":false,"context_lines":[{"line_number":905,"context_line":"                         resp.status_code)"},{"line_number":906,"context_line":"            raise exceptions.from_response(resp, method, url)"},{"line_number":907,"context_line":""},{"line_number":908,"context_line":"        if self._collect_timing:"},{"line_number":909,"context_line":"            for h in resp.history:"},{"line_number":910,"context_line":"                self._api_times.append(RequestTiming("},{"line_number":911,"context_line":"                    method\u003dh.request.method,"},{"line_number":912,"context_line":"                    url\u003dh.request.url,"},{"line_number":913,"context_line":"                    elapsed\u003dh.elapsed,"},{"line_number":914,"context_line":"                ))"},{"line_number":915,"context_line":"            self._api_times.append(RequestTiming("},{"line_number":916,"context_line":"                method\u003dresp.request.method,"},{"line_number":917,"context_line":"                url\u003dresp.request.url,"},{"line_number":918,"context_line":"                elapsed\u003dresp.elapsed,"},{"line_number":919,"context_line":"            ))"},{"line_number":920,"context_line":""},{"line_number":921,"context_line":"        return resp"},{"line_number":922,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fce034c_6518081d","line":919,"range":{"start_line":908,"start_character":3,"end_line":919,"end_character":14},"updated":"2019-04-12 14:45:33.000000000","message":"We can wind up making more than one call. I\u0027m not sure if this is something we should account for or not.","commit_id":"fa7866fbe3ece38f23c923a71956ed2aece14919"}],"requirements.txt":[{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"3dfcebe2a2ce89cca6b92d14ccb219f46241e5da","unresolved":false,"context_lines":[{"line_number":17,"context_line":"six\u003e\u003d1.10.0 # MIT"},{"line_number":18,"context_line":"stevedore\u003e\u003d1.20.0 # Apache-2.0"},{"line_number":19,"context_line":"os-service-types\u003e\u003d1.2.0  # Apache-2.0"},{"line_number":20,"context_line":"opentracing\u003c3,\u003e\u003d2.0.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":1,"id":"3fce034c_e52638b8","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":34},"updated":"2019-04-12 14:45:33.000000000","message":"We try to keep ksa depends to a minimum. Let\u0027s remove this and do a try/except import in the code, then add opentracing as a depend in openstacksdk.","commit_id":"fa7866fbe3ece38f23c923a71956ed2aece14919"}]}