)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"e189ba083dfbe2d0eb916ae763635e30248cf791","unresolved":false,"context_lines":[{"line_number":10,"context_line":"obtain a token. To support an authentication with a public client the"},{"line_number":11,"context_line":"payload should contain the `client_id` and the `requests_auth` attribute"},{"line_number":12,"context_line":"must be None."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Icadb6009fe27893a89122c01bcdab990b2389089"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_6fbbba0d","line":13,"updated":"2019-07-10 19:07:53.000000000","message":"Friendly suggestion: most of the reviewers aren\u0027t intricately familiar with the OAuth2 or OpenIDC specs, so including links to relevant external resources that would explain why this is correct would be helpful and would get you reviews faster.","commit_id":"042b0399df9155bfd9e86141981b460b5d11b9ca"}],"keystoneauth1/identity/v3/oidc.py":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"e189ba083dfbe2d0eb916ae763635e30248cf791","unresolved":false,"context_lines":[{"line_number":257,"context_line":"        payload \u003d self.get_payload(session)"},{"line_number":258,"context_line":"        payload.setdefault(\u0027grant_type\u0027, self.grant_type)"},{"line_number":259,"context_line":"        if not self.client_secret and self.client_id:"},{"line_number":260,"context_line":"            payload.setdefault(\"client_id\", self.client_id)"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"        # get an access token"},{"line_number":263,"context_line":"        access_token \u003d self._get_access_token(session, payload)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_fc176a50","line":260,"updated":"2019-07-10 19:07:53.000000000","message":"IMO it would be more straightforward if this happened within _get_access_token, where client_auth is currently being set.","commit_id":"042b0399df9155bfd9e86141981b460b5d11b9ca"}]}
