)]}'
{"id":"openstack%2Fkeystoneauth~706774","triplet_id":"openstack%2Fkeystoneauth~stable%2Fstein~I1f06c2cd5c4e93e04582d4ffbb434db92010d712","project":"openstack/keystoneauth","branch":"stable/stein","topic":"update-error-handler","hashtags":[],"change_id":"I1f06c2cd5c4e93e04582d4ffbb434db92010d712","subject":"add handling for multiple error returns","status":"ABANDONED","created":"2020-02-10 10:00:17.000000000","updated":"2020-08-04 13:56:57.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"bcca6dbbe9bbf3d58954b2c132261afebf3ae94c","_number":706774,"virtual_id_number":706774,"owner":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":1,"date":"2020-02-10 11:46:48.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},{"date":"2020-05-25 08:20:19.000000000","_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},{"date":"2020-05-22 06:28:03.000000000","_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"date":"2020-02-10 10:00:17.000000000","_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},{"date":"2020-03-05 23:48:24.000000000","_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},{"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-02-10 10:00:17.000000000","updated_by":{"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},"reviewer":{"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},"state":"REVIEWER"},{"updated":"2020-02-10 11:46:48.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-03-05 23:48:24.000000000","updated_by":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"reviewer":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"state":"REVIEWER"},{"updated":"2020-05-22 06:28:03.000000000","updated_by":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"reviewer":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"state":"REVIEWER"}],"messages":[{"id":"0e31b2ae35120a5b1af2b62aff0374a8bbd3c7a7","author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"date":"2020-02-10 10:00:17.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"dc324f55ca68a5b6177540ff2c1590afbd2c014e","author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"date":"2020-02-10 10:15:29.000000000","message":"Patch Set 1:\n\nThe backport was proposed to fix routed provider net bug (https://bugs.launchpad.net/neutron/+bug/1828543) on stein.","accounts_in_message":[],"_revision_number":1},{"id":"d21aeebb26ea492d0b9aad5178ac6a3512f4facf","author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"date":"2020-02-10 10:30:13.000000000","message":"Topic changed from update-error-handler-stable/stein to update-error-handler","accounts_in_message":[],"_revision_number":1},{"id":"25f9a2ddc6f2d55d541353dc12cffe356c92e3dc","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-10 11:46:48.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full https://zuul.opendev.org/t/openstack/build/b00b2189b5a546b69bb597f60bffc6c0 : SUCCESS in 1h 44m 18s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/af3e6bc968d44cea9638561ee547c18e : SUCCESS in 1h 11m 29s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/c3a5d7f0cf8a41e9aaf107e5aa8a3b4d : SUCCESS in 7m 57s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/3741fdd8e1914f86b6f9db5684b3a95e : SUCCESS in 5m 36s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/315936786e374b1e82766a2fe5172795 : SUCCESS in 7m 57s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/69fcdb7ec58542439c39325604ec9a90 : SUCCESS in 4m 36s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/146a9e46ce6e4169b2ca99c14fd8841c : SUCCESS in 6m 42s\n- openstacksdk-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/1c437b9ce10741d998e58cac45254858 : SUCCESS in 58m 53s\n- openstacksdk-functional-devstack-tips-python2 https://zuul.opendev.org/t/openstack/build/edde3865c8ff4cc7abbd2ea2e32d17f7 : SUCCESS in 1h 00m 36s\n- openstacksdk-tox-py36-tips https://zuul.opendev.org/t/openstack/build/6b64915817be446ba147aed9b27c5162 : SUCCESS in 4m 29s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/2476179a06ff495595719d082b246ce2 : SUCCESS in 4m 44s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/96bd3ec2bed94159bc966411e25aa228 : SUCCESS in 5m 16s","accounts_in_message":[],"_revision_number":1},{"id":"3af29a826345d079c509b66af1a0ff5a072eba1a","author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"date":"2020-02-11 16:50:57.000000000","message":"Patch Set 1:\n\nWe discussed this backport on the original commit, I made this comment:\n\n This is a feature, not a bugfix, so I don\u0027t think it should be backported. I\u0027m not sure how the neutron tests could be failing since this isn\u0027t fixing a regression, keystoneauth has always been like this.\n\nI didn\u0027t really get an answer to why the neutron tests are failing on the stable branches. Given that this isn\u0027t a regression in keystoneauth, it would seem that some new functionality is being added to the neutron stable branches that needs this?","accounts_in_message":[],"_revision_number":1},{"id":"27c66275e7502135996a7be3b3385d6e1c64b7fe","author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"date":"2020-02-12 09:39:54.000000000","message":"Patch Set 1:\n\n\u003e We discussed this backport on the original commit, I made this\n \u003e comment:\n \u003e \n \u003e This is a feature, not a bugfix, so I don\u0027t think it should be\n \u003e backported. I\u0027m not sure how the neutron tests could be failing\n \u003e since this isn\u0027t fixing a regression, keystoneauth has always been\n \u003e like this.\n \u003e \n \u003e I didn\u0027t really get an answer to why the neutron tests are failing\n \u003e on the stable branches. Given that this isn\u0027t a regression in\n \u003e keystoneauth, it would seem that some new functionality is being\n \u003e added to the neutron stable branches that needs this?\n\nThanks, sorry I missed/forgot that comment. \nThe issue is present on stein as well, as placement uses a format described in api-sig guideline (see: http://specs.openstack.org/openstack/api-wg/guidelines/errors.html ) and the placement client implemented in neutron-lib can\u0027t parse the returned exceptions from placement due to this misunderstanding of how errors formatting should look like.\n\nAnd this is why a user of routed provider net feature on Stein opened a new bug (see: https://bugs.launchpad.net/neutron/+bug/1862565 )\n\nThis feature is not that well tested (see some trials for that: https://review.opendev.org/665155 ) and it seems that potential users started to appear and give useful feedback","accounts_in_message":[],"_revision_number":1},{"id":"93eceadd59897d1a0cb2c2c8c823cb8db709a116","author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"date":"2020-03-05 23:48:24.000000000","message":"Patch Set 1:\n\nFrom the duplicated bug: \"Previous placement client request payload with content-type \"text/*\", and keystoneauth1 process it correctly.\" - is this an issue of incompatible library versions? Can using an older version of the placement client be a workaround?","accounts_in_message":[],"_revision_number":1},{"id":"1afba9b256245c9ada82e9f460c6838b40fdef5a","author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"date":"2020-03-06 12:37:10.000000000","message":"Patch Set 1:\n\n\u003e From the duplicated bug: \"Previous placement client request payload\n \u003e with content-type \"text/*\", and keystoneauth1 process it\n \u003e correctly.\" - is this an issue of incompatible library versions?\n \u003e Can using an older version of the placement client be a workaround?\n\nSadly this client is in neutron-lib (https://opendev.org/openstack/neutron-lib/src/branch/stable/stein/neutron_lib/placement/client.py ), so changing to older version on stein for example can harm other things.","accounts_in_message":[],"_revision_number":1},{"id":"490464e5e871346fa9ec5ecf3a47a0f6aae89938","author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"date":"2020-05-22 06:28:03.000000000","message":"Patch Set 1:\n\nThis *feels* like an incorrect backport. This change should really be a master and forward only type of change IMO. I wont score this as I could see the benefit of having it behave this way.\n\nFrom strictly a standpoint of \"don\u0027t introduce new behavior to past releases\" I would think 3 or 4 times before offering a +2.","accounts_in_message":[],"_revision_number":1},{"id":"63b1d5bd64f5d4be2b8e05d05632c7d6e3caf144","author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"date":"2020-05-25 08:20:19.000000000","message":"Patch Set 1:\n\n\u003e This *feels* like an incorrect backport. This change should really\n \u003e be a master and forward only type of change IMO. I wont score this\n \u003e as I could see the benefit of having it behave this way.\n \u003e \n \u003e From strictly a standpoint of \"don\u0027t introduce new behavior to past\n \u003e releases\" I would think 3 or 4 times before offering a +2.\n\nThanks for your comment. The need for this backport appeared in this bug. As I remember it is possible to workaround the issue in neutron-lib but with fumbling in the response json from placement","accounts_in_message":[],"_revision_number":1},{"id":"bcca6dbbe9bbf3d58954b2c132261afebf3ae94c","author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"date":"2020-08-04 13:56:57.000000000","message":"Abandoned\n\nLet\u0027s forget it, if it will be a serious problem in stein, perhaps there\u0027s other way to fix it in neutron","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"a90c05fd835c60e3c02d6cc6182aaf2edff71e5e","revisions":{"a90c05fd835c60e3c02d6cc6182aaf2edff71e5e":{"kind":"REWORK","_number":1,"created":"2020-02-10 10:00:17.000000000","uploader":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"ref":"refs/changes/74/706774/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystoneauth","ref":"refs/changes/74/706774/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystoneauth refs/changes/74/706774/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystoneauth refs/changes/74/706774/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystoneauth refs/changes/74/706774/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystoneauth refs/changes/74/706774/1"}}},"commit":{"parents":[{"commit":"51874630142d7de4cb8226f04f102402a0ed89ed","subject":"Make tests pass in 2020","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystoneauth/commit/51874630142d7de4cb8226f04f102402a0ed89ed"}]}],"author":{"name":"Michael McCune","email":"msm@redhat.com","date":"2019-05-30 18:17:42.000000000","tz":-240},"committer":{"name":"Lajos Katona","email":"katonalala@gmail.com","date":"2020-02-10 10:00:17.000000000","tz":0},"subject":"add handling for multiple error returns","message":"add handling for multiple error returns\n\nThis change adds logic to the `exceptions.from_response` to handle\nerrors formatted in accordance with the API-SIG guidelines. When there\nare multiple errors returned, only the first error will be included in\nthe exception with a note informing that there were more errors.\n\nAPI SIG guideline:\nhttps://specs.openstack.org/openstack/api-sig/guidelines/errors.html\n\nemail thread for content:\nhttp://lists.openstack.org/pipermail/openstack-discuss/2019-May/006377.html\n\nrelated neutron bug:\nhttps://bugs.launchpad.net/neutron/+bug/1828543\n\nChange-Id: I1f06c2cd5c4e93e04582d4ffbb434db92010d712\n(cherry picked from commit 01d2da9e4776fed0f2551a4c6e39a72865d5ca72)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystoneauth/commit/a90c05fd835c60e3c02d6cc6182aaf2edff71e5e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystoneauth/commit/a90c05fd835c60e3c02d6cc6182aaf2edff71e5e"}]},"branch":"refs/heads/stable/stein"}},"requirements":[],"submit_records":[],"submit_requirements":[]}