)]}'
{"doc/source/authentication-plugins.rst":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"b81768466291d882176497954bac10e82c5fce6f","unresolved":false,"context_lines":[{"line_number":252,"context_line":"    auth \u003d http_basic.HTTPBasicAuth(endpoint\u003d\u0027http://hostname:6385/\u0027,"},{"line_number":253,"context_line":"                                    username\u003d\u0027myUser\u0027,"},{"line_number":254,"context_line":"                                    password\u003d\u0027myPassword\u0027)"},{"line_number":255,"context_line":"    sess \u003d session.Session(auth\u003dauth)"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"Federation"},{"line_number":258,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bf51134e_691d3cbc","line":255,"updated":"2020-06-19 22:35:43.000000000","message":"\u003c3 for all of this doc!","commit_id":"ff6866321728f5be715d99b7ac3401fe923ec00e"}],"keystoneauth1/http_basic.py":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"a51ea36fb60df89a93166609493290c278c76976","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        return kwargs.get(\u0027endpoint_override\u0027) or self.endpoint"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def get_auth_ref(self, session, **kwargs):"},{"line_number":58,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_f73e69b7","line":58,"updated":"2020-06-11 22:38:42.000000000","message":"Is this needed? The parent class doesn\u0027t define it so I don\u0027t think it needs to be overridden. If it is needed, it would be nice to include a comment about why it\u0027s an empty method.","commit_id":"9835c541d0c4481065bdf2eda9401746012968b4"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"43aeb1a39a699f8b0b9012bdc87fb5128ad43869","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        return kwargs.get(\u0027endpoint_override\u0027) or self.endpoint"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def get_auth_ref(self, session, **kwargs):"},{"line_number":58,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf51134e_72b638dc","line":58,"in_reply_to":"ff570b3c_f73e69b7","updated":"2020-06-14 22:27:20.000000000","message":"Agreed, it looks like its not needed","commit_id":"9835c541d0c4481065bdf2eda9401746012968b4"}],"setup.cfg":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e51f24361acbd3705229339d70432a6dea1a61b4","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"keystoneauth1.plugin \u003d"},{"line_number":43,"context_line":"    none \u003d keystoneauth1.loading._plugins.noauth:NoAuth"},{"line_number":44,"context_line":"    basic \u003d keystoneauth1.loading._plugins.basic:BasicAuth"},{"line_number":45,"context_line":"    password \u003d keystoneauth1.loading._plugins.identity.generic:Password"},{"line_number":46,"context_line":"    token \u003d keystoneauth1.loading._plugins.identity.generic:Token"},{"line_number":47,"context_line":"    admin_token \u003d keystoneauth1.loading._plugins.admin_token:AdminToken"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"ff570b3c_997009a8","line":44,"updated":"2020-05-13 14:55:40.000000000","message":"so I _suspect_ that this is going to be confused with using keystone as the intent is keystone specific authentication methods live here, except so many things have been built around the session code in here, it kind of also makes sense.","commit_id":"a526604792aa2098e1845d65f7fe28121a68ee74"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"edd2885e83f13728c1372e1ddd7a6dd5a7747d89","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"keystoneauth1.plugin \u003d"},{"line_number":43,"context_line":"    none \u003d keystoneauth1.loading._plugins.noauth:NoAuth"},{"line_number":44,"context_line":"    basic \u003d keystoneauth1.loading._plugins.basic:BasicAuth"},{"line_number":45,"context_line":"    password \u003d keystoneauth1.loading._plugins.identity.generic:Password"},{"line_number":46,"context_line":"    token \u003d keystoneauth1.loading._plugins.identity.generic:Token"},{"line_number":47,"context_line":"    admin_token \u003d keystoneauth1.loading._plugins.admin_token:AdminToken"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"ff570b3c_f0535d6b","line":44,"in_reply_to":"ff570b3c_2966192b","updated":"2020-05-22 14:10:39.000000000","message":"I agree, HTTPBasicAuth would be better. I also agree with morgan that it otherwise looks good and I think this is great.","commit_id":"a526604792aa2098e1845d65f7fe28121a68ee74"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"0a84997446fcbb94f4c533fac050b068a3c9c52e","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"keystoneauth1.plugin \u003d"},{"line_number":43,"context_line":"    none \u003d keystoneauth1.loading._plugins.noauth:NoAuth"},{"line_number":44,"context_line":"    basic \u003d keystoneauth1.loading._plugins.basic:BasicAuth"},{"line_number":45,"context_line":"    password \u003d keystoneauth1.loading._plugins.identity.generic:Password"},{"line_number":46,"context_line":"    token \u003d keystoneauth1.loading._plugins.identity.generic:Token"},{"line_number":47,"context_line":"    admin_token \u003d keystoneauth1.loading._plugins.admin_token:AdminToken"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"ff570b3c_2966192b","line":44,"in_reply_to":"ff570b3c_6bdd5013","updated":"2020-05-22 06:23:12.000000000","message":"++ I would support calling this http_basic or (HTTPBasicAuth). The plugin should be named in a manner that is highly descriptive especially as this is not keystone-specific.\n\nI am adding a -1 here, highlighting that the plugin name is confusing as named. This -1 is intended to be overridden by other cores if this is deemed to be a non-issue.\n\nBarring the naming, this code looks pretty good to me.","commit_id":"a526604792aa2098e1845d65f7fe28121a68ee74"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"b81768466291d882176497954bac10e82c5fce6f","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"keystoneauth1.plugin \u003d"},{"line_number":43,"context_line":"    none \u003d keystoneauth1.loading._plugins.noauth:NoAuth"},{"line_number":44,"context_line":"    basic \u003d keystoneauth1.loading._plugins.basic:BasicAuth"},{"line_number":45,"context_line":"    password \u003d keystoneauth1.loading._plugins.identity.generic:Password"},{"line_number":46,"context_line":"    token \u003d keystoneauth1.loading._plugins.identity.generic:Token"},{"line_number":47,"context_line":"    admin_token \u003d keystoneauth1.loading._plugins.admin_token:AdminToken"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"ff570b3c_8a4d10c6","line":44,"in_reply_to":"ff570b3c_6bdd5013","updated":"2020-06-19 22:35:43.000000000","message":"That does seem more reasonable to me.","commit_id":"a526604792aa2098e1845d65f7fe28121a68ee74"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"6e62472934f734469d8b6b7e5b9449cac38cf05b","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"keystoneauth1.plugin \u003d"},{"line_number":43,"context_line":"    none \u003d keystoneauth1.loading._plugins.noauth:NoAuth"},{"line_number":44,"context_line":"    basic \u003d keystoneauth1.loading._plugins.basic:BasicAuth"},{"line_number":45,"context_line":"    password \u003d keystoneauth1.loading._plugins.identity.generic:Password"},{"line_number":46,"context_line":"    token \u003d keystoneauth1.loading._plugins.identity.generic:Token"},{"line_number":47,"context_line":"    admin_token \u003d keystoneauth1.loading._plugins.admin_token:AdminToken"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"ff570b3c_6bdd5013","line":44,"in_reply_to":"ff570b3c_997009a8","updated":"2020-05-13 21:40:30.000000000","message":"maybe calling the plugin entry http_basic would help with this","commit_id":"a526604792aa2098e1845d65f7fe28121a68ee74"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"b7651d9f9662d838cdbd774d41ee3349fdbdae29","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"keystoneauth1.plugin \u003d"},{"line_number":43,"context_line":"    none \u003d keystoneauth1.loading._plugins.noauth:NoAuth"},{"line_number":44,"context_line":"    basic \u003d keystoneauth1.loading._plugins.basic:BasicAuth"},{"line_number":45,"context_line":"    password \u003d keystoneauth1.loading._plugins.identity.generic:Password"},{"line_number":46,"context_line":"    token \u003d keystoneauth1.loading._plugins.identity.generic:Token"},{"line_number":47,"context_line":"    admin_token \u003d keystoneauth1.loading._plugins.admin_token:AdminToken"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"ff570b3c_f1bb436f","line":44,"in_reply_to":"ff570b3c_f0535d6b","updated":"2020-05-26 20:34:22.000000000","message":"Done","commit_id":"a526604792aa2098e1845d65f7fe28121a68ee74"}]}