)]}'
{"id":"openstack%2Fkeystoneauth~733139","triplet_id":"openstack%2Fkeystoneauth~master~Ib1db7694a8f0f59d8762b02acbb4ef16e5176098","project":"openstack/keystoneauth","branch":"master","hashtags":[],"change_id":"Ib1db7694a8f0f59d8762b02acbb4ef16e5176098","subject":"Replace assertItemsEqual with assertCountEqual","status":"MERGED","created":"2020-06-03 13:14:43.000000000","updated":"2020-06-05 04:46:24.000000000","submitted":"2020-06-05 04:45:24.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"733139-1591332324344-c58cac8c","meta_rev_id":"9929cc8c232bc80c160f60c8b864422dc35a43cd","_number":733139,"virtual_id_number":733139,"owner":{"_account_id":31068,"name":"Joel Capitao","email":"jcapitao@redhat.com","username":"jcapiitao"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-06-05 04:45:24.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"all":[{"value":2,"date":"2020-06-05 03:26:19.000000000","_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2020-06-03 13:49:10.000000000","_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"all":[{"value":1,"date":"2020-06-05 03:26:19.000000000","_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-06-03 13:49:10.000000000","updated_by":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"reviewer":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"state":"REVIEWER"},{"updated":"2020-06-05 03:26:19.000000000","updated_by":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"reviewer":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"state":"REVIEWER"},{"updated":"2020-06-05 04:45:24.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"e4da58952a59f296936dc6f0566e8fad35ce28d5","author":{"_account_id":31068,"name":"Joel Capitao","email":"jcapitao@redhat.com","username":"jcapiitao"},"date":"2020-06-03 13:14:43.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"aed4c80bd85abd6fcd6f8a8d5e89ca2b9cf00104","author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"date":"2020-06-03 13:49:10.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"13267f37de8af21fcd09c7907452e2b5193f02d6","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-03 14:32:23.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/ead07d71633945fdb682c7cdf07209a3 : SUCCESS in 1h 14m 54s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/bb0d5769aa904d71b030066a964813c2 : SUCCESS in 4m 37s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/c678f68505914adcbe00b1fef877f379 : SUCCESS in 3m 57s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/d087365399ee4423babc5ede19be855c : SUCCESS in 3m 39s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/7847b7f514654b79a63a184b0561f6e3 : SUCCESS in 3m 46s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/ca1be300e76845d0befb7813e9596b21 : SUCCESS in 4m 49s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/2e1c64371fe146c698364979514d793e : SUCCESS in 3m 56s (non-voting)\n- openstacksdk-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/0fb51cf82a874801aaa260e92f580113 : SUCCESS in 38m 48s\n- openstacksdk-tox-py38-tips https://zuul.opendev.org/t/openstack/build/c87baf979a42494194feb1cc5709ae3c : SUCCESS in 4m 54s\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/9af10ba5df5e4965b72db40128a6b88d : SUCCESS in 4m 58s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/22f02b6a2eca4174979edf684e7e677b : SUCCESS in 5m 49s","accounts_in_message":[],"_revision_number":1},{"id":"a570c9ae2da1d381245ad799bfdb823aac22aa5c","author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"date":"2020-06-05 03:26:19.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"7e46d2821effd002dfb264d9e77d0a2e7747eb9f","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-05 03:26:31.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"163f048002287c6f8cd8b8cd9b0b37e9919baada","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-05 04:45:24.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/b03510f04cdf467386949d083c3a6539 : SUCCESS in 1h 18m 06s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/18381d316ae1401095c34d2fa960db76 : SUCCESS in 4m 52s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/fdafbbec7dad43039307e5eb2f373c5d : SUCCESS in 3m 25s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/1fd53c4f7750448f870a6c20db287788 : SUCCESS in 3m 27s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/7367634d6ad14d35820e014622f635d2 : SUCCESS in 3m 38s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/c5d3cabfb5554d4a829c04d19c89204b : SUCCESS in 3m 59s\n- openstacksdk-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/cc45f85601b14a5ca683216e3a056360 : SUCCESS in 44m 24s\n- openstacksdk-tox-py38-tips https://zuul.opendev.org/t/openstack/build/077afb292eb048bb9d7c87668baad520 : SUCCESS in 5m 08s\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/fd5558e08e214bd3b6dc8e3a4292df87 : SUCCESS in 4m 55s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f71dc517964a46d5861d0042c4030746 : SUCCESS in 6m 16s","accounts_in_message":[],"_revision_number":1},{"id":"5cb6a51d3bb23eb1287c93ba141ef5349f203bb6","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-05 04:45:24.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"9929cc8c232bc80c160f60c8b864422dc35a43cd","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-05 04:46:24.000000000","message":"Patch Set 1:\n\nBuild failed (promote pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/1a2e1b9e2b34496985ca39e8972836d7 : FAILURE in 45s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"1fe8df2bc854f3b1a586c7cd92462050aa5912f0","revisions":{"1fe8df2bc854f3b1a586c7cd92462050aa5912f0":{"kind":"REWORK","_number":1,"created":"2020-06-03 13:14:43.000000000","uploader":{"_account_id":31068,"name":"Joel Capitao","email":"jcapitao@redhat.com","username":"jcapiitao"},"ref":"refs/changes/39/733139/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystoneauth","ref":"refs/changes/39/733139/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystoneauth refs/changes/39/733139/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystoneauth refs/changes/39/733139/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystoneauth refs/changes/39/733139/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystoneauth refs/changes/39/733139/1"}}},"commit":{"parents":[{"commit":"7d03b2b2f46c12a0110821a9989a930d87c8b2a8","subject":"Merge \"Switch to newer openstackdocstheme and reno versions\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystoneauth/commit/7d03b2b2f46c12a0110821a9989a930d87c8b2a8"}]}],"author":{"name":"Joel Capitao","email":"jcapitao@redhat.com","date":"2020-06-03 13:09:14.000000000","tz":120},"committer":{"name":"Joel Capitao","email":"jcapitao@redhat.com","date":"2020-06-03 13:14:41.000000000","tz":120},"subject":"Replace assertItemsEqual with assertCountEqual","message":"Replace assertItemsEqual with assertCountEqual\n\nassertItemsEqual was removed from Python\u0027s unittest.TestCase in\nPython 3.3 [1][2]. We have been able to use them since then, because\ntesttools required unittest2, which still included it. With testtools\nremoving Python 2.7 support [3][4], we will lose support for\nassertItemsEqual, so we should switch to use assertCountEqual.\nCredits to [5].\n\n[1] - https://bugs.python.org/issue17866\n[2] - https://hg.python.org/cpython/rev/d9921cb6e3cd\n[3] - testing-cabal/testtools#286\n[4] - testing-cabal/testtools#277\n[5] - https://review.opendev.org/#/c/732393/\n\nChange-Id: Ib1db7694a8f0f59d8762b02acbb4ef16e5176098\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystoneauth/commit/1fe8df2bc854f3b1a586c7cd92462050aa5912f0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystoneauth/commit/1fe8df2bc854f3b1a586c7cd92462050aa5912f0"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
