)]}'
{"id":"openstack%2Fkeystoneauth~734359","triplet_id":"openstack%2Fkeystoneauth~master~Ied00252f43bfd468dbf8c43cfe20d54adb2261f9","project":"openstack/keystoneauth","branch":"master","topic":"drop_mock","hashtags":[],"change_id":"Ied00252f43bfd468dbf8c43cfe20d54adb2261f9","subject":"drop mock from lower-constraints","status":"ABANDONED","created":"2020-06-08 23:18:22.000000000","updated":"2020-06-23 07:49:53.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"72df49276f60ee799230102d3ee61bffe039ab4f","_number":734359,"virtual_id_number":734359,"owner":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"tag":"autogenerated:zuul:check","value":-1,"date":"2020-06-10 12:44:14.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"all":[{"value":-1,"date":"2020-06-10 11:41:33.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":2,"date":"2020-06-10 11:24:57.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"rejected":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"all":[{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":-1,"date":"2020-06-11 12:06:41.000000000","permitted_voting_range":{"min":-1,"max":0},"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-06-08 23:48:00.000000000","updated_by":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"reviewer":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"state":"REVIEWER"},{"updated":"2020-06-10 11:41:33.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"},{"updated":"2020-06-10 12:44:14.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"6a953f3ab08aa016f2f7d04fed6c528057c34ea5","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2020-06-08 23:18:22.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"98c55752ac8d86072e4bafbff9068e9a97f3dd7d","author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"date":"2020-06-08 23:48:00.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"ed29dad2baa75c05267b7890230d12c5ef0474af","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-09 00:18:12.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- requirements-check https://zuul.opendev.org/t/openstack/build/68e069bbfb9d48bfaafaf7a389b62a27 : FAILURE in 5m 23s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/7f1a32f11c484b4c85b819c6375b5d4f : SUCCESS in 58m 33s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/5e975ff532e1441b8c3a39413e53af4c : SUCCESS in 6m 35s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/2f2b1ede4a6a4c3da2bb170478cae434 : SUCCESS in 5m 33s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/af729c77d73b4ae1838c503cd0b95823 : SUCCESS in 4m 44s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/8c0f0ddcf4f04becbb8c70a18d127228 : SUCCESS in 5m 52s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/a98c100453d242ccb813681299d9f95f : SUCCESS in 4m 35s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/4f531b42236d463a9fc6c178c8c68d78 : SUCCESS in 6m 06s (non-voting)\n- openstacksdk-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/d4a5a42cb20b45dbacd7dee53e570442 : SUCCESS in 52m 34s\n- openstacksdk-tox-py38-tips https://zuul.opendev.org/t/openstack/build/b741264dc08f45de95f564b295696d98 : SUCCESS in 6m 56s\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/f00fd84337954297854013fb99d99a4e : SUCCESS in 7m 21s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a9843d6e4e6b407e83e5d5ce52388324 : SUCCESS in 6m 15s","accounts_in_message":[],"_revision_number":1},{"id":"1a51b22176a854c09a782832d93224d059904743","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2020-06-10 11:24:57.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"2e7e150e039256ffd2ac5845fa9c39cff94c0cda","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2020-06-10 11:41:33.000000000","message":"Patch Set 2: Code-Review-1\n\nRegenerating lower-constraints, this is actually incorrect. Mock is still being used by one or more of the dependencies, so it does still get installed. So the entry really should not be removed.","accounts_in_message":[],"_revision_number":2},{"id":"72f55cdc5bc05fe6b84b67a4479365e20ca54019","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-10 12:44:14.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- requirements-check https://zuul.opendev.org/t/openstack/build/e0b9f89ceb214f3dad9cd91b38f01dff : FAILURE in 2m 33s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/58b5878396084908b443599ae901f80e : SUCCESS in 1h 17m 33s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/f4e28c0de11046c1828610da7dcb5b62 : SUCCESS in 4m 40s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/2ab49f1fa4514797aa5a80a50dd31797 : SUCCESS in 5m 30s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ef3649d7e28f4c3abd7e6a20c69cc55f : SUCCESS in 5m 08s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/0480a415be3b4747a7127b111149de66 : SUCCESS in 5m 29s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/2a4ca22d446448f0bc45fe5844c87580 : SUCCESS in 7m 40s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/e28304cb1a5f439795cc07d12db8a682 : SUCCESS in 7m 40s (non-voting)\n- openstacksdk-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/7cb3139d20c1490ab9e7469640c67c3e : SUCCESS in 1h 17m 07s\n- openstacksdk-tox-py38-tips https://zuul.opendev.org/t/openstack/build/d6acef3f7e104a5597d4822c25660373 : SUCCESS in 7m 23s\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/0775d065f0474a34a9f6b70e73738b9b : SUCCESS in 7m 47s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/847888d7195e407d8a7078239276d94e : SUCCESS in 13m 57s","accounts_in_message":[],"_revision_number":2},{"id":"3d9cd5a0336c8c6d4afd90e3c01e253ebd153c14","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2020-06-10 15:54:07.000000000","message":"Patch Set 2:\n\n\u003e Regenerating lower-constraints, this is actually incorrect. Mock is\n \u003e still being used by one or more of the dependencies, so it does\n \u003e still get installed. So the entry really should not be removed.\n\nI seen a similar scenario on charm-* with charms.openstack that use mock but he doesn\u0027t have it in its requirements, so managed this use case by using depends-on, can we use a similar approach here?\n\nWho in the stack still need mock?","accounts_in_message":[],"_revision_number":2},{"id":"8391c8c1c589a6751b0ffbb4591ff81413fd1921","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2020-06-10 17:55:16.000000000","message":"Patch Set 2:\n\n\u003e \u003e Regenerating lower-constraints, this is actually incorrect. Mock\n \u003e is\n \u003e \u003e still being used by one or more of the dependencies, so it does\n \u003e \u003e still get installed. So the entry really should not be removed.\n \u003e \n \u003e I seen a similar scenario on charm-* with charms.openstack that use\n \u003e mock but he doesn\u0027t have it in its requirements, so managed this\n \u003e use case by using depends-on, can we use a similar approach here?\n \u003e \n \u003e Who in the stack still need mock?\n\nIf a project is using mock but not including it in test-requirements then that is another issue. That\u0027s really a bug.\n\nThere are a lot of packages, openstack or otherwise, that use mock. So even though we don\u0027t use it directly here, with the goals of having a lower-constraints job, it should still be constrained there.","accounts_in_message":[],"_revision_number":2},{"id":"b1977bc9d5e98f9db30753814c73b11754271f63","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2020-06-11 12:06:33.000000000","message":"Patch Set 2:\n\n\u003e \u003e \u003e Regenerating lower-constraints, this is actually incorrect.\n \u003e Mock\n \u003e \u003e is\n \u003e \u003e \u003e still being used by one or more of the dependencies, so it does\n \u003e \u003e \u003e still get installed. So the entry really should not be removed.\n \u003e \u003e\n \u003e \u003e I seen a similar scenario on charm-* with charms.openstack that\n \u003e use\n \u003e \u003e mock but he doesn\u0027t have it in its requirements, so managed this\n \u003e \u003e use case by using depends-on, can we use a similar approach here?\n \u003e \u003e\n \u003e \u003e Who in the stack still need mock?\n \u003e \n \u003e If a project is using mock but not including it in\n \u003e test-requirements then that is another issue. That\u0027s really a bug.\n \u003e \n \u003e There are a lot of packages, openstack or otherwise, that use mock.\n \u003e So even though we don\u0027t use it directly here, with the goals of\n \u003e having a lower-constraints job, it should still be constrained\n \u003e there.\n\nI got it, thanks for the heads up","accounts_in_message":[],"_revision_number":2},{"id":"7fdeae0336d0254a43958e12c66f2372659b5212","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2020-06-11 12:06:41.000000000","message":"Patch Set 2: Workflow-1","accounts_in_message":[],"_revision_number":2},{"id":"28c07c798fdb56e3d906b9454335f4c783160f54","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2020-06-23 07:49:53.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"7f2ea4f9d10db4978e6393f8df9275684a20ecf6","revisions":{"c3f85299bbf4b635bab045d8d22ee2dfba17b475":{"kind":"REWORK","_number":1,"created":"2020-06-08 23:18:22.000000000","uploader":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"ref":"refs/changes/59/734359/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystoneauth","ref":"refs/changes/59/734359/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystoneauth refs/changes/59/734359/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystoneauth refs/changes/59/734359/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystoneauth refs/changes/59/734359/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystoneauth refs/changes/59/734359/1"}}},"commit":{"parents":[{"commit":"94314329e9adcc5b1b8945bad28bee3ab7d37e82","subject":"Merge \"Replace assertItemsEqual with assertCountEqual\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystoneauth/commit/94314329e9adcc5b1b8945bad28bee3ab7d37e82"}]}],"author":{"name":"Hervé Beraud","email":"hberaud@redhat.com","date":"2020-06-08 23:18:16.000000000","tz":120},"committer":{"name":"Hervé Beraud","email":"hberaud@redhat.com","date":"2020-06-08 23:18:16.000000000","tz":120},"subject":"drop mock from lower-constraints","message":"drop mock from lower-constraints\n\nThe mock third party library was needed for mock support in py2\nruntimes. Since we now only support py36 and later, we don\u0027t need it\nin lower-constraints.\n\nThese changes will help us to drop `mock` from openstack/requirements\n\nChange-Id: Ied00252f43bfd468dbf8c43cfe20d54adb2261f9\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystoneauth/commit/c3f85299bbf4b635bab045d8d22ee2dfba17b475"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystoneauth/commit/c3f85299bbf4b635bab045d8d22ee2dfba17b475"}]},"branch":"refs/heads/master"},"7f2ea4f9d10db4978e6393f8df9275684a20ecf6":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2020-06-10 11:24:57.000000000","uploader":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"ref":"refs/changes/59/734359/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystoneauth","ref":"refs/changes/59/734359/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystoneauth refs/changes/59/734359/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystoneauth refs/changes/59/734359/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystoneauth refs/changes/59/734359/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystoneauth refs/changes/59/734359/2"}}},"commit":{"parents":[{"commit":"f81f62cf693dcdbcd31e105109f8ba8281362e5c","subject":"fix reno lower-constraints for py35","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystoneauth/commit/f81f62cf693dcdbcd31e105109f8ba8281362e5c"}]}],"author":{"name":"Hervé Beraud","email":"hberaud@redhat.com","date":"2020-06-08 23:18:16.000000000","tz":120},"committer":{"name":"Hervé Beraud","email":"hberaud@redhat.com","date":"2020-06-10 11:24:20.000000000","tz":120},"subject":"drop mock from lower-constraints","message":"drop mock from lower-constraints\n\nThe mock third party library was needed for mock support in py2\nruntimes. Since we now only support py36 and later, we don\u0027t need it\nin lower-constraints.\n\nThese changes will help us to drop `mock` from openstack/requirements\n\nChange-Id: Ied00252f43bfd468dbf8c43cfe20d54adb2261f9\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystoneauth/commit/7f2ea4f9d10db4978e6393f8df9275684a20ecf6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystoneauth/commit/7f2ea4f9d10db4978e6393f8df9275684a20ecf6"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}