)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"905afa6470dd9c48b1dda7e9e9f9b8a1512259ae","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When a non-keystone plugin is used together with an unversioned endpoint,"},{"line_number":10,"context_line":"we give up on discovery before figuring out both major version and"},{"line_number":11,"context_line":"the correct endpoint."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ie623931b150748d7759cf276e0023a2f06a8d4db"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f560f44_c19a7a6c","line":11,"updated":"2020-07-30 20:42:44.000000000","message":"I don\u0027t pay as much attention to IRC as I used to, say more here? Is this the before state or the after state?","commit_id":"5df761193e8333f0029627d23ac88904c5c28b08"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"73c4abbee56209f9a48011a5080c34933995cf41","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When a non-keystone plugin is used together with an unversioned endpoint,"},{"line_number":10,"context_line":"we give up on discovery before figuring out both major version and"},{"line_number":11,"context_line":"the correct endpoint."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ie623931b150748d7759cf276e0023a2f06a8d4db"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f560f44_071bdd80","line":11,"in_reply_to":"9f560f44_c19a7a6c","updated":"2020-07-31 09:29:28.000000000","message":"Honestly, I\u0027m struggling to explain this, my understanding of what is happening if very intuitive, and discovery.py is one big black hole for me.","commit_id":"5df761193e8333f0029627d23ac88904c5c28b08"}],"keystoneauth1/plugin.py":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"905afa6470dd9c48b1dda7e9e9f9b8a1512259ae","unresolved":false,"context_lines":[{"line_number":342,"context_line":"        # NOTE(dtantsur): first try the normal discovery path. It will use our"},{"line_number":343,"context_line":"        # overridden get_endpoint_data."},{"line_number":344,"context_line":"        endpoint \u003d super(FixedEndpointPlugin, self).get_endpoint("},{"line_number":345,"context_line":"            session, **kwargs)"},{"line_number":346,"context_line":"        return endpoint or kwargs.get(\u0027endpoint_override\u0027) or self.endpoint"},{"line_number":347,"context_line":""},{"line_number":348,"context_line":"    def get_endpoint_data(self, session,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_a195c642","line":345,"updated":"2020-07-30 20:42:44.000000000","message":"Doesn\u0027t this add an extra API call? Why should this take precedence over an explicitly set endpoint_override argument? Looking at the tests it seems like this is changing behavior which makes me nervous.","commit_id":"5df761193e8333f0029627d23ac88904c5c28b08"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"73c4abbee56209f9a48011a5080c34933995cf41","unresolved":false,"context_lines":[{"line_number":342,"context_line":"        # NOTE(dtantsur): first try the normal discovery path. It will use our"},{"line_number":343,"context_line":"        # overridden get_endpoint_data."},{"line_number":344,"context_line":"        endpoint \u003d super(FixedEndpointPlugin, self).get_endpoint("},{"line_number":345,"context_line":"            session, **kwargs)"},{"line_number":346,"context_line":"        return endpoint or kwargs.get(\u0027endpoint_override\u0027) or self.endpoint"},{"line_number":347,"context_line":""},{"line_number":348,"context_line":"    def get_endpoint_data(self, session,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_87252dc5","line":345,"in_reply_to":"9f560f44_a195c642","updated":"2020-07-31 09:29:28.000000000","message":"get_endpoint_data is supposed to use endpoint_override, although we may make it explicit.\n\nafter some unit testing, I\u0027m no longer sure we actually need to change get_endpoint, maybe changing only get_api_major_version is enough.","commit_id":"5df761193e8333f0029627d23ac88904c5c28b08"}]}