)]}'
{"keystoneauth1/session.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"4f67b273d5f1fb3db8652470a74ebd743c60d07a","unresolved":true,"context_lines":[{"line_number":621,"context_line":"            headers.setdefault(\u0027OpenStack-API-Version\u0027,"},{"line_number":622,"context_line":"                               \u0027{service_type} {microversion}\u0027.format("},{"line_number":623,"context_line":"                                   service_type\u003dservice_type,"},{"line_number":624,"context_line":"                                   microversion\u003dmicroversion))"},{"line_number":625,"context_line":"        header_names \u003d _mv_legacy_headers_for_service(service_type)"},{"line_number":626,"context_line":"        for h in header_names:"},{"line_number":627,"context_line":"            headers.setdefault(h, microversion)"}],"source_content_type":"text/x-python","patch_set":1,"id":"d9c53632_dd6f69e0","line":624,"updated":"2021-02-10 00:09:55.000000000","message":"Does manila reject the request if it\u0027s set?","commit_id":"a670a9f7b506bf3cce5c5847e37dca09632b5d23"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1e3b77f2e5bde53978679295ca7c688fab8e2d16","unresolved":false,"context_lines":[{"line_number":621,"context_line":"            headers.setdefault(\u0027OpenStack-API-Version\u0027,"},{"line_number":622,"context_line":"                               \u0027{service_type} {microversion}\u0027.format("},{"line_number":623,"context_line":"                                   service_type\u003dservice_type,"},{"line_number":624,"context_line":"                                   microversion\u003dmicroversion))"},{"line_number":625,"context_line":"        header_names \u003d _mv_legacy_headers_for_service(service_type)"},{"line_number":626,"context_line":"        for h in header_names:"},{"line_number":627,"context_line":"            headers.setdefault(h, microversion)"}],"source_content_type":"text/x-python","patch_set":1,"id":"e014d600_580a0b5c","line":624,"in_reply_to":"273cf545_43a099a0","updated":"2021-02-18 16:40:47.000000000","message":"Done","commit_id":"a670a9f7b506bf3cce5c5847e37dca09632b5d23"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"c1f4cf36181c822b5a2257c5b3bec8d8c9f4badf","unresolved":true,"context_lines":[{"line_number":621,"context_line":"            headers.setdefault(\u0027OpenStack-API-Version\u0027,"},{"line_number":622,"context_line":"                               \u0027{service_type} {microversion}\u0027.format("},{"line_number":623,"context_line":"                                   service_type\u003dservice_type,"},{"line_number":624,"context_line":"                                   microversion\u003dmicroversion))"},{"line_number":625,"context_line":"        header_names \u003d _mv_legacy_headers_for_service(service_type)"},{"line_number":626,"context_line":"        for h in header_names:"},{"line_number":627,"context_line":"            headers.setdefault(h, microversion)"}],"source_content_type":"text/x-python","patch_set":1,"id":"e36f14ff_0c7a10a6","line":624,"in_reply_to":"81affce4_8d910b25","updated":"2021-02-18 15:05:28.000000000","message":"If manila doesn\u0027t reject, why not to send it? Maybe in future manila can switch to using OpenStack-API-Version. I agree, this \"if\" looks strange.","commit_id":"a670a9f7b506bf3cce5c5847e37dca09632b5d23"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"fbba23bbb5e00d09a5c4122c3ab400a99364ae61","unresolved":true,"context_lines":[{"line_number":621,"context_line":"            headers.setdefault(\u0027OpenStack-API-Version\u0027,"},{"line_number":622,"context_line":"                               \u0027{service_type} {microversion}\u0027.format("},{"line_number":623,"context_line":"                                   service_type\u003dservice_type,"},{"line_number":624,"context_line":"                                   microversion\u003dmicroversion))"},{"line_number":625,"context_line":"        header_names \u003d _mv_legacy_headers_for_service(service_type)"},{"line_number":626,"context_line":"        for h in header_names:"},{"line_number":627,"context_line":"            headers.setdefault(h, microversion)"}],"source_content_type":"text/x-python","patch_set":1,"id":"81affce4_8d910b25","line":624,"in_reply_to":"d89971b9_823d2394","updated":"2021-02-10 13:23:12.000000000","message":"I was looking at some of the other microversion headers for nova and ironic, but we don\u0027t have conditionals for them here, which prompted my question.\n\nI\u0027ll let others weigh-in with their thoughts.","commit_id":"a670a9f7b506bf3cce5c5847e37dca09632b5d23"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"176d3ad1f8ae6e49311b90b569e3504546fcbceb","unresolved":true,"context_lines":[{"line_number":621,"context_line":"            headers.setdefault(\u0027OpenStack-API-Version\u0027,"},{"line_number":622,"context_line":"                               \u0027{service_type} {microversion}\u0027.format("},{"line_number":623,"context_line":"                                   service_type\u003dservice_type,"},{"line_number":624,"context_line":"                                   microversion\u003dmicroversion))"},{"line_number":625,"context_line":"        header_names \u003d _mv_legacy_headers_for_service(service_type)"},{"line_number":626,"context_line":"        for h in header_names:"},{"line_number":627,"context_line":"            headers.setdefault(h, microversion)"}],"source_content_type":"text/x-python","patch_set":1,"id":"d89971b9_823d2394","line":624,"in_reply_to":"d9c53632_dd6f69e0","updated":"2021-02-10 05:45:09.000000000","message":"It does not, it ignores it; but thought i\u0027d do this check for correctness\u0027 sake - wdyt?","commit_id":"a670a9f7b506bf3cce5c5847e37dca09632b5d23"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c24bab848cfe7977328239078e1250c6d42311d5","unresolved":true,"context_lines":[{"line_number":621,"context_line":"            headers.setdefault(\u0027OpenStack-API-Version\u0027,"},{"line_number":622,"context_line":"                               \u0027{service_type} {microversion}\u0027.format("},{"line_number":623,"context_line":"                                   service_type\u003dservice_type,"},{"line_number":624,"context_line":"                                   microversion\u003dmicroversion))"},{"line_number":625,"context_line":"        header_names \u003d _mv_legacy_headers_for_service(service_type)"},{"line_number":626,"context_line":"        for h in header_names:"},{"line_number":627,"context_line":"            headers.setdefault(h, microversion)"}],"source_content_type":"text/x-python","patch_set":1,"id":"273cf545_43a099a0","line":624,"in_reply_to":"e36f14ff_0c7a10a6","updated":"2021-02-18 16:27:54.000000000","message":"hmm, sure. I can live with that. Thanks for the feedback, Lance and Artem!","commit_id":"a670a9f7b506bf3cce5c5847e37dca09632b5d23"}]}