)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"5d1a4f724206b66b80ef18e41834373e48e027c6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"6a14df01_d74de332","updated":"2022-07-20 20:34:27.000000000","message":"recheck need logs, dependency resolution locally is \u003e30 minutes.","commit_id":"3292513f90d18fbb6bfd361273eb1bfc45c7b7a5"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"7383544be204dcdaefc050cb4cf52a199147ea6d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"79f7dafa_14f34033","updated":"2022-09-12 19:08:58.000000000","message":"recheck would like fresh failure logs","commit_id":"3292513f90d18fbb6bfd361273eb1bfc45c7b7a5"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"5dc8ffa7e38ade0da16ba7f32ffdf81de60fab62","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"f9fe4bb5_f8445287","updated":"2022-09-16 21:20:33.000000000","message":"I couldn\u0027t figure out how to get the unit test working, and neither could Julia. This is an issue that needs fixing, but I don\u0027t think the mocks in test_session.py are good enough to understand params (or my brain isn\u0027t good enough to understand the mocks)","commit_id":"689dd7a8e2d30daeba6dd94b18e15d61eaf9bdea"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"00dbb0f23a1de041f4202c74dd1e5bdfbc49bd1d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e12e2e3a_4018ea0d","in_reply_to":"f9fe4bb5_f8445287","updated":"2022-09-20 19:00:30.000000000","message":"I concur, I seriously considered dropping the tests, and had reached out to a keystone core who was also unable to reproduce the test issue. :\\","commit_id":"689dd7a8e2d30daeba6dd94b18e15d61eaf9bdea"},{"author":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"change_message_id":"f25fefdbbea50c0f3aa7b16f58c6249938f5bb1e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"a0f1084e_a4662af1","updated":"2023-05-11 15:23:54.000000000","message":"This looks good but I can\u0027t approve since I helped write the tests. Please someone else from the team look at it :)","commit_id":"ddcafb04c0f703001c469fa14530e23a5acb54ce"},{"author":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"change_message_id":"dca26fe613bd3727a6a2ca127a55b2fb7fcbb1b8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"17447dda_d95496ed","updated":"2023-10-06 14:22:15.000000000","message":"This had the approvals before the rebase, LGTM","commit_id":"74f05249d1df2cdfe7836c7ef096f864d18d7201"}],"keystoneauth1/session.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"31a07293a270e6487332b487012972b6f6b31da1","unresolved":true,"context_lines":[{"line_number":1091,"context_line":"                if \u0027params\u0027 in kwargs:"},{"line_number":1092,"context_line":"                    for k,v in kwargs[\u0027params\u0027]:"},{"line_number":1093,"context_line":"                        expected_string \u003d f\"{k}\u003d{v}\""},{"line_number":1094,"context_line":"                        if expected_string not in location:"},{"line_number":1095,"context_line":"                            redirect_params[k] \u003d v"},{"line_number":1096,"context_line":"                kwargs[\u0027params\u0027] \u003d redirect_params"},{"line_number":1097,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"8b7ff1a8_b320b606","line":1094,"updated":"2022-05-10 07:59:35.000000000","message":"The pure requests library does not do this, I wonder why we should? At the very least, this will not work correctly with non-trivial types. Passing a list results in two parameters.","commit_id":"736935582b349dde0c72b43da7e6e8b66b600aa6"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"5d1a4f724206b66b80ef18e41834373e48e027c6","unresolved":false,"context_lines":[{"line_number":1091,"context_line":"                if \u0027params\u0027 in kwargs:"},{"line_number":1092,"context_line":"                    for k,v in kwargs[\u0027params\u0027]:"},{"line_number":1093,"context_line":"                        expected_string \u003d f\"{k}\u003d{v}\""},{"line_number":1094,"context_line":"                        if expected_string not in location:"},{"line_number":1095,"context_line":"                            redirect_params[k] \u003d v"},{"line_number":1096,"context_line":"                kwargs[\u0027params\u0027] \u003d redirect_params"},{"line_number":1097,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da5591c2_536ec4bf","line":1094,"in_reply_to":"45244187_3d9ef607","updated":"2022-07-20 20:34:27.000000000","message":"Done","commit_id":"736935582b349dde0c72b43da7e6e8b66b600aa6"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"6e7f4d04aad3ba0e4ca0d7e79fe5214f57ec074b","unresolved":true,"context_lines":[{"line_number":1091,"context_line":"                if \u0027params\u0027 in kwargs:"},{"line_number":1092,"context_line":"                    for k,v in kwargs[\u0027params\u0027]:"},{"line_number":1093,"context_line":"                        expected_string \u003d f\"{k}\u003d{v}\""},{"line_number":1094,"context_line":"                        if expected_string not in location:"},{"line_number":1095,"context_line":"                            redirect_params[k] \u003d v"},{"line_number":1096,"context_line":"                kwargs[\u0027params\u0027] \u003d redirect_params"},{"line_number":1097,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"b47bcc5f_54e49245","line":1094,"in_reply_to":"8b7ff1a8_b320b606","updated":"2022-05-10 13:48:20.000000000","message":"So what are you thinking? Just drop all params and hope?","commit_id":"736935582b349dde0c72b43da7e6e8b66b600aa6"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b19fcbc8e66bb29140874397db0c8515bcab21ad","unresolved":true,"context_lines":[{"line_number":1091,"context_line":"                if \u0027params\u0027 in kwargs:"},{"line_number":1092,"context_line":"                    for k,v in kwargs[\u0027params\u0027]:"},{"line_number":1093,"context_line":"                        expected_string \u003d f\"{k}\u003d{v}\""},{"line_number":1094,"context_line":"                        if expected_string not in location:"},{"line_number":1095,"context_line":"                            redirect_params[k] \u003d v"},{"line_number":1096,"context_line":"                kwargs[\u0027params\u0027] \u003d redirect_params"},{"line_number":1097,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"45244187_3d9ef607","line":1094,"in_reply_to":"b47bcc5f_54e49245","updated":"2022-05-10 13:50:01.000000000","message":"Yeah, I suggest we drop the params. If the server also drops the params, at least the Python\u0027s requests will be broken IMO.","commit_id":"736935582b349dde0c72b43da7e6e8b66b600aa6"}]}