)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"change_message_id":"f0db5e0b9557d4e3e5608bb992ea393c011ba603","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"63b7e225_bfa02a68","updated":"2022-12-20 14:18:00.000000000","message":"This looks good, but can you please help me understand the behavior better?\n\nHow does the data returned look from Barbican without the microversion header and with? What version is the client expected to send (given that this is the discovery step for versions). ","commit_id":"e0950b639fd4ae82efe91f05276af66bb81a30ce"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"4da018c5c68560d71537208dac7837631a7c7e6b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f97f877c_5ba8b161","in_reply_to":"63b7e225_bfa02a68","updated":"2022-12-20 14:24:57.000000000","message":"Without the microversion, barbican, for backward compatibility returns an older output format, so for example, the following is the output without the microversion header:\n\n{\n  \"versions\": {\n    \"values\": [\n      {\n        \"id\": \"v1\",\n        \"status\": \"stable\",\n        \"links\": [\n          {\n            \"rel\": \"self\",\n            \"href\": \"http://localhost:9311/v1/\"\n          },\n          {\n            \"rel\": \"describedby\",\n            \"type\": \"text/html\",\n            \"href\": \"https://docs.openstack.org/\"\n          }\n        ],\n        \"media-types\": [\n          {\n            \"base\": \"application/json\",\n            \"type\": \"application/vnd.openstack.key-manager-v1+json\"\n          }\n        ]\n      }\n    ]\n  }\n}\n\n\nand below output with the microversion header:\n\n{\n  \"versions\": [\n    {\n      \"id\": \"v1\",\n      \"status\": \"CURRENT\",\n      \"min_version\": \"1.0\",\n      \"max_version\": \"1.1\",\n      \"links\": [\n        {\n          \"rel\": \"self\",\n          \"href\": \"http://localhost:9311/v1/\"\n        },\n        {\n          \"rel\": \"describedby\",\n          \"type\": \"text/html\",\n          \"href\": \"https://docs.openstack.org/\"\n        }\n      ]\n    }\n  ]\n}","commit_id":"e0950b639fd4ae82efe91f05276af66bb81a30ce"}],"keystoneauth1/discover.py":[{"author":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"change_message_id":"8a2f8c21d1124e6b4507f13d42774e5eacbf6612","unresolved":true,"context_lines":[{"line_number":102,"context_line":"    \"\"\""},{"line_number":103,"context_line":"    headers \u003d {\u0027Accept\u0027: \u0027application/json\u0027}"},{"line_number":104,"context_line":"    if microversion_header:"},{"line_number":105,"context_line":"        headers[\u0027OpenStack-API-Version\u0027] \u003d microversion_header"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    try:"},{"line_number":108,"context_line":"        resp \u003d session.get(url, headers\u003dheaders, authenticated\u003dauthenticated)"}],"source_content_type":"text/x-python","patch_set":5,"id":"0a5878b9_352ace7b","line":105,"updated":"2022-12-20 14:48:31.000000000","message":"Due to the header being called `API Version` rather than `Microversion`, I would like to see this renamed to `version_header`. But otherwise this looks good and I\u0027ll +2.","commit_id":"e0950b639fd4ae82efe91f05276af66bb81a30ce"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"c007254d3d286932feef389da7ad17bd66a4329f","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    \"\"\""},{"line_number":103,"context_line":"    headers \u003d {\u0027Accept\u0027: \u0027application/json\u0027}"},{"line_number":104,"context_line":"    if microversion_header:"},{"line_number":105,"context_line":"        headers[\u0027OpenStack-API-Version\u0027] \u003d microversion_header"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    try:"},{"line_number":108,"context_line":"        resp \u003d session.get(url, headers\u003dheaders, authenticated\u003dauthenticated)"}],"source_content_type":"text/x-python","patch_set":5,"id":"480734ae_e8c92a7f","line":105,"in_reply_to":"0a5878b9_352ace7b","updated":"2022-12-20 17:49:42.000000000","message":"Done","commit_id":"e0950b639fd4ae82efe91f05276af66bb81a30ce"}]}
