)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a71479e37b2ce38dbf1f36f1e621e01084a191e1","unresolved":true,"context_lines":[{"line_number":13,"context_line":"in a centos based job yet. Example of the failed job can be"},{"line_number":14,"context_line":"found in [1], I extracted a traceback, which leads to keystoneauth1"},{"line_number":15,"context_line":"into [2]. According to [3] and [4] using copy() should help with"},{"line_number":16,"context_line":"the issue"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"[1] https://zuul.opendev.org/t/openstack/build/c99db592871a441e9cddad2f4e60c2fc/console"},{"line_number":19,"context_line":"[2] https://paste.opendev.org/show/bpzng2EUyFh1tvBHczt7/"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"a89cd549_ff6cffc4","line":16,"updated":"2023-11-09 15:01:11.000000000","message":"Probably worth adding that the docs now indicate this [1] since [2] was merged.\n\n[1] https://docs.python.org/3/library/sys.html#sys.modules\n[2] https://github.com/python/cpython/pull/28842","commit_id":"b8b470ba7aab3a3fef05f83bde2907b69ec6981b"},{"author":{"_account_id":34975,"name":"Jaromír Wysoglad","email":"jwysogla@redhat.com","username":"jwysogla"},"change_message_id":"db4a0be4c727b11873bb4bdeb75b654bc6f6ce85","unresolved":false,"context_lines":[{"line_number":13,"context_line":"in a centos based job yet. Example of the failed job can be"},{"line_number":14,"context_line":"found in [1], I extracted a traceback, which leads to keystoneauth1"},{"line_number":15,"context_line":"into [2]. According to [3] and [4] using copy() should help with"},{"line_number":16,"context_line":"the issue"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"[1] https://zuul.opendev.org/t/openstack/build/c99db592871a441e9cddad2f4e60c2fc/console"},{"line_number":19,"context_line":"[2] https://paste.opendev.org/show/bpzng2EUyFh1tvBHczt7/"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"330ae538_63dc4c50","line":16,"in_reply_to":"a89cd549_ff6cffc4","updated":"2023-11-09 15:40:15.000000000","message":"I added the docs link to the commit message","commit_id":"b8b470ba7aab3a3fef05f83bde2907b69ec6981b"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":34975,"name":"Jaromír Wysoglad","email":"jwysogla@redhat.com","username":"jwysogla"},"change_message_id":"d113a423d78eb7ba3d8ee9c5e62e1a963049f0f7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0e63fa81_862d2852","updated":"2023-11-09 18:46:34.000000000","message":"CCing you two, since you hit / saw the issue previously too.","commit_id":"3b492a7aa0bcb73c7fff62c8e7b1cd5d42118fbe"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"07219bcb6a39afcf539f5f12a7ab67f5f68476b3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ad422b7f_25268fec","updated":"2023-11-10 09:24:33.000000000","message":"Makes very clear sense. Comments by Stephen have been addressed.","commit_id":"3b492a7aa0bcb73c7fff62c8e7b1cd5d42118fbe"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"27bee3f37e4c150089707e513ca1633672944777","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ad8f71e2_9d44a941","updated":"2023-11-21 14:47:07.000000000","message":"since this patch has already 2 +2, what would it take to get a +W?","commit_id":"3b492a7aa0bcb73c7fff62c8e7b1cd5d42118fbe"}],"keystoneauth1/session.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a71479e37b2ce38dbf1f36f1e621e01084a191e1","unresolved":true,"context_lines":[{"line_number":153,"context_line":"    # module does this but is far less efficient. Same story with the"},{"line_number":154,"context_line":"    # frame walking below.  One could use ``inspect.stack()`` but it"},{"line_number":155,"context_line":"    # has far more overhead."},{"line_number":156,"context_line":"    mod_lookup \u003d dict((m.__file__, n) for n, m in sys.modules.copy().items()"},{"line_number":157,"context_line":"                      if hasattr(m, \u0027__file__\u0027))"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    # NOTE(shaleh): these are not useful because they hide the real"}],"source_content_type":"text/x-python","patch_set":1,"id":"56164ac2_ed92e1ab","line":156,"updated":"2023-11-09 15:01:11.000000000","message":"Can you add a note here explaining why the copy is here? A link to the doc I noted in the commit message would likely do the trick.","commit_id":"b8b470ba7aab3a3fef05f83bde2907b69ec6981b"},{"author":{"_account_id":34975,"name":"Jaromír Wysoglad","email":"jwysogla@redhat.com","username":"jwysogla"},"change_message_id":"db4a0be4c727b11873bb4bdeb75b654bc6f6ce85","unresolved":false,"context_lines":[{"line_number":153,"context_line":"    # module does this but is far less efficient. Same story with the"},{"line_number":154,"context_line":"    # frame walking below.  One could use ``inspect.stack()`` but it"},{"line_number":155,"context_line":"    # has far more overhead."},{"line_number":156,"context_line":"    mod_lookup \u003d dict((m.__file__, n) for n, m in sys.modules.copy().items()"},{"line_number":157,"context_line":"                      if hasattr(m, \u0027__file__\u0027))"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    # NOTE(shaleh): these are not useful because they hide the real"}],"source_content_type":"text/x-python","patch_set":1,"id":"8f5e78a9_aa8aeb07","line":156,"in_reply_to":"56164ac2_ed92e1ab","updated":"2023-11-09 15:40:15.000000000","message":"I added a note with a link to the docs into the code as you suggested. Thanks for the review","commit_id":"b8b470ba7aab3a3fef05f83bde2907b69ec6981b"}]}