)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"75cba2287e3c40d493d7d8baaef3e39556bf9b84","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Tatsuya Hayashino \u003ctatsuya.hayashino@lycorp.co.jp\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-02-16 10:52:55 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Output verification_uri_complete as stderr"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit changes the output of verification_uri_complete from using"},{"line_number":10,"context_line":"print to using _logger.warning."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"97d379db_266d685a","line":7,"range":{"start_line":7,"start_character":33,"end_line":7,"end_character":42},"updated":"2024-02-16 04:21:51.000000000","message":"by logger ?","commit_id":"97732cf2028a30d024af4bc50c439ec827e9c03f"},{"author":{"_account_id":36776,"name":"Tatsuya Hayashino","display_name":"Tatsuya Hayashino","email":"tatsuya.hayashino@lycorp.co.jp","username":"tatsuya.hayashino"},"change_message_id":"b8925addb5bdd5834630400243d5a94df698d685","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Tatsuya Hayashino \u003ctatsuya.hayashino@lycorp.co.jp\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-02-16 10:52:55 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Output verification_uri_complete as stderr"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit changes the output of verification_uri_complete from using"},{"line_number":10,"context_line":"print to using _logger.warning."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"4256ce0e_a1cd18cc","line":7,"range":{"start_line":7,"start_character":33,"end_line":7,"end_character":42},"in_reply_to":"97d379db_266d685a","updated":"2024-02-16 06:57:44.000000000","message":"I fixed it.","commit_id":"97732cf2028a30d024af4bc50c439ec827e9c03f"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"152b314217c707d6d982603906f93f5bc73c0c4d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5188a627_494c5cd2","updated":"2024-02-15 08:28:25.000000000","message":"Why do we use print at the first place ? This module may be technically used by server components and usage of print within this library looks inappropriate. We should replace it by _logger call. If a specific user output is required then it should be implemented in openstackclient.","commit_id":"8167abf164700a97c635ec21243aa60403729c92"},{"author":{"_account_id":36776,"name":"Tatsuya Hayashino","display_name":"Tatsuya Hayashino","email":"tatsuya.hayashino@lycorp.co.jp","username":"tatsuya.hayashino"},"change_message_id":"a1709417666901c3e74ce0fa185be5a70ef7e8f6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"405c702b_b25d7e81","in_reply_to":"1050c540_fea8822a","updated":"2024-02-15 10:42:02.000000000","message":"Thank you for your quick feedback!\n\n\u003e so I\u0027d suggest you first try this approach:\n\u003e https://review.opendev.org/c/openstack/keystoneauth/+/909073 .\n\nI have tested the changes you proposed in my environment and confirmed that they work as I desired.\n\n\u003e Why do we use print at the first place ?\n\nThe only reason I used print was that the existing code used print.\nI would like to abandon this commit and wait for your changes to be merged.","commit_id":"8167abf164700a97c635ec21243aa60403729c92"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"75cba2287e3c40d493d7d8baaef3e39556bf9b84","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6eea6dc7_f9217e92","in_reply_to":"28dc3d94_53c6d213","updated":"2024-02-16 04:21:51.000000000","message":"Thanks !","commit_id":"8167abf164700a97c635ec21243aa60403729c92"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b613ebd42d0e41144dee29e1ad0e6908ac709f05","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"560864c8_72734e22","in_reply_to":"405c702b_b25d7e81","updated":"2024-02-15 11:31:08.000000000","message":"I don\u0027t have actual env to test my change, so if you can test it in your local env then feel free to use that code change and update this patch. I\u0027ll abandone MINE once this is updated.\n\nWhen you update this change, do you mind taking care of the following favors ?\n\n* Create a bug here ? and describe the problem with current implementation (usage of print in library, which can collapse output)\n\nhttps://bugs.launchpad.net/keystoneauth\n\n* Add `Closes-bug: #\u003cnumber\u003e` in the commit message (and probably update the commit message to explain usage of print is the core problem here)","commit_id":"8167abf164700a97c635ec21243aa60403729c92"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"9077c4bcf0e9e1af0bc2a00ecd4def675f788d92","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1050c540_fea8822a","in_reply_to":"5188a627_494c5cd2","updated":"2024-02-15 08:39:27.000000000","message":"AFAIK all warnings logs are directed to stderr in case these codes are called from openstack CLI, so I\u0027d suggest you first try this approach: https://review.opendev.org/c/openstack/keystoneauth/+/909073 .","commit_id":"8167abf164700a97c635ec21243aa60403729c92"},{"author":{"_account_id":36776,"name":"Tatsuya Hayashino","display_name":"Tatsuya Hayashino","email":"tatsuya.hayashino@lycorp.co.jp","username":"tatsuya.hayashino"},"change_message_id":"780eb43932866674e0aefc33bbfc983d78ef136b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"28dc3d94_53c6d213","in_reply_to":"560864c8_72734e22","updated":"2024-02-16 02:04:08.000000000","message":"* bug report: https://bugs.launchpad.net/keystoneauth/+bug/2053292\n* Update this patch\n  * Update the code to use _logger.warning()\n  * Update commit message\n    * Add description that \"print should not be used\"\n    * Add Closes-bug: #2053292\n* I have tested this code my local env with openstack cli, verification URL is output as stderr without --debug option.","commit_id":"8167abf164700a97c635ec21243aa60403729c92"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"75cba2287e3c40d493d7d8baaef3e39556bf9b84","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e9b55577_cc2c715a","updated":"2024-02-16 04:21:51.000000000","message":"The change looks almost good. One suggestion about commit title.","commit_id":"97732cf2028a30d024af4bc50c439ec827e9c03f"},{"author":{"_account_id":33451,"name":"Yushiro Furukawa","display_name":"Yushiro Furukawa","email":"yushiro.furukawa@lycorp.co.jp","username":"yushiro2"},"change_message_id":"087a0fa9e9dc54820e9cb2395d032f4b18d02b73","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7b66ede7_a9795851","updated":"2024-02-20 07:12:31.000000000","message":"LGTM now.","commit_id":"cabcb705e8d2e7d9f7d57fba87174c1ee5b48c26"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"aab594f6910864f7d909bf7c329bb57f752f98b6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"56d74f4d_db52e2f0","updated":"2024-02-16 07:00:05.000000000","message":"Thanks !","commit_id":"cabcb705e8d2e7d9f7d57fba87174c1ee5b48c26"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"01a03285da2e3fff7a47b458857f98cebfd83fb1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e295b3fb_67c48319","updated":"2024-06-30 04:44:55.000000000","message":"recheck","commit_id":"cabcb705e8d2e7d9f7d57fba87174c1ee5b48c26"}]}