)]}'
{"id":"openstack%2Fkeystoneauth~928808","triplet_id":"openstack%2Fkeystoneauth~master~I23b09662d900eb35b4ac4116520e8d1ac825a6af","project":"openstack/keystoneauth","branch":"master","topic":"typing","attention_set":{},"removed_from_attention_set":{"15334":{"account":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"last_update":"2024-09-27 16:17:34.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I23b09662d900eb35b4ac4116520e8d1ac825a6af","subject":"typing: Synchronise overridden method signatures","status":"MERGED","created":"2024-09-10 14:06:30.000000000","updated":"2024-09-27 16:19:17.000000000","submitted":"2024-09-27 16:17:34.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"928808-typing","meta_rev_id":"2353bccf5b34e266919164f98c8cdaa95a4cb1dc","_number":928808,"virtual_id_number":928808,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2024-09-27 16:17:34.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},{"value":0,"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2024-09-11 17:44:56.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},{"value":2,"date":"2024-09-27 14:36:50.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},{"value":1,"date":"2024-09-27 14:36:50.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-09-10 15:46:55.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-09-11 15:44:55.000000000","updated_by":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"reviewer":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"state":"REVIEWER"},{"updated":"2024-09-27 14:36:50.000000000","updated_by":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"reviewer":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"state":"REVIEWER"}],"messages":[{"id":"d9484d6cc6045d128de981bc50a4e9738cfb8b96","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2024-09-10 14:06:30.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f5572e9f7d2f76b03f644678f1bd5279a9ff4fd0","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-09-10 15:46:55.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/1a6f4a2796a34eab8522c03318bbaf84\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/88eb126ae90d4b378d76e832fb6ec579 : SUCCESS in 1h 34m 18s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/f14ddaaa33544f2480271c6cc399eb3f : SUCCESS in 3m 20s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/5ccc9e1f0d0b4b7ea1aada62f3e701ad : SUCCESS in 7m 34s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/5dec0a73edc14897b822928967d7781c : SUCCESS in 7m 11s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/ec0cbb9c16404069ab71b9ff8c130754 : SUCCESS in 8m 25s (non-voting)\n- openstacksdk-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/89e3b267ecb14654b09c4cf893b9f43e : SUCCESS in 50m 22s\n- osc-tox-py38-tips https://zuul.opendev.org/t/openstack/build/9af53945b824477dbc6f2a7e319952bb : SUCCESS in 5m 10s\n- osc-tox-py312-tips https://zuul.opendev.org/t/openstack/build/5eb7cfc2e22e4bdf8ba559e6deb093bd : SUCCESS in 5m 46s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/2fdd120159fb4870821e52ff313a98fc : SUCCESS in 5m 29s","accounts_in_message":[],"_revision_number":1},{"id":"2eeb1a1a025f36b1c6a35ae50146ecadddefa87f","author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"date":"2024-09-11 15:44:55.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"e95f2aeda17421fa85101141dd054bf2c080af9d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2024-09-11 17:44:56.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.\n\nCopied Votes:\n* Code-Review+2 (copy condition: \"**changekind:TRIVIAL_REBASE** OR is:MIN\")\n\nOutdated Votes:\n* Verified+1\n","accounts_in_message":[],"_revision_number":2},{"id":"f7b99a531cbc28650627847e05ec0e0a2e1bfda1","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-09-11 19:14:27.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/31737e7a30d644b39d1cae65baafc4ae\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/3d74f026b783463fbbfd8234f2d77802 : SUCCESS in 1h 28m 30s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/25cafa52ec7b47d8a59f097b86243cd6 : SUCCESS in 3m 31s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/d053866888034cb7bd23af9e09a481ad : SUCCESS in 8m 25s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/8adca8ebc1a8437dbc5ce774ca1efb00 : SUCCESS in 7m 31s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/b72d6e7afdb5405984e142e342f01ed8 : SUCCESS in 9m 24s (non-voting)\n- openstacksdk-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/ea5f6a0a2ef34ba78dbb2c150fe27a45 : SUCCESS in 53m 19s\n- osc-tox-py38-tips https://zuul.opendev.org/t/openstack/build/1e576b5e770840e3a888c868ceab318f : SUCCESS in 5m 58s\n- osc-tox-py312-tips https://zuul.opendev.org/t/openstack/build/5e25ee3730a64a24afc65b6f2a5ee44c : SUCCESS in 7m 39s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ad6653785bb645a7a9da20777c712aba : SUCCESS in 6m 09s","accounts_in_message":[],"_revision_number":2},{"id":"dcbf8192a92ae7f02844ac6814562d6724e8189f","author":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"date":"2024-09-27 14:36:50.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"6d45aeddf8f54d5e5e9b98fb1835d360d963a8ff","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-09-27 14:37:26.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"7b228dfaf36991f9475fef4e05c68b399bda601e","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-09-27 16:17:34.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/e100b2df3d0243a0852effa58dab0934\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/10d04aaacd9d430e8337b02575726585 : SUCCESS in 1h 39m 42s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/baa7f147f2494ecbb72d6f5034776f7c : SUCCESS in 2m 42s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/f60e84cbd0974dec99fc07529931016b : SUCCESS in 8m 06s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/ab92a878ad754cbf9a86ed650b60fcaf : SUCCESS in 7m 34s\n- openstacksdk-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/3c4e2da787e84354af40d8da5e91a46b : SUCCESS in 25m 22s\n- osc-tox-py39-tips https://zuul.opendev.org/t/openstack/build/8551d0fcf98645df855e35e7a058b217 : SUCCESS in 5m 56s\n- osc-tox-py312-tips https://zuul.opendev.org/t/openstack/build/3da48eafdc73426f81d6514ad125c16a : SUCCESS in 5m 02s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/52dac15a5c184957b677b44c42edef50 : SUCCESS in 6m 24s","accounts_in_message":[],"_revision_number":2},{"id":"94d74d8840ffa6e437f72bf5f0e5595b7193b41a","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-09-27 16:17:34.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":2},{"id":"2353bccf5b34e266919164f98c8cdaa95a4cb1dc","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-09-27 16:19:17.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/dbf0c21b8c3946118648eea34cc095cc\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/4f76928ca73241fb921457d841144b26 : SUCCESS in 56s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"b1f71c9db6ac4bc2ed7d950263c9ebaf109e6169","revisions":{"6176b3a31dd7b840d7ebfaf193e944e9dae0c4c7":{"kind":"REWORK","_number":1,"created":"2024-09-10 14:06:30.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/08/928808/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystoneauth","ref":"refs/changes/08/928808/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystoneauth refs/changes/08/928808/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystoneauth refs/changes/08/928808/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystoneauth refs/changes/08/928808/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystoneauth refs/changes/08/928808/1"}}},"commit":{"parents":[{"commit":"a8e1a95b2da4b162fa15c8fa9f5d6bd25f9d0112","subject":"typing: Make abstract method actually abstract","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystoneauth/commit/a8e1a95b2da4b162fa15c8fa9f5d6bd25f9d0112"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2024-07-30 13:38:08.000000000","tz":60},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2024-09-10 09:41:58.000000000","tz":60},"subject":"typing: Synchronise overridden method signatures","message":"typing: Synchronise overridden method signatures\n\nResolve a whole class of errors like the following:\n\n    error: Signature of \"get_auth_data\" incompatible with supertype \"AuthMethod\"  [override]\n    note:      Superclass:\n    note:          def get_auth_data(self, session: Any, auth: Any, headers: Any, **kwargs: Any) -\u003e Any\n    note:      Subclass:\n    note:          def get_auth_data(self, session: Any, auth: Any, headers: Any, request_kwargs: Any, **kwargs: Any) -\u003e Any\n\nIn most cases this involves adding a redundant kwargs argument to match\nthe (also redundant) kwargs argument on the superclass. We can remove\nthese everywhere at a later date.\n\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\nChange-Id: I23b09662d900eb35b4ac4116520e8d1ac825a6af\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystoneauth/commit/6176b3a31dd7b840d7ebfaf193e944e9dae0c4c7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystoneauth/commit/6176b3a31dd7b840d7ebfaf193e944e9dae0c4c7"}]},"branch":"refs/heads/master"},"b1f71c9db6ac4bc2ed7d950263c9ebaf109e6169":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2024-09-11 17:44:56.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/08/928808/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystoneauth","ref":"refs/changes/08/928808/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystoneauth refs/changes/08/928808/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystoneauth refs/changes/08/928808/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystoneauth refs/changes/08/928808/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystoneauth refs/changes/08/928808/2"}}},"commit":{"parents":[{"commit":"f07049bce985d1e2f8465e626d585b8b30cce2ef","subject":"typing: Make abstract method actually abstract","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystoneauth/commit/f07049bce985d1e2f8465e626d585b8b30cce2ef"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2024-07-30 13:38:08.000000000","tz":60},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2024-09-11 17:43:59.000000000","tz":60},"subject":"typing: Synchronise overridden method signatures","message":"typing: Synchronise overridden method signatures\n\nResolve a whole class of errors like the following:\n\n    error: Signature of \"get_auth_data\" incompatible with supertype \"AuthMethod\"  [override]\n    note:      Superclass:\n    note:          def get_auth_data(self, session: Any, auth: Any, headers: Any, **kwargs: Any) -\u003e Any\n    note:      Subclass:\n    note:          def get_auth_data(self, session: Any, auth: Any, headers: Any, request_kwargs: Any, **kwargs: Any) -\u003e Any\n\nIn most cases this involves adding a redundant kwargs argument to match\nthe (also redundant) kwargs argument on the superclass. We can remove\nthese everywhere at a later date.\n\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\nChange-Id: I23b09662d900eb35b4ac4116520e8d1ac825a6af\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystoneauth/commit/b1f71c9db6ac4bc2ed7d950263c9ebaf109e6169"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystoneauth/commit/b1f71c9db6ac4bc2ed7d950263c9ebaf109e6169"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}