)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"59a46062c1ce3970978e307239ceb0b3dd4ef58a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"66c33d1f_e543f481","updated":"2024-11-20 11:43:52.000000000","message":"This is the wrong approach to take here. lxml is already a dependency but it\u0027s optional. You can install it with keystoneauth like so:\n\n```\npip install keystoneauth[saml2]\n```\n\nWhat you likely want to do here is to replace the else condition in the branch. Instead of setting `etree` to `None`, you could raise a custom exception complaining about the missing optional library. Then users/packagers could fix that issue.","commit_id":"b9cf6d75abfa4551cafd3a469d5a77c061ad64bb"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8af533f185f5e4cbd4c3b54d0ae9dc8900410cbc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"88906702_c98ff41d","in_reply_to":"66c33d1f_e543f481","updated":"2024-11-20 11:44:28.000000000","message":"Alternatively, we can make it a non-optional dependency, but then we need to remove the try-except blocks and remove the extra from `setup.cfg`.","commit_id":"b9cf6d75abfa4551cafd3a469d5a77c061ad64bb"}]}