)]}'
{"id":"openstack%2Fkeystoneauth~935766","triplet_id":"openstack%2Fkeystoneauth~master~I239dc34fdcbff9bd658dc89ddb1536c7f0df9395","project":"openstack/keystoneauth","branch":"master","topic":"typing","attention_set":{},"removed_from_attention_set":{"15334":{"account":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"last_update":"2025-02-05 17:53:01.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I239dc34fdcbff9bd658dc89ddb1536c7f0df9395","subject":"typing: Remove unused BaseAuthPlugin.get_auth_ref kwargs","status":"MERGED","created":"2024-11-20 11:34:19.000000000","updated":"2025-02-05 17:53:01.000000000","submitted":"2025-02-05 17:53:01.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"935766-typing","meta_rev_id":"c5ce6757be95a93616dc8c36f451fce064a50924","_number":935766,"virtual_id_number":935766,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},{"value":0,"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2025-02-05 17:53:01.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"all":[{"value":2,"date":"2025-01-24 15:18:47.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},{"value":2,"date":"2025-02-05 14:05:24.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"all":[{"value":0,"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},{"value":1,"date":"2025-02-05 14:05:24.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-11-20 13:21:25.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-01-17 14:07:34.000000000","updated_by":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"reviewer":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"state":"REVIEWER"},{"updated":"2025-02-05 14:05:24.000000000","updated_by":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"reviewer":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"state":"REVIEWER"}],"messages":[{"id":"b8c21b9815563dce64340ce26e483d6be4ea72e2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2024-11-20 11:34:19.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"42751d057eb53a7b744c0a494f7c0b82ff8b2fc4","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-11-20 13:21:25.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/f9f88e1c0ef3424f8170db218db6be28\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/cfd73595435840ea839328c9d34951ba : SUCCESS in 1h 40m 28s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/9f38b5b3ba5d4fb58f84f4886e7cccaa : SUCCESS in 2m 56s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/a55564fc49ff4c02af0393c2de4db820 : SUCCESS in 7m 56s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/ad74a1d51bd4433aa5dfc4afd5a64f7a : SUCCESS in 9m 14s\n- openstacksdk-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/9037228b894345939f99a9df81f073da : SUCCESS in 57m 09s\n- osc-tox-py39-tips https://zuul.opendev.org/t/openstack/build/e33a2e55a4384809b4dce92af4f90580 : SUCCESS in 5m 18s\n- osc-tox-py312-tips https://zuul.opendev.org/t/openstack/build/f7f9ecf79418403bbd4bf55c55e1123c : SUCCESS in 6m 02s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/4ec1b359286a49b68d5f32e6aef8241d : SUCCESS in 6m 52s","accounts_in_message":[],"_revision_number":1},{"id":"417d3854e4ef1bc31149a2f762d4c646dac692cb","author":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"date":"2025-01-17 14:07:34.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"1d51c7fc30902f0545a3bb18b60cd169c502f1cb","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2025-01-24 15:18:47.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.\n\nCopied Votes:\n* Code-Review+2 (copy condition: \"**changekind:TRIVIAL_REBASE** OR is:MIN\")\n\nOutdated Votes:\n* Verified+1\n","accounts_in_message":[],"_revision_number":2},{"id":"cd8e29d9c15d152619f22098a26834a3e20be8f6","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-01-24 16:55:03.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/cba7afbc46de4421b36ce553a65c1619\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/4eae69a7690d429e80cb68c0d3310365 : SUCCESS in 1h 33m 37s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/12ccfc2efcdf4ae48ce551031762da21 : SUCCESS in 4m 06s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/ec52b799e7674e638d48c66d72ce831e : SUCCESS in 8m 21s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/9cda5b6642694ca9846604fa89beeb06 : SUCCESS in 9m 46s\n- openstacksdk-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/2306d5e9e01040fdbf331ae3c883609e : SUCCESS in 1h 08m 45s\n- osc-tox-py39-tips https://zuul.opendev.org/t/openstack/build/74b2da964cbc4a68b9c6072d2335815d : SUCCESS in 4m 26s\n- osc-tox-py312-tips https://zuul.opendev.org/t/openstack/build/92ed2b73d59d40f5bf458acbb827e7d3 : SUCCESS in 6m 23s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ad75925707554dbca80561eff913ec16 : SUCCESS in 8m 36s","accounts_in_message":[],"_revision_number":2},{"id":"0101514789264a46a7855e2739ec9f2b85eefadb","author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"date":"2025-02-05 14:05:24.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"14117537bcc951b015c0ae986b44beb6b840bf13","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-02-05 15:51:22.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"39f0a9f94b864c03e144b5fbb932182249b77991","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-02-05 17:53:01.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/b799b71490034f24b37a657d57f7b143\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/2919bf4c1da9461f9ee54f7b5661b128 : SUCCESS in 1h 50m 20s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/8fc0300a956642ec9f6194b4ffd81a2a : SUCCESS in 3m 43s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/3abf68e547fc417f8c70396b2515cb6e : SUCCESS in 7m 43s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/90d74e2ee0934eb394bea0c7370a2064 : SUCCESS in 8m 48s\n- openstacksdk-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/c5fb18b1e2c948e5a60358cb3dd9053b : SUCCESS in 52m 28s\n- osc-tox-py39-tips https://zuul.opendev.org/t/openstack/build/c01d8ee45b484801ace1523afae10555 : SUCCESS in 5m 48s\n- osc-tox-py312-tips https://zuul.opendev.org/t/openstack/build/c77d3bf5c80543b1a1b8c42bf56b9ec9 : SUCCESS in 4m 58s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/61c4bf93aac648ed9466b0da04b6b62e : SUCCESS in 6m 21s","accounts_in_message":[],"_revision_number":2},{"id":"c5ce6757be95a93616dc8c36f451fce064a50924","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-02-05 17:53:01.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"27d9fc7f0722300a38dd91382d90a1bd9ad1773d","revisions":{"48d36c1a960a455da6a97e51df55da1e3e5caba7":{"kind":"REWORK","_number":1,"created":"2024-11-20 11:34:19.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/66/935766/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystoneauth","ref":"refs/changes/66/935766/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystoneauth refs/changes/66/935766/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystoneauth refs/changes/66/935766/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystoneauth refs/changes/66/935766/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystoneauth refs/changes/66/935766/1"}}},"commit":{"parents":[{"commit":"33a9643481b5026e4190f18bdffc768c1eeab172","subject":"typing: Remove unused AuthMethod.get_auth_data arguments","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystoneauth/commit/33a9643481b5026e4190f18bdffc768c1eeab172"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2024-10-24 10:50:00.000000000","tz":60},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2024-11-01 17:09:46.000000000","tz":0},"subject":"typing: Remove unused BaseAuthPlugin.get_auth_ref kwargs","message":"typing: Remove unused BaseAuthPlugin.get_auth_ref kwargs\n\nAgain, nothing is using or requires these so their removal is easy. This\nactually highlights a bit of a TODO here though. There\u0027s a comment\nsuggesting that BaseAuthPlugin should not define get_access or\nget_auth_ref methods since these do not apply to non-keystone auth\nplugins. However, in change Iacfba0940beda4dce2a9be0c863cb506d4013e2f we\nadded \u0027BaseAuthPlugin.get_auth_ref\u0027, apparently because OSC was using\nkeystoneauth incorrectly. We should probably address this at some point\nbut a TODO is left for now.\n\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\nChange-Id: I239dc34fdcbff9bd658dc89ddb1536c7f0df9395\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystoneauth/commit/48d36c1a960a455da6a97e51df55da1e3e5caba7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystoneauth/commit/48d36c1a960a455da6a97e51df55da1e3e5caba7"}]},"branch":"refs/heads/master"},"27d9fc7f0722300a38dd91382d90a1bd9ad1773d":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2025-01-24 15:18:47.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/66/935766/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystoneauth","ref":"refs/changes/66/935766/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystoneauth refs/changes/66/935766/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystoneauth refs/changes/66/935766/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystoneauth refs/changes/66/935766/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystoneauth refs/changes/66/935766/2"}}},"commit":{"parents":[{"commit":"99fb3f53e3b91f73c5a5e23d56230e81d27fb9fb","subject":"typing: Remove unused AuthMethod.get_auth_data arguments","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystoneauth/commit/99fb3f53e3b91f73c5a5e23d56230e81d27fb9fb"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2024-10-24 10:50:00.000000000","tz":60},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2025-01-24 15:09:51.000000000","tz":0},"subject":"typing: Remove unused BaseAuthPlugin.get_auth_ref kwargs","message":"typing: Remove unused BaseAuthPlugin.get_auth_ref kwargs\n\nAgain, nothing is using or requires these so their removal is easy. This\nactually highlights a bit of a TODO here though. There\u0027s a comment\nsuggesting that BaseAuthPlugin should not define get_access or\nget_auth_ref methods since these do not apply to non-keystone auth\nplugins. However, in change Iacfba0940beda4dce2a9be0c863cb506d4013e2f we\nadded \u0027BaseAuthPlugin.get_auth_ref\u0027, apparently because OSC was using\nkeystoneauth incorrectly. We should probably address this at some point\nbut a TODO is left for now.\n\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\nChange-Id: I239dc34fdcbff9bd658dc89ddb1536c7f0df9395\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystoneauth/commit/27d9fc7f0722300a38dd91382d90a1bd9ad1773d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystoneauth/commit/27d9fc7f0722300a38dd91382d90a1bd9ad1773d"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}