)]}'
{"id":"openstack%2Fkeystoneauth~947669","triplet_id":"openstack%2Fkeystoneauth~stable%2F2025.1~I6e44e70394d51c9fca06d7f511d1ffe0d9b2c025","project":"openstack/keystoneauth","branch":"stable/2025.1","topic":"bug/2107373-stable/2025.1","attention_set":{},"removed_from_attention_set":{"14250":{"account":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"last_update":"2025-04-25 15:24:32.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I6e44e70394d51c9fca06d7f511d1ffe0d9b2c025","subject":"Fix bug in OIDC Device Authorization","status":"MERGED","created":"2025-04-18 14:46:26.000000000","updated":"2025-04-25 15:25:35.000000000","submitted":"2025-04-25 15:24:32.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"947669-bug/2107373-stable/2025.1","cherry_pick_of_change":947208,"cherry_pick_of_patch_set":5,"meta_rev_id":"38a7cd3ca4d9c1f1b714bd83c2bb71b6f703ed84","_number":947669,"virtual_id_number":947669,"owner":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},{"value":0,"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2025-04-25 15:24:32.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"all":[{"value":2,"date":"2025-04-18 14:46:57.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},{"value":2,"date":"2025-04-25 13:42:35.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"all":[{"value":0,"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},{"value":1,"date":"2025-04-25 13:42:35.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"}],"CC":[{"_account_id":36776,"name":"Tatsuya Hayashino","display_name":"Tatsuya Hayashino","email":"tatsuya.hayashino@lycorp.co.jp","username":"tatsuya.hayashino"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-04-18 14:46:26.000000000","updated_by":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"reviewer":{"_account_id":36776,"name":"Tatsuya Hayashino","display_name":"Tatsuya Hayashino","email":"tatsuya.hayashino@lycorp.co.jp","username":"tatsuya.hayashino"},"state":"CC"},{"updated":"2025-04-18 16:31:24.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-04-25 13:42:35.000000000","updated_by":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"reviewer":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"state":"REVIEWER"}],"messages":[{"id":"30de9e339b671f3bbac06084f7a24abeea54f5c0","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"date":"2025-04-18 14:46:26.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"9d84f176a754d2aecbdd83e818b18387f9d49d95","author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"date":"2025-04-18 14:46:57.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"20da271b1721dc821b37650b24b04dc7b42658d5","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-04-18 16:31:24.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/619a8b2e773b4f79b31e6010462b9832\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/80297b4f37a841b39bb9ab4f14f58110 : SUCCESS in 1h 40m 14s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ecf05ab26be946e4a4303cc5c467b4e1 : SUCCESS in 3m 24s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/0644f028dffb44949c36a7f94a6b1f4b : SUCCESS in 7m 43s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/a0135d0fb1084b578376e303b7e02164 : SUCCESS in 8m 03s\n- openstacksdk-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/60cc41d46d044c678a518897726e30cc : SUCCESS in 1h 02m 12s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/fdce27fe16f844ef9a5b71ea284d7197 : SUCCESS in 8m 41s","accounts_in_message":[],"_revision_number":1},{"id":"47dc09b57d7bec9b75751399a3c44365e2b24000","author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"date":"2025-04-25 13:42:35.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"502600706177a5302cf0a2f9d8bad48607db978e","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-04-25 13:42:55.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"998af4342b1949f80fa0fd418ebbb904f0e0b409","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-04-25 15:24:32.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/27c512b260fd4d45b9cbb573a60528a6\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/b41c438401894424ab70bf9b6d0e06b8 : SUCCESS in 1h 37m 25s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/1bb7fe7688d4462c99862b2b31c4ebfb : SUCCESS in 3m 10s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/5b7f4b50e9e142e798f0c26b8469c44c : SUCCESS in 7m 41s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/c64bd7053a6f47419c1bcb9f9c877012 : SUCCESS in 8m 44s\n- openstacksdk-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/f9cc752b223e4d6d86fabb4cefcb0828 : SUCCESS in 55m 26s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/76fad6c613dc4e9ba395e8c37805ad7a : SUCCESS in 7m 52s","accounts_in_message":[],"_revision_number":1},{"id":"21bb395a0424e109c1b860042a20b468bd908971","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-04-25 15:24:32.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"38a7cd3ca4d9c1f1b714bd83c2bb71b6f703ed84","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-04-25 15:25:35.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/952e7faefc8544589785c642c8246783\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/c5b70c50aac54037b014455f1efbd619 : SUCCESS in 55s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"7472cfd32d58f673aaaedfaf1f60df219fda46fe","revisions":{"7472cfd32d58f673aaaedfaf1f60df219fda46fe":{"kind":"REWORK","_number":1,"created":"2025-04-18 14:46:26.000000000","uploader":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"ref":"refs/changes/69/947669/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystoneauth","ref":"refs/changes/69/947669/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystoneauth refs/changes/69/947669/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystoneauth refs/changes/69/947669/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystoneauth refs/changes/69/947669/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystoneauth refs/changes/69/947669/1"}}},"commit":{"parents":[{"commit":"704b7360887d4a44ed254cdae63ec90ac4214291","subject":"Update TOX_CONSTRAINTS_FILE for stable/2025.1","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystoneauth/commit/704b7360887d4a44ed254cdae63ec90ac4214291"}]}],"author":{"name":"Tatsuya Hayashino","email":"tatsuya.hayashino@lycorp.co.jp","date":"2025-04-15 09:24:34.000000000","tz":540},"committer":{"name":"Grzegorz Grasza","email":"xek@redhat.com","date":"2025-04-18 14:46:26.000000000","tz":0},"subject":"Fix bug in OIDC Device Authorization","message":"Fix bug in OIDC Device Authorization\n\nThere are two bugs in the current device flow using keystoneauth:\n\n1. An issue where an error occurs if `client_secret` is not specified.\nIn the device flow, authentication should be possible without specifying\n`client_secret`[1] but the current implementation requires it.\nThis bug was introduced by the following patch:\n- https://review.opendev.org/c/openstack/keystoneauth/+/932989\n\n2. An issue with the polling process from the client in the device flow\nIn the device flow, polling is used to verify that the user has\nauthenticated. There is an issue with the process that checks for\nincomplete polling, causing the process to halt with an error:\n\"Unrecognized schema in response body. (HTTP 400)\"\nThis bug was introduced by the following patch update:\nhttps://review.opendev.org/c/openstack/keystoneauth/+/930769\n\n[1] https://datatracker.ietf.org/doc/html/rfc8628#section-5.6\n\nCloses-bug: #2107373\nChange-Id: I6e44e70394d51c9fca06d7f511d1ffe0d9b2c025\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystoneauth/commit/7472cfd32d58f673aaaedfaf1f60df219fda46fe"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystoneauth/commit/7472cfd32d58f673aaaedfaf1f60df219fda46fe"}]},"branch":"refs/heads/stable/2025.1"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}