)]}'
{"keystonemiddleware/auth_token.py":[{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"86185387794769ced4dd03a633a08ef6e37173b4","unresolved":false,"context_lines":[{"line_number":898,"context_line":"                # Token was retrieved from the cache. In this case, there\u0027s no"},{"line_number":899,"context_line":"                # need to check that the token is expired because the cache"},{"line_number":900,"context_line":"                # fetch fails for an expired token. Also, there\u0027s no need to"},{"line_number":901,"context_line":"                # put the token in the cache because it\u0027s already in the cache."},{"line_number":902,"context_line":""},{"line_number":903,"context_line":"                data \u003d cached"},{"line_number":904,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_274e0339","line":901,"updated":"2014-06-25 04:52:37.000000000","message":"I disagree that it is a given that expiration check on cached items is not needed. This is assuming that the interaction between the middleware and the cache system honors both the TTL and sets it. This may not always be the case (or even now be the case since it is possible to uses a memory cache implementation from the environment.\n\nWe should still check expiry.  The rest of the assertions here in the comment are correct.","commit_id":"7428413036c9463b8201bc6c38a2dc627fd8aa44"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"7bd02de0a4755a66eae8bdd43695939c666d6064","unresolved":false,"context_lines":[{"line_number":898,"context_line":"                # Token was retrieved from the cache. In this case, there\u0027s no"},{"line_number":899,"context_line":"                # need to check that the token is expired because the cache"},{"line_number":900,"context_line":"                # fetch fails for an expired token. Also, there\u0027s no need to"},{"line_number":901,"context_line":"                # put the token in the cache because it\u0027s already in the cache."},{"line_number":902,"context_line":""},{"line_number":903,"context_line":"                data \u003d cached"},{"line_number":904,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_2a49c1d0","line":901,"in_reply_to":"1ae5cdf2_274e0339","updated":"2014-06-30 22:15:55.000000000","message":"Morgan - _token_cache.get() will fail if the token is expired -- http://git.openstack.org/cgit/openstack/keystonemiddleware/tree/keystonemiddleware/auth_token.py#n1520\n\nThis doesn\u0027t have anything to do with the TTL for the cached item (actually, the TTL is always the same). The expiration time is stored along with the token, and the token cache will fail the get if the expiration time is past.","commit_id":"7428413036c9463b8201bc6c38a2dc627fd8aa44"}]}