)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11717,"name":"Ryan Oshima","email":"ryan.oshima@hp.com","username":"RyanOshima"},"change_message_id":"b839626a0e53c7d2fd9bdc0c7aa4a8a8eb7cf907","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Correct return code"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When a nova-api call is made with a token, the middleware"},{"line_number":10,"context_line":"verifies the token with keystone. Even if the response from"},{"line_number":11,"context_line":"keystone is an internal error the response shown to user is"},{"line_number":12,"context_line":"401 (unauthorised). Checked the return code in verify_uuid_token()"},{"line_number":13,"context_line":"and raised an exception and then caught it in _validate_user_token()"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"baada198_e42f6e87","line":10,"updated":"2014-07-18 23:03:55.000000000","message":"\"keystone-\u003e\"Keystone\"","commit_id":"d6ef8209f36a4688e2d3b01ac87e09693eb0b005"},{"author":{"_account_id":11717,"name":"Ryan Oshima","email":"ryan.oshima@hp.com","username":"RyanOshima"},"change_message_id":"b839626a0e53c7d2fd9bdc0c7aa4a8a8eb7cf907","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When a nova-api call is made with a token, the middleware"},{"line_number":10,"context_line":"verifies the token with keystone. Even if the response from"},{"line_number":11,"context_line":"keystone is an internal error the response shown to user is"},{"line_number":12,"context_line":"401 (unauthorised). Checked the return code in verify_uuid_token()"},{"line_number":13,"context_line":"and raised an exception and then caught it in _validate_user_token()"},{"line_number":14,"context_line":"and then raised an ServiceError exception."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"baada198_042d428f","line":11,"updated":"2014-07-18 23:03:55.000000000","message":"same as above","commit_id":"d6ef8209f36a4688e2d3b01ac87e09693eb0b005"}],"keystonemiddleware/auth_token.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"0c1775eaf32ed6e87be884403ccbcd8d42e56c83","unresolved":false,"context_lines":[{"line_number":1126,"context_line":"            self.admin_token \u003d None"},{"line_number":1127,"context_line":"        elif response.status_code \u003d\u003d 500:"},{"line_number":1128,"context_line":"            self._LOG.warn(\u0027keystone internal error\u0027)"},{"line_number":1129,"context_line":"            raise ServiceError(\u0027Token authorization failed\u0027)"},{"line_number":1130,"context_line":"        else:"},{"line_number":1131,"context_line":"            self._LOG.error(\u0027Bad response code while validating token: %s\u0027,"},{"line_number":1132,"context_line":"                            response.status_code)"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_063389ab","line":1129,"updated":"2014-07-11 20:46:22.000000000","message":"Can some tests be added for this?","commit_id":"72ce2d8209e0d94ecc9ffbb43ba7531fd68cc0bd"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"b7a6015d1d9821a2fc599a0d5d3e5455c79790e6","unresolved":false,"context_lines":[{"line_number":1127,"context_line":"        elif response.status_code \u003d\u003d 500:"},{"line_number":1128,"context_line":"            self._LOG.warn(\u0027keystone internal error\u0027)"},{"line_number":1129,"context_line":"            raise ServiceError(\u0027Token authorization failed\u0027)"},{"line_number":1130,"context_line":"        else:"},{"line_number":1131,"context_line":"            self._LOG.error(\u0027Bad response code while validating token: %s\u0027,"},{"line_number":1132,"context_line":"                            response.status_code)"},{"line_number":1133,"context_line":"        if retry:"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_44c01a50","line":1130,"updated":"2014-07-11 21:17:51.000000000","message":"+1, Also why are we resetting admin_token only for status_code 401","commit_id":"72ce2d8209e0d94ecc9ffbb43ba7531fd68cc0bd"},{"author":{"_account_id":11717,"name":"Ryan Oshima","email":"ryan.oshima@hp.com","username":"RyanOshima"},"change_message_id":"b839626a0e53c7d2fd9bdc0c7aa4a8a8eb7cf907","unresolved":false,"context_lines":[{"line_number":885,"context_line":"        :return uncrypted body of the token if the token is valid"},{"line_number":886,"context_line":"        :raise InvalidUserToken if token is rejected"},{"line_number":887,"context_line":"        :raise ServiceError if token could not be verified due to"},{"line_number":888,"context_line":"        keystone internal error."},{"line_number":889,"context_line":""},{"line_number":890,"context_line":"        \"\"\""},{"line_number":891,"context_line":"        token_id \u003d None"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_04446245","line":888,"updated":"2014-07-18 23:03:55.000000000","message":"\"keystone\"-\u003e\"Keystone\"","commit_id":"d6ef8209f36a4688e2d3b01ac87e09693eb0b005"},{"author":{"_account_id":11717,"name":"Ryan Oshima","email":"ryan.oshima@hp.com","username":"RyanOshima"},"change_message_id":"b839626a0e53c7d2fd9bdc0c7aa4a8a8eb7cf907","unresolved":false,"context_lines":[{"line_number":924,"context_line":"            self._LOG.warn(\u0027Authorization failed for token\u0027)"},{"line_number":925,"context_line":"            raise InvalidUserToken(\u0027Token authorization failed\u0027)"},{"line_number":926,"context_line":"        except ServiceError:"},{"line_number":927,"context_line":"            self._LOG.debug(\u0027token validation failure.\u0027, exec_info\u003dTrue)"},{"line_number":928,"context_line":"            self._LOG.warn(\u0027Authorization failed for token\u0027)"},{"line_number":929,"context_line":"            raise ServiceError(\u0027Token authorization failed\u0027)"},{"line_number":930,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_2474069b","line":927,"updated":"2014-07-18 23:03:55.000000000","message":"\"token\"-\u003e\"Token\"","commit_id":"d6ef8209f36a4688e2d3b01ac87e09693eb0b005"},{"author":{"_account_id":11717,"name":"Ryan Oshima","email":"ryan.oshima@hp.com","username":"RyanOshima"},"change_message_id":"b839626a0e53c7d2fd9bdc0c7aa4a8a8eb7cf907","unresolved":false,"context_lines":[{"line_number":1126,"context_line":"            self._LOG.info(\u0027Keystone rejected admin token, resetting\u0027)"},{"line_number":1127,"context_line":"            self.admin_token \u003d None"},{"line_number":1128,"context_line":"        elif response.status_code \u003d\u003d 500:"},{"line_number":1129,"context_line":"            self._LOG.warn(\u0027keystone internal error\u0027)"},{"line_number":1130,"context_line":"            raise ServiceError(\u0027Token authorization failed\u0027)"},{"line_number":1131,"context_line":"        else:"},{"line_number":1132,"context_line":"            self._LOG.error(\u0027Bad response code while validating token: %s\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_4479fa91","line":1129,"updated":"2014-07-18 23:03:55.000000000","message":"Same as above","commit_id":"d6ef8209f36a4688e2d3b01ac87e09693eb0b005"}]}