)]}'
{"keystonemiddleware/auth_token.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"6407866f45d13eaad680b304fbfe270466ea4909","unresolved":false,"context_lines":[{"line_number":1467,"context_line":""},{"line_number":1468,"context_line":"        try:"},{"line_number":1469,"context_line":"            if self._auth_version \u003d\u003d \u0027v3.0\u0027:"},{"line_number":1470,"context_line":"                path \u003d \u0027/v3/auth/tokens/OS-PKI/revoked\u0027"},{"line_number":1471,"context_line":"            else:"},{"line_number":1472,"context_line":"                path \u003d \u0027/v2.0/tokens/revoked\u0027"},{"line_number":1473,"context_line":"            response, data \u003d self._json_request(\u0027GET\u0027, path,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa7fdbe_39b6ca8a","line":1470,"updated":"2014-10-27 12:58:40.000000000","message":"OS-PKI is an extension so the auth_token middleware must be able to work without it.","commit_id":"8841769271a1ab6acfa28732724faa80f9c64294"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"0c8071b1c09592e15e4ed0e5d50483ba1de6b9f3","unresolved":false,"context_lines":[{"line_number":1467,"context_line":""},{"line_number":1468,"context_line":"        try:"},{"line_number":1469,"context_line":"            if self._auth_version \u003d\u003d \u0027v3.0\u0027:"},{"line_number":1470,"context_line":"                path \u003d \u0027/v3/auth/tokens/OS-PKI/revoked\u0027"},{"line_number":1471,"context_line":"            else:"},{"line_number":1472,"context_line":"                path \u003d \u0027/v2.0/tokens/revoked\u0027"},{"line_number":1473,"context_line":"            response, data \u003d self._json_request(\u0027GET\u0027, path,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa7fdbe_d6d3b6d2","line":1470,"in_reply_to":"9aa7fdbe_39b6ca8a","updated":"2014-10-28 03:27:43.000000000","message":"@Brant\n\nhttps://bugs.launchpad.net/openstack-api-site/+bug/1304606\n\nThis looks like an undocumented API","commit_id":"8841769271a1ab6acfa28732724faa80f9c64294"},{"author":{"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"},"change_message_id":"2c1096b122f8cc7c6d334d38b98e665f6fe3598a","unresolved":false,"context_lines":[{"line_number":1467,"context_line":""},{"line_number":1468,"context_line":"        try:"},{"line_number":1469,"context_line":"            if self._auth_version \u003d\u003d \u0027v3.0\u0027:"},{"line_number":1470,"context_line":"                path \u003d \u0027/v3/auth/tokens/OS-PKI/revoked\u0027"},{"line_number":1471,"context_line":"            else:"},{"line_number":1472,"context_line":"                path \u003d \u0027/v2.0/tokens/revoked\u0027"},{"line_number":1473,"context_line":"            response, data \u003d self._json_request(\u0027GET\u0027, path,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa7fdbe_17b9bd78","line":1470,"in_reply_to":"9aa7fdbe_39b6ca8a","updated":"2014-10-28 01:08:03.000000000","message":"I think this can be fixed in this patch https://review.openstack.org/#/c/131036/1","commit_id":"8841769271a1ab6acfa28732724faa80f9c64294"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"b9e8ee9458db1377156b2cf3275316025d9d03e6","unresolved":false,"context_lines":[{"line_number":1480,"context_line":"            raise InvalidToken()"},{"line_number":1481,"context_line":""},{"line_number":1482,"context_line":"    def fetch_revocation_list(self):"},{"line_number":1483,"context_line":"        if not self._auth_version:"},{"line_number":1484,"context_line":"            self._auth_version \u003d self._choose_api_version()"},{"line_number":1485,"context_line":""},{"line_number":1486,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a890539_de0bff21","line":1483,"updated":"2014-11-24 19:01:52.000000000","message":"Is there a way we can check if OS-PKI is enabled before relying on this?","commit_id":"fc65fd4bcd54fd572bd096a339c6d6b66608d297"},{"author":{"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"},"change_message_id":"1435e876bbdd2b9f9c2c18ffbeeeb4131c212bda","unresolved":false,"context_lines":[{"line_number":1480,"context_line":"            raise InvalidToken()"},{"line_number":1481,"context_line":""},{"line_number":1482,"context_line":"    def fetch_revocation_list(self):"},{"line_number":1483,"context_line":"        if not self._auth_version:"},{"line_number":1484,"context_line":"            self._auth_version \u003d self._choose_api_version()"},{"line_number":1485,"context_line":""},{"line_number":1486,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_243498dd","line":1483,"in_reply_to":"5a890539_de0bff21","updated":"2014-12-08 07:34:10.000000000","message":"It\u0027s very strange, OS-PKI is an extension but, now the url OS-PKI/revoked is always defined: https://github.com/openstack/keystone/blob/master/keystone/auth/routers.py#L38","commit_id":"fc65fd4bcd54fd572bd096a339c6d6b66608d297"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"6173697ff21bade749699b36825b09931fc8c194","unresolved":false,"context_lines":[{"line_number":1610,"context_line":""},{"line_number":1611,"context_line":"    def _do_fetch_revocation_list(self):"},{"line_number":1612,"context_line":"        return self._json_request(\u0027GET\u0027,"},{"line_number":1613,"context_line":"                                  \u0027/tokens/revoked\u0027, authenticated\u003dFalse)"},{"line_number":1614,"context_line":""},{"line_number":1615,"context_line":""},{"line_number":1616,"context_line":"class _V3IdentityServer(_IdentityServer):"}],"source_content_type":"text/x-python","patch_set":6,"id":"da86d52c_5b90ec42","line":1613,"updated":"2015-02-12 00:32:23.000000000","message":"Why did the argument authenticated changed from True to False?\n\nThat API seems protected, so the token must be passed with it: https://github.com/openstack/keystone/blob/master/keystone/token/controllers.py#L454","commit_id":"802ff6939e6d342837dd98f0f6f40ec51c670eb4"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"cf15043e18516c7eb3cad96b3e4e7a8a431fbd02","unresolved":false,"context_lines":[{"line_number":1633,"context_line":""},{"line_number":1634,"context_line":"        return self._adapter.get(\u0027/OS-SIMPLE-CERT/%s\u0027 % cert_type,"},{"line_number":1635,"context_line":"                                 authenticated\u003dFalse)"},{"line_number":1636,"context_line":""},{"line_number":1637,"context_line":"    def _do_fetch_revocation_list(self):"},{"line_number":1638,"context_line":"        return self._json_request(\u0027GET\u0027,"},{"line_number":1639,"context_line":"                                  \u0027/auth/tokens/OS-PKI/revoked\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"da86d52c_d408f32e","line":1636,"updated":"2015-02-13 03:55:54.000000000","message":"I suggest you go with revocation event. Revocation event is way better than revocation list. I believe we are moving towards revocation event","commit_id":"802ff6939e6d342837dd98f0f6f40ec51c670eb4"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"b3d6fd1bded99fda895e873e883006c46b2762f8","unresolved":false,"context_lines":[{"line_number":1637,"context_line":"    def _do_fetch_revocation_list(self):"},{"line_number":1638,"context_line":"        return self._json_request(\u0027GET\u0027,"},{"line_number":1639,"context_line":"                                  \u0027/auth/tokens/OS-PKI/revoked\u0027,"},{"line_number":1640,"context_line":"                                  authenticated\u003dFalse)"},{"line_number":1641,"context_line":""},{"line_number":1642,"context_line":""},{"line_number":1643,"context_line":"class _TokenCache(object):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a961159_70efc8e9","line":1640,"updated":"2014-12-10 23:20:05.000000000","message":"wanghong - OS-PKI is always defined in the keystone server, but the keystone server is only one implementation of the identity API. auth_token middleware needs to be targeted to the identity API and not to a particular implementation. So this needs to work when the OS-PKI extension isn\u0027t available.","commit_id":"802ff6939e6d342837dd98f0f6f40ec51c670eb4"}],"keystonemiddleware/tests/test_auth_token_middleware.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"b9e8ee9458db1377156b2cf3275316025d9d03e6","unresolved":false,"context_lines":[{"line_number":1828,"context_line":"            \u0027GET\u0027,"},{"line_number":1829,"context_line":"            \"%s/v3/auth/tokens/OS-PKI/revoked\" % BASE_URI,"},{"line_number":1830,"context_line":"            json\u003d\"{}\")"},{"line_number":1831,"context_line":""},{"line_number":1832,"context_line":"        self.assertRaises(auth_token.ServiceError,"},{"line_number":1833,"context_line":"                          self.middleware._fetch_revocation_list)"},{"line_number":1834,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5a890539_9e7a5786","line":1831,"updated":"2014-11-24 19:01:52.000000000","message":"Can we test the that if OS-PKI is not available we fall back to the old behavior? This tests the try/except but doesn\u0027t necessarily tests the if/else within the try except.","commit_id":"fc65fd4bcd54fd572bd096a339c6d6b66608d297"}]}