)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"2ed6b1b9cd26c66a1564c11631d27f43e057270c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"call _choose_api_version in one place"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, we call _choose_api_version in three places. Let we remove"},{"line_number":10,"context_line":"the duplicate codes."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ic3463e4f943edaa378d40c7e18635e28653ac5e8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5a890539_3eb6c33e","line":9,"updated":"2014-11-24 19:09:22.000000000","message":"s/Let we/Let\u0027s/","commit_id":"c8d9ad7f4e70f05c4c648f389deb3f6d9638284f"}],"keystonemiddleware/auth_token.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"3b7180c09b44331a45b83d41863c7a9e4542c46e","unresolved":false,"context_lines":[{"line_number":1423,"context_line":""},{"line_number":1424,"context_line":"        # Determine the highest api version we can use."},{"line_number":1425,"context_line":"        if not self._auth_version:"},{"line_number":1426,"context_line":"            self._auth_version \u003d self._choose_api_version()"},{"line_number":1427,"context_line":""},{"line_number":1428,"context_line":"        if self._auth_version \u003d\u003d \u0027v3.0\u0027:"},{"line_number":1429,"context_line":"            headers \u003d {\u0027X-Subject-Token\u0027: user_token}"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aa7fdbe_65e4ce0d","side":"PARENT","line":1426,"updated":"2014-10-20 18:31:50.000000000","message":"Should we be calling _auth_version here?","commit_id":"8841769271a1ab6acfa28732724faa80f9c64294"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"3b7180c09b44331a45b83d41863c7a9e4542c46e","unresolved":false,"context_lines":[{"line_number":1464,"context_line":"    def fetch_revocation_list(self):"},{"line_number":1465,"context_line":"        if not self._auth_version:"},{"line_number":1466,"context_line":"            self._auth_version \u003d self._choose_api_version()"},{"line_number":1467,"context_line":""},{"line_number":1468,"context_line":"        try:"},{"line_number":1469,"context_line":"            if self._auth_version \u003d\u003d \u0027v3.0\u0027:"},{"line_number":1470,"context_line":"                path \u003d \u0027/v3/auth/tokens/OS-PKI/revoked\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aa7fdbe_a5eeb6ea","side":"PARENT","line":1467,"updated":"2014-10-20 18:31:50.000000000","message":"and here?","commit_id":"8841769271a1ab6acfa28732724faa80f9c64294"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"3b7180c09b44331a45b83d41863c7a9e4542c46e","unresolved":false,"context_lines":[{"line_number":1605,"context_line":"    def _fetch_cert_file(self, cert_type):"},{"line_number":1606,"context_line":"        if not self._auth_version:"},{"line_number":1607,"context_line":"            self._auth_version \u003d self._choose_api_version()"},{"line_number":1608,"context_line":""},{"line_number":1609,"context_line":"        if self._auth_version \u003d\u003d \u0027v3.0\u0027:"},{"line_number":1610,"context_line":"            if cert_type \u003d\u003d \u0027signing\u0027:"},{"line_number":1611,"context_line":"                cert_type \u003d \u0027certificates\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aa7fdbe_c5badae0","side":"PARENT","line":1608,"updated":"2014-10-20 18:31:50.000000000","message":"and here?","commit_id":"8841769271a1ab6acfa28732724faa80f9c64294"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"3b7180c09b44331a45b83d41863c7a9e4542c46e","unresolved":false,"context_lines":[{"line_number":1408,"context_line":"        self._http_request_max_retries \u003d http_request_max_retries"},{"line_number":1409,"context_line":""},{"line_number":1410,"context_line":"    @property"},{"line_number":1411,"context_line":"    def _auth_version(self):"},{"line_number":1412,"context_line":"        if self._auth_version_prop is None:"},{"line_number":1413,"context_line":"            self._auth_version_prop \u003d self._choose_api_version()"},{"line_number":1414,"context_line":"        return self._auth_version_prop"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aa7fdbe_e5d8be55","line":1411,"updated":"2014-10-20 18:31:50.000000000","message":"this is never called?","commit_id":"f6481bb0b48c11456c882a25e0652f21ec8dcd5e"},{"author":{"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"},"change_message_id":"f0a6d867f3b2b7321f3ea71d08d5dfd3a7691532","unresolved":false,"context_lines":[{"line_number":1408,"context_line":"        self._http_request_max_retries \u003d http_request_max_retries"},{"line_number":1409,"context_line":""},{"line_number":1410,"context_line":"    @property"},{"line_number":1411,"context_line":"    def _auth_version(self):"},{"line_number":1412,"context_line":"        if self._auth_version_prop is None:"},{"line_number":1413,"context_line":"            self._auth_version_prop \u003d self._choose_api_version()"},{"line_number":1414,"context_line":"        return self._auth_version_prop"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aa7fdbe_5d187581","line":1411,"in_reply_to":"9aa7fdbe_e5d8be55","updated":"2014-10-21 01:28:52.000000000","message":"Note that the _auth_version method is a @property method, that is say, when we call self._auth_version the _auth_version method here will be called.","commit_id":"f6481bb0b48c11456c882a25e0652f21ec8dcd5e"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"2ed6b1b9cd26c66a1564c11631d27f43e057270c","unresolved":false,"context_lines":[{"line_number":1425,"context_line":"    def _auth_version(self):"},{"line_number":1426,"context_line":"        if self._auth_version_prop is None:"},{"line_number":1427,"context_line":"            self._auth_version_prop \u003d self._choose_api_version()"},{"line_number":1428,"context_line":"        return self._auth_version_prop"},{"line_number":1429,"context_line":""},{"line_number":1430,"context_line":"    def verify_token(self, user_token, retry\u003dTrue):"},{"line_number":1431,"context_line":"        \"\"\"Authenticate user token with keystone."}],"source_content_type":"text/x-python","patch_set":6,"id":"5a890539_fe96fb92","line":1428,"updated":"2014-11-24 19:09:22.000000000","message":"Do we have tests for this?","commit_id":"c8d9ad7f4e70f05c4c648f389deb3f6d9638284f"}]}
