)]}'
{"keystonemiddleware/auth_token.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"1db19de1e34658669a8dbe60bcd1214e04e3fa67","unresolved":false,"context_lines":[{"line_number":1256,"context_line":"            self._identity_server.fetch_ca_cert())"},{"line_number":1257,"context_line":""},{"line_number":1258,"context_line":"    # NOTE(hrybacki): This and subsequent factory functions are part of a"},{"line_number":1259,"context_line":"    # cleanup and better organization effort of AuthProtocol."},{"line_number":1260,"context_line":"    def _identity_server_factory(self):"},{"line_number":1261,"context_line":"        # NOTE(jamielennox): Loading Session here should be exactly the"},{"line_number":1262,"context_line":"        # same as calling Session.load_from_conf_options(CONF, GROUP)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa7fdbe_da496261","line":1259,"updated":"2014-10-23 23:55:30.000000000","message":"Doesn\u0027t this change make the organization worse?","commit_id":"6e99bffeefde80394ea4888b01fced9a489ec329"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"223e4e0a0f49e3ee36bd9ad6ec4e61f899d0998a","unresolved":false,"context_lines":[{"line_number":1256,"context_line":"            self._identity_server.fetch_ca_cert())"},{"line_number":1257,"context_line":""},{"line_number":1258,"context_line":"    # NOTE(hrybacki): This and subsequent factory functions are part of a"},{"line_number":1259,"context_line":"    # cleanup and better organization effort of AuthProtocol."},{"line_number":1260,"context_line":"    def _identity_server_factory(self):"},{"line_number":1261,"context_line":"        # NOTE(jamielennox): Loading Session here should be exactly the"},{"line_number":1262,"context_line":"        # same as calling Session.load_from_conf_options(CONF, GROUP)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa7fdbe_50f0e666","line":1259,"in_reply_to":"9aa7fdbe_0ac62f68","updated":"2014-10-24 14:29:36.000000000","message":"get rid of the comment.","commit_id":"6e99bffeefde80394ea4888b01fced9a489ec329"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"98fd557e81f5673eea5e3b3e3944d6653f74c58d","unresolved":false,"context_lines":[{"line_number":1256,"context_line":"            self._identity_server.fetch_ca_cert())"},{"line_number":1257,"context_line":""},{"line_number":1258,"context_line":"    # NOTE(hrybacki): This and subsequent factory functions are part of a"},{"line_number":1259,"context_line":"    # cleanup and better organization effort of AuthProtocol."},{"line_number":1260,"context_line":"    def _identity_server_factory(self):"},{"line_number":1261,"context_line":"        # NOTE(jamielennox): Loading Session here should be exactly the"},{"line_number":1262,"context_line":"        # same as calling Session.load_from_conf_options(CONF, GROUP)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa7fdbe_0ac62f68","line":1259,"in_reply_to":"9aa7fdbe_da496261","updated":"2014-10-24 13:26:01.000000000","message":"arguable - i don\u0027t know if the comment here was ever a good idea. \n\nWhat it means though is that we have no need for the session as a stand alone object, so it moves that into the process of constructing an identity server.","commit_id":"6e99bffeefde80394ea4888b01fced9a489ec329"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"1db19de1e34658669a8dbe60bcd1214e04e3fa67","unresolved":false,"context_lines":[{"line_number":1379,"context_line":"            yield client"},{"line_number":1380,"context_line":""},{"line_number":1381,"context_line":""},{"line_number":1382,"context_line":"# NOTE(jamielennox): It might be worth moving this to keystoneclient. It seems"},{"line_number":1383,"context_line":"# like a better approach than the LegacyJsonAdapter that is there now."},{"line_number":1384,"context_line":"class _JsonView(object):"},{"line_number":1385,"context_line":"    \"\"\"A wrapper around an adapter to interpret as JSON."}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa7fdbe_5a6d72cb","line":1382,"updated":"2014-10-23 23:55:30.000000000","message":"All the calls to keystone should be through regular keystoneclient functions rather than doing the requests directly.","commit_id":"6e99bffeefde80394ea4888b01fced9a489ec329"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"1db19de1e34658669a8dbe60bcd1214e04e3fa67","unresolved":false,"context_lines":[{"line_number":1407,"context_line":"        if resp.text:"},{"line_number":1408,"context_line":"            try:"},{"line_number":1409,"context_line":"                body \u003d jsonutils.loads(resp.text)"},{"line_number":1410,"context_line":"            except ValueError:"},{"line_number":1411,"context_line":"                pass"},{"line_number":1412,"context_line":""},{"line_number":1413,"context_line":"        return resp, body"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa7fdbe_5a7bb27a","line":1410,"updated":"2014-10-23 23:55:30.000000000","message":"This isn\u0027t tested","commit_id":"6e99bffeefde80394ea4888b01fced9a489ec329"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"98fd557e81f5673eea5e3b3e3944d6653f74c58d","unresolved":false,"context_lines":[{"line_number":1407,"context_line":"        if resp.text:"},{"line_number":1408,"context_line":"            try:"},{"line_number":1409,"context_line":"                body \u003d jsonutils.loads(resp.text)"},{"line_number":1410,"context_line":"            except ValueError:"},{"line_number":1411,"context_line":"                pass"},{"line_number":1412,"context_line":""},{"line_number":1413,"context_line":"        return resp, body"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa7fdbe_6a96db40","line":1410,"in_reply_to":"9aa7fdbe_5a7bb27a","updated":"2014-10-24 13:26:01.000000000","message":"sure, this stuff was copied directly from the equivalent stuff in keystoneclient because i was looking at hosting it there - i can trim it all back to just what\u0027s required here.","commit_id":"6e99bffeefde80394ea4888b01fced9a489ec329"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"1db19de1e34658669a8dbe60bcd1214e04e3fa67","unresolved":false,"context_lines":[{"line_number":1416,"context_line":"        return self.request(url, \u0027GET\u0027, **kwargs)"},{"line_number":1417,"context_line":""},{"line_number":1418,"context_line":"    def head(self, url, **kwargs):"},{"line_number":1419,"context_line":"        return self.request(url, \u0027HEAD\u0027, **kwargs)"},{"line_number":1420,"context_line":""},{"line_number":1421,"context_line":"    def post(self, url, **kwargs):"},{"line_number":1422,"context_line":"        return self.request(url, \u0027POST\u0027, **kwargs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa7fdbe_ba957e88","line":1419,"updated":"2014-10-23 23:55:30.000000000","message":"Only get is used and tested. The rest of these should just be removed.","commit_id":"6e99bffeefde80394ea4888b01fced9a489ec329"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"98fd557e81f5673eea5e3b3e3944d6653f74c58d","unresolved":false,"context_lines":[{"line_number":1416,"context_line":"        return self.request(url, \u0027GET\u0027, **kwargs)"},{"line_number":1417,"context_line":""},{"line_number":1418,"context_line":"    def head(self, url, **kwargs):"},{"line_number":1419,"context_line":"        return self.request(url, \u0027HEAD\u0027, **kwargs)"},{"line_number":1420,"context_line":""},{"line_number":1421,"context_line":"    def post(self, url, **kwargs):"},{"line_number":1422,"context_line":"        return self.request(url, \u0027POST\u0027, **kwargs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa7fdbe_8a977f39","line":1419,"in_reply_to":"9aa7fdbe_ba957e88","updated":"2014-10-24 13:26:01.000000000","message":"Done","commit_id":"6e99bffeefde80394ea4888b01fced9a489ec329"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"1db19de1e34658669a8dbe60bcd1214e04e3fa67","unresolved":false,"context_lines":[{"line_number":1450,"context_line":"            session,"},{"line_number":1451,"context_line":"            auth\u003dauth_plugin,"},{"line_number":1452,"context_line":"            service_type\u003d\u0027identity\u0027,"},{"line_number":1453,"context_line":"            interface\u003d\u0027public\u0027,"},{"line_number":1454,"context_line":"            connect_retries\u003dconnect_retries)"},{"line_number":1455,"context_line":""},{"line_number":1456,"context_line":"        if auth_uri is None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa7fdbe_3aa34e02","line":1453,"updated":"2014-10-23 23:55:30.000000000","message":"really?","commit_id":"6e99bffeefde80394ea4888b01fced9a489ec329"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"98fd557e81f5673eea5e3b3e3944d6653f74c58d","unresolved":false,"context_lines":[{"line_number":1450,"context_line":"            session,"},{"line_number":1451,"context_line":"            auth\u003dauth_plugin,"},{"line_number":1452,"context_line":"            service_type\u003d\u0027identity\u0027,"},{"line_number":1453,"context_line":"            interface\u003d\u0027public\u0027,"},{"line_number":1454,"context_line":"            connect_retries\u003dconnect_retries)"},{"line_number":1455,"context_line":""},{"line_number":1456,"context_line":"        if auth_uri is None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa7fdbe_6ae41be1","line":1453,"in_reply_to":"9aa7fdbe_3aa34e02","updated":"2014-10-24 13:26:01.000000000","message":"so this has no impact on the current plugin because it isn\u0027t looked at in the default plugin\u0027s get_endpoint. \n\nWorking on the principal though that this will be respected by other plugins should we defaulting to admin or public?","commit_id":"6e99bffeefde80394ea4888b01fced9a489ec329"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"223e4e0a0f49e3ee36bd9ad6ec4e61f899d0998a","unresolved":false,"context_lines":[{"line_number":1450,"context_line":"            session,"},{"line_number":1451,"context_line":"            auth\u003dauth_plugin,"},{"line_number":1452,"context_line":"            service_type\u003d\u0027identity\u0027,"},{"line_number":1453,"context_line":"            interface\u003d\u0027public\u0027,"},{"line_number":1454,"context_line":"            connect_retries\u003dconnect_retries)"},{"line_number":1455,"context_line":""},{"line_number":1456,"context_line":"        if auth_uri is None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa7fdbe_b0a2f248","line":1453,"in_reply_to":"9aa7fdbe_6ae41be1","updated":"2014-10-24 14:29:36.000000000","message":"Should add a comment that it has no effect which is picked. I\u0027d actually expect it to be internal (there\u0027s an internal interface, right?)","commit_id":"6e99bffeefde80394ea4888b01fced9a489ec329"}],"keystonemiddleware/tests/test_auth_token_middleware.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"48068e236c2d4bb74f146c8dc90b4c10f9e20d0e","unresolved":false,"context_lines":[{"line_number":625,"context_line":"    def test_conf_values_type_convert(self):"},{"line_number":626,"context_line":"        conf \u003d {"},{"line_number":627,"context_line":"            \u0027revocation_cache_time\u0027: \u002724\u0027,"},{"line_number":628,"context_line":"            \u0027identity_uri\u0027: \u0027https://keystone.example.com:1234\u0027,"},{"line_number":629,"context_line":"            \u0027include_service_catalog\u0027: \u00270\u0027,"},{"line_number":630,"context_line":"            \u0027nonexsit_option\u0027: \u00270\u0027,"},{"line_number":631,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa7fdbe_97922cf4","line":628,"updated":"2014-10-26 23:31:26.000000000","message":"probably don\u0027t need this in conf now.","commit_id":"bd291d6aab1a62f7664b07c6deb8b42e1550972a"}]}