)]}'
{"keystonemiddleware/auth_token.py":[{"author":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"change_message_id":"466a62bb9b84e222d98dc1c5dee4cc3cf9f99e27","unresolved":false,"context_lines":[{"line_number":874,"context_line":"                        expires \u003d _confirm_token_not_expired(data)"},{"line_number":875,"context_line":"                except exceptions.CertificateConfigError:"},{"line_number":876,"context_line":"                    self._LOG.warn(\u0027Fetch certificate config failed, fallback \u0027"},{"line_number":877,"context_line":"                                   \u0027to purely online validation.\u0027)"},{"line_number":878,"context_line":"                except RevocationListError:"},{"line_number":879,"context_line":"                    self._LOG.warn(\u0027Fetch revocation list failed, fallback \u0027"},{"line_number":880,"context_line":"                                   \u0027to purely online validation.\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa7fdbe_74e059fa","line":877,"updated":"2014-10-27 13:16:56.000000000","message":"I\u0027d suggest remove \u0027purely\u0027 here and below. I think it\u0027s an excess - you even named your tests without it :)","commit_id":"006187c4e8955d1d8c3e9c38dd1a41f2a65d9753"},{"author":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"change_message_id":"a7236c720f6157d36922c20714d1512c58fee945","unresolved":false,"context_lines":[{"line_number":903,"context_line":"                # checked that it\u0027s not expired, and also put in the cache."},{"line_number":904,"context_line":"                try:"},{"line_number":905,"context_line":"                    if cms.is_pkiz(token):"},{"line_number":906,"context_line":"                        verified \u003d self._verify_pkiz_token(token, token_ids)"},{"line_number":907,"context_line":"                        data \u003d jsonutils.loads(verified)"},{"line_number":908,"context_line":"                        expires \u003d _confirm_token_not_expired(data)"},{"line_number":909,"context_line":"                    elif cms.is_asn1_token(token):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_c2505d0d","line":906,"updated":"2014-11-17 18:21:54.000000000","message":"(Nit) The only point of interest in \u0027if\u0027 block is \u0027verified\u0027\nI suppose data extraction to be moved outside.\nNot sure but it may be moved eved outside of try..except since _confirm_token_not_expired doesn\u0027t raise anything caught here.","commit_id":"5f18779d0296eaa3c4c5d5eca676665afc6d1c4a"},{"author":{"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"},"change_message_id":"73fc658e3c34dc4bae7a87a2da4893a9677bdca5","unresolved":false,"context_lines":[{"line_number":903,"context_line":"                # checked that it\u0027s not expired, and also put in the cache."},{"line_number":904,"context_line":"                try:"},{"line_number":905,"context_line":"                    if cms.is_pkiz(token):"},{"line_number":906,"context_line":"                        verified \u003d self._verify_pkiz_token(token, token_ids)"},{"line_number":907,"context_line":"                        data \u003d jsonutils.loads(verified)"},{"line_number":908,"context_line":"                        expires \u003d _confirm_token_not_expired(data)"},{"line_number":909,"context_line":"                    elif cms.is_asn1_token(token):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_4d4d75c3","line":906,"in_reply_to":"5a890539_c2505d0d","updated":"2014-11-18 01:09:03.000000000","message":"Yes, good catch. And, there are duplicate codes here too.","commit_id":"5f18779d0296eaa3c4c5d5eca676665afc6d1c4a"},{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"a22d00ff8f0b1ab31453d863799087c8543ec796","unresolved":false,"context_lines":[{"line_number":969,"context_line":"                verified \u003d None"},{"line_number":970,"context_line":"                # Token wasn\u0027t cached. In this case, the token needs to be"},{"line_number":971,"context_line":"                # checked that it\u0027s not expired, and also put in the cache."},{"line_number":972,"context_line":"                try:"},{"line_number":973,"context_line":"                    if cms.is_pkiz(token):"},{"line_number":974,"context_line":"                        verified \u003d self._verify_pkiz_token(token, token_ids)"},{"line_number":975,"context_line":"                    elif cms.is_asn1_token(token):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_3bf10e96","line":972,"updated":"2014-12-16 10:55:32.000000000","message":"You might also want to catch CalledProcessError. It would work for a bug simillar to https://bugzilla.redhat.com/show_bug.cgi?id\u003d1141615.","commit_id":"bf491dbee798b49093ab4d9ddb83e64d30764100"},{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"a22d00ff8f0b1ab31453d863799087c8543ec796","unresolved":false,"context_lines":[{"line_number":1561,"context_line":"                endpoint_filter\u003d{\u0027version\u0027: (2, 0)})"},{"line_number":1562,"context_line":"        except exceptions.HTTPError as e:"},{"line_number":1563,"context_line":"            raise RevocationListError(_(\u0027Failed to fetch token revocation \u0027"},{"line_number":1564,"context_line":"                                      \u0027list: %d\u0027) % e.http_status)"},{"line_number":1565,"context_line":"        if response.status_code !\u003d 200:"},{"line_number":1566,"context_line":"            raise RevocationListError(_(\u0027Unable to fetch token revocation\u0027"},{"line_number":1567,"context_line":"                                        \u0027 list.\u0027))"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_c4221051","line":1564,"updated":"2014-12-16 10:55:32.000000000","message":"Please, make this consistent with indentation below.","commit_id":"bf491dbee798b49093ab4d9ddb83e64d30764100"}]}